- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > } > > +static LSTATUS create_empty_key(HKEY hkey, LPCSTR name, PHKEY open_key) > +{ > + HKEY key; > + LSTATUS ret; > + > + ret = RegOpenKeyExA(hkey, name, 0, KEY_READ|KEY_WRITE, &key); > + if (ret == ERROR_SUCCESS) { > + ret = RegDeleteTreeA(key, NULL); > + if (ret != ERROR_SUCCESS) { > + return ret; > + } > + } > + ret = RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL); > + return ret; ``` return RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137722

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > ok( ret == ERROR_INVALID_HANDLE, "got %lx\n", ret ); > } > > +static LSTATUS create_empty_key(HKEY hkey, LPCSTR name, PHKEY open_key) > +{ > + HKEY key; > + LSTATUS ret; > + > + ret = RegOpenKeyExA(hkey, name, 0, KEY_READ|KEY_WRITE, &key); > + if (ret == ERROR_SUCCESS) { > + ret = RegDeleteTreeA(key, NULL); This deletes any subkey that already exist. You should create the test keys under this key and remove them when done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137721

1 0

[PATCH v3 0/2] MR10725: win32u: Check config again before setting win32 window position.
by Zhiyi Zhang (＠zhiyi) April 27, 2026

April 27, 2026

For example, Homeworld Remastered Collection (244160) Homeworld 2 Classic changes the display mode after NtUserSetActiveWindow(), then the following NtUserSetInternalWindowPos() call sets the window rect to the window rect before the display mode change. Thus, the game window can end up having an unexpected rect. There is a similar problem when LOWORD(state_cmd) == 0. Fix a regression from be60f77909fc9ce2c9b6f1abd005e3b4aabaafec. -- v3: win32u: Check window_rect again later if set_foreground_window() or NtUserSetActiveWindow() is called. win32u: Set the normal window position without going through NtUserSetInternalWindowPos(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10725

3 4

[PATCH v2 0/4] MR10753: ntdll/actctx: Add privatePath probing functions in SxS loader
by Bolan Chen (＠bolanc) April 27, 2026

April 27, 2026

Besides manifest files, SxS Loader can also take a config file similar to CLR apps which can instruct the loader to look for manifests in additional paths. Autodesk installers uses this somewhat obscure feature so this probe path will help Autodesk software installer to start. The config file looks like ``` <configuration> <windows> <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1"> <probing privatePath="path"/> </assemblyBinding> </windows> </configuration> ``` Microsoft mentions this feature in [application config files doc](https://learn.microsoft.com/en-us/windows/win32/sbscs/application-conf…. -- v2: add correct fallback path using manifest.info add tests add proper probing functionality add essential functions to read .config file and parse privatePath https://gitlab.winehq.org/wine/wine/-/merge_requests/10753

2 4

[PATCH 0/2] MR10712: wineandroid: fix desktop sizing and repaint on resolution changes
by Twaik Yont (＠twaik) April 27, 2026

April 27, 2026

This series fixes two related issues in wineandroid affecting desktop initialization and repaint behavior when using the virtual desktop mode. First, launching explorer.exe with an empty desktop size ("/desktop=shell,,android") does not behave as intended on wineandroid. When the size is omitted, explorer attempts to determine the desktop resolution via get_default_desktop_size(). If no matching registry entry is found, it falls back to a hardcoded default (typically 800x600). Later, even if the wineandroid backend sets the correct display size through pCreateDesktop, explorer overrides it again during initialize_display_settings(), restoring the default resolution. As a result, the desktop ends up stuck at 800x600 regardless of the actual display size reported by the backend. To address this, the desktop is now launched with a size of "-1x-1". This value is accepted by parse_size(), but does not correspond to a valid resolution. As a result, explorer does not fall back to the default resolution, and also avoids overriding the backend-provided size during initialization. This allows the desktop to retain the correct resolution as configured by wineandroid. Second, window repainting on resolution changes is fixed. Previously, WM_ANDROID_REFRESH used NtUserExposeWindowSurface(), which only exposes existing surface contents without invalidating the window. This prevents WM_PAINT and WM_ERASEBKGND from being generated. When the desktop or other windows are resized (e.g. after applying a new display mode), they may retain stale contents instead of repainting. This is resolved by replacing NtUserExposeWindowSurface() with NtUserRedrawWindow(), ensuring proper invalidation and repaint of window contents. This fixes cases where the desktop background is not redrawn after a resolution change. Together, these changes ensure that the desktop starts with the correct resolution and that windows are properly repainted when display settings change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10712

2 3

[PATCH v49 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 27, 2026

April 27, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v49: imagehlp: Fix ImageGetDigestStream https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v48 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 27, 2026

April 27, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v48: imagehlp: Fix ImageGetDigestStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v2 0/2] MR10725: win32u: Check config again before setting win32 window position.
by Zhiyi Zhang (＠zhiyi) April 27, 2026

April 27, 2026

For example, Homeworld Remastered Collection (244160) Homeworld 2 Classic changes the display mode after NtUserSetActiveWindow(), then the following NtUserSetInternalWindowPos() call sets the window rect to the window rect before the display mode change. Thus, the game window can end up having an unexpected rect. There is a similar problem when LOWORD(state_cmd) == 0. Fix a regression from be60f77909fc9ce2c9b6f1abd005e3b4aabaafec. -- v2: win32u: Check window_rect again later if set_foreground_window() or NtUserSetActiveWindow() is called. win32u: Set the normal window position without going through NtUserSetInternalWindowPos(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10725

2 2

[PATCH v47 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 27, 2026

April 27, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v47: imagehlp: Fix ImageGetDigestStream. Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH 0/5] MR10753: ntdll/actctx: Add privatePath probing functions in SxS loader
by Bolan Chen (＠bolanc) April 26, 2026

April 26, 2026

Besides manifest files, SxS Loader can also take a config file similar to CLR apps which can instruct the loader to look for manifests in additional paths. Autodesk installers uses this somewhat obscure feature so this probe path will help Autodesk software installer to start. The config file looks like ``` <configuration> <windows> <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1"> <probing privatePath="path"/> </assemblyBinding> </windows> </configuration> ``` Microsoft mentions this feature in [application config files doc](https://learn.microsoft.com/en-us/windows/win32/sbscs/application-conf…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10753

2 5

[PATCH 0/1] MR10752: msado15: Handle BSTR data in IRowsetFind::FindNextRow.
by Piotr Caban (＠piotr) April 26, 2026

April 26, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10752

2 1

[PATCH v2 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Guillaume Raffin (＠TheElectronWill) April 26, 2026

April 26, 2026

These functions are necessary to make some smartcard-based programs work. They rely on the "SmartCard Database", which can be found in the windows registry, at \`HKLM\\SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards\`. I have added extensive unit tests and validated the implementation with a real application (an internal program based on Atos CardOS). As this is my first PR here, please don't hesitate to tell me if something's wrong! I was wondering if the database-related code should be moved to a dedicated file `winscard-database.c`? same for the tests?), let me know what you think. -- v2: winscard: Implement SCardGetCardTypeProviderNameA winscard: Implement SCardListCardsA winscard: Implement SCardListCardsW winscard: Implement SCardGetCardTypeProviderNameW https://gitlab.winehq.org/wine/wine/-/merge_requests/10751

2 4

[PATCH v3 0/4] MR10741: Draft: msxml3: Support for max-element-depth property.
by Nikolay Sivov (＠nsivov) April 26, 2026

April 26, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: msxml3: Add support for MaxElementDepth property in the DOM parser. msxml3/sax: Add support for max-element-depth property. msxml3/tests: Extend MaxElementDepth tests. msxml3/tests: Add some tests for max-element-depth property. https://gitlab.winehq.org/wine/wine/-/merge_requests/10741

2 4

[PATCH 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Guillaume Raffin (＠TheElectronWill) April 26, 2026

April 26, 2026

These functions are necessary to make some smartcard-based programs work. They rely on the "SmartCard Database", which can be found in the windows registry, at \`HKLM\\SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards\`. I have added extensive unit tests and validated the implementation with a real application (an internal program based on Atos CardOS). As this is my first PR here, please don't hesitate to tell me if something's wrong! I was wondering if the database-related code should be moved to a dedicated file `winscard-database.c`? same for the tests?), let me know what you think. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751

2 4

[PATCH v2 0/2] MR10750: msado15: Handle BSTR bookmarks in _Recordset::Find.
by Piotr Caban (＠piotr) April 26, 2026

April 26, 2026

-- v2: msado15: Handle BSTR bookmarks in _Recordset::Find. https://gitlab.winehq.org/wine/wine/-/merge_requests/10750

2 2

[PATCH 0/2] MR10750: msado15: Handle BSTR bookmarks in _Recordset::Find.
by Piotr Caban (＠piotr) April 26, 2026

April 26, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10750

2 2

[PATCH 0/1] MR10748: wusa: Recognize runtime.syswow64 expressions.
by David Carrasco Flores (＠dcf1007) April 26, 2026

April 26, 2026

Some update manifests use $(runtime.syswow64) as an explicit target for the 32-bit system directory. wusa currently handles runtime.system32 with WoW64-aware redirection, but does not recognize runtime.syswow64, causing expression expansion to fail. Map runtime.syswow64 to CSIDL_SYSTEMX86 on x86_64, matching the existing runtime.programfilesx86 and runtime.commonfilesx86 handling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10748

3 3

[PATCH 0/1] MR10749: secur32: Handle SEC_WINNT_AUTH_IDENTITY_EX in the Negotiate provider.
by Hans Leidekker (＠hans) April 26, 2026

April 26, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59689 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10749

2 1

[PATCH v2 0/1] MR10747: kernelbase: Add message string for error 318-326
by Antoine Leresche (＠A2va) April 25, 2026

April 25, 2026

-- v2: kernelbase: Add message string for error 318-326 https://gitlab.winehq.org/wine/wine/-/merge_requests/10747

2 1

[PATCH 0/1] MR10746: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) April 25, 2026

April 25, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10746

2 1

[PATCH v5 0/1] MR10459: vbscript: Implement DateDiff built-in function.
by Francis De Brabandere (＠francisdb) April 25, 2026

April 25, 2026

Implement DateDiff(interval, date1, date2 [, firstdayofweek [, firstweekofyear]]) with support for all interval types: yyyy, q, m, y, d, w, ww, h, n, s. For yyyy/q/m the difference is computed from calendar fields via VarUdateFromDate. For d/y the day number difference is used. For w it is the day difference integer-divided by 7 (not affected by firstdayofweek). For ww it counts week boundary crossings based on firstdayofweek. For h/n/s the dates are converted to the respective unit and truncated before subtracting. Returns VT_I4 (Long). Null date arguments return Null; null interval or null firstdayofweek/firstweekofyear return VBSE_ILLEGAL_NULL_USE. -- v5: vbscript: Implement DateDiff built-in function. https://gitlab.winehq.org/wine/wine/-/merge_requests/10459

2 1

[PATCH v2 0/3] MR10741: Draft: msxml3: Support for max-element-depth property.
by Nikolay Sivov (＠nsivov) April 24, 2026

April 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: msxml3/sax: Add support for max-element-depth property. msxml3/tests: Extend MaxElementDepth tests. msxml3/tests: Add some tests for max-element-depth property. https://gitlab.winehq.org/wine/wine/-/merge_requests/10741

2 3

Re: [PATCH v2 0/1] MR10744: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10744

1 0

Re: [PATCH v2 0/4] MR10742: msado15: Add partial implementation of IRowsetFind::FindNextRow in rowset wrapper. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10742

1 0

Re: [PATCH v5 0/1] MR10456: vbscript: Implement DatePart built-in function. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10456

1 0