- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/1] MR10456: vbscript: Implement DatePart built-in function. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10456

1 0

Re: [PATCH v2 0/6] MR10740: msxml3: Improvements to node name validation. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10740

1 0

Re: [PATCH v2 0/3] MR10628: nsiproxy.sys: Avoid null pointer dereference on if_nameindex() failure. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10628

1 0

Re: [PATCH v2 0/3] MR10738: urlmon,itss: Fix -Wunused-but-set-global warnings. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10738

1 0

Re: [PATCH v2 0/2] MR10734: winspool, localspl: Remove unused variables. - approved
by Alexandre Julliard (＠julliard) April 24, 2026

April 24, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10734

1 0

[PATCH v15 0/4] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v15: vbscript: Pass script LCID to VariantChangeType in to_system_time helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 5

[PATCH 0/1] MR10744: po: update Polish translation
by Adam Markowski (＠AMark) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10744

2 1

[PATCH 0/4] MR10743: small odbc fixes
by Ivan Ivlev (＠iviv) April 24, 2026

April 24, 2026

1)odbc32: compare strings case-insensitively in get_driver_filename() Driver names should be compared without case-sensetivity. unixODBC has no problems when testDSN got "Driver = SQLite3" instead of "Driver = SQLITE3" https://learn.microsoft.com/en-us/openspecs/sql_server_protocols/ms-odbcstr… 2)odbc32: skip set_value for NULL filename in replicate_odbc_to_registry() get_driver_filename can return NULL, for example when \~/.odbc.ini contains driver that has been deleted. We want to prevent SIGSEGV because of wcslen(filename) when filename is NULL. 3)odbc32: check if row_number is NULL in param_options_unix() According to documentation, SQLParamOptions can accept NULL row_number. Now when NULL row_nuber is passed, crash happens 4)odbc32: make sure ODBC_CALL returns SQLRETURN Not sure about this one, need opinion. The targeted problem: now ODBC_CALL return SQLRETURN which is truncated from NTSTATUS. If WINE_UNIX_CALL fails at some point, ODBC_CALL returns truncated NTSTATUS error code, STATUS_ACCESS_VIOLATION (0xC0000005) truncated to 5, then function gets invalid SQLRETURN. The following solution checks of NTSTATUS is actually short SQLRETURN casted to NTSTATUS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10743

3 5

[PATCH v14 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v14: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v13 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v13: vbscript: Pass script LCID to VariantChangeType in to_string helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v12 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v12: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v22 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v22: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 6

[PATCH 0/4] MR10742: msado15: Add partial implementation of IRowsetFind::FindNextRow in rowset wrapper.
by Piotr Caban (＠piotr) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10742

2 4

[PATCH v2 0/6] MR10739: opengl32/tests: Test object names allocation and sharing.
by Rémi Bernon (＠rbernon) April 24, 2026

April 24, 2026

-- v2: opengl32/tests: Test object types shared namespaces. opengl32/tests: Test wglShareLists sharing of GLsync objects. opengl32/tests: Test wglShareLists sharing of various types. opengl32/tests: Test implicit object allocation support. opengl32/tests: Declare and load every GL/WGL functions. opengl32/tests: Remove unnecessary window creation check. https://gitlab.winehq.org/wine/wine/-/merge_requests/10739

2 7

[PATCH v11 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v11: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 1

[PATCH 0/6] MR10739: opengl32/tests: Test object names allocation and sharing.
by Rémi Bernon (＠rbernon) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10739

3 7

[PATCH v10 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v10: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

3 2

Re: [PATCH v4 0/1] MR10456: vbscript: Implement DatePart built-in function. - approved
by Jacek Caban (＠jacek) April 24, 2026

April 24, 2026

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10456

1 0

[PATCH v11 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v11: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

3 6

[PATCH 0/3] MR10741: msxml3: Support for max-element-depth property.
by Nikolay Sivov (＠nsivov) April 24, 2026

April 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10741

2 3

[PATCH 0/6] MR10740: msxml3: Improvements to node name validation.
by Nikolay Sivov (＠nsivov) April 24, 2026

April 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10740

2 6

[PATCH 0/3] MR10738: urlmon,itss: Fix -Wunused-but-set-global warnings.
by Jacek Caban (＠jacek) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10738

2 3

[PATCH v5 0/2] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != source buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_w_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- v5: fix hotspot clamping to max dim instead of 1px offset https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 2

[PATCH v4 0/1] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != soruce buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_w_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- v4: Optional handling of XQueryBestCursor https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 1

[PATCH 0/1] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != soruce buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_x_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 1