- Wine-GitLab - list.winehq.org

[PATCH v5 0/3] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 3, 2026

March 3, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v5: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Add a test for bogus SP values from GetThreadContext(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 3

[PATCH v3 0/3] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 3, 2026

March 3, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v3: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Add a test for bogus SP values from GetThreadContext(). ntdll: Avoid exposing non-user rsp in normal syscall return path https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 3

[PATCH v2 0/1] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 3, 2026

March 3, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v2: ntdll: Avoid exposing non-user rsp in normal syscall return path https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 1

[PATCH 0/3] MR10231: winegstreamer: Implement presentation clock functions for media sink.
by Ziqing Hui (＠zhui) March 3, 2026

March 3, 2026

This is needed by MF sink writer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10231

2 3

[PATCH v7 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2
by pan hui (＠panhui) March 3, 2026

March 3, 2026

An application adds a new button using IFileDialogCustomize_AddPushButton. The application obtains IServiceProvider_iface through QueryInterface using the parameter IFileDialogCustomize_iface of the callback function IFileDialogControlEvents_OnButtonClicked, and then uses IServiceProvider_iface to pass IID_IFolderView and IID_IFolderView2 through IServiceProvider_fnQueryService to obtain IFolderView2. After that, it obtains the selected files and folders through IFolderView2_GetSelection. Currently, the implementation of obtaining IFolderView2 through IServiceProvider_fnQueryService is missing and needs to be added. -- v7: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2 https://gitlab.winehq.org/wine/wine/-/merge_requests/10193

2 1

[PATCH v3 0/2] MR10008: start: Fix arg parsing for quoted paths ending with backslash.
by Yeshun Ye (＠yeyeshun) March 3, 2026

March 3, 2026

When using the `start` command with a `/d` switch specifying a quoted path that ends with a backslash (e.g., `start /d "c:\path\" app.exe`), subsequent arguments were incorrectly concatenated into the path string due to parsing ambiguity. The error I encountered was with `start /d "c:\temp\" test.exe`, which was parsed into the arguments `/d` and `"c:\temp\" test.exe`. The path and the executable were merged into a single argument as a new path, preventing the child process from launching. In my first patch, I attempted to identify and split this combined argument, but this caused test failures in `kernel32`. I then retested on Windows and found that Windows also parses it as `/d` and `"c:\temp\" test.exe`—Wine's parsing is consistent with Windows. However, `start` works correctly on Windows because it is a built-in command, whereas in Wine, `start` is an external executable, leading to different behavior. Signed-off-by: YeshunYe yeyeshun(a)uniontech.com -- v3: start: Re-parsing the command line. https://gitlab.winehq.org/wine/wine/-/merge_requests/10008

3 5

[PATCH 0/1] MR10230: combase: Add RoFailFastWithErrorContext stub
by Alistair Leslie-Hughes (＠alesliehughes) March 2, 2026

March 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10230

3 3

[PATCH 0/3] MR10229: Add windows.ui.text.core.idl
by Alistair Leslie-Hughes (＠alesliehughes) March 2, 2026

March 2, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10229

2 3

Re: [PATCH v4 0/6] MR10204: cfgmgr32: Get rid of setupapi dependency in DevObject* implementation (2/2). - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10204

1 0

Re: [PATCH v5 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222

1 0

Re: [PATCH v2 0/2] MR10215: Improve mouse in pointer message flags - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10215

1 0

Re: [PATCH v2 0/1] MR10211: include: Add IDataTransferManagerInterop interface - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10211

1 0

Re: [PATCH v2 0/1] MR10212: propsys: Add more System Device Properties. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10212

1 0

Re: [PATCH v4 0/4] MR10089: mciavi32: Fix handling of the end position in the play command. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10089

1 0

Re: [PATCH v3 0/1] MR10216: winebth.sys: Ignore incoming method calls that are not from BlueZ. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10216

1 0

Re: [PATCH v2 0/1] MR10214: shell32: Only compute HASSUBFOLDER if requested. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10214

1 0

Re: [PATCH v2 0/1] MR10218: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) March 2, 2026

March 2, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10218

1 0

[PATCH 0/1] MR10228: ntoskrnl.exe: Add stub for KdChangeOption().
by Nello De Gregoris (＠bluechxin) March 2, 2026

March 2, 2026

Found while testing Persona 5: The Phantom X. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10228

2 1

Re: [PATCH v11 0/3] MR10225: libs/xml2: Tolerate embedded XML declarations inside elements.
by Nikolay Sivov (＠nsivov) March 2, 2026

March 2, 2026

> Test that loadXML() and load() correctly handle XML documents with > embedded <?xml?> declarations inside elements. Windows MSXML rejects > these documents (returns S_FALSE), while Wine's patched libxml2 > tolerates them and emits the embedded content as text nodes. This part is the problem. Tests included here do not point to an issue, but show that such documents are invalid both on Windows, and currently on Wine. We should not make them valid on Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10225#note_131003

1 0

[PATCH 0/1] MR7419: wininet: Fix crash when connection is null in NETCON_secure_connect
by Yongjie Yao (＠yaoyongjie) March 2, 2026

March 2, 2026

There will be crashed when connect is null, so we need avoid crash by checking connect value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7419

4 3

[PATCH 0/20] MR10227: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) March 2, 2026

March 2, 2026

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10227

2 2

[PATCH v6 0/1] MR10193: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2
by pan hui (＠panhui) March 2, 2026

March 2, 2026

An application adds a new button using IFileDialogCustomize_AddPushButton. The application obtains IServiceProvider_iface through QueryInterface using the parameter IFileDialogCustomize_iface of the callback function IFileDialogControlEvents_OnButtonClicked, and then uses IServiceProvider_iface to pass IID_IFolderView and IID_IFolderView2 through IServiceProvider_fnQueryService to obtain IFolderView2. After that, it obtains the selected files and folders through IFolderView2_GetSelection. Currently, the implementation of obtaining IFolderView2 through IServiceProvider_fnQueryService is missing and needs to be added. -- v6: dlls/comdlg32：Add the implementation of IServiceProvider_fnQueryService to obtain IFolderView2 https://gitlab.winehq.org/wine/wine/-/merge_requests/10193

3 2

[PATCH v4 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) March 2, 2026

March 2, 2026

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v4: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Select a default voice in synthesizer. windows.media.speech: Add more tests about default voice. windows.media.speech: Finish implementation of voice information view. windows.media.speech/tests: Add tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Add a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 10

Re: [PATCH v2 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values
by Elizabeth Figura (＠zfigura) March 2, 2026

March 2, 2026

On Sun Mar 1 11:59:02 2026 +0000, Vibhav Pant wrote: > Characteristics are how most IO in BLE is done, so I wanted to minimize > the roundtrips between PE and Unix as much as possible (given that the > wineserver IPC already going to make this slow). Plus, from my > understanding, most GATT services tend to limit the size of the values > to the default MTU (23 or so bytes). This way, most value reads should > be happening inline anyway. This, and a lot of things honestly, seem like premature optimization. Even if the cost of a Unix call weren't already small in comparison with the server I/O, or indeed the actual hardware I/O, I think it'd still be a mistake to be adding extra code to optimize before we have any evidence it matters. Same sort of thing about splitting up all the locks, which I've already talked about. It seems unlikely we need more than one; we don't _know_ we need more than one, and the extra complexity just makes things harder and risks deadlocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10208#note_130970

1 0

[PATCH 0/1] MR10226: change vkb hidraw handling to catchall
by Ty (＠chaos) March 2, 2026

March 2, 2026

now supports new modular hardware and user custom pid reason: in consulting with a large number of vkb device users it was found their pid is arbitrary for modular items (pid gets xor'd for each component plugged in), and devices can be software modified to have different numbers of axis/buttons, or user modified pid's. vkb have no known (to me) VID collisions so should be safe to just catch-all. Contingency for failure: if a hypothetical future device existed from vkb that didnt want hidraw (xinput gamepad), an explicit exemption for that device pid would be the solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10226

2 2