- Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR1286: secur32: Implement graceful secure connection shutdown.
by Paul Gofman (＠gofman) Nov. 8, 2022

Nov. 8, 2022

... and fix output buffer allocation on the way. I am not aware of any app which strictly depends on the ApplyControlToken / connection shutdown to be implemented. Yet I saw a few games calling ApplyToken to perform the connection shutdown (similar to what is described in [1]). I once implemented that while debugging something and probably it makes some sense support secure connection shutdown once the app tries to do so (which as I understand is now recommended to do before closing socket). 1. https://learn.microsoft.com/en-us/windows/win32/secauthn/shutting-down-an-s… -- v2: secur32: Implement ApplyControlToken for SCHANNEL_SHUTDOWN. secur32: Add semi-stub for ApplyControlToken (schannel). secur32: Allocate buffer for either ISC_REQ_ALLOCATE_MEMORY or NULL output in schan_InitializeSecurityContextW(). secure32/tests: Add tests for ApplyControlToken (schannel). https://gitlab.winehq.org/wine/wine/-/merge_requests/1286

3 5

[PATCH v6 0/3] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) Nov. 8, 2022

Nov. 8, 2022

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v6: mf/samplegrabber: Handle samples receieved in paused state. mf/samplegrabber: Process samples in paused state in ignore_clock mode. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

4 6

[PATCH v3 0/5] MR1262: mf: Set source and output nodes media types in the media session.
by Bernhard Kölbl Nov. 8, 2022

Nov. 8, 2022

Supersedes: https://gitlab.winehq.org/wine/wine/-/merge_requests/789 This MR, with patches from Rémi should fix the no sound issue in media engine and also the black screen issue with MfPlayer.exe. -- v3: mf: Set media types for output nodes in the media session. mf: Assume same up and downstream media type for copier creation. mf/tests: Test for copier node in topology using evr. mf: Add some topology source node checks in IMFMediaSession_SetTopology. mf: Always enumerate branch source types for transform nodes. https://gitlab.winehq.org/wine/wine/-/merge_requests/1262

4 9

[PATCH 0/1] MR1294: netprofm: Store a list manager pointer in the network object instead of...
by Hans Leidekker (＠hans) Nov. 8, 2022

Nov. 8, 2022

netprofm: Store a list manager pointer in the network object instead of creating a new list manager. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1294

2 1

[PATCH 0/1] MR1293: shell32: Improve timeout detection in shlexec tests.
by eric pouech (＠epo) Nov. 8, 2022

Nov. 8, 2022

Some shlexec tests timeout on Windows10 (and generate errors as no action has been executed). Improve detection of timeout in child program (so that existing workaround in shell_execute_ex can be triggered). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1293

2 1

[PATCH 0/2] MR1166: ntdll: don't claim to have not found a library that is in place
by Konstantin Kharlamov (＠Hi-Angel) Nov. 8, 2022

Nov. 8, 2022

When `import_dll` function gets `STATUS_DLL_NOT_FOUND` from `load_dll()`, it has no way of distinguishing whether it's a dependency for the dll wasn't found, or the dll itself is missing. That results in confusing ERR messages, where a dll is found, but wine claims it isn't. Fix this by moving the print to the actual place that is aware of whether it's the parent or the child dll haven't been found. Log before: 0024:err:module:import_dll Library lib2.dll (which is needed by L"Z:\\tmp\\lib1.dll") not found 0024:err:module:import_dll Library lib1.dll (which is needed by L"Z:\\tmp\\a.exe") not found Log after: 0024:err:module:load_dll Library L"lib2.dll" (which is needed by L"Z:\\tmp\\foo\\lib1.dll") not found 0024:err:module:import_dll Loading library lib2.dll (which is needed by L"Z:\\tmp\\foo\\lib1.dll") failed (error c0000135). 0024:err:module:import_dll Loading library lib1.dll (which is needed by L"Z:\\tmp\\foo\\a.exe") failed (error c0000135). -------- While it's just about prints, but it costed me hours of wandering *(because if I know where to find the dependency dll, but I see that the main dll is also "not found" despite being "right there", I have to research the latter problem that looks more complicated. But given enough resources applied, it then turns out to be a faux)*. As a fun fact, I am apparently not the only one to have stumbled upon. Here's a screenshot of a `#english` chat where I asked about a commit title correctness. It's the last place where you'd expect to find someone familiar with WINE, and yet here's a person that had to deal with that exact error as well: ![Screenshot_20221026_023411](/uploads/55552d7c335ef5ce0b507f61adacbb00/Screenshot_20221026_023411.png) So, I think it's kinda serious problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1166

4 13

[PATCH 0/3] MR1291: dwrite: fix get fontface frome cache is error.
by Jiajin Cui (＠jin-king1) Nov. 8, 2022

Nov. 8, 2022

Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1291

4 9

Re: [PATCH v2 0/1] MR1232: ntdll: Set the QoS class of the main Wine thread on macOS.
by Huw Davies (＠huw) Nov. 8, 2022

Nov. 8, 2022

@bshanks this is producing a compiler warning here: ``` gcc -m32 -c -o dlls/ntdll/unix/loader.o dlls/ntdll/unix/loader.c -Idlls/ntdll -Iinclude -D__WINESRC__ -DWINE_NO_LONG_TYPES \ -D_NTSYSTEM_ -D_ACRTIMP= -DWINBASEAPI= -D_MSVCR_VER=0 -DBINDIR=\"/usr/local/bin\" \ -DSYSTEMDLLPATH=\"\" -DDLL_TO_BINDIR=\"`tools/makedep -R /usr/local/lib/wine /usr/local/bin`\" \ -DBIN_TO_DATADIR=\"`tools/makedep -R /usr/local/bin /usr/local/share/wine`\" -DWINE_UNIX_LIB -Wall -pipe \ -fno-stack-protector -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Winit-self -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits -Wvla \ -Wwrite-strings -Wpointer-arith -gdwarf-4 -fno-omit-frame-pointer -fPIC \ -fasynchronous-unwind-tables -O2 -g -Wno-deprecated-declarations -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 dlls/ntdll/unix/loader.c:2339:9: warning: address of function 'pthread_attr_set_qos_class_np' will always evaluate to 'true' [-Wpointer-bool-conversion] if (pthread_attr_set_qos_class_np) ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dlls/ntdll/unix/loader.c:2339:9: note: prefix with the address-of operator to silence this warning if (pthread_attr_set_qos_class_np) ^ & 1 warning generated. ``` Why do we need the test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1232#note_13594

1 0

[PATCH 0/1] MR1289: uuid: Add propkey.h.
by Alex Henrie (＠alexhenrie) Nov. 8, 2022

Nov. 8, 2022

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1289

4 3

Re: [PATCH v4 0/8] MR1275: opengl32: Use the unixlib interface in more windows functions.
by Rémi Bernon Nov. 8, 2022

Nov. 8, 2022

Rebased and added a change for the macOS build that should solve the build failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1275#note_13590

1 0

[PATCH 0/1] MR1285: winealsa: Set name of internal threads.
by Brendan Shanks (＠bshanks) Nov. 8, 2022

Nov. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1285

3 2

[PATCH 0/1] MR1284: winepulse: Set name of internal threads.
by Brendan Shanks (＠bshanks) Nov. 8, 2022

Nov. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1284

3 2

[PATCH 0/1] MR1283: dsound: Set name of internal threads.
by Brendan Shanks (＠bshanks) Nov. 8, 2022

Nov. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1283

3 2

[PATCH 0/3] MR1280: riched20: Don't send EN_CHANGE events during window creation
by Evan Tang (＠etang-cw) Nov. 8, 2022

Nov. 8, 2022

Fixes an issue in GenoPro where existing data would be cleared whenever you went to edit it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1280

4 7

[PATCH 0/3] MR1292: uxtheme: Protect CloseThemeData() from invalid input.
by Zhiyi Zhang (＠zhiyi) Nov. 8, 2022

Nov. 8, 2022

The first patch is from Dmitry. I asked him before sending it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1292

3 4

[PATCH 0/1] MR1255: gitlab: Run win64 tests instead of wow64.
by Rémi Bernon Nov. 8, 2022

Nov. 8, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1241. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

3 4

[PATCH 0/1] MR1207: comctl32/edit: Prevent a use after free
by Mark Jansen (＠learn-more) Nov. 8, 2022

Nov. 8, 2022

This was observed in ReactOS, when 'Debug Page Heap'[^1] was enabled: - Start renaming a file in a shell view - Cancel the renaming [^1]: DPH is modeled after 'Windows Page Heap Verification' -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1207

3 8

[PATCH v10 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) Nov. 8, 2022

Nov. 8, 2022

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v10: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Do not store debug message callback in kernel callback table. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 11

[PATCH v4 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) Nov. 8, 2022

Nov. 8, 2022

The function is implemented by setting cache file pointer to fill read_buf. Consequently, when HTTPREQ_ReadFile is called, it will try reading data from cache after read_buf is depleted, before continuing reading from http stream. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=26570 -- v4: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 3

[PATCH 0/4] MR1286: secur32: Implement graceful secure connection shutdown.
by Paul Gofman (＠gofman) Nov. 8, 2022

Nov. 8, 2022

... and fix output buffer allocation on the way. I am not aware of any app which strictly depends on the ApplyControlToken / connection shutdown to be implemented. Yet I saw a few games calling ApplyToken to perform the connection shutdown (similar to what is described in [1]). I once implemented that while debugging something and probably it makes some sense support secure connection shutdown once the app tries to do so (which as I understand is now recommended to do before closing socket). 1. https://learn.microsoft.com/en-us/windows/win32/secauthn/shutting-down-an-s… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1286

3 5

[PATCH 0/1] MR1287: ws2_32/tests: Don't test protocol name in test_WSASocket().
by Paul Gofman (＠gofman) Nov. 8, 2022

Nov. 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53893 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1287

3 2

[PATCH v2 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon Nov. 7, 2022

Nov. 7, 2022

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v2: ntdll: Fix call_user_mode_callback cfi. ntdll: Tweak KeUserModeCallback to please Valgrind and GDB. ntdll: Introduce a new ntdll_dispatch_syscall helper. tools: Add suppressions from third party libraries. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. winebuild: Enable unwind tables by default in PE files. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 13

[PATCH 0/1] MR1282: ntoskrnl.exe: Implement ExInterlockedInsertTailList.
by Etaash Mathamsetty (＠etaash.mathamsetty) Nov. 7, 2022

Nov. 7, 2022

I'm not exactly sure what is calling this function, but it's probably that anti virus I installed to test the KeInitializeGuardedMutex implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1282

2 1

[PATCH 0/1] MR1244: Draft: ntdll/tests: Test syscall SSE register save / restore strategy.
by Rémi Bernon Nov. 7, 2022

Nov. 7, 2022

Showing that only non-volatile registers are reliably saved. Volatile registers are only saved by NtGetContextThread whenever it interrupts a thread in user space, and are otherwise returned from some previous, possibly outdated, state. @jacek Unless I'm missing something, I think this shows that we do not have to save the full context in syscalls in general, and instead only the non-volatile XMM registers? NtGetContextThread syscall still probably needs to save the full context and it should probably be using a specific code path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1244

4 8

Re: [PATCH v2 0/6] MR1158: winegstreamer: Add a skeleton MPEG layer-3 decoder filter. - approved
by Alexandre Julliard (＠julliard) Nov. 7, 2022

Nov. 7, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1158

1 0