- Wine-GitLab - list.winehq.org

[PATCH v3 0/2] MR1263: kernelbase: Fix VerQueryValueW with no data
by Mark Jansen (＠learn-more) Nov. 4, 2022

Nov. 4, 2022

xul.dll from Mypal 27.9.4 has a resource entry without any data. Windows returns this as null-terminated string, instead of pointing past the data. The first commit adds a test, the second commit fixes the bugs (and removes the todo_wine). Original ticket for reference: https://jira.reactos.org/browse/CORE-15781 -- v3: kernelbase: Fix VerQueryValueW with no data https://gitlab.winehq.org/wine/wine/-/merge_requests/1263

2 2

[PATCH v3 0/6] MR1001: winebuild: Reimplement dlltool for import lib and delay import lib generation.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

This is slightly different from dlltool but I think it should be compatible. The transition is done by first replacing dlltool with its bugs, and fixing them in separate changes. I based the ARM / AARCH64 implementation on the existing code around, but I have no idea if it is correct, and dlltool also doesn't include any delay load implementation for ARM. -- v3: winebuild: Put the delay import descriptor in data section. winebuild: Fix import hint value for symbols imported by name. winebuild: Implement delay import lib generation without dlltool. makedep: Pass DLLFLAGS to winebuild --implib invocations. winebuild: Implement import lib generation without dlltool. winebuild: Introduce a new --without-dlltool winebuild flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/1001

2 11

[PATCH 0/1] MR1264: winebuild: Avoid calling asm_name twice in function arguments.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

It returns a static buffer pointer and will free the first returned pointer on the second call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1264

1 1

[PATCH 0/2] MR1263: kernelbase: Fix VerQueryValueW with no data
by Mark Jansen (＠learn-more) Nov. 4, 2022

Nov. 4, 2022

xul.dll from Mypal 27.9.4 has a resource entry without any data. Windows returns this as null-terminated string, instead of pointing past the data. The first commit adds a test, the second commit fixes the bugs (and removes the todo_wine). Original ticket for reference: https://jira.reactos.org/browse/CORE-15781 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1263

3 3

[PATCH v2 0/2] MR1263: kernelbase: Fix VerQueryValueW with no data
by Mark Jansen (＠learn-more) Nov. 4, 2022

Nov. 4, 2022

xul.dll from Mypal 27.9.4 has a resource entry without any data. Windows returns this as null-terminated string, instead of pointing past the data. The first commit adds a test, the second commit fixes the bugs (and removes the todo_wine). Original ticket for reference: https://jira.reactos.org/browse/CORE-15781 -- v2: kernelbase: Fix VerQueryValueW with no data version/tests: Add a test for an empty value in VerQueryValueW https://gitlab.winehq.org/wine/wine/-/merge_requests/1263

2 2

[PATCH v4 0/8] MR1206: mshtml: More misc improvements.
by Gabriel Ivăncescu Nov. 4, 2022

Nov. 4, 2022

The storage event url prop fix is tested after the location.hash tests are added, implicitly. I didn't find a need to add extra tests for no reason there. The super_navigate changes for fragments is also necessary for the location.hash tests (and its behavior, apparently)… -- v4: mshtml: Implement document.importNode. mshtml: Implement HTMLLocation_put_hash. mshtml: Always use super_navigate when navigating fragments. mshtml: Don't include fragment in storage event's url prop. mshtml: Return E_ABORT if wine-gecko's OnDataAvailable aborts the binding. mshtml: Improve locale stub for KeyboardEvent. mshtml: Implement isContentEditable for HTML elements. mshtml/tests: Handle broken localStorage on native. https://gitlab.winehq.org/wine/wine/-/merge_requests/1206

3 12

[PATCH 0/1] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

2 4

[PATCH 0/6] MR1262: mf: Set source and output nodes media types in the media session.
by Bernhard Kölbl Nov. 4, 2022

Nov. 4, 2022

Supersedes: https://gitlab.winehq.org/wine/wine/-/merge_requests/789 This MR, with patches from Rémi should fix the no sound issue in media engine and also the black screen issue with MfPlayer.exe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1262

3 7

[PATCH 0/4] MR789: mf: Set source and output nodes media types in the media session.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/789

3 11

[PATCH v3 0/3] MR1247: windows.gaming.ui.gamebar: Add DLL.
by Paul Gofman (＠gofman) Nov. 4, 2022

Nov. 4, 2022

-- v3: windows.gaming.ui.gamebar: Add IGameBarStatics interface. windows.gaming.ui.gamebar: Add stub DLL. include: Add windows.gaming.ui.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/1247

4 6

[PATCH 0/2] MR1162: ntdll: Use local unwinding reimplementations for Unix libraries on ARM
by Martin Storsjö Nov. 4, 2022

Nov. 4, 2022

Currently, unwinding the unix libraries (or full ELF builds) requires having libunwind available. When starting up a wine environment, an exception of type `RPC_S_SERVER_UNAVAILABLE` gets thrown - and if libunwind isn't available, this breaks the startup. Thus, currently on ARM/ARM64, libunwind is essentially mandatory. Additionally, at least on ARM, libunwind seems brittle (commits in latest git master breaks the unwinding use cases in Wine, see e.g. https://github.com/libunwind/libunwind/pull/203#issuecomment-984126066. For ARM, libunwind has currently relied on DWARF debug info in the `.debug_frame` section, since Linux on ARM doesn't use DWARF for runtime unwinding. This MR adds ARM EHABI unwind opcodes where necessary, and adds a local reimplementation of an ARM EHABI/EXIDX/EXTBL unwinder, similar to the DWARF one. With these changes, unwinding on ARM seems to work fine, even without libunwind. See the individual commit messages for more commentary on the decisions taken so far (I've tried to write up all relevant considerations there - it's a fair amount of commentery). A couple open questions: - I wrote the ARM EHABI unwind code mostly with `stdint.h` types like `uint32_t`(as it's in the ntdll/unix directory anyway), but I can rewrite it with `DWORD` or similar if that's preferred. - The ARM EHABI opcodes are enabled for `defined(__arm__) && defined(__ELF__) && defined(__GNUC__) && !defined(__SEH__) && !defined(__ARM_DWARF_EH__)` - there's no define to check for for knowing it's used and enabled, but it has to be implicitly assumed if no other other unwind mechanism is signaled. - The `dl_iterate_phdr` function, used for finding the EXIDX section for locating ARM EHABI unwind info, is used within `#ifdef linux`. It might be available on other OSes too (like FreeBSD etc). Or should I go ahead and add a configure check for it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1162

3 5

[PATCH v15 0/3] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) Nov. 4, 2022

Nov. 4, 2022

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v15: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 3

[PATCH v14 0/3] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) Nov. 4, 2022

Nov. 4, 2022

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v14: ntdll: Fix reading stale Information from IOSB. ws2_32: Access internal fields of WSAOVERLAPPED as IO_STATUS_BLOCK. kernelbase: Access internal fields of OVERLAPPED as IO_STATUS_BLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 3

[PATCH 0/1] MR1260: kernel32/test: Fix sporadic process test failure.
by eric pouech (＠epo) Nov. 4, 2022

Nov. 4, 2022

In attribute list test: - current test tries to ensure that a handle, valid in process' parent, hasn't been inherited - but nothing guarantees that a valid handle isn't present in child process with same value - so harden test to verify that the handle isn't the parent's pipe handle Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1260

2 1

[PATCH 0/5] MR1254: opengl32: Use the unixlib interface for more WGL functions.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

More work to split the module, still not using the syscalls yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1254

1 6

[PATCH 0/2] MR1258: cmd: Consider only first argument as console title in "start".
by Nikolay Sivov (＠nsivov) Nov. 4, 2022

Nov. 4, 2022

These patches are meant to fix batch files that are using quoted arguments like this: start /D "%~dp0" game.exe %* cmd adds extra quotes around directory path, assuming it's a console title. Later this does not work with start.exe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1258

3 3

[PATCH 0/1] MR1257: gdi32/tests: Fix assertion error message
by Tarcísio Ladeia de Oliveira Nov. 4, 2022

Nov. 4, 2022

A test had failed with ``` gdi32: font.c:6523: Test failed: expected a positive value, got 1 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1257

1 1

[PATCH v6 0/2] MR1182: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (i386).
by Jinoh Kang (＠iamahuman) Nov. 4, 2022

Nov. 4, 2022

This change is adding DWARF (CFI) unwind information to the hand-written assembly of the `__wine_syscall_dispatcher` function. This enables unwinding through the dispatcher from the Linux stack into (and through) the Windows stack. The general idea is that the `syscall_frame` struct contains the content of the callee-save registers before the function call (in particular the stack pointer and the return address). At any point of the execution, we have a pointer into the `syscall_frame` in $ebx, $ecx, $ebp, or $esp. For the CFI codes the general idea is that we are defining the computations of the callee-save registers based on the `syscall_frame` using DWARF’s `breg` instruction, rather than relative to CFA. cc/ @florian-kuebler -- v6: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (i386). ntdll: Move CFI helper macros out of signal_x86_64.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/1182

3 3

[PATCH v13 0/3] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) Nov. 4, 2022

Nov. 4, 2022

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v13: ntdll: Fix reading stale Information from IOSB. ws2_32: Access internal fields of WSAOVERLAPPED as IO_STATUS_BLOCK. kernelbase: Access internal fields of OVERLAPPED as IO_STATUS_BLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 3

Re: [PATCH v2 0/1] MR1248: kernel32: null-terminate the atom names passed to NtAddAtom - approved
by Huw Davies (＠huw) Nov. 4, 2022

Nov. 4, 2022

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1248

1 0

[PATCH v2 0/4] MR1237: gdi32/uniscribe: Add fall back font for Kana and CJK script.
by Ziqing Hui (＠zhui) Nov. 4, 2022

Nov. 4, 2022

This fixes Chinese and Japanese text display issue for Sins of a Solar Empire: Rebellion. -- v2: gdi32/uniscribe: Add fallback font for Kana and CJK script. https://gitlab.winehq.org/wine/wine/-/merge_requests/1237

3 5

[PATCH v10 0/3] MR231: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) Nov. 4, 2022

Nov. 4, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v10: server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children. server: Redraw composited window child when its z-order changes. server: Correctly expose composited parent window and its child on position change. https://gitlab.winehq.org/wine/wine/-/merge_requests/231

4 6

[PATCH 0/8] MR1256: winevulkan: Separate array and struct conversions.
by Jacek Caban (＠jacek) Nov. 4, 2022

Nov. 4, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1256

2 8

[PATCH 0/3] MR1241: gitlab: Split full MR testsuite run in individual jobs.
by Rémi Bernon Nov. 4, 2022

Nov. 4, 2022

This splits the full MR test run, with short running tests on a side and now executed for both Win64 and WOW64, roughly 5min each, and the long running tests executed only for Win64, taking roughly 20min. All are executed unconditionally, but we could maybe add some early exit if that feels useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1241

2 7

[PATCH 0/1] MR1253: cmd: Use the wcsrev function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) Nov. 4, 2022

Nov. 4, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1253

2 1