- Wine-GitLab - list.winehq.org

[PATCH v3 0/6] MR1231: Improve delete-on-close and delete disposition for files.
by eric pouech (＠epo) Nov. 3, 2022

Nov. 3, 2022

This series improves Wine's support for delete-on-close flag and delete disposition information on files: - adapts tests for Windows 10 - extend and fix some tests - implement some missing features in ntdll & server -- v3: server: Let file creation fail depending unlink status. server: Propagate the unlink status to all opened/closed files. ntdll: Query FILE_STANDARD_INFORMATION.DeletePending from server. ntdll: Extend file tests about delete-on-close and disposition. ntdll: Fix share mode for some delete-on-close/delete disposition tests. ntdll: Adapt file tests on delete-on-close / delete disposition to Windows 10. https://gitlab.winehq.org/wine/wine/-/merge_requests/1231

3 8

[PATCH v2 0/2] MR1245: comctl32:edit test fixes for flaky failures (message sequences)
by Jinoh Kang (＠iamahuman) Nov. 3, 2022

Nov. 3, 2022

-- v2: comctl32/tests: Flush events before testing edit control IME messages. comctl32/tests: Flush events before testing edit control SetFocus() messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/1245

2 2

[PATCH v3 0/8] MR1206: mshtml: More misc improvements.
by Gabriel Ivăncescu Nov. 3, 2022

Nov. 3, 2022

The storage event url prop fix is tested after the location.hash tests are added, implicitly. I didn't find a need to add extra tests for no reason there. The super_navigate changes for fragments is also necessary for the location.hash tests (and its behavior, apparently)… -- v3: mshtml: Implement document.importNode. mshtml: Implement HTMLLocation_put_hash. mshtml: Always use super_navigate when navigating fragments. mshtml: Don't include fragment in storage event's url prop. mshtml: Return E_ABORT if wine-gecko's OnDataAvailable aborts the binding. mshtml: Improve locale stub for KeyboardEvent. mshtml: Implement isContentEditable for HTML elements. mshtml/tests: Handle broken localStorage on native. https://gitlab.winehq.org/wine/wine/-/merge_requests/1206

2 10

[PATCH 0/2] MR1245: comctl32:edit test fixes for flaky failures (message sequences)
by Jinoh Kang (＠iamahuman) Nov. 3, 2022

Nov. 3, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1245

4 4

[PATCH v8 0/3] MR231: Draft: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) Nov. 3, 2022

Nov. 3, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children. https://gitlab.winehq.org/wine/wine/-/merge_requests/231

4 9

Re: [PATCH v2 0/1] MR1219: ntdll: Fix building on Mojave / Xcode 11.3.1.
by Dean M Greer (＠Gcenx) Nov. 3, 2022

Nov. 3, 2022

I’d advice against building wine against Xcode11, the included version of cctools will cause weird breakages for 32Bit binaries. The default Xcode 10 command Line Tools version for Mojave is fine and comes with the headers package that installs the DevSDK like prior macOS versions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1219#note_12984

1 0

[PATCH 0/7] MR1243: winevulkan: Pass direction to needs_conversion helpers.
by Jacek Caban (＠jacek) Nov. 3, 2022

Nov. 3, 2022

Current solution of _set_direction() is very imprecise. This MR replaces it with more precise needs_conversion() functions. It already fixes a few cases and will be more important in the future, when we will use more generated conversion functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1243

2 7

Re: [PATCH v2 0/1] MR1229: msvcp90: Make _Condition_variable_* function pointers static - approved
by Piotr Caban (＠piotr) Nov. 3, 2022

Nov. 3, 2022

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1229

1 0

Re: [PATCH v2 0/1] MR1229: msvcp90: Make _Condition_variable_* function pointers static
by Wu Liande (＠wuliande) Nov. 3, 2022

Nov. 3, 2022

On Thu Nov 3 10:12:10 2022 +0000, Piotr Caban wrote: > I don't know why it crashes on startup on your machine but it's not > caused by _Condition_variable_notify_one being redefined in multiple .so > files (I guess you're using no-mingw build of Wine). Maybe there's e.g. > some kind of memory corruption that happens to be hidden by that change. > If you don't believe me that it's not the problem - the application > loads both msvcp120 and msvcp140, there are much more global symbols > with the same names and you don't see any problem caused by it. > Please change the commit message (patch title you set with git while > committing the patch, not only merge request title). Thanks for the tip I've updated the commit info -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1229#note_12971

1 0

[PATCH 0/2] MR1234: include: Add wcsncat_s.
by Alex Henrie (＠alexhenrie) Nov. 3, 2022

Nov. 3, 2022

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1234

4 4

[PATCH 0/2] MR1236: include: Add freopen_s.
by Alex Henrie (＠alexhenrie) Nov. 3, 2022

Nov. 3, 2022

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1236

3 3

[PATCH 0/2] MR1235: include: Add _splitpath_s.
by Alex Henrie (＠alexhenrie) Nov. 3, 2022

Nov. 3, 2022

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1235

3 3

[PATCH 0/1] MR1229: msvcrt: Fix crash due to global symbol coverage of dynamic libraries
by Wu Liande (＠wuliande) Nov. 3, 2022

Nov. 3, 2022

_Condition_variable_notify_one and DEFINE_THISCALL_WRAPPER(_Condition_variable_notify_one, 4) are redefined in other dynamic libraries. Therefore, it caused the problem of global symbol coverage, which caused crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1229

4 7

[PATCH 0/2] MR1242: winevulkan: Update to VK spec version 1.3.233.
by Georg Lehmann (＠DadSchoorse) Nov. 3, 2022

Nov. 3, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1242

2 2

[PATCH v13 0/3] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon Nov. 3, 2022

Nov. 3, 2022

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v13: win32u: Read mode from the registry if GetCurrentDisplaySettings fails. win32u: Write display settings to the registry in apply_display_settings. win32u: Lock display devices while applying display settings. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

3 5

[PATCH v2 0/3] MR1230: winebuild: Cleanup in preparation for dlltool replacement.
by Rémi Bernon Nov. 3, 2022

Nov. 3, 2022

For https://gitlab.winehq.org/wine/wine/-/merge_requests/1001. -- v2: winebuild: Split output_static_lib into output_(import|static)_lib. winebuild: Use asm_name to add underscore prefix in asm_globl. winebuild: Split get_link_name into a separate get_abi_name helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/1230

1 3

[PATCH v3 0/19] MR1191: Draft: msvcm: add missing function implementation to fix crashes
by Bartosz Kosiorek (＠gang65) Nov. 3, 2022

Nov. 3, 2022

After applying these patches, the applications Athenas ASS MHFU v3.42b and miniDSP/IL-DSP runs without crash, and working correctly. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=47304 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=32091 -- v3: msvcm90: add _Addstd implementation. msvcm90: add _Getgloballocale implementation. msvcm90: add _Clocptr_func implementation. msvcm90: add _Sync_func implementation. msvcm90: add _Index_func implementation. msvcm90: add _Init_ctor, _Init_dtor, _Init_locks_ctor, _Init_locks_dtor implementation. msvcm90: add _Init_cnt_func implementation. msvcm90: add _Id_func implementation. msvcm90: add _Id_cnt_func implementation. msvcm90: add _Fpz_func implementation. msvcm90: add _BADOFF_func implementation. msvcm90: add _Wcerr_func implementation. msvcm90: add _Wclog_func implementation. msvcm90: add _Wcout_func implementation. msvcm90: add _Cerr_func implementation. msvcm90: add _Clog_func implementation. msvcm90: add _Cout_func implementation. msvcm90: add _Wcin_func implementation. msvcm90: add _Cin_func implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1191

1 0

[PATCH 0/1] MR1238: mf/session: Add support for MESessionScrubSampleComplete event.
by Nikolay Sivov (＠nsivov) Nov. 3, 2022

Nov. 3, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1238

2 1

[PATCH 0/4] MR1237: gdi32/uniscribe: Add fall back font for Kana and CJK script.
by Ziqing Hui (＠zhui) Nov. 3, 2022

Nov. 3, 2022

This fixes Chinese and Japanese text display issue for Sins of a Solar Empire: Rebellion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1237

2 4

[PATCH 0/2] MR1233: winex11.drv: Support _NET_WM_FULLSCREEN_MONITORS.
by Zhiyi Zhang (＠zhiyi) Nov. 3, 2022

Nov. 3, 2022

Support _NET_WM_FULLSCREEN_MONITORS for fullscreen windows spanning multiple monitors. This property is used to hint window managers about which monitor a fullscreen window should cover. Window managers make a fullscreen window spanning multiple monitors cover only one monitor when this property is missing. Fix Project Cars 2/3 incorrect game window size when the triple-screen mode is on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1233

2 2

Re: [PATCH v2 0/1] MR1219: ntdll: Fix building on Mojave / Xcode 11.3.1.
by Stefan Dösinger Nov. 3, 2022

Nov. 3, 2022

$ shasum /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/_structs.h 28a8d4a04a365b9e77222876b7cddb5ee574a914 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/_structs.h -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1219#note_12916

1 0

Re: [PATCH v2 0/1] MR1219: ntdll: Fix building on Mojave / Xcode 11.3.1.
by Stefan Dösinger Nov. 3, 2022

Nov. 3, 2022

The `_STRUCT_X86_THREAD_FULL_STATE64` definition comes from `/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/_structs.h` . It does not contain `_STRUCT_MCONTEXT64_FULL` or `_STRUCT_MCONTEXT_AVX64_FULL`. There is a usr/include/i386/_mcontext.h file in 10.14.sdk, but it doesn't contain any of these definitions, unlike its cousins in later SDK versions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1219#note_12915

1 0

Re: [PATCH v2 0/1] MR1219: ntdll: Fix building on Mojave / Xcode 11.3.1.
by Stefan Dösinger Nov. 3, 2022

Nov. 3, 2022

bshanks was wondering about some details. While the fix seems sensible, it shouldn't be necessary according to him. I had a closer look, and indeed Xcode 11.3.1 is not the problem. The command line tools for Xcode 11.3.1 are. Having them installed, even without pointing xcode-select, DEVELOPER_DIR or SDKROOT to them does some magic, for good (32 bit programs compile) and bad (the bug fixed here). Some possibly relevant info: ``` grey:ntdll stefan$ xcode-select -p /Applications/Xcode.app/Contents/Developer grey:ntdll stefan$ sudo xcode-select -p /Applications/Xcode.app/Contents/Developer grey:ntdll stefan$ echo $DEVELOPER_DIR grey:ntdll stefan$ echo $SDKROOT ``` (Homebrew choked on a difference between xcode-select -p and sudo xcode-select -p once. I have no idea how that can happen, since xcode-select -s is system wide. Oh well) wine configure command line: `~/src/wine/configure --enable-win64 --without-x LDFLAGS="-L/Users/stefan/src/MoltenVK/Package/Latest/MoltenVK/dylib/macOS"` And the exact build failure: ``` gcc -m64 -c -o dlls/ntdll/unix/signal_x86_64.o /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c -Idlls/ntdll \ -I/Users/stefan/src/wine/dlls/ntdll -Iinclude -I/Users/stefan/src/wine/include -D__WINESRC__ \ -DWINE_NO_LONG_TYPES -D_NTSYSTEM_ -D_ACRTIMP= -DWINBASEAPI= -D_MSVCR_VER=0 -DWINE_UNIX_LIB -Wall \ -pipe -fcf-protection=none -fno-stack-protector -fno-strict-aliasing -Wdeclaration-after-statement \ -Wempty-body -Wignored-qualifiers -Winit-self -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits \ -Wvla -Wwrite-strings -Wpointer-arith -gdwarf-4 -fPIC -fasynchronous-unwind-tables -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 In file included from /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c:83: /Users/stefan/src/wine/dlls/ntdll/unix/dwarf.h:913:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value] case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^ /Users/stefan/src/wine/dlls/ntdll/unix/dwarf.h:913:45: note: remove the call to 'labs' since unsigned values cannot be negative case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^~~~ /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c:282:38: error: use of undeclared identifier '_STRUCT_MCONTEXT64_FULL' if (context->uc_mcsize == sizeof(_STRUCT_MCONTEXT64_FULL) || ^ /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c:283:38: error: use of undeclared identifier '_STRUCT_MCONTEXT_AVX64_FULL' context->uc_mcsize == sizeof(_STRUCT_MCONTEXT_AVX64_FULL) || ^ /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c:286:63: error: expected expression return (XMM_SAVE_AREA32 *)&((_STRUCT_MCONTEXT64_FULL *)context->uc_mcontext)->__fs.__fpu_fcw; ^ /Users/stefan/src/wine/dlls/ntdll/unix/signal_x86_64.c:286:38: error: use of undeclared identifier '_STRUCT_MCONTEXT64_FULL' return (XMM_SAVE_AREA32 *)&((_STRUCT_MCONTEXT64_FULL *)context->uc_mcontext)->__fs.__fpu_fcw; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1219#note_12913

1 0

Re: [PATCH v9 0/1] MR721: Draft: ntoskrnl: Implement cmp instruction with opcode 0x83
by Etaash Mathamsetty (＠etaash.mathamsetty) Nov. 3, 2022

Nov. 3, 2022

seems like Guy1524 already made an implementation for this (back in 2020), so I will fix that up, and bring it over here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/721#note_12912

1 0

[PATCH v4 0/6] MR1192: win32u: Improve handling of ppem == 0
by Tarcísio Ladeia de Oliveira Nov. 3, 2022

Nov. 3, 2022

Some fonts can end up with too low height for some sizes, resulting in ppem == 0, which can lead to some metrics becoming 0 too, especially tmHeight and tmAveCharWidth. This behavior is also observed on Windows, but on Linux it could lead to division by zero. This was noticed with the font `Emmentaler-Brace`, which comes with TexLive and GNU LilyPond, in the comctl32 status test. This patch set also tries to make the Wine behavior closer to the Windows one by enabling tmAveCharWidth to be 0 and preventing it and tmHeight from causing divisions by zero. This is very much an edge case, and I don't know if it has caused problems in actual programs, so I don't know if it would be worth it to make the behavior match exactly. But this way at least the tests should pass if some incomplete/misconfigured fonts are installed. I mainly limited myself to win32u. I'm not sure if these changes could affect behavior in other parts of the codebase, but the tests seems unchanged. -- v4: win32u: Allow tmAveCharWidth to be 0 when tmHeight == 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/1192

1 6