- Wine-GitLab - list.winehq.org

[PATCH v5 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) Sept. 15, 2022

Sept. 15, 2022

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v5: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

[PATCH v4 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) Sept. 15, 2022

Sept. 15, 2022

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v4: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Use pread in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Do not use hardcoded page shift in NtQueryVirtualMemory(MemoryWorkingSetExInformation) ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional page check https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

[PATCH v3 0/1] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) Sept. 15, 2022

Sept. 15, 2022

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. Signed-off-by: Witold Baryluk's avatarWitold Baryluk <witold.baryluk(a)gmail.com> -- v3: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread. https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 1

[PATCH 0/1] MR863: wininet/tests: Don't send two HTTP responses for a single request in server_thread.
by Jacek Caban (＠jacek) Sept. 15, 2022

Sept. 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/863

2 1

[PATCH v2 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)
by Connor McAdams (＠cmcadams) Sept. 15, 2022

Sept. 15, 2022

Changes since prior MR: - Check if HWND is valid after sending `WM_GETOBJECT` and getting a 0 return value. - Block on thread calling `UiaNodeFromHandle()` rather than the marshaling thread. - Squash `IWineUiaNode::get_prop_val` commit into commit where it is actually used. -- v2: uiautomationcore: Add tests for UiaNodeFromHandle. uiautomationcore: Create UI Automation client thread. uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Shutdown provider thread when all returned nodes are released. uiautomationcore: Increment module reference count when starting provider thread. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/846

2 7

[PATCH 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)
by Connor McAdams (＠cmcadams) Sept. 15, 2022

Sept. 15, 2022

Changes since prior MR: - Check if HWND is valid after sending `WM_GETOBJECT` and getting a 0 return value. - Block on thread calling `UiaNodeFromHandle()` rather than the marshaling thread. - Squash `IWineUiaNode::get_prop_val` commit into commit where it is actually used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/846

3 15

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub. - approved
by Huw Davies (＠huw) Sept. 15, 2022

Sept. 15, 2022

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827

1 0

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub.
by Huw Davies (＠huw) Sept. 15, 2022

Sept. 15, 2022

Looks like the app calls `WinUsb_Free(NULL)` on startup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8508

1 0

[PATCH 0/1] MR854: winevulkan: Update to VK spec version 1.3.228.
by Georg Lehmann (＠DadSchoorse) Sept. 15, 2022

Sept. 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/854

2 1

[PATCH v3 0/4] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) Sept. 15, 2022

Sept. 15, 2022

-- v3: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_LOAD_APP_KEY flag ntdll: Pass filename to server in NtLoadKeyEx. ntdll: Implement roothandle parameter for NtLoadKeyEx https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

[PATCH 0/6] MR844: win32u: Move display modes enumeration and WM_DISPLAYCHANGE out of graphics drivers.
by Rémi Bernon Sept. 15, 2022

Sept. 15, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/844

2 19

[PATCH 0/1] MR851: po: Update Dutch translation
by Floris Renaud (＠jkfloris) Sept. 15, 2022

Sept. 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/851

4 4

[PATCH v2 0/11] MR849: xmllite/writer: Add initial implementation of WriteNode().
by Nikolay Sivov (＠nsivov) Sept. 15, 2022

Sept. 15, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: xmllite/writer: Implement WriteNodeShallow(). xmllite/writer: Handle empty local name in WriteAttributeString(). xmllite/tests: Add a test for IsEmptyElement() on attributes. xmllite/tests: Add some more tests for WriteStartElement(). xmllite/writer: Add initial implementation of WriteNode(). xmllite/writer: Implement WriteAttributes(). xmllite/writer: Close open tag on WriteProcessingInstruction(). xmllite/writer: Close open tag on WriteRaw(). xmllite/writer: Handle empty prefix and uri correctly in WriteStartElement(). xmllite/writer: Implement WriteWhitespace(). xmllite/reader: Improve xml declaration node parsing. https://gitlab.winehq.org/wine/wine/-/merge_requests/849

2 11

[PATCH 0/1] MR853: kernelbase: Return system error codes in the ReadDirectoryChangesW() completion callback.
by Zhiyi Zhang (＠zhiyi) Sept. 15, 2022

Sept. 15, 2022

Return system error codes instead of NT status codes in the ReadDirectoryChangesW() completion callback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/853

2 1

[PATCH v4 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) Sept. 15, 2022

Sept. 15, 2022

-- v4: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

2 10

Re: [PATCH v2 0/2] MR827: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) Sept. 15, 2022

Sept. 15, 2022

Not sure who to request review from for this MR. Can anyone with approval privileges please review it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8471

1 0

[PATCH 0/4] MR850: server: Fix debug register getting/setting on macOS.
by Brendan Shanks (＠bshanks) Sept. 14, 2022

Sept. 14, 2022

- On macOS, add error reporting when getting/setting debug registers. - Also, as in ptrace.c, use context->machine to determine which context struct to read/write. - And when setting, ensure that the correct debug state flavor is used (needed for Wow64) The debug register tests should now pass on Mojave and Monterey, for 32- and 64-bit. Note that Rosetta 2 on Apple Silicon mostly doesn't emulate debug registers, and the tests fail there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/850

2 4

Re: [PATCH v4 0/1] MR804: mf: Assume maintainership of MF transforms. - approved
by Alexandre Julliard (＠julliard) Sept. 14, 2022

Sept. 14, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

1 0

Re: [PATCH v7 0/8] MR795: mshtml: Implement Storage Events. - approved
by Alexandre Julliard (＠julliard) Sept. 14, 2022

Sept. 14, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/795

1 0

Re: [PATCH v7 0/9] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface. - approved
by Alexandre Julliard (＠julliard) Sept. 14, 2022

Sept. 14, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/716

1 0

Re: [PATCH v2 0/2] MR845: tests: urlmon and wininet fixes - approved
by Alexandre Julliard (＠julliard) Sept. 14, 2022

Sept. 14, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/845

1 0

Re: [PATCH v14 0/2] MR787: notepad: Add status bar and goto line dialog - approved
by Alexandre Julliard (＠julliard) Sept. 14, 2022

Sept. 14, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787

1 0

[PATCH 0/9] MR849: xmllite/writer: Add initial implementation of WriteNode().
by Nikolay Sivov (＠nsivov) Sept. 14, 2022

Sept. 14, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/849

2 9

[PATCH 0/1] MR848: ntoskrnl: KeIpiGenericCall semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 14, 2022

Sept. 14, 2022

fixes bug #48989 based on a patch that was made in that issue -- https://gitlab.winehq.org/wine/wine/-/merge_requests/848

2 1

[PATCH 0/9] MR847: winegstreamer: Misc MF transform fixes and unifying.
by Rémi Bernon Sept. 14, 2022

Sept. 14, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/847

1 9