- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR606: msvcp90: Call 'setlocale' before 'mbstowcs_s'
by Piotr Caban (＠piotr) Aug. 18, 2022

Aug. 18, 2022

On Wed Aug 17 06:20:22 2022 +0000, Yeshun Ye wrote: > I built the demo by vs2003/vs2005/vs2008, and it printed 'read: ok' for > vs2003 building, but printed 'open file failed!' for vs2005/vs2008 > buildings. > I think "\_MSVCP_VER >= 71" can change to "\_MSVCP_VER >= 80" at least. > And I think it's a bug on vs2005/vs2008, do we have to be exactly the > same as windows? Why do we keep this bug? I've created MR !673 to fix msvcp71. I've made a mistake while testing it earlier. The idea is to implement the function as closely to native as possible. Applications may depend on bugs in libraries (and taking into account _Fiopen is an internal function it's not necessarily a bug). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/606#note_6472

1 0

[PATCH 0/1] MR673: msvcp71: Use MultiByteToWideChar in _Fiopen implemen.
by Piotr Caban (＠piotr) Aug. 18, 2022

Aug. 18, 2022

Also use MultiByteToWideChar in msvcp71. I've made a mistake while testing it earlier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/673

2 1

[PATCH 0/5] MR665: win32u: Tweak reading / writing of DEVMODEW into the registry.
by Rémi Bernon Aug. 18, 2022

Aug. 18, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576, for which I'll then add modes sorting, and move support for stretched / interlaced modes from winemac to win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/665

2 10

[PATCH v3 0/1] MR672: Draft: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 18, 2022

Aug. 18, 2022

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v3: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 2

[PATCH 0/10] MR658: winepulse: Switch to mmdevapi's unixlib.h
by Davide Beatrici (＠davidebeatrici) Aug. 18, 2022

Aug. 18, 2022

Follow-up to !600. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/658

3 20

Re: [PATCH v2 0/1] MR672: Draft: Common item dialog fixes
by Zhiyi Zhang (＠zhiyi) Aug. 18, 2022

Aug. 18, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/idb_hist_large.svg: > -<?xml version="1.0" encoding="UTF-8" standalone="no"?> > +<?xml version="1.0" encoding="UTF-8"?> >  > -<svg id="bitmap:120-32" xmlns="http://www.w3.org/2000/svg" height="24" width="120" version="1.1" xmlns:xlink="http://www.w3.org/1999/xlink"> Do not remove the id property. There should be a id="bitmap:width-depth" property for the wine's build system to generate the bitmaps from SVGs. Also, the commit subject is way too long. And, for the WineHQ bugzilla link. We use the Wine-Bug: tag. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6461

1 0

[PATCH 0/3] MR670: ddraw: Don't report unsupported device capability in d3d7_EnumDevices().
by Zhiyi Zhang (＠zhiyi) Aug. 18, 2022

Aug. 18, 2022

Fix Battle Realms: Zen Edition failing to start. The game expects to find a device without D3DDEVCAPS_HWTRANSFORMANDLIGHT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/670

2 3

[PATCH v2 0/11] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Francisco Casas (＠fcasas) Aug. 17, 2022

Aug. 17, 2022

Copy propagation is translated to index paths, invalidation of variable components is made more precise. This, together with checking for non-static object references (which are not allowed in HLSL) allows to set object register sizes back to zero without overlapping registers. I also included implicit array initialization, since, if I remember correctly, what was holding it back was that structs/arrays with object components couldn't be represented with the correct register offsets. After this, we have to decide if (and how to) move register allocation and register offset calculation to each shader model. -- v2: vkd3d-shader/hlsl: Support initialization of implicit size arrays. vkd3d-shader/hlsl: Set objects' register size back to 0. vkd3d-shader/hlsl: Check for non-static object references. vkd3d-shader/hlsl: Invalidate components more precisely in copy vkd3d-shader/hlsl: Replace register offsets with index paths in copy vkd3d-shader/hlsl: Print halfs in dump_ir_constant(). vkd3d-shader/hlsl: Skip implicit conversion if types are equal. vkd3d-shader/hlsl: Set component count for objects to 1. tests: Test object references. vkd3d-shader/hlsl: Emit a fixme on complex resource load object derefs. vkd3d-shader/hlsl: Rename 'inner_type' to 'element_type' in function https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7

2 11

Re: [PATCH v2 0/9] MR664: wow64win: thunk fixes - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/664

1 0

Re: [PATCH v2 0/3] MR666: compstui: Add partial CommonPropertySheetUIW implementation - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/666

1 0

Re: [PATCH v3 0/1] MR656: jscript: Implement fdexNameCaseInsensitive flag handling. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/656

1 0

Re: [PATCH v3 0/1] MR647: winex11.drv: Make last_cursor per-thread. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/647

1 0

Re: [PATCH v3 0/2] MR653: Dsdmo fx - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/653

1 0

Re: [PATCH v3 0/2] MR661: wshom: Support default style argument in IWshShell3::Run. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/661

1 0

Re: [PATCH v2 0/8] MR663: mfreadwrite/writer: Implement some functionality. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/663

1 0

Re: [PATCH v2 0/1] MR662: mfsrcsnk/wave: Add a type handler stub. - approved
by Alexandre Julliard (＠julliard) Aug. 17, 2022

Aug. 17, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/662

1 0

[PATCH 0/10] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Francisco Casas (＠fcasas) Aug. 17, 2022

Aug. 17, 2022

Copy propagation is translated to index paths, invalidation of variable components is made more precise. This, together with checking for non-static object references (which are not allowed in HLSL) allows to set object register sizes back to zero without overlapping registers. I also included implicit array initialization, since, if I remember correctly, what was holding it back was that structs/arrays with object components couldn't be represented with the correct register offsets. After this, we have to decide if (and how to) move register allocation and register offset calculation to each shader model. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7

4 21

[PATCH 0/9] MR664: wow64win: thunk fixes
by Jacek Caban (＠jacek) Aug. 17, 2022

Aug. 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/664

3 10

[PATCH 0/3] MR666: compstui: Add partial CommonPropertySheetUIW implementation
by Piotr Caban (＠piotr) Aug. 17, 2022

Aug. 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/666

2 3

[PATCH v2 0/1] MR656: jscript: Implement fdexNameCaseInsensitive flag handling.
by Gabriel Ivăncescu Aug. 17, 2022

Aug. 17, 2022

Despite common sense, native doesn't seem to look for exact match first; it simply case-insensitively compares the props and returns as soon as it finds one. This is also reliant on implementation details in case the object has multiple props with same case-insensitive names, e.g. an object having `Foo` prop, with `foo` prop on its prototype, can still find `Foo` even if you look up `foo` instead (which matches exactly on the prototype). Which is not always reliable, sometimes it finds the prototype first. See the following diff to illustrate possible behavior on native (which is what I get). Note that especially for jscript, the behavior makes no sense logically; first it picks 'Foo', despite 'foo' being available on the prototype (i.e. exact match). You might think it just looks up on props first, and prototype later, but the second ok() added shows that it finds the prototype's prop first, instead! ```diff diff --git a/dlls/jscript/tests/jscript.c b/dlls/jscript/tests/jscript.c index 03774da..2428363 100644 --- a/dlls/jscript/tests/jscript.c +++ b/dlls/jscript/tests/jscript.c @@ -999,6 +999,7 @@ static void test_case_sens(void) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id != id2, "id == id2\n"); hr = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hr == S_OK, "GetIDsOfNames failed: %08lx\n", hr); @@ -1031,6 +1032,7 @@ static void test_case_sens(void) hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id == id2, "id != id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index 14e3a14..563b87a 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -241,6 +241,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); hres = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hres == S_OK, "GetIDsOfNames failed: %08lx\n", hres); @@ -273,6 +274,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); ``` Strangely, mshtml's jscript still finds the prop on the object the second time, but that could be to different underlying implementation. I don't think it's necessary to replicate this quirk. The main point of this case insensitive handling is that it will be needed later when IE9+ modes use jscript proxy objects for the mshtml objects, because those default to case-insensitive search in GetIDsOfNames, likely to preserve backwards compatibility with pre-IE9 modes. It's a weird quirk, I know, but we have tests for that, which would otherwise break when proxies get added. I'll also add more tests around it later, to prove this, of course, that it also applies to jscript props (e.g. hasOwnProperty on the prototype is still looked case-insensitively if GetIDsOfNames is used). -- v2: jscript: Implement fdexNameCaseInsensitive flag handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/656

3 4

[PATCH v27 0/4] MR464: Implement _StructuredTaskCollection::_Schedule{,_loc}
by Torge Matthies (＠tmatthies) Aug. 17, 2022

Aug. 17, 2022

- Based on !463 - _RunAndWait and exception handling implemented in later commits @piotr -- v27: msvcr100: Implement _StructuredTaskCollection::_Schedule and _Schedule_loc. msvcr100: Factor out the mapping of a context to a scheduler. msvcr100: Factor out EXCEPTION_RECORD to exception_ptr conversion. msvcr100: Move exception_ptr functions to a separate file. https://gitlab.winehq.org/wine/wine/-/merge_requests/464

2 5

[PATCH v2 0/1] MR655: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Fan WenJie (＠fanwenjie) Aug. 17, 2022

Aug. 17, 2022

function call from windows dll to unix function should use `__wine_unix_call` instead of callback function pointer. remove callback struct unix_funcs and add wrapper function of `unixlib_entry_t` type. -- v2: win32u: replace calling unix functions by unix_call and remove callback unix_funcs https://gitlab.winehq.org/wine/wine/-/merge_requests/655

6 8

Re: [PATCH v2 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Huw Davies (＠huw) Aug. 17, 2022

Aug. 17, 2022

On Wed Aug 17 10:20:46 2022 +0000, Jiajin Cui wrote: > This is to ensure that the second_name is english in a non-english environment. > When we get the name of another non-english environment before get the > local environment name, it causes the second_name to be the name of the > other non-english environment. > As a result, when looking up a font using an English name, the > corresponding font cannot be found. But should it overwrite a second_name if one has already been found? Note also that this MR has failed the build pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/628#note_6406

1 0

Re: [PATCH v2 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Jiajin Cui (＠jin-king1) Aug. 17, 2022

Aug. 17, 2022

On Wed Aug 17 10:06:52 2022 +0000, Huw Davies wrote: > I'm afraid I don't understand the logic behind this change. This is to ensure that the second_name is english in a non-english environment. When we get the name of another non-english environment before get the local environment name, it causes the second_name to be the name of the other non-english environment. As a result, when looking up a font using an English name, the corresponding font cannot be found. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/628#note_6405

1 0

Re: [PATCH v2 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Huw Davies (＠huw) Aug. 17, 2022

Aug. 17, 2022

Huw Davies (@huw) commented about dlls/win32u/freetype.c: > else if (data->primary_langid == langid) > { > data->primary_seen = TRUE; > - if (!data->second_name.bytes) data->second_name = data->family_name; > + if (data->family_name.bytes) data->second_name = data->family_name; I'm afraid I don't understand the logic behind this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/628#note_6404

1 0