- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR4: vkd3d: Remove unused field fence_destruction_cond. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2022

Aug. 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/4

1 0

Re: [PATCH v3 0/1] MR3: vkd3d: Unlock fence worker mutex before exiting. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2022

Aug. 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/3

1 0

[PATCH v2 0/2] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) Aug. 8, 2022

Aug. 8, 2022

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v2: mf/samplegrabber: Request a sample when going from paused to running state. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

2 3

[PATCH 0/5] MR581: d3d8, d3d9: More tests for dirty rects and UpdateTexture().
by Zebediah Figura (＠zfigura) Aug. 8, 2022

Aug. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/581

4 7

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Huw Davies (＠huw) Aug. 8, 2022

Aug. 8, 2022

On Mon Aug 8 14:11:55 2022 +0000, Francois Gouget wrote: > Ah, right. Well, there is a `memset( &ip_h, 0, sizeof(ip_h) );` earlier on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5818

2 1

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) Aug. 8, 2022

Aug. 8, 2022

On Mon Aug 8 13:20:50 2022 +0000, **** wrote: > Paul Gofman replied on the mailing list: > ``` > > On 8 Aug 2022, at 02:56, Francois Gouget (@fgouget) > <wine(a)gitlab.winehq.org> wrote: > > > > ��Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > >> + req->icmp_seq = icmp_h->un.echo.sequence; > >> + if (!(fixup_status = wine_server_call( req ))) > >> + icmp_h->un.echo.id = reply->icmp_id; > >> + else > >> + WARN( "socket_get_fixup_data returned %#x.\n", > fixup_status ); > >> + } > >> + SERVER_END_REQ; > >> + > >> + if (!fixup_status) > >> + { > >> + icmp_h->checksum = 0; > >> + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - > sizeof(ip_h) ); > >> + } > >> + } > >> + ip_h.checksum = 0; > >> + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); > > Isn't the first assignment redundant? > > > No, it isn��t. checksum field is not excluded anyhow else from checksum > calculation and should be 0 for correct result. > > -- > > https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796 > > _______________________________________________ > > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` Ah, right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5817

1 0

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) Aug. 8, 2022

Aug. 8, 2022

Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > + req->icmp_seq = icmp_h->un.echo.sequence; > + if (!(fixup_status = wine_server_call( req ))) > + icmp_h->un.echo.id = reply->icmp_id; > + else > + WARN( "socket_get_fixup_data returned %#x.\n", fixup_status ); > + } > + SERVER_END_REQ; > + > + if (!fixup_status) > + { > + icmp_h->checksum = 0; > + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - sizeof(ip_h) ); > + } > + } > + ip_h.checksum = 0; > + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); Isn't the first assignment redundant? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796

2 1

[PATCH 0/4] MR2: tests: Test float4 UAV buffer load/store.
by Conor McCarthy (＠cmccarthy) Aug. 8, 2022

Aug. 8, 2022

This currently fails if the shader loads from the UAV, because it causes vkd3d-shader to specify the R32f format instead of Unknown. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2

4 8

[PATCH 0/8] MR604: user32: Don't include ntuser_private.h.
by Jacek Caban (＠jacek) Aug. 8, 2022

Aug. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/604

3 9

[PATCH v8 0/5] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon Aug. 8, 2022

Aug. 8, 2022

-- v8: qasf: Implement ASF Reader filter pin DecideBufferSize. qasf: Implement ASF Reader filter pin_get_media_type. qasf: Implement ASF Reader filter pin_query_accept. winegstreamer: Implement IWMOutputMediaProps_SetMediaType. wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/140

1 6

[PATCH v7 0/5] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon Aug. 8, 2022

Aug. 8, 2022

-- v7: qasf: Implement ASF Reader filter pin DecideBufferSize. qasf: Implement ASF Reader filter pin_get_media_type. qasf: Implement ASF Reader filter pin_query_accept. winegstreamer: Implement IWMOutputMediaProps_SetMediaType. wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/140

2 7

Re: [PATCH v2 0/1] MR598: secur32: Define AES-CCM ciphers missing from GNUTLS before 3.4.0. - approved
by Hans Leidekker (＠hans) Aug. 8, 2022

Aug. 8, 2022

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/598

1 0

[PATCH 0/1] MR4: vkd3d: Remove unused field fence_destruction_cond.
by Giovanni Mascellani (＠giomasce) Aug. 8, 2022

Aug. 8, 2022

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/4

3 2

[PATCH v2 0/1] MR3: vkd3d: Unlock fence worker mutex before exiting.
by Giovanni Mascellani (＠giomasce) Aug. 8, 2022

Aug. 8, 2022

Pthread mandates that a mutex must be unlocker before being destroyed. In pratice I doubt this make a difference on any platform (certainly it doesn't on Linux), but let's comply to standards. -- v2: vkd3d: Unlock fence worker mutex before exiting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/3

3 2

[PATCH v4 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon Aug. 8, 2022

Aug. 8, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v4: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

2 7

[PATCH v2 0/1] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) Aug. 8, 2022

Aug. 8, 2022

This is the very first step for merging the `mmdevdrv.c` files into a single one. The commit strictly focuses on Linux drivers, `wine{oss,coreaudio}` will follow. Huge thanks to @jacek and @huw for making this simple, as they took care of ELF/PE separation. -- v2: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi https://gitlab.winehq.org/wine/wine/-/merge_requests/600

3 4

[PATCH v3 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon Aug. 8, 2022

Aug. 8, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v3: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

3 8

[PATCH v2 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon Aug. 8, 2022

Aug. 8, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v2: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

2 7

[PATCH v7 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) Aug. 8, 2022

Aug. 8, 2022

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v7: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 8

[PATCH 0/1] MR602: ntdll: Also initialize icmp_over_dgram in sock_read().
by Paul Gofman (＠gofman) Aug. 7, 2022

Aug. 7, 2022

Fixes a regression introduced by commit 1e35966eb57db7060d0c459bc7aaac2f6cad7442. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52429 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/602

2 1

[PATCH 0/1] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) Aug. 7, 2022

Aug. 7, 2022

This is the very first step for merging the `mmdevdrv.c` files into a single one. The commit strictly focuses on Linux drivers, `wine{oss,coreaudio}` will follow. Huge thanks to @jacek and @huw for making this simple, as they took care of ELF/PE separation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600

2 2

[PATCH 0/6] MR575: mf: Use the Video Processor transform for video conversion.
by Rémi Bernon Aug. 6, 2022

Aug. 6, 2022

This should fix the Color Converter transform regression, which cannot actually be used by the topology loader in some cases because it exposes DMO-specific RGB media types. The Video Processor must be used instead (and it has its own quirks). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/575

3 8

[PATCH 0/2] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) Aug. 6, 2022

Aug. 6, 2022

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/574

3 3

[PATCH v3 0/4] MR596: win32u: Send the total number of registered devices to the server.
by Rémi Bernon Aug. 6, 2022

Aug. 6, 2022

-- v3: win32u: Avoid invalid access when registered device alloc failed. (Coverity) win32u: Send the total number of registered devices to the server. win32u: Avoid reallocating rawinput device array with zero size. server: Avoid reallocating rawinput device array with zero size. https://gitlab.winehq.org/wine/wine/-/merge_requests/596

1 5

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) Aug. 6, 2022

Aug. 6, 2022

On Wed Aug 3 14:09:24 2022 +0000, Akihiro Sagawa wrote: > Got it. Good tip. It turns out that SM_CXMIN is used only when creating an overlapped window. In other words, if a user supplies WS_CHILD or WS_POPUP style, CreateWindow won't adjust the window width to SM_CXMIN. Nevertheless, I'll squash two patches into one to avoid regressions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5762

1 0