- Wine-GitLab - list.winehq.org

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens Aug. 1, 2022

Aug. 1, 2022

On Mon Aug 1 19:43:52 2022 +0000, Bernhard K��lbl wrote: > Tests cannot fail in their own commit. You need to denote stuff, that's > going to be implemented with todo_wine, which expects a failure. Then > the commit message for tests needs to be cabinet/tests: I'll slowly add/improve commits after the test results are available, I don't want to delete every commit again lol Is there any way to manually trigger the test bot? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5461

1 0

[PATCH v2 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it. -- v2: winegstreamer: Make IWMReader state transitions asynchronous. winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable. wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/393

2 7

[PATCH v6 0/3] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens Aug. 1, 2022

Aug. 1, 2022

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v6: cabinet: Implement GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

2 5

[PATCH 0/1] MR572: ntdll: Use correct mcontext struct on macOS under Wow64.
by Brendan Shanks (＠bshanks) Aug. 1, 2022

Aug. 1, 2022

This bug was causing incorrect FPU state to be read under Wow64 on macOS. This use of different mcontext structures is only documented in Apple's kernel source, most helpfully a test program for custom LDTs: https://github.com/apple-oss-distributions/xnu/blob/e7776783b89a353188416a9… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/572

2 1

[PATCH 0/3] MR568: mshtml: MediaQueryList semi-implementation.
by Gabriel Ivăncescu Aug. 1, 2022

Aug. 1, 2022

This doesn't implement the listeners (needs wine-gecko notification). Also "media" seems to return somewhat different strings on gecko in some cases, so some of the tests are todo_wine because of that, but I'm not sure if it's worth replicating in practice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/568

2 4

[PATCH v3 0/2] MR352: cmd: Don't loop infinitely on NUL.
by Arek Hiler (＠ivyl) Aug. 1, 2022

Aug. 1, 2022

-- v3: cmd/tests: Make sure for /f doesn't loop infinitely on NULs. cmd: Use CRT file I/O function inside 'for /F' handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/352

3 2

[PATCH 0/2] MR569: include: Add more UI Automation definitions.
by Connor McAdams (＠cmcadams) Aug. 1, 2022

Aug. 1, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/569

2 2

[PATCH v3 0/6] MR561: winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them. -- v3: winex11.drv: Constify set_current_mode DEVMODEW parameter. winex11.drv: Iterate display settings using dmDriverExtra. winex11.drv: Use DEVMODEW instead of x11drv_display_setting. winex11.drv: Update devmode dmPosition instead of new_rect. winex11.drv: Use DM_POSITION field bit to mark placed displays. winex11.drv: Use a local desired_rect variable when placing displays. https://gitlab.winehq.org/wine/wine/-/merge_requests/561

2 7

[PATCH 0/1] MR567: user32: scroll regression fix
by Jacek Caban (＠jacek) Aug. 1, 2022

Aug. 1, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/567

2 1

[PATCH v2 0/1] MR564: cabinet.dll: implement DllGetVersion & GetDllVersion
by Tobias Görgens Aug. 1, 2022

Aug. 1, 2022

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v2: cabinet.dll: implement DllGetVersion & GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

2 7

Re: [PATCH v5 0/4] MR406: win32u: Introduce new add_modes device manager callback.
by Zhiyi Zhang (＠zhiyi) Aug. 1, 2022

Aug. 1, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > > #undef query_mode_field > > + ret = query_reg_value( hkey, driver_extraW, value, sizeof(value_buf) ) && > + value->Type == REG_BINARY; > + if (ret && value->DataLength <= mode->dmDriverExtra) > + memcpy( mode + 1, value->Data, mode->dmDriverExtra ); Hi, R��mi. This is causing a new Coverity report. In NtUserChangeDisplaySettings(), default_mode is passed to read_registry_settings(), which eventually calls read_adapter_mode() and then writes to the mode + 1. This is out of bound access because default_mode is not an array. I think the correct fix is to not set dmDriverExtra for ENUM_REGISTRY_SETTINGS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/406#note_5410

1 0

[PATCH v2 0/6] MR561: winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them. -- v2: winex11.drv: Constify set_current_mode DEVMODEW parameter. winex11.drv: Iterate display settings using dmDriverExtra. winex11.drv: Use DEVMODEW instead of x11drv_display_setting. winex11.drv: Update devmode dmPosition instead of new_rect. winex11.drv: Use DM_POSITION field bit to mark placed displays. winex11.drv: Use a local desired_rect variable when placing displays. https://gitlab.winehq.org/wine/wine/-/merge_requests/561

1 7

[PATCH v4 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) Aug. 1, 2022

Aug. 1, 2022

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v4: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 9

[PATCH 0/6] MR561: winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
by Rémi Bernon Aug. 1, 2022

Aug. 1, 2022

In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/561

2 11

[PATCH 0/3] MR504: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Aug. 1, 2022

Aug. 1, 2022

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/504

2 5

[PATCH v2 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) July 31, 2022

July 31, 2022

Some installer, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- v2: ncrypt: Initial implementation for NCryptEncrypt. bcrypt: Initial RSA encryption implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/565

2 4

[PATCH 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) July 31, 2022

July 31, 2022

Some installer, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/565

2 4

[PATCH 0/1] MR564: cabinet.dll: implement DllGetVersion & GetDllVersion
by Tobias Görgens July 31, 2022

July 31, 2022

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564

1 2

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) July 31, 2022

July 31, 2022

Fix intermediate test failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5382

1 0

[PATCH v2 0/7] MR536: xactengine3_7: Add helper function to add entries
by Alistair Leslie-Hughes (＠alesliehughes) July 31, 2022

July 31, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages xactengine3_7: Record context for each notications xactengine3_7: Map IXACT3Wave interfaces xactengine3_7: Map IXACT3Cue interfaces xactengine3_7: Map SoundBank interfaces xactengine3_7: Add helper function to add entries https://gitlab.winehq.org/wine/wine/-/merge_requests/536

2 7

[PATCH v2 0/6] MR553: mf: Some attribute tweaks to fix Resampler transform regressions.
by Rémi Bernon July 30, 2022

July 30, 2022

-- v2: winegstreamer: Use the correct name for WMADecMediaObject DMO. mf: Increase min_buffer_size to MF_MT_AUDIO_AVG_BYTES_PER_SECOND. mf: Implement SAR media type required attributes checks. winegstreamer: Set the MF_MT_AUDIO_AVG_BYTES_PER_SECOND attribute. mf: Return MF_E_NO_MORE_TYPE from AudioRenderer GetMediaTypeByIndex. mf/tests: Add required SAR media type attributes tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/553

2 8

Re: [PATCH v2 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat(). - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/563

1 0

Re: [PATCH v3 0/5] MR562: mshtml: Doctype node and windowless document fixes. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/562

1 0

Re: [PATCH v2 0/1] MR560: dwrite: Fix fallback config ranges text parsing. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/560

1 0

Re: [PATCH v2 0/2] MR559: Type 'pointer to type' in WineDbg. - approved
by Alexandre Julliard (＠julliard) July 29, 2022

July 29, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/559

1 0