- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat().
by Paul Gofman (＠gofman) July 29, 2022

July 29, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53429 As the bug states, the test is failing on Wine / Intel GPU. The test was added in commit 83cbcdefa3f55afc449b6be51e215c4f646869f4 which was a test for cc8d8b5ee33561e984d4abe4112ddd6324f77115 (opengl32: Prioritize stencil check over depth check in wglChoosePixelFormat()). The motivation under that change was to avoid the situation when we erroneously return the no-stencil format (which was breaking a game) and not vice versa. This specific test was probably added for completeness. I don't have a Windows Intel GPU machine to check how it looks like there but it seems to me that this aspect (returning 0 depth stencil instead of 8 when no stencil requested) is much less likely to affect things in practice, so just remove the test instead of trying to fix that in Wine on Intel. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/563

3 2

[PATCH v2 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu July 29, 2022

July 29, 2022

-- v2: mshtml: Handle lack of window in methods for detached documents. https://gitlab.winehq.org/wine/wine/-/merge_requests/562

2 6

[PATCH 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu July 29, 2022

July 29, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/562

1 5

[PATCH v3 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) July 29, 2022

July 29, 2022

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v3: comctl32/tests: Add more ownerdata listview tests. comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges. comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes. comctl32/listview: Send LVN_ODSTATECHANGED only for LVS_OWNERDATA listviews. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send one deselect all items notification for LVS_OWNERDATA listviews. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 10

[PATCH 0/1] MR560: dwrite: Fix fallback config ranges text parsing.
by Nikolay Sivov (＠nsivov) July 29, 2022

July 29, 2022

Currently it's using all 16 slots, filling trailing ones with rudimentary ranges. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/560

2 2

[PATCH 0/2] MR559: Type 'pointer to type' in WineDbg.
by eric pouech (＠epo) July 29, 2022

July 29, 2022

This series ensures that when WineDbg looks up for the type 'pointer to a given type', this type always exists. There's no reason this is always available from DbgHelp, so synthetize the relevant type when it's not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/559

2 2

[PATCH v2 0/5] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon July 29, 2022

July 29, 2022

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v2: win32u: Add a default EnumDisplaySettingsEx driver implementation. win32u: Add a default ChangeDisplaySettingsEx driver implementation. win32u: Move enumeration of available modes out of graphics drivers. win32u: Validate NtUserChangeDisplaySettings mode against available modes. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

2 25

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > - ownerdata_multiselect_odstatechanged_seq, > - "ownerdata select multiple notification", FALSE); > + ownerdata_multiselect_move_3_to_2_odstatechanged_seq, > + "ownerdata multiselect: keep selection but move cursor via CONTROL+UP ", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_UP, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > > - res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* Select multiple via SHIFT+CONTROL+DOWN after moving cursor over an item without selecting */ Wrong comment. Should be SHIFT+CONTROL+UP. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5317

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + res = SendMessageA(hwnd, WM_KEYDOWN, VK_DOWN, 0); > + expect(0, res); > + ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > + ownerdata_multiselect_select_3_odstatechanged_seq, > + "ownerdata multiselect: deselect all, select item 3 via DOWN", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > + > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* First up then down */ > + /* Select multiple items via SHIFT+UP */ For consistency, let's move hold_key() to the start of each test. Right now some of them are at the start and some are at the up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5316

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) July 29, 2022

July 29, 2022

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c: > > - /* disable per item notifications on LVS_OWNERDATA style > - FIXME: single LVN_ODSTATECHANGED should be used */ > + /* Disable per item notifications on LVS_OWNERDATA style */ > old_mask = infoPtr->notify_mask & NOTIFY_MASK_ITEM_CHANGE; > if (infoPtr->dwStyle & LVS_OWNERDATA) > infoPtr->notify_mask &= ~NOTIFY_MASK_ITEM_CHANGE; > > LISTVIEW_DeselectAllSkipItems(infoPtr, selection); > > - > iterator_rangesitems(&i, selection); > while(iterator_next(&i)) > - LISTVIEW_SetItemState(infoPtr, i.nItem, &item); > + { > + // Find the range for LVN_ODSTATECHANGED Please use /**/ instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5315

1 0

Re: [PATCH v2 0/1] MR558: win32u: Fix typo in font handle creation in NtUserDrawCaptionTemp(). - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/558

1 0

Re: [PATCH v2 0/5] MR552: win32u: Simplify and move rawinput registration logic to the client side. - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/552

1 0

Re: [PATCH v2 0/3] MR556: mshtml: Basic implementation of XMLHttpRequest response method. - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/556

1 0

Re: [PATCH v2 0/2] MR554: regedit: More REG_DWORD / REG_QWORD dialog fixes - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/554

1 0

Re: [PATCH v2 0/6] MR555: win32u: user32 separation - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/555

1 0

Re: [PATCH v2 0/3] MR537: riched20: Ensure that cursor is visible when selecting text. - approved
by Alexandre Julliard (＠julliard) July 28, 2022

July 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/537

1 0

[PATCH 0/1] MR558: win32u: Fix typo in font handle creation in NtUserDrawCaptionTemp().
by Nikolay Sivov (＠nsivov) July 28, 2022

July 28, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/558

2 1

[PATCH 0/5] MR553: mf: Some attribute tweaks to fix Resampler transform regressions.
by Rémi Bernon July 28, 2022

July 28, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/553

2 7

[PATCH 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) July 28, 2022

July 28, 2022

This is a new try of mciqtz32's video window patch. Comparing to the previous !370, I added a lot of tests regarding the video window behavior. Some portion of the previous patch are dropped to avoid complexity, I'll add that part later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557

2 11

[PATCH v4 0/11] MR370: mciqtz32: Simplify video window management by creating default window.
by Akihiro Sagawa (＠sgwaki) July 28, 2022

July 28, 2022

-- v4: mciqtz32: Show the default video window when switching from another one. mciqtz32: Hide the default video window when switching to another one. mciqtz32: Reset the video size when switching video destination. mciqtz32: Correct initial video window dimensions. mciqtz32: Fix MCI_DGV_WHERE_WINDOW behavior. mciqtz32: Correct video window behavior by creating default window. winmm/tests: Add tests for destination of video window. winmm/tests: Add tests for dimensions of video window. winmm/tests: Add tests for window style of video window. mciqtz32: Don't hide video window when stopping. winmm/tests: Add tests for visibility of video window. https://gitlab.winehq.org/wine/wine/-/merge_requests/370

2 12

[PATCH 0/3] MR556: mshtml: Basic implementation of XMLHttpRequest response method.
by Gabriel Ivăncescu July 28, 2022

July 28, 2022

The first (unrelated) patch was my fault for messing it up the first time on the last MR, and it seems to have been lost on your changes. Sorry for the noise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/556

2 4

[PATCH 0/6] MR555: win32u: user32 separation
by Jacek Caban (＠jacek) July 28, 2022

July 28, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/555

3 7

[PATCH 0/2] MR554: regedit: More REG_DWORD / REG_QWORD dialog fixes
by Hugh McMaster (＠hmc) July 28, 2022

July 28, 2022

1. Default to zero on IDOK if the edit control is empty. 2. Limit text input length to 8 or 16 hexadecimal characters, or 10 or 20 decimal characters, depending on registry value type and format specifier chosen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/554

2 2

[PATCH 0/5] MR552: win32u: Simplify and move rawinput registration logic to the client side.
by Rémi Bernon July 28, 2022

July 28, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/552

1 5

[PATCH 0/5] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon July 28, 2022

July 28, 2022

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/551

2 8