- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/2] MR9975: where: Add quiet mode.
by eric pouech (＠epo) Jan. 28, 2026

Jan. 28, 2026

eric pouech (@epo) commented about programs/where/main.c: > int __cdecl wmain(int argc, WCHAR *argv[]) > { > WCHAR *pattern, *colon, *search_paths, *search_path, *next_search_path; > + DWORD flags = 0; > int i; > > for (i = 0; i < argc; i++) > { > - if (argv[i][0] == '/') > + if (argv[i][0] == '/' && wcslen(argv[i]) == 2) > + { > + switch(toupper(argv[i][1])) > + { > + case 'Q': flags |= OPT_QUIET; break; > + default: > + FIXME("Unsupported option %ls -- %c\n", argv[i], argv[i][1]); the %c arg is useless -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9975#note_128273

1 0

Re: [PATCH v3 0/2] MR9975: where: Add quiet mode.
by eric pouech (＠epo) Jan. 28, 2026

Jan. 28, 2026

eric pouech (@epo) commented about programs/where/main.c: > } > else if (argv[i][0] == '/') > { > - FIXME("Unsupported option %ls len %lld\n", argv[i], (long long)wcslen(argv[i])); > + FIXME("Unsupported option %ls\n", argv[i]); that should be rebased into previous patch. note also that you'd rather use wine_dbgstr_w(argv\[i\]) as argument, to prevent too long strings from overflowing FIXME internal buffer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9975#note_128268

1 0

[PATCH v17 0/6] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Jan. 28, 2026

Jan. 28, 2026

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v17: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. kernel32: Fix CreateToolhelp32Snapshot on old WoW64. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Handle ERROR_BAD_LENGTH from CreateToolhelp32Snapshot. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

3 8

[PATCH v2 0/2] MR9975: where: Add quiet mode.
by Thomas Csovcsity (＠thc13) Jan. 28, 2026

Jan. 28, 2026

Fixes Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59234 -- v2: where: Fix index for option parsing https://gitlab.winehq.org/wine/wine/-/merge_requests/9975

3 4

[PATCH v3 0/2] MR9946: start: Remove quotes from the path specified by '/d'.
by Yeshun Ye (＠yeyeshun) Jan. 28, 2026

Jan. 28, 2026

I'm not sure how to write a test case for this bug, as it involves creating a child process and I don't know how to verify if the child process was created correctly. Please test manually: enter `start /d "c:\windows" regedit.exe` in a batch file. It won't work correctly because `start` wraps the directory specified by `/D` with `L"\"\\\""` and `L"\\\"\""`. -- v3: start: Remove quotes from the path specified by '/d'. https://gitlab.winehq.org/wine/wine/-/merge_requests/9946

3 5

[PATCH 0/5] MR9991: Draft: opengl32: Avoid using context HDC after context creation.
by Rémi Bernon Jan. 28, 2026

Jan. 28, 2026

There's no guarantee that the HDCs are still valid. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9991

1 5

[PATCH 0/1] MR9907: include: Annotate p_wglAllocateMemoryNV with __WINE_ALLOC_SIZE.
by Alex Henrie (＠alexhenrie) Jan. 28, 2026

Jan. 28, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9907

3 4

[PATCH v5 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) Jan. 28, 2026

Jan. 28, 2026

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. P.S. I am not intending to post further changes until this MR is being merged. These changes are pretty much simple but fundamental for future changes. -- v5: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring wineandroid: Fix start_device_callback assignment type https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 12

[PATCH v4 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) Jan. 28, 2026

Jan. 28, 2026

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. P.S. I am not intending to post further changes until this MR is being merged. These changes are pretty much simple but fundamental for future changes. -- v4: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 12

[PATCH 0/6] MR9990: winevulkan: Get rid of debug handles unwraps in struct chains (and misc other cleanups).
by Rémi Bernon Jan. 28, 2026

Jan. 28, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9990

1 6

[PATCH v3 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) Jan. 28, 2026

Jan. 28, 2026

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. P.S. I am not intending to post further changes until this MR is being merged. These changes are pretty much simple but fundamental for future changes. -- v3: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 11

[PATCH 0/1] MR9989: dwrite/layout: Partially implement HitTestTextPosition().
by Nikolay Sivov (＠nsivov) Jan. 28, 2026

Jan. 28, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9989

2 1

[PATCH v4 0/2] MR9639: Fix the integration of PowerPoint add-in in MS Office 2016
by Ivan Lyugaev (＠valy) Jan. 28, 2026

Jan. 28, 2026

Encountered an issue with PowerPoint add-in integration. Reviewing the logs revealed the problem was due to the lack of CLSID lookup via the CurVer section and incorrect handling of the PARAMFLAG_NONE flag. A test was conducted in Windows to verify the handling of PARAMFLAG_NONE, PARAMFLAG_FIN, and PARAMFLAG_FOUT. Test class: ``` interface ITest : IDispatch { [id(1)] HRESULT TestMethod(BSTR* value); [id(2)] HRESULT TestMethodOut([out] BSTR* retVal); [id(3)] HRESULT TestMethodIn([in] BSTR* inVal); }; ``` Results in Windows: ``` --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) Invoke returned: 0x00000000 ``` Results in Wine: ``` --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] (null) Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) ``` Therefore, parameters with the PARAMFLAG_NONE flag are implied to be input parameters in Windows and are handled accordingly as PARAMFLAG_FIN. Added tests for the implemented changes. In the last two tests (their code is provided below), the CLSID is nullified in the guid_from_string function, which is why this test is left with a todo_wine tag. ``` clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.3", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.5", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); ``` -- v4: combase: Implement CLSID lookup with CurVer fallback oleaut32: Fix parameter value loss in ITypeInfo_Invoke for byref parameters https://gitlab.winehq.org/wine/wine/-/merge_requests/9639

3 8

[PATCH v8 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 28, 2026

Jan. 28, 2026

according to MSDN they are implemented in the same way as a fast mutex. -- v8: ntoskrnl.exe: Implement KeReleaseGuardedMutex. ntoskrnl.exe: Implement KeAcquireGuardedMutex. https://gitlab.winehq.org/wine/wine/-/merge_requests/2044

2 3

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 28, 2026

Jan. 28, 2026

On Wed Jan 28 07:10:06 2026 +0000, Elizabeth Figura wrote: > These functions are fastcall. > Also, if you're going to use the same implementation as fast mutexes I > would just call the fast mutex functions instead of copying them. Both unsafe and safe versions are fastcall? in wine the fast lock (safe version) is winapi (stdcall) for safe and fastcall for unsafe -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_128231

1 0

[PATCH 0/1] MR9960: shell32: Create parent directories when creating trash directory.
by Bernhard Übelacker Jan. 28, 2026

Jan. 28, 2026

It looks like since 82ad0ecd12 the parents of the trash directory get no longer automatically created before the test starts. The current `CreateDirectoryW` returns in GetLastError 3, ERROR_PATH_NOT_FOUND, as the parent directory does not exist. Locally I could reproduce it inside a test VM when the directory `$HOME/.local/share` did not exist. One solution may be to use this `SHCreateDirectoryExW`. This shows a few `fixme:shell:ISF_NetworkPlaces_fnParseDisplayName not implemented for`, don't know if this matters much. [Test pattern page](https://test.winehq.org/data/patterns.html#shell32:recyclebin) [Test run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161570) CC: @jactry -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9960

2 3

Re: [PATCH v2 0/7] MR9579: ntdll: On macOS, transform the main thread into a Wine thread (running a CFRunLoop) on launch.
by Brendan Shanks (＠bshanks) Jan. 28, 2026

Jan. 28, 2026

On Wed Jan 28 02:09:33 2026 +0000, Elizabeth Figura wrote: > > `start_thread()` jumps to PE code, then we need the Unix call so > GSBASE gets set. Also, the PE function lets us handle a syscall fault. > I'm not sure I follow what the alternative would be. > I might be misunderstanding things, but couldn't we just create the Wine > thread but then never jump to PE code? If I'm reading correctly, nothing > we want a Wine thread for actually requires PE code to have ever run in > the process. Hmmm, like if we had a custom `start_thread()` that went straight to `CFRunLoopRun()` instead of calling `signal_start_thread()` at the end? That would work for logging functions, but I'm pretty sure catching a syscall fault would not work (the syscall_frame isn't set up). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9579#note_128220

1 0

Re: [PATCH v2 0/6] MR9958: wminet_utils: Add dll. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9958

1 0

Re: [PATCH v3 0/4] MR9941: ntoskrnl: Handle FileFsDeviceInformation. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9941

1 0

Re: [PATCH v2 0/3] MR9984: mountmgr.sys: Stub StorageDeviceTrimProperty query. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9984

1 0

Re: [PATCH v2 0/1] MR9985: dwrite/tests: Add a test for newline clusters with HitTestTextPosition(). - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9985

1 0

Re: [PATCH v2 0/5] MR9981: winevulkan: More make_vulkan cleanup and simplifications. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9981

1 0

Re: [PATCH v3 0/1] MR9983: winedump: Print CLR string offset instead of index. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9983

1 0

Re: [PATCH v7 0/1] MR9858: qasf: Fix use-after-free of filter in reader callback. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9858

1 0

Re: [PATCH v2 0/1] MR9871: qasf: Stop the WMReader first in asf_reader_destroy. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9871

1 0