- Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR9881: cmd: Replace '/' to '\' for path in 'WCMD_pushd' - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9881

1 0

Re: [PATCH v2 0/1] MR9980: opengl32: Fix a typo in client-side GLsync allocated object. - approved
by Alexandre Julliard (＠julliard) Jan. 27, 2026

Jan. 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9980

1 0

[PATCH 0/6] MR9958: wminet_utils: Add dll.
by Esme Povirk (＠madewokherd) Jan. 27, 2026

Jan. 27, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59223 This also requires a Wine Mono change to install the dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9958

4 13

[PATCH v2 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) Jan. 27, 2026

Jan. 27, 2026

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. -- v2: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring wineandroid: Fix start_device_callback assignment type wineandroid: Drop leftover drawable_mutex after win32u OpenGL changes wineandroid: Fix ANDROID_WindowPosChanged prototype in android.h ntdll: Include <strings.h> for ffs() declaration https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 11

Re: [PATCH v4 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Brendan McGrath (＠redmcg) Jan. 27, 2026

Jan. 27, 2026

On Tue Jan 27 12:23:48 2026 +0000, Nikolay Sivov wrote: > Any idea where those numbers are coming from? Is this accessible somehow > from mmdevapi maybe? I'm not sure where these come from actaully. I'll investigate and see if I can find out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128185

1 0

Re: [PATCH v4 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Brendan McGrath (＠redmcg) Jan. 27, 2026

Jan. 27, 2026

v4: - Rebase to master -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128184

1 0

[PATCH v3 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Brendan McGrath (＠redmcg) Jan. 27, 2026

Jan. 27, 2026

This also removes duplicated tests from test_sar. -- v3: mf/tests: Test SAR scrubbing start. mf/tests: Test SAR timer with ENDOFSEGMENT marker. mf/tests: Test SAR timer with pre-roll and duration. mf/tests: Test SAR timer with pre-roll and no duration. mf/tests: Test SAR's SetPresentationClock. mf/tests: Test SAR's IMFPresentationTimeSource interface. mf/tests: Test SAR's IMFRateSupport interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/9979

2 10

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Elizabeth Figura (＠zfigura) Jan. 27, 2026

Jan. 27, 2026

These functions are fastcall. Also, if you're going to use the same implementation as fast mutexes I would just call the fast mutex functions instead of copying them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_128172

1 0

[PATCH v16 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Jan. 27, 2026

Jan. 27, 2026

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v16: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolhelp32Snapshot if possible. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. kernel32: Fix CreateToolhelp32Snapshot on old WoW64. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Handle ERROR_BAD_LENGTH from CreateToolhelp32Snapshot. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

4 10

[PATCH 0/1] MR9985: dwrite/tests: Add a test for newline clusters with HitTestTextPosition().
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9985

2 1

[PATCH 0/1] MR9975: where: Add quiet mode.
by Thomas Csovcsity (＠thc13) Jan. 27, 2026

Jan. 27, 2026

Fixes Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59234 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9975

6 11

[PATCH 0/6] MR9947: mf/tests: Add more topology loader tests.
by Conor McCarthy (＠cmccarthy) Jan. 27, 2026

Jan. 27, 2026

The first three commits are from !9935 which this goes atop, otherwise it will crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9947

3 15

[PATCH 0/3] MR9984: mountmgr.sys: Stub StorageDeviceTrimProperty query.
by Jactry Zeng (＠jactry) Jan. 27, 2026

Jan. 27, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9984

2 3

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + PropVariantClear(&propvar); > + > + /* Place an ENDOFSEGMENT marker after the third sample */ > + hr = IMFStreamSink_PlaceMarker(stream, MFSTREAMSINK_MARKER_ENDOFSEGMENT, NULL, NULL); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + hr = gen_wait_media_event_until_blocking((IMFMediaEventGenerator*)stream, callback, MEStreamSinkMarker, 1000, &propvar); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + PropVariantClear(&propvar); > + > + /* Check clock time */ > + while (time <= 300000) > + { > + IMFPresentationClock_GetTime(clock, &time); > + Sleep(50); > + } This does not look very safe to me. If we must to do GetTime(), maybe do it in a separate thread, and have a timeout? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128139

1 0

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + hr = IMFMediaTypeHandler_SetCurrentMediaType(type_handler, media_type); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + IMFMediaType_Release(media_type); > + IMFMediaTypeHandler_Release(type_handler); > + > + /* Test rate support when initialised */ > +if (rate_support1) > +{ > + hr = IMFRateSupport_GetSlowestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + ok(rate == 0.125, "Unexpected rate %f\n", rate); > + > + hr = IMFRateSupport_GetFastestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + ok(rate == 8.0, "Unexpected rate %f\n", rate); Any idea where those numbers are coming from? Is this accessible somehow from mmdevapi maybe? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128138

1 0

Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
by Nikolay Sivov (＠nsivov) Jan. 27, 2026

Jan. 27, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c: > + > +if (rate_support1) > +{ > + hr = IMFRateSupport_GetSlowestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > + > + hr = IMFRateSupport_GetFastestRate(rate_support1, MFRATE_FORWARD, FALSE, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > + > + hr = IMFRateSupport_IsRateSupported(rate_support1, FALSE, 1.0, &rate); > + ok(hr == MF_E_NOT_INITIALIZED, "Unexpected hr %#lx.\n", hr); > +} > +else > +{ > + skip("Skipping rate support tests\n"); > +} There is no need for a skip, you know that GetService is todo, then a return object check is enough to guard tests that need it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128137

1 0

[PATCH v2 0/1] MR9983: winedump: Print CLR string offset instead of index.
by Hans Leidekker (＠hans) Jan. 27, 2026

Jan. 27, 2026

-- v2: winedump: Print CLR string offset instead of index. https://gitlab.winehq.org/wine/wine/-/merge_requests/9983

2 1

[PATCH 0/1] MR9983: winedump: Print CLR string offset instead of index.
by Hans Leidekker (＠hans) Jan. 27, 2026

Jan. 27, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9983

2 1

[PATCH 0/5] MR9981: winevulkan: More make_vulkan cleanup and simplifications.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9981

1 5

[PATCH 0/1] MR9980: opengl32: Fix a typo in client-side GLsync allocated object.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

Fixes: df7943684d11c4ad26128da2abc1506f29c4eb45 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59320 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9980

1 1

[PATCH 0/5] MR9930: cfgmgr32: Update header and specifications.
by Rémi Bernon Jan. 27, 2026

Jan. 27, 2026

This is in preparation for implementing cfgmgr32 functions more properly, which are widely used by native gameinput. The module is supposed to be the lower-level API, abstracting the registry, and used by other modules like setupapi instead of the other way around. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9930

2 12

[PATCH v3 0/1] MR9881: cmd: Replace '/' to '\' for path in 'WCMD_pushd'
by Yeshun Ye (＠yeyeshun) Jan. 27, 2026

Jan. 27, 2026

The parameter of the 'pushd' command may contain the character ‘/’, which is compatible with Windows. Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v3: cmd: Allow '/' in quoted 'WCMD_pushd' args. https://gitlab.winehq.org/wine/wine/-/merge_requests/9881

3 2

[PATCH v2 0/2] MR9946: start: Remove quotes from the path specified by '/d'.
by Yeshun Ye (＠yeyeshun) Jan. 27, 2026

Jan. 27, 2026

I'm not sure how to write a test case for this bug, as it involves creating a child process and I don't know how to verify if the child process was created correctly. Please test manually: enter `start /d "c:\windows" regedit.exe` in a batch file. It won't work correctly because `start` wraps the directory specified by `/D` with `L"\"\\\""` and `L"\\\"\""`. -- v2: start: Remove quotes from the path specified by '/d'. cmd/tests: Add test for 'start' with '/d'. https://gitlab.winehq.org/wine/wine/-/merge_requests/9946

3 6

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 27, 2026

Jan. 27, 2026

On Tue Jan 27 05:45:22 2026 +0000, Jactry Zeng wrote: > Thanks for testing it! I also tried to test it with the upstream Wine > development branch. To make Endfield work on Wine 11.1, we also need > https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-Sysc… > from wine-staging (bug 48291), then plusing Etaash's work for > ntoskrnl.exe, I was able to log in to and start a game. Glad to hear it's not entirely useless 😂 Like I said before feel free to take this code to use as a basis for future work -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_128103

1 0

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Jactry Zeng (＠jactry) Jan. 27, 2026

Jan. 27, 2026

On Fri Jan 23 18:42:09 2026 +0000, Colleirose wrote: > Got it, thank you :) Thanks for testing it! I also tried to test it with the upstream Wine development branch. To make Endfield work on Wine 11.1, we also need https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-Sysc… from wine-staging (bug 48291), then plusing Etaash's work for ntoskrnl.exe, I was able to log in to and start a game. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_128097

1 0