- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR9900: d3d8/tests: ATI2 DS surface creation attempt crashes nvidia. - approved
by Alexandre Julliard (＠julliard) Jan. 21, 2026

Jan. 21, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

1 0

Re: [PATCH v2 0/1] MR9903: wined3d: Don't print opcodes for cs padding packets. - approved
by Alexandre Julliard (＠julliard) Jan. 21, 2026

Jan. 21, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9903

1 0

[PATCH v15 0/4] MR9265: crt: Run MSVC constructors and destructors
by Yuxuan Shui (＠yshui) Jan. 21, 2026

Jan. 21, 2026

There are several motivations to enable ctor/dtor support: 1. ASan. This is not just about my wine-asan work, this is important for @bernhardu's PE asan work as well. The compiler generates ctors that poisons memory around global variables so misuses of them can be caught. This is the same both of our implementations of ASan. 2. Building third-party codebases against wine's CRT. This is not necessary for mingw-gcc or llvm-mingw, but the MSVC frontend of clang is another option for cross-compiling to Windows. However right now that requires Windows SDK. Bringing wine CRT to the point of being functional enough will give us another option. Could be useful for things like Proton. 3. (Controversial) Many dlls perform init/deinit tasks in `DllMain`. Some of them might benefit from a conversion to ctor/dtor. Since nothing in wine uses ctor/dtor right now, this change shouldn't have any impact by itself. -- v15: crt: Run MSVC constructors and destructors. winecrtend: Add a static lib for hosting fallback initterm implementations. winegcc: Merge .CRT sections for windows targets. winebuild: Generate start and end symbols for .CRT sections. https://gitlab.winehq.org/wine/wine/-/merge_requests/9265

4 8

[PATCH 0/2] MR9940: Include inkobj
by Alistair Leslie-Hughes (＠alesliehughes) Jan. 21, 2026

Jan. 21, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9940

3 4

[PATCH 0/1] MR9923: windowscodecs: Correct GIF LZW compression initialization for images with truncated color palette.
by Dmitry Timoshkov (＠dmitry) Jan. 21, 2026

Jan. 21, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/9486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9923

3 3

[PATCH v2 0/1] MR9898: windowscodecs: Remove unused comparison.
by Dmitry Timoshkov (＠dmitry) Jan. 21, 2026

Jan. 21, 2026

-- v2: windowscodecs: Add fallback path to copypixels_to_64bppRGBA(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9898

3 3

[PATCH 0/1] MR9943: msiexec: Fix escaping quoted arguments passed from Shell.
by Yaroslav Osipov (＠mcm) Jan. 21, 2026

Jan. 21, 2026

Properties with spaces passed to `msiexec` from shells like Bash may result in re-escaping the string. This results in wrong new quote position and so in MSI error `ERROR_INVALID_COMMAND_LINE`. This patch moves the quote back to its legal position. Step-by-step behavior after fixes in commit `14b718b69bb8d` (linked with Wine bug https://bugs.winehq.org/show_bug.cgi?id=57024) 1. Shell input: wine msiexec /i some.msi INSTALLDIR="C:\\Path with spaces\\data" 2. Shell args parser may remove double quote escaping: args\[3\] == "some.msi" args\[4\] == "INSTALLDIR=C:\\Path with spaces\\data" 3. `GetCommandLineW()` returns string with quote moved to the start: "msiexec ... some.msi "INSTALLDIR=C:\\Path with spaces\\data"" 4. Then MSI parser truncates beginning of the string up to character '=', leading to unbalanced quotes in result value: C:\\Path with spaces\\data" 5. MSI fails with error `ERROR_INVALID_COMMAND_LINE` (1639). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57024 Tests in bug 57024 are fine to reproduce the behavior, but note that `system()` and `execvp()` function passes their input on without extra parsing (without item 2 in the fail trace algorithm above). An example of such test: ``` execlp("msiexec", "msiexec", "/i", msi_path, "/qn", "\"MY_PROPERTY=foo bar\"", NULL); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9943

3 2

[PATCH v8 0/1] MR9477: shell32: Implement the function PickIconDlg.
by Matthias Zorn (＠Matthias-Zorn.0178) Jan. 21, 2026

Jan. 21, 2026

-- v8: shell32: Implement the function PickIconDlg https://gitlab.winehq.org/wine/wine/-/merge_requests/9477

2 1

[PATCH v33 0/1] MR9868: winewayland: Fix non-square icons with xdg-toplevel-icon protocol.
by Alex Schwartz (＠alexschwartz01) Jan. 21, 2026

Jan. 21, 2026

Currently, it will stop the app that is running that has a non-square icon This PR fixes that -- v33: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9868

2 1

[PATCH 0/5] MR9942: winevulkan: Misc make_vulkan function generation cleanups.
by Rémi Bernon Jan. 21, 2026

Jan. 21, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9942

1 5

[PATCH v7 0/1] MR9917: ntdll: Accept device paths in LdrAddDllDirectory.
by Alexandre Esteves (＠alexfmpe) Jan. 21, 2026

Jan. 21, 2026

This is needed to allow running Template Haskell inside Wine when cross-compiling as GHC uses device paths nowadays. Upstreaming from https://github.com/input-output-hk/haskell.nix/pull/2034/commits/44f2822afd… Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/6308 but only for AddDll as the GetDll part seems to already allow `RtlPathTypeLocalDevice` (old `DEVICE_PATH`). -- v7: ntdll: Accept device paths in LdrAddDllDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9917

2 3

[PATCH v6 0/1] MR9917: ntdll: Accept device paths in LdrAddDllDirectory.
by Alexandre Esteves (＠alexfmpe) Jan. 21, 2026

Jan. 21, 2026

This is needed to allow running Template Haskell inside Wine when cross-compiling as GHC uses device paths nowadays. Upstreaming from https://github.com/input-output-hk/haskell.nix/pull/2034/commits/44f2822afd… Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/6308 but only for AddDll as the GetDll part seems to already allow `RtlPathTypeLocalDevice` (old `DEVICE_PATH`). -- v6: ntdll: Accept device paths in LdrAddDllDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9917

3 3

[PATCH v9 0/6] MR9843: wtsapi32: Fix session id and desktop handling when using CreateProcessAsUserW with tokens from WTSQueryUserToken
by Katharina Bogad (＠hackathi) Jan. 20, 2026

Jan. 20, 2026

This Merge request resolves [Wine-Bug #58588](https://bugs.winehq.org/show_bug.cgi?id=58588). The underlying problem was that services started on their own, non-interactive winstation, but within the current user's session. This is trivially not the case for system services on Windows: they run, by design, in other user contexts (e.g. NTAUTHORITY\SYSTEM). Whenever a service wants to start a process within another user's graphical session, it needs to set the session id to the correct value. This may be done using the WTS API. This MR implements this functionality in a (hopefully) wine-compatible way: 1. Patch wineserver so tokens can be transferred to other sessions 2. Implement NtSetInformationToken for TokenSessionId 3. Change the session of non-interactive services to session 0 (from the default session 1) in addition to setting their desktop to `__wineservice_winstation\Default` 4. Let CreateProcessAsUserW reset the desktop to the default value `__winsta0\Default` if the session of the to-be-created process is not a service session. This avoids implementing all user and session handling in-depth while still allowing the underlying functionality to work. A real-world user of this mechanism is the Dassault 3DEXPERIENCE launcher, which runs as a system service and wants to open interactive child processes within a user's scope. -- v9: server: Let connect_process_winstation overwrite the desktop if needed services: start services with session id 0 wtsapi32: Let WTSEnumerateSessionsA/W return Console and Service session server: attach winstations to sessions, filter enum_windowstation wtsapi32: Make WTSQueryUserToken return a token with correct session id server: Allow changing of session id for process tokens https://gitlab.winehq.org/wine/wine/-/merge_requests/9843

3 10

[PATCH 0/4] MR9939: wined3d/hlsl: Implement generated texcoords.
by Elizabeth Figura (＠zfigura) Jan. 20, 2026

Jan. 20, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9939

2 4

[PATCH 0/3] MR9900: d3d8/tests: ATI2 DS surface creation attempt crashes nvidia.
by Stefan Dösinger Jan. 20, 2026

Jan. 20, 2026

It doesn't return an error (as it should), it just crashes somewhere deep in the driver dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

2 4

[PATCH 0/1] MR9903: wined3d: Don't print opcodes for cs padding packets.
by Francisco Casas (＠fcasas) Jan. 20, 2026

Jan. 20, 2026

Command stream queues are implemented using a fixed size array. This implementation requires NOP packets to be inserted at the end sometimes, so that these packets can be skipped and the head pointer can be properly move back to the beginning. Furthermore, sometimes it is necessary to insert padding packets that contain zero data (besides the size field), so they don't even have space for the NOP opcode. Their opcode shouldn't be read. Currently it is possible to get trace messages such as this: 0484:trace:d3d:wined3d_cs_queue_submit Queuing op UNKNOWN_OP(0x34) at 06EF1C8C. for these padding packets. In this case the packet was from cs->queue[0] but 0x34 was actually cs->queue[1].size. Depending of the out-of-bounds data, spurious yet valid opcodes could be reported, so we fix that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9903

3 2

Re: [PATCH v2 0/2] MR9927: mountmgr: Implement FileFsFullSizeInformationEx. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9927

1 0

Re: [PATCH v2 0/1] MR9936: msado15: Fix WrapDSOandSession usage in connection_Open. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9936

1 0

Re: [PATCH v2 0/2] MR9929: msado15: Respect DBPROP_CANHOLDROWS property in cache_get(). - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9929

1 0

Re: [PATCH v3 0/2] MR9916: win32u: Fixup Vulkan deviceName to match win32u GPU name. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9916

1 0

Re: [PATCH v2 0/5] MR9931: winevulkan: Cleanups and simplifications for make_vulkan. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9931

1 0

Re: [PATCH v2 0/1] MR9932: ncrypt: Support ECDSA_P256. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9932

1 0

Re: [PATCH v2 0/1] MR9933: fusion: Create the legacy GAC directory in CreateAssemblyCache(). - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9933

1 0

Re: [PATCH v2 0/1] MR9934: propsys: Fix parameter type of PropVariantToGUID. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9934

1 0

Re: [PATCH v8 0/2] MR9660: jscript: Treat DISPATCH_PROPERTYGET | DISPATCH_METHOD as property getter in ES5+ modes. - approved
by Alexandre Julliard (＠julliard) Jan. 20, 2026

Jan. 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9660

1 0