- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Hans Leidekker (＠hans) April 23, 2026

April 23, 2026

On Thu Apr 23 07:11:20 2026 +0000, Nikolai Abdusamatov wrote: > Hi @huw , could you please take another look at this MR when you have a moment? > I’ve addressed the previous review comments and updated the patch > accordingly. Please let me know if anything else needs to be changed. > Thanks! @tclem and @bshanks may know better if these interfaces are still used. Alternatively we could put them last, although that presumably brings back the buffer overflow in your app. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_137410

1 0

[PATCH v5 0/8] MR10364: dinput: Add support for generating consistent guidInstance values for devices.
by Connor McAdams (＠cmcadams) April 23, 2026

April 23, 2026

This MR adds support for creating `guidInstance` values for joystick devices in a way that matches native behavior. Our current method of creating a `guidInstance` value uses the device's rawinput handle, which changes each time a controller is plugged in. Fixes a bug in Rocket League where a controller plug/unplug cycle results in a new controller being detected each time. The process is like this: - Controller is connected, the game gets its `guidInstance` value from `EnumDevices()`, stores it and associates it with player 1. - Controller is disconnected. - The same controller is reconnected, the game calls `EnumDevices()`, and finds a new `guidInstance` value. - It then assumes this is a new controller, creates a new player, and behaves as though player 1's controller is unplugged. This MR implements `guidInstance` in a way that matches native, and ensures that the `guidInstance` value remains consistent. Doing things this way also makes it easier to add support for `DIPROP_JOYSTICKID` and `GUID_Joystick` in a future MR. I've implemented those in a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/dinput-instance-gu… using this system. -- v5: dinput: Refresh joystick devices when an unknown GUID is used to create a device. dinput: Return E_FAIL when opening a joystick device that is currently disconnected. dinput: Create a version 1 UUID for dinput joystick devices. dinput: Create registry entries for HID joysticks. dinput: Use joystick cache in hid_joystick_create_device(). dinput: Use joystick cache in hid_joystick_enum_device(). dinput: Create a cache of currently connected HID joysticks. dinput: Only pass instance name string to device_instance_is_disabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10364

3 16

Re: [PATCH v6 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Nikolai Abdusamatov (＠n-abdusamatov) April 23, 2026

April 23, 2026

On Tue Apr 14 19:47:26 2026 +0000, Nikolai Abdusamatov wrote: > Thanks to everyone for your detailed feedback and suggestions. I've > updated the patch based on them - I hope I got it right. The game still > loads correctly, and the buffer size doesn't exceed the client’s limit. > I've also attached the latest logs, including a comparison with the > previous version. > [analysis_summary.txt](/uploads/68d89f1348ab9b257566b116cddaf80d/analysis_summary.txt) Hi @huw , could you please take another look at this MR when you have a moment? I’ve addressed the previous review comments and updated the patch accordingly. Please let me know if anything else needs to be changed. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_137409

1 0

[PATCH v3 0/1] MR10427: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface
by Alistair Leslie-Hughes (＠alesliehughes) April 23, 2026

April 23, 2026

-- v3: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface https://gitlab.winehq.org/wine/wine/-/merge_requests/10427

2 1

[PATCH v3 0/2] MR10723: ddraw: Ignore hwnd clipper in exclusive fullscreen mode.
by Paul Gofman (＠gofman) April 23, 2026

April 23, 2026

-- v3: ddraw: Ignore hwnd clipper in exclusive fullscreen mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/10723

2 2

[PATCH v2 0/2] MR10723: ddraw: Ignore hwnd clipper in exclusive fullscreen mode.
by Paul Gofman (＠gofman) April 23, 2026

April 23, 2026

-- v2: ddraw: Ignore hwnd clipper in exclusive fullscreen mode. ddraw/tests: Add tests for clipper in exclusive fullscreen mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/10723

2 2

[PATCH 0/2] MR10723: ddraw: Ignore hwnd clipper in exclusive fullscreen mode.
by Paul Gofman (＠gofman) April 23, 2026

April 23, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10723

2 3

[PATCH v4 0/2] MR10714: Various fixes for GdipWarpPath and GdipGetNearestColor in graphics.c module
by Bartosz Kosiorek (＠gang65) April 22, 2026

April 22, 2026

-- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/10714

3 4

[PATCH 0/1] MR10722: gdiplus: Add support to line alignment for GdipMeasureString
by Bartosz Kosiorek (＠gang65) April 22, 2026

April 22, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10722

3 2

Re: [PATCH v2 0/1] MR10721: mscoree: Update Wine Mono to 11.1.0. - approved
by Alexandre Julliard (＠julliard) April 22, 2026

April 22, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10721

1 0

Re: [PATCH v2 0/3] MR10720: msxml3: Support for Shift_JIS encoding in parser. - approved
by Alexandre Julliard (＠julliard) April 22, 2026

April 22, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10720

1 0

Re: [PATCH v3 0/9] MR10719: dinput: Save and load HID joystick instance GUIDs to the registry. - approved
by Alexandre Julliard (＠julliard) April 22, 2026

April 22, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10719

1 0

Re: [PATCH v2 0/1] MR10713: mf: Handle no time and/or duration during markin. - approved
by Alexandre Julliard (＠julliard) April 22, 2026

April 22, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10713

1 0

Re: [PATCH v2 0/4] MR10717: mf/topology_loader: Always call IsMediaTypeSupported() on downstream when connecting a branch. - approved
by Alexandre Julliard (＠julliard) April 22, 2026

April 22, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10717

1 0

[PATCH v4 0/4] MR9775: gdiplus: Move X position calculation to callbacks.
by Dmitry Timoshkov (＠dmitry) April 22, 2026

April 22, 2026

An application I'm working on does GdipMeasureCharacterRanges(graphics, "1", 1, ..., 2, regions); GdipGetRegionBounds(regions[0], graphics, &bounds); GdipSetClipRegion(graphics, regions[0], CombineModeReplace); GdipDrawString(graphics, graphics, "1", 1, ..); which leads to an almost completely clipped text output. Attached test application graphically shows the results of bounding boxes calculated by GdipMeasureCharacterRanges(), GdipMeasureString() and GdipDrawString(). This patchset makes the resulting image look closer to what is observed under Windows. Gdip[test_GdipMeasureCharacterRanges.tar.xz](/uploads/53c8bd3f9b7b005d5b0b675296f0631c/test_GdipMeasureCharacterRanges.tar.xz) -- v4: gdiplus: Copy logic for trimming bounds width from GdipMeasureString() to GdipMeasureCharacterRanges(). gdiplus: Move vertical alignment calculation from GdipDrawString() to common helper. gdiplus: Take into account line alignment in GdipMeasureString(). gdiplus: gdip_format_string() always passes valid gdip_format_string_info->format to callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/9775

4 18

[PATCH 0/1] MR10721: mscoree: Update Wine Mono to 11.1.0.
by Esme Povirk (＠madewokherd) April 22, 2026

April 22, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10721

2 1

[PATCH 0/3] MR10720: msxml3: Support for Shift_JIS encoding in parser.
by Nikolay Sivov (＠nsivov) April 22, 2026

April 22, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10720

3 5

[PATCH v2 0/9] MR10719: dinput: Save and load HID joystick instance GUIDs to the registry.
by Rémi Bernon (＠rbernon) April 22, 2026

April 22, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10364 -- v2: dinput: Create a version 1 UUID for dinput joystick devices. dinput: Save and load HID joystick instance GUIDs to the registry. dinput: Return E_FAIL when opening a joystick device that is currently disconnected. dinput: Use joystick cache in hid_joystick_enum_device(). dinput: Use joystick cache in hid_joystick_create_device(). dinput: Create a cache of currently connected HID joysticks. dinput: Handle device override directly in hid_joystick_device_try_open. dinput: Check for disabled/overriden devices in hid_joystick_try_open. dinput: Only pass instance name string to device_instance_is_disabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10719

3 9

[PATCH 0/9] MR10719: dinput: Save and load HID joystick instance GUIDs to the registry.
by Rémi Bernon (＠rbernon) April 22, 2026

April 22, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10364 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10719

3 9

[PATCH 0/1] MR10718: kernelbase: Add language resource search functionality
by Craig Schulstad (＠NoDakker) April 22, 2026

April 22, 2026

For applications relying upon language specific resources, search for an associated language specific subfolder and mui file based upon the language in force for the prefix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10718

2 1

[PATCH v3 0/5] MR9777: mfplat: Implement mf d3d12 synchronization object.
by Charlotte Pabst (＠CharlottePabst) April 22, 2026

April 22, 2026

I'm also working on tests & implementation for d3d12-backed IMFMediaBuffers and sample allocators, submitting this here to receive some feedback while working on more. Sorry if the tests are too involved, perhaps they could be simplified, but since there is very little documentation on this I had to figure out a lot of minor details using tests. The use case is Fuga Melodies of Steel 3 which uses the UE5 electra decoder plugin. It expects d3d12 support in media foundation (sample allocator, media buffer, sync object). This game doesn't require implementing proper d3d12 video decoding, only that frame data is stored in a IMFMediaBuffer that is backed by a ID3D12Resource. Once finished, this feature would presumably help with other UE5 games that have similar usage patterns as well (All the code for it is in UE5, which is source-available). Other real world examples are limited, but I believe chromium and mesa have some optional code using this feature. MFCreateD3D12SynchronizationObject is (presumably) used by MFCreateDXGISurfaceBuffer to create a synchronization object for the buffer (I already have some tests that query and use the synchronization object from a d3d12-backed mediabuffer, which I will submit together with the other d3d12 buffer tests.) -- v3: mfplat: Use freelist for mfd3d12 syncobj release. mfplat/tests: Test that mfd3d12 syncobj release keeps working through multiple resets. mfplat: Implement mf d3d12 synchronization object. mfplat/tests: Add tests for mf d3d12 synchronization object. mfd3d12.h: Add some missing definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/9777

3 19

[PATCH 0/1] MR10612: gdi32/uniscribe: Fix heap buffer overflow in ScriptStringAnalyse().
by समीरसिंह Sameer Singh (＠ss141309) April 22, 2026

April 22, 2026

Hi, I came across this bug while solving another issue. Steps to reproduce: 1. Open wine notepad 2. Start spamming any character that requires mark_invalid_combinations() in the notepad, such as: َ (0x064e Arabic Fatha) 3. At nearly 41 inserted Fatha, notepad will crash -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10612

5 7

[PATCH 0/1] MR10713: mf: Handle no time and/or duration during markin.
by Brendan McGrath (＠redmcg) April 22, 2026

April 22, 2026

This MR fixes handling of the `MF_TOPONODE_MARKIN_HERE` attribute when sample time and/or duration are missing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10713

3 2

[PATCH 0/4] MR10717: mf/topology_loader: Always call IsMediaTypeSupported() on downstream when connecting a branch.
by Rémi Bernon (＠rbernon) April 22, 2026

April 22, 2026

Split from !10645 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10717

2 4

[PATCH v2 0/1] MR10575: kernelbase: Add language resource search functionality
by Craig Schulstad (＠NoDakker) April 22, 2026

April 22, 2026

For applications relying upon language specific resources, search for an associated language specific subfolder and mui file based upon the language in force for the prefix. -- v2: kernelbase: Add language resource search functionality https://gitlab.winehq.org/wine/wine/-/merge_requests/10575

2 2