- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR9562: vkd3d: Import upstream release 1.18.
by Alexandre Julliard (＠julliard) Nov. 23, 2025

Nov. 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9562

5 5

[PATCH v5 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) Nov. 23, 2025

Nov. 23, 2025

-- v5: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH 0/1] MR9561: ntdll/tests: Avoid out-of-bounds read in call_virtual_unwind_x86 (ASan).
by Bernhard Übelacker Nov. 23, 2025

Nov. 23, 2025

In `call_virtual_unwind_x86` in `unwind_size` a size to read 16 bytes is determined. This patch simply allocates that much bytes in the source variable. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161010) [ASan report in gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/210659/viewer#L14266) <details> <summary>ASan details</summary> ``` $ wine dlls/ntdll/tests/x86_64-windows/ntdll_test.exe unwind ================================================================= ==392==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0001402cdf86 at pc 0x6ffffe8cc0eb bp 0x7ffffe1fdbb0 sp 0x7ffffe1fdbf8 READ of size 16 at 0x0001402cdf86 thread T0 #0 0x6ffffe8cc0ea in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x0001401b02d0 in call_virtual_unwind_x86 .../wine/dlls/ntdll/tests/unwind.c:2730 #2 0x0001401ad7ab in test_virtual_unwind_x86 .../wine/dlls/ntdll/tests/unwind.c:3371 #3 0x0001401ad602 in func_unwind .../wine/dlls/ntdll/tests/unwind.c:3767 #4 0x0001401e4242 in run_test .../wine/include/wine/test.h:780 #5 0x0001401e3c4b in main .../wine/include/wine/test.h:900 #6 0x0001401e5eda in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6fffffc67a54 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a54) #8 0x6fffffde06d6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506d6) 0x0001402cdf86 is located 26 bytes before global variable 'test_virtual_unwind_x86.results_6_epilogue' defined in '.../wine/dlls/ntdll/tests/unwind.c:3166' (0x0001402cdfa0) of size 336 0x0001402cdf86 is located 0 bytes after global variable 'test_virtual_unwind_x86.unwind_info_6' defined in '.../wine/dlls/ntdll/tests/unwind.c:3156' (0x0001402cdf80) of size 6 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/ntdll/tests/unwind.c:2730 in call_virtual_unwind_x86 ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9561

1 1

[PATCH v4 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) Nov. 23, 2025

Nov. 23, 2025

-- v4: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. rometadata: Implement IMetaDataTables::{EnumProperties, GetPropertyProps}. rometadata: Implement IMetaDataDispenser::OpenScopeOnMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH v3 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) Nov. 23, 2025

Nov. 23, 2025

-- v3: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. rometadata: Implement IMetaDataTables::{EnumProperties, GetPropertyProps}. rometadata: Implement IMetaDataDispenser::OpenScopeOnMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH v3 0/2] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) Nov. 22, 2025

Nov. 22, 2025

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- v3: dlls/twain_32, dlls/twaindsm: Build Twain DSM as twaindsm.dll on 64-Bit build dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier. https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

4 6

[PATCH 0/3] MR9557: ntdll: Support iterative barrier usage without re-initialization.
by Paul Gofman (＠gofman) Nov. 22, 2025

Nov. 22, 2025

https://bugs.winehq.org/show_bug.cgi?id=59017 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9557

3 5

[PATCH v2 0/5] MR9558: d2d1: Add some new effect stubs
by Alfred Agrell (＠Alcaro) Nov. 22, 2025

Nov. 22, 2025

Needed by https://store.steampowered.com/app/1138210/Esperia__Uprising_of_the_Scarlet… demo (and presumably the full game too); without this, it throws a message box saying No Interface | 1 | 88990028 on first entry to any combat (the 1 varies depending on which specific effect is unimplemented), then segfaults if any character gets a critical hit (those are prefixed with a bar showing the character's eyes). Even with these stubs, the game looks glitched when getting a crit, but better ugly than segfault. The game also needs Color Matrix, Gaussian Blur and Flood effects relative to Proton 10, but those three were already stubbed in Wine 10.n. -- v2: d2d1: Add Saturation effect stub d2d1: Add Hue Rotation effect stub d2d1: Add Directional Blur effect stub d2d1: Add Brightness effect stub d2d1: Add Blend effect stub https://gitlab.winehq.org/wine/wine/-/merge_requests/9558

2 6

[PATCH 0/5] MR9558: d2d1: Add some new effect stubs
by Alfred Agrell (＠Alcaro) Nov. 22, 2025

Nov. 22, 2025

Needed by https://store.steampowered.com/app/1138210/Esperia__Uprising_of_the_Scarlet… demo (and presumably the full game too); without this, it throws a message box saying No Interface | 1 | 88990028 on first entry to any combat (the 1 varies depending on which specific effect is unimplemented), then segfaults if any character gets a critical hit (those are prefixed with a bar showing the character's eyes). Even with these stubs, the game looks glitched when getting a crit, but better ugly than segfault. The game also needs Color Matrix, Gaussian Blur and Flood effects relative to Proton 10, but those three were already stubbed in Wine 10.n. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9558

3 11

[PATCH v2 0/2] MR9553: ntdll: Refuse to start if wineserver is in wrong pid namespace
by Alfred Agrell (＠Alcaro) Nov. 22, 2025

Nov. 22, 2025

To reproduce: - `unshare -Upf ./wine cmd` - (in another terminal) `unshare -Upf ./wine not-a-command` The first terminal will now go completely unresponsive, until you kill -9 the relevant start.exe from the second terminal. Root cause analysis: In the first Wine, wineserver gets Unix pid 3 in its namespace. (And a different pid in the root namespace, but no relevant process sees that.) In the second Wine, not-a-command gets Unix pid 3 in its namespace, and sends it to wineserver. When not-a-command notices it doesn't exist and exits, wineserver checks if pid 3 did indeed exit, and SIGKILLs it if not. But since that pid is from wrong namespace, wineserver ends up killing itself instead. While this only happens in badly configured sandboxes, such things do exist in the wild. https://github.com/flathub/org.winehq.Wine/issues/41 The real solution would be either fixing the sandbox config, or making Wine use pidfds instead of pids, but former is out of our control, and latter would be a lot of effort and ifdefs (and unlikely to work, there's no process_vm_readv for pidfds). The second commit only blocks cases where wineserver exists in ntdll's namespace, but not the other way round. It's a much rarer case than having the processes in mutually-inaccessible sibling namespaces, it's a much bigger patch than the ntdll side, and the error is detected at wrong side (meaning it can't print a friendly error). I'm not sure if it's worth keeping. -- v2: server: Reject clients from wrong pid namespace https://gitlab.winehq.org/wine/wine/-/merge_requests/9553

4 4

Re: [PATCH v7 0/1] MR9442: comctl32/treeview: check for child item before SendExpanding
by Zhiyi Zhang (＠zhiyi) Nov. 22, 2025

Nov. 22, 2025

Hi, you don't need to rebase the MR to master every day. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9442#note_123343

1 0

Re: [PATCH v3 0/1] MR9436: windowscodecs: Fix the bug when the input palette hpal is NULL in... - approved
by Esme Povirk (＠madewokherd) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9436

1 0

[PATCH v4 0/2] MR9530: dlls/sane.ds: Added cancel button and progress bar to progress dialog
by Bernd Herd (＠herdsoft) Nov. 21, 2025

Nov. 21, 2025

Control display of progress dialog with CAP_INDICATORS. Use PeekMessage/DispatchMessage loop while scanning. Display some informations on scan job in progress dialog. If ADF is enabled and not filled with paper, display an error message to the user and allow a retry. Also displays paper jammed message and cover open message. Added german translation for the new error messages and progress dialog controls. ![no_docs_error.png](/uploads/0ff5e941fbae3685e0a94ca8031f075b/no_docs_error.png){width=389 height=320} Error message display are controlled with CAP_INDICATORS if Data Source UI is not shown. -- v4: dlls/sane.ds: Display message if ADF is empty in ADF scan https://gitlab.winehq.org/wine/wine/-/merge_requests/9530

3 7

Re: [PATCH v3 0/3] MR9550: dwrite/fallback: Add the Cyrillic range to the fallback data. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9550

1 0

Re: [PATCH v2 0/3] MR9537: dmsynth: Add layering support - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9537

1 0

Re: [PATCH v3 0/6] MR9517: d3dx{9,10,11}: Implement a box filter. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9517

1 0

Re: [PATCH v3 0/4] MR9441: quartz/dsoundrender: A few bits around EOS handling. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9441

1 0

Re: [PATCH v6 0/1] MR9479: dlls/sane.ds: Load last settings from registry immediatly when opening the DS - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9479

1 0

Re: [PATCH v3 0/1] MR9545: wbemprox: Add PartialProductKey and ApplicationId to SoftwareLicensingProduct class. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9545

1 0

Re: [PATCH v5 0/1] MR9410: urlmon: FindMimeFromData return only the mime type - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410

1 0

Re: [PATCH v4 0/9] MR9548: msado15: Don't load all data from recordset on open. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9548

1 0

Re: [PATCH v2 0/1] MR9547: wine.inf: Add .crt association. - approved
by Alexandre Julliard (＠julliard) Nov. 21, 2025

Nov. 21, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9547

1 0

[PATCH 0/1] MR9546: winex11: Flush after presenting.
by Elizabeth Figura (＠zfigura) Nov. 21, 2025

Nov. 21, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9546

2 2

[PATCH 0/1] MR9555: Fix ICAP_BITDEPTH semantics, allow setting it
by Bernd Herd (＠herdsoft) Nov. 21, 2025

Nov. 21, 2025

In Twain the capability ICAP_BITDEPTH defines the number of bits to transfer per pixel during a scan. So for an RGB image with 8 bit per color channel, ICAP_BITDEPTH is 24. In Sane the depth is defined as the number of bits per color channel, so for an RGB image with 8 bit per color channel, depth is 8. See Page 10-132 (PDF Page 550) if the Twain 2.5 Spec. Obviously older spec versions where not as exact, so there were misunderstandings. The existing code to handle ICAP_BITDEPTH did not consider this difference and returned the sane depth value. This merge request fixes this and adds the ability to set the depth to 16 bit per color channel for those sane backends that support the "depth" option. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9555

2 1

[PATCH 0/7] MR9554: Cmd engine rewrite (part XXXXI)
by eric pouech (＠epo) Nov. 21, 2025

Nov. 21, 2025

This is cmd engine rewrite part XXXXI. Main goal is to cover bug entry 39289. To do so we need to: - properly handle the echo of commands when not in interactive mode + good news if that this shares mostly the code we added to rewrite commands to pass them in pipe sub-shells, + also fixing the handling of @ at start of command (there we a bunch of issues: it was only supported at the start of a single command, all the other forms IF/FOR/() are supposed to handle them too) + some of the tests assumed there is some kind of propagation of @ in chained commands; I do believe it's mostly linked to the commands actually run + most of the tests related to echo now pass (expect a few where there are discrepancies but only on the number of spaces inserted). I don't feel like fixing these unless an app actually depends on it, - fix a couple of other issues: + prompt $H actually echo:es \x08\x20\x08 instead of \x08... to ensure that prev char is actually cleaned (manually tested on Windows) + loop variables when not expanded inside a !foo! construct (other env variables were). Test program from Bug 29389 works as expected, even if output isn't as nice as on windows, mainly because of conhost refresh rate (BZ#56851). Side note: this is probably the last MR from the cmd engine rewrite saga. There are still open tickets on cmd.exe but most of the structural work should be ok by now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9554

2 7