- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) Nov. 20, 2025

Nov. 20, 2025

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } > + > + *ret_mime = CoTaskMemAlloc((len+1)*sizeof(WCHAR)); > if(!*ret_mime) > return E_OUTOFMEMORY; > > memcpy(*ret_mime, ret, len*sizeof(WCHAR)); > + ((WCHAR*)(*ret_mime))[len] = 0; ```suggestion:-0+0 (*ret_mime)[len] = 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123132

1 0

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) Nov. 20, 2025

Nov. 20, 2025

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > > TRACE("found %s for %s\n", debugstr_w(ret), debugstr_an((const char*)buf, min(32, size))); > > - len = lstrlenW(ret)+1; > - *ret_mime = CoTaskMemAlloc(len*sizeof(WCHAR)); > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } ```suggestion:-8+0 len = wcsspn(ret, L";"); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123131

1 0

[PATCH v2 0/1] MR9516: jscript: Do existing prop lookups for external props only on objects with volatile props.
by Gabriel Ivăncescu Nov. 20, 2025

Nov. 20, 2025

-- v2: jscript: Do existing prop lookups for external props only on objects with https://gitlab.winehq.org/wine/wine/-/merge_requests/9516

2 5

[PATCH 0/2] MR9543: msado15: Don't use row index in _Recordset::get_EditMode.
by Piotr Caban (＠piotr) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9543

2 2

[PATCH v3 0/3] MR9526: win32u/tests: Test which Vulkan/GL/D3D graphics objects hold shared resource handles.
by Derek Lesho (＠dlesho) Nov. 20, 2025

Nov. 20, 2025

In prep for my OpenGL shared resource series. The behavior there seems to be heavily driver-specific. -- v3: win32u/tests: Test shared handle lifetime. https://gitlab.winehq.org/wine/wine/-/merge_requests/9526

2 4

[PATCH 0/2] MR9542: win32u, winex11: Fix and workaround crashes in UpdateLayeredWindow calls.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9542

1 2

[PATCH 0/1] MR9532: win32u: Only delete subkeys when clearing DirectX key.
by Paul Gofman (＠gofman) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9532

3 3

[PATCH 0/3] MR9540: win32u/tests: Set GL_DEDICATED_MEMORY_OBJECT_EXT on import.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/9526 with stylistic fixups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9540

2 4

[PATCH 0/2] MR9538: winegstreamer: Return S_FALSE from DMO when there is not enough data.
by Yuxuan Shui (＠yshui) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9538

3 7

Re: [PATCH v4 0/6] MR9453: xactengine3/tests: Add many more tests.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

The xactengine3_7:xact3 tests are crashing on some wow32/wow64 VMs (https://test.winehq.org/data/patterns.html#xactengine3_7:xact3) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9453#note_123092

1 0

Re: [PATCH v4 0/2] MR9500: In CreateProcess(), set std handle when passing a pseudo-console.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

This introduced entry points which are missing on Windows 8.1, the kernel32 tests aren't there anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9500#note_123091

1 0

[PATCH 0/1] MR9539: winex11: Don't update client maximized state if window is minimized.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=59012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9539

1 1

[PATCH v2 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Bernhard Kölbl Nov. 20, 2025

Nov. 20, 2025

Black Squad's launcher creates a font like ```c font = CreateFontW(12, 0, 0, 0, 0, 0, 0, 0, DEFAULT_CHARSET, 0, 0, 0, 0x80 /* ??? */ | FF_ROMAN, L""); ``` This confuses Wine and causes it to pick a sans serif font instead of a serif one. -- v2: win32u: Explicitly check for font family bits. gdi32/tests: Test font creation by family. https://gitlab.winehq.org/wine/wine/-/merge_requests/9514

1 2

Re: [PATCH v2 0/1] MR9477: shell32: Implement the function PickIconDlg.
by Matthias Zorn (＠Matthias-Zorn.0178) Nov. 20, 2025

Nov. 20, 2025

On Thu Nov 20 07:20:30 2025 +0000, Vijay Kiran Kamuju wrote: > Please check if it can be split into smaller patches I see the possibility of splitting the patch into a large patch that does not contain the PickIconDlg_OnClickButton function and a small patch that adds the PickIconDlg_OnClickButton function and also the call to this function in the PickIconDlg_Proc function. Unfortunately, this does not help much, because the PickIconDlg_OnClickButton function has less than 100 lines of code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9477#note_123080

1 0

[PATCH v2 0/1] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) Nov. 20, 2025

Nov. 20, 2025

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- v2: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier. https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

2 1

[PATCH 0/1] MR9536: d3d11: Implement DecoderExtension().
by Elizabeth Figura (＠zfigura) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9536

2 1

[PATCH 0/1] MR9535: d3d11: Use GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS in D3D11CoreCreateDevice().
by Elizabeth Figura (＠zfigura) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9535

2 1

[PATCH v2 0/3] MR8925: winemac.drv: Add EDID support.
by Jactry Zeng (＠jactry) Nov. 20, 2025

Nov. 20, 2025

-- v2: winemac.drv: Support to generate EDID from display parameters from Core Graphics APIs. winemac.drv: Support to get EDID from IODisplayConnect. winemac.drv: Support to get EDID from DCPAVServiceProxy. https://gitlab.winehq.org/wine/wine/-/merge_requests/8925

3 6

[PATCH v2 0/12] MR9489: mf: Fix seeking within sample grabber.
by Brendan McGrath (＠redmcg) Nov. 19, 2025

Nov. 19, 2025

This fixes seeking within sample grabber by matching Windows functionality. -- v2: mf: Request new sample before processing markers. mf: Remove no longer used sample_count and samples array. mf: Ensure we always have four requests outstanding/satisfied. mf: Always queue a sample unless stopped. mf: Keep count of samples queued. mf: Make flushing on sample grabber largely a no-op. mf/tests: Check contents of sample collection. mf/tests: Test seek with sample grabber whilst ignoring clock. mf/tests: Test samplegrabber flush then seek. mf/tests: Check StreamSinkMarker event. mf/tests: Test sample grabber {Set,Cancel}Timer. mf/tests: Add test for sample grabber seek. https://gitlab.winehq.org/wine/wine/-/merge_requests/9489

2 13

[PATCH 0/1] MR9534: wined3d: Make SHADOW into a format attr.
by Elizabeth Figura (＠zfigura) Nov. 19, 2025

Nov. 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9534

2 1

Re: [PATCH v2 0/1] MR9524: comctl32_v6/taskdialog: Fix not enough width for the expando button text. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9524

1 0

Re: [PATCH v2 0/5] MR9521: comctl32/updown: Refactor UPDOWN_DrawBuddyBackground() to support drawing... - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9521

1 0

Re: [PATCH v3 0/6] MR9522: dmsynth: DLS fixes, part 2 - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9522

1 0

Re: [PATCH v3 0/4] MR9508: winex11: Track more window state to avoid unnecessary requests. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9508

1 0

Re: [PATCH v3 0/1] MR9512: widl: Fix MethodList value for apicontract typedefs. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9512

1 0