- Wine-GitLab - list.winehq.org

[PATCH v26 0/1] MR10244: Draft: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts ~~There are still quite some compiler issues left but~~ this addresses the biggest parser issues. -- v26: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

[PATCH v25 0/1] MR10244: Draft: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts ~~There are still quite some compiler issues left but~~ this addresses the biggest parser issues. -- v25: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

[PATCH v24 0/1] MR10244: Draft: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts ~~There are still quite some compiler issues left but~~ this addresses the biggest parser issues. -- v24: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 2

[PATCH v10 0/5] MR10611: LPC: Implement proper LPC system
by Rose Hellsing (＠axtlos) April 17, 2026

April 17, 2026

Until now, LPC was just a stub, any application that relied on LPC for communication would fail. This change implements parts of LPC, to allow for IPC between programs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=30069 - fully fixed, sqlservr is able to run as expected Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59494 - partially fixed, starmoney doesn't flat out crash anymore, but it doesn't start fully, possibly because it uses the ALPC system which was introduced in Windows Vista, the version Starmoney 10 was advertised for -- v10: LPC: Properly handle port closes https://gitlab.winehq.org/wine/wine/-/merge_requests/10611

3 6

[PATCH v22 0/1] MR10244: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts ~~There are still quite some compiler issues left but~~ this addresses the biggest parser issues. -- v22: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 2

[PATCH v2 0/5] MR10689: winex11: Keyboard layouts rework, part 1
by Rémi Bernon (＠rbernon) April 17, 2026

April 17, 2026

Same as https://gitlab.winehq.org/wine/wine/-/merge_requests/10550 with misc tweaks. -- v2: winex11: Decode current keyboard layout from the Xkb group name. winex11: Look up keysyms for the currently selected Xkb group in X11DRV_KEYBOARD_DetectLayout(). winex11: Get Xkb group names. winex11: Factor out mapping keycodes to scancodes / keysyms into a separate function. winex11: Fix some X11DRV_InitKeyboard loop indentation. https://gitlab.winehq.org/wine/wine/-/merge_requests/10689

3 5

[PATCH v4 0/4] MR10550: winex11: Keyboard layouts rework, part 1
by Matteo Bruni (＠Mystral) April 17, 2026

April 17, 2026

The idea is to improve the detection of the available keyboard layouts, normally via Xkb group names + xkbregistry, and then propagate the current layout to win32u and the PE / win32 side state. Along the way also start using `KBDTABLES` and the related newer win32u machinery that was introduced for winewayland. I'm taking a lot of inspiration (and also actual patches, or pieces of code) from the winewayland driver and Rémi's draft MR !2122. The main difference from that attempt is that I'm going to keep around `X11DRV_KEYBOARD_DetectLayout()` and use it as a fallback detection mechanism (e.g. for vncserver), but still move winex11 to `KBDTABLES` and such. You can find the current (still WIP, especially for later patches) branch at https://gitlab.winehq.org/Mystral/wine/-/commits/hl-kbl?ref_type=heads -- v4: winex11: Decode current keyboard layout from the Xkb group name. winex11: Look up keysyms for the currently selected Xkb group in X11DRV_KEYBOARD_DetectLayout(). winex11: Factor out mapping keycodes to scancodes / keysyms into a separate function. winex11: Get Xkb group names. https://gitlab.winehq.org/wine/wine/-/merge_requests/10550

3 8

[PATCH 0/5] MR10689: winex11: Keyboard layouts rework, part 1
by Rémi Bernon (＠rbernon) April 17, 2026

April 17, 2026

Same as https://gitlab.winehq.org/wine/wine/-/merge_requests/10550 with misc tweaks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10689

3 6

[PATCH v7 0/6] MR10009: mf/topology_loader: Fix some topology loader test failures.
by Conor McCarthy (＠cmccarthy) April 17, 2026

April 17, 2026

A followup MR will move converter connection behaviour closer to native, and maybe revise decoder connection a bit. -- v7: mf/topology_loader: Always enable enumeration when connecting a decoder down. mf/topology_loader: Enumerate up and down types if applicable when inserting a converter. mf/topology_loader: Create video converters via CoCreateInstance(). mf/topology_loader: Create audio resamplers via CoCreateInstance(). mf/topology_loader: Load the down connection method in topology_branch_connect(). mf/topology_loader: Introduce a helper to clone a media type and update it from upstream. https://gitlab.winehq.org/wine/wine/-/merge_requests/10009

3 11

[PATCH v20 0/3] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function, duplicate class members), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store source locations in const_decl_t, dim_decl_t, function_decl_t, and class_decl_t so errors point to the duplicate name. Also fix duplicate Sub/Function/Property/Dim detection inside classes, including the case where a Property collides with an existing Sub/Function. -- v20: vbscript: Return "Name redefined" error for duplicate class members. vbscript: Return "Name redefined" error for duplicate global declarations. vbscript: Track source location in const, class, and function declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 4

[PATCH 0/1] MR10682: mfplat/tests: Test MFInitAMMediaTypeFromMFMediaType GUID conversions.
by Rémi Bernon (＠rbernon) April 17, 2026

April 17, 2026

Proves that it doesn't convert GUIDs when using FORMAT_MFVideoFormat. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10682

3 4

[PATCH v3 0/2] MR10298: mfreadwrite: Implement sample encoding.
by Ziqing Hui (＠zhui) April 17, 2026

April 17, 2026

-- v3: mfreadwrite: Process samples through converter and encoder. mfreadwrite: Set encoder types correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/10298

3 3

[PATCH 0/1] MR10675: Draft: scrrun: Implement IFolder and IFile ShortName and ShortPath.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

Both get_ShortPath methods wrap GetShortPathNameW on the stored long path; get_ShortName extracts the last component of the resulting short path. Add matching tests comparing against GetShortPathNameW directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10675

3 2

[PATCH v19 0/1] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) April 17, 2026

April 17, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function, duplicate class members), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store source locations in const_decl_t, dim_decl_t, function_decl_t, and class_decl_t so errors point to the duplicate name. Also fix duplicate Sub/Function/Property/Dim detection inside classes, including the case where a Property collides with an existing Sub/Function. -- v19: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH 0/7] MR10688: msxml3: Improvements to setAttribute().
by Nikolay Sivov (＠nsivov) April 17, 2026

April 17, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688

3 8

[PATCH 0/1] MR10632: msxml3/tests: Test encoding of special characters.
by Daniel Lehman (＠dlehman25) April 17, 2026

April 17, 2026

recent rewrite fixes my issue submitting just the tests. `IXMLDOMText_get_text` result had a `todo_wine` https://testbot.winehq.org/JobDetails.pl?Key=162504 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10632

3 3

[PATCH 0/6] MR10686: opengl32: Fix missing hooks and merge similar wrappers together.
by Rémi Bernon (＠rbernon) April 17, 2026

April 17, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10686

2 6

[PATCH v3 0/1] MR10633: kernelbase: Ignore GENERIC_WRITE in CreateFile on CDs on Windows 9x.
by Alex Henrie (＠alexhenrie) April 17, 2026

April 17, 2026

The hack has to be in kernel32.dll; having it in krnl386.exe is not enough for all programs that need the old behavior. And in my testing, the error was STATUS_ACCESS_DENIED whether using a physical CD or a mounted ISO file, never STATUS_MEDIA_WRITE_PROTECTED. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59636 -- v3: kernelbase: Ignore GENERIC_WRITE in CreateFile on CDs on Windows 9x. https://gitlab.winehq.org/wine/wine/-/merge_requests/10633

2 2

[PATCH v3 0/1] MR10508: fonts: Add Thai glyphs to Tahoma.
by Ziqing Hui (＠zhui) April 17, 2026

April 17, 2026

The original glyphs are from Waree: https://github.com/tlwg/fonts-tlwg/blob/master/tlwg/Waree.sfd Waree is in BitStream licence. See: https://github.com/tlwg/fonts-tlwg/blob/master/COPYING > Copyright: > > Copyright (C) 2003 by Bitstream, Inc. All Rights Reserved. > TLWG changes are in public domain. > > Bitstream Vera is a trademark of Bitstream, Inc. > > License: > > Permission is hereby granted, free of charge, to any person obtaining > a copy of the fonts accompanying this license ("Fonts") and associated > documentation files (the "Font Software"), to reproduce and distribute > the Font Software, including without limitation the rights to use, > copy, merge, publish, distribute, and/or sell copies of the Font > Software, and to permit persons to whom the Font Software is furnished > to do so, subject to the following conditions: > > The above copyright and trademark notices and this permission notice > shall be included in all copies of one or more of the Font Software > typefaces. > > The Font Software may be modified, altered, or added to, and in > particular the designs of glyphs or characters in the Fonts may be > modified and additional glyphs or characters may be added to the > Fonts, only if the fonts are renamed to names not containing either > the words "Bitstream" or the word "Vera". > > This License becomes null and void to the extent applicable to Fonts > or Font Software that has been modified and is distributed under the > "Bitstream Vera" names. > > The Font Software may be sold as part of a larger software package > but no copy of one or more of the Font Software typefaces may be sold > by itself. > > THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF > MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT > OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL > BITSTREAM OR THE GNOME FOUNDATION BE LIABLE FOR ANY CLAIM, DAMAGES OR > OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, > OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR > OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT > SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE. > > Except as contained in this notice, the names of Gnome, the Gnome > Foundation, and Bitstream Inc., shall not be used in advertising or > otherwise to promote the sale, use or other dealings in this Font > Software without prior written authorization from the Gnome Foundation > or Bitstream Inc., respectively. For further information, contact: > fonts at gnome dot org. -- v3: fonts: Add Thai glyphs to Tahoma. https://gitlab.winehq.org/wine/wine/-/merge_requests/10508

2 1

[PATCH v10 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) April 16, 2026

April 16, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- v10: vbscript: Return "Invalid for loop control variable" error for member expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

[PATCH 0/1] MR10685: Draft: vbscript: Fast-path For-Each iteration over SAFEARRAY.
by Francis De Brabandere (＠francisdb) April 16, 2026

April 16, 2026

When a For-Each loop iterates over a SAFEARRAY, bypass the IEnumVARIANT COM vtable dispatch and copy elements directly from the array data. This eliminates the COM call overhead and one intermediate VariantCopy per iteration. For non-refcounted element types (VT_I2, VT_I4, VT_R8, etc.), also skip VariantCopyInd and VariantClear entirely, replacing them with a direct struct assignment. Non-SAFEARRAY iterators (e.g. IDispatch collections) continue to use the standard IEnumVARIANT_Next path. For-Each over a 10M-element integer array: 6,339ms -> 58ms (109x faster). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10685

2 3

[PATCH v2 0/7] MR10513: d3dx{9,10,11}: Add support for premultiplied alpha and SRGB conversions.
by Connor McAdams (＠cmcadams) April 16, 2026

April 16, 2026

-- v2: d3dx{9,10,11}: Handle SRGB filter flags. d3dx{10,11}/tests: Add tests for SRGB formats and filter flags. d3dx9/tests: Add tests for D3DX_FILTER_SRGB flags. d3dx{10,11}: Only use passed in filter flags if image scaling is necessary. d3dx{10,11}/tests: Add a test for invalid image load filter flags. d3dx9: Properly handle DXT textures with premultiplied alpha. d3dx{10,11}/tests: Add tests for decoding DXTn DDS files. https://gitlab.winehq.org/wine/wine/-/merge_requests/10513

3 12

[PATCH v18 0/8] MR10515: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) April 16, 2026

April 16, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v18: https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 8

[PATCH v17 0/9] MR10515: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) April 16, 2026

April 16, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v17: vbscript: Fast-path For-Each iteration over SAFEARRAY. vbscript: Bind For-Each loop variable at compile time. vbscript: Bind global-scope Dim variables at compile time. vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

3 15

Re: [PATCH v2 0/8] MR10679: msxml3: Reduce duplication in IXMLDOMCharacterData methods. - approved
by Alexandre Julliard (＠julliard) April 16, 2026

April 16, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10679

1 0