- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR8509: hid: Implement HidP_SetData.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

This has been merged as https://gitlab.winehq.org/wine/wine/-/merge_requests/9495, thank you! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8509#note_122743

1 0

[PATCH 0/3] MR9510: win32u: Implement timeline semaphore rewinding.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

Pretty much the same kind of thing Proton does, this is only for non-shared semaphores for now. This creates timeline events backed by host timeline semaphores, for every wait and signal operation on a client timeline semaphore. Events are host timeline semaphores with monotonically increasing values. One event is a `(host semaphore, value)` unique tuple, and their value is incremented every time they get signaled. They can be reused right away as a different event, with the new value. Signaled events are queued to a per-device event list for reuse, as we cannot safely destroy them [^1] and as creating them might be costly. A thread is spawned for every device that uses timeline semaphores, monitoring the events and semaphore value changes. The semaphore wrapper keeps the current client semaphore value, which is read directly by `vkGetSemaphoreCounterValue`. CPU and GPU waits on the client semaphore are swapped with a wait on a timeline event, and GPU signals with a signal on a timeline event. CPU signals simply update the client semaphore value on the wrapper, signaling the timeline thread to check and notify any waiter. The timeline thread waits on signal events, coming from the GPU, and on a per-device semaphore for CPU notifications (wait/signal list updates, CPU-side signal). It will then signal any pending wait for a client semaphore value that has been reached, and removes timed out waits. --- For shared semaphores my idea is to use the client timeline semaphore host handle itself as a signal to notify other device threads of semaphore value changes, as the host semaphore is what is exported and imported in other devices. The timeline threads would wait on that semaphore too in addition to the signal events and thread notification semaphore. The main issue with shared semaphores actually comes from sharing the client semaphore values, so that they can be read from each device timeline threads as well as from other processes. There's two scenarios to support, one that is for in-process sharing which could perhaps keep the information locally, but we also need to support cross-process sharing so I think there's no other way than to involve wineserver. My idea then is to move shared semaphore client value to wineserver, which will cost a request on every signal and wait (and reading the value for waits could later be moved to a shared memory object). This will also allow us to implement `D3DKMTWaitForSynchronizationObjectFromCpu` which might be useful for D3D12 fence implementation as it'll allow us to translate a timeline semaphore wait to an asynchronous NT event signal. [^1]: Vulkan spec indicates that semaphores may only be destroyed *after* every operation that uses them has fully executed, and it's unclear whether signaling or waiting a semaphore is enough as an indicator for full execution or whether we would need to wait on a submit fence. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9510

1 4

[PATCH 0/1] MR9509: win32u: Avoid crashing if Vulkan is disabled or failed to load.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9509

2 2

Re: [PATCH v3 0/4] MR9493: win32u: Move device and instance wrappers from winevulkan.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

On Tue Nov 18 08:06:53 2025 +0000, Rémi Bernon wrote: > Ah right thanks and sorry about that. It's not very surprising actually, > it probably crashes and breaks everything. https://gitlab.winehq.org/wine/wine/-/merge_requests/9509 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9493#note_122728

1 0

Re: [PATCH v3 0/4] MR9493: win32u: Move device and instance wrappers from winevulkan.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

On Tue Nov 18 08:06:53 2025 +0000, Martin Storsjö wrote: > This change (in particular, commit "win32u: Use the vulkan instance > wrappers for D3DKMT.") broke builds without Vulkan (e.g. > `--without-vulkan`). Starting up (in a clean prefix) prints: > ``` > 004c:err:vulkan:vulkan_init_once Wine was built without Vulkan support. > [5 minute wait] > 0024:err:environ:run_wineboot boot event wait timed out > wine: could not load kernel32.dll, status c0000135 > ``` > This looks highly surprising, but seems reproducible. I'll skip digging > further and leave it up to you to figure out why this gets broken. Ah right thanks and sorry about that. It's not very surprising actually, it probably crashes and breaks everything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9493#note_122724

1 0

[PATCH v4 0/1] MR9496: shlwapi: make StrFromTimeIntervalA and StrFromTimeIntervalW more like windows xp
by Alanas Tebuev (＠BZZZZ) Nov. 18, 2025

Nov. 18, 2025

<a href="https://mh-nexus.de/en/downloads.php?product=HxD20">hxd</a> <code>Analyzing...</code> dialog calls <code>StrFromTimeIntervalW</code> with <code>lpszStr</code>=0 to get length of <code> 30 sec</code> text and calls <code>StrFromTimeIntervalW</code> with non-0 <code>lpszStr</code> to get <code> 30 sec</code> text <img src="/uploads/6209a82d2aa063d355147034ceccc9ff/hxd.webp" alt="hxd "Analyzing..." dialog showing "Remaining time: 30 sec""> -- v4: shlwapi: make StrFromTimeIntervalA and StrFromTimeIntervalW more like windows xp https://gitlab.winehq.org/wine/wine/-/merge_requests/9496

2 1

Re: [PATCH v3 0/4] MR9493: win32u: Move device and instance wrappers from winevulkan.
by Martin Storsjö Nov. 18, 2025

Nov. 18, 2025

This change (in particular, commit "win32u: Use the vulkan instance wrappers for D3DKMT.") broke builds without Vulkan (e.g. `--without-vulkan`). Starting up (in a clean prefix) prints: ``` 004c:err:vulkan:vulkan_init_once Wine was built without Vulkan support. [5 minute wait] 0024:err:environ:run_wineboot boot event wait timed out wine: could not load kernel32.dll, status c0000135 ``` This looks highly surprising, but seems reproducible. I'll skip digging further and leave it up to you to figure out why this gets broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9493#note_122721

1 0

[PATCH 0/4] MR9508: winex11: Track more window state to avoid unnecessary requests.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

We don't track the corresponding property changes, because it seems like they sometimes are different from what was requested [^1], and that would defeat the purpose of this MR. This shouldn't matter and there's actually no reason for the properties to change as these are direct property change requests. [^1]: At least for me on XWayland, the differences seem mostly about x/y position hints, and they might come from XWayland quirks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9508

1 4

[PATCH v2 0/5] MR9506: dmsynth: DLS fixes, part 1
by Anton Baskanov (＠baskanov) Nov. 18, 2025

Nov. 18, 2025

-- v2: dmsynth: Use a factor of 1/10 for modulation LFO x channel pressure -> gain connections. dmsynth: Handle channel pressure events. dmsynth: Don't add 1000 to the sustain modulators. dmsynth: Use 0.1% as the sustain level unit. dmsynth/tests: Add DLS tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/9506

3 8

[PATCH 0/1] MR9507: winex11: Avoid unmapping window if it only got layered style.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

Layered window will need to be explicitly hidden, after layered style is added, and we shouldn't hide them ourselves as the style might just get removed right away. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58984 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9507

1 1

[PATCH v4 0/3] MR9427: combobox: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6.
by Paul Gofman (＠gofman) Nov. 18, 2025

Nov. 18, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58932 -- v4: user32/combo: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6. comctl32/combo: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6. comctl32/tests: Add tests for WM_MEASUREITEM with combobox. https://gitlab.winehq.org/wine/wine/-/merge_requests/9427

3 5

[PATCH 0/5] MR9506: dmsynth: DLS fixes, part 1
by Anton Baskanov (＠baskanov) Nov. 18, 2025

Nov. 18, 2025

It's already added by the generators. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9506

2 5

[PATCH 0/4] MR9441: quartz/dsoundrender: A few bits around EOS handling.
by Paul Gofman (＠gofman) Nov. 18, 2025

Nov. 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9441

3 12

[PATCH v3 0/4] MR9427: combobox: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6.
by Paul Gofman (＠gofman) Nov. 18, 2025

Nov. 18, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58932 -- v3: user32/combo: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6. comctl32/tests: Add tests for WM_MEASUREITEM with combobox v5. https://gitlab.winehq.org/wine/wine/-/merge_requests/9427

3 8

Re: [PATCH v2 0/6] MR9488: comctl32/trackbar: Add a helper to get the pen color for drawing tics.
by Zhiyi Zhang (＠zhiyi) Nov. 18, 2025

Nov. 18, 2025

On Tue Nov 18 01:52:50 2025 +0000, Nikolay Sivov wrote: > Regarding TreeView, I don't see any difference in +/- symbols between v5 > and v6, with or without this MR. Are we missing something in the theme? No. It's because light.msstyles uses similar shapes for the plus and minus signs. I didn't bother designing a different shape for light.msstyles. If you use, for example, luna.msstyles from XP. You can see the difference. ![Screenshot_From_2025-11-18_09-51-50](/uploads/75bac893bbf6c37ed46bb63f68d84241/Screenshot_From_2025-11-18_09-51-50.png) ![Screenshot_From_2025-11-18_09-47-45](/uploads/d970e281476f3e6aaa1db0fcbf1ab560/Screenshot_From_2025-11-18_09-47-45.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9488#note_122676

1 0

[PATCH 0/1] MR9502: ntoskrnl.exe: Open thread with MAXIMUM_ALLOWED access in KeGetCurrentThread().
by Paul Gofman (＠gofman) Nov. 17, 2025

Nov. 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9502

2 2

[PATCH v3 0/1] MR9496: shlwapi: make StrFromTimeIntervalA and StrFromTimeIntervalW more like windows xp
by Alanas Tebuev (＠BZZZZ) Nov. 17, 2025

Nov. 17, 2025

<a href="https://mh-nexus.de/en/downloads.php?product=HxD20">hxd</a> <code>Analyzing...</code> dialog calls <code>StrFromTimeIntervalW</code> with <code>lpszStr</code>=0 to get length of <code> 30 sec</code> text and calls <code>StrFromTimeIntervalW</code> with non-0 <code>lpszStr</code> to get <code> 30 sec</code> text <img src="/uploads/6209a82d2aa063d355147034ceccc9ff/hxd.webp" alt="hxd "Analyzing..." dialog showing "Remaining time: 30 sec""> -- v3: shlwapi: make StrFromTimeIntervalA and StrFromTimeIntervalW more like windows xp https://gitlab.winehq.org/wine/wine/-/merge_requests/9496

2 1

[PATCH 0/1] MR4078: dmime/tests: Mark 3 PMsg tests as flaky
by Michael Stefaniuc (＠mstefani) Nov. 17, 2025

Nov. 17, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55637 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4078

4 9

Re: [PATCH v2 0/2] MR9501: msxml3: Add normalize-line-breaks sax feature.
by Vijay Kiran Kamuju (＠infyquest) Nov. 17, 2025

Nov. 17, 2025

On Mon Nov 17 22:39:12 2025 +0000, Nikolay Sivov wrote: > This is not implementing actual normalization. I don't think we want to > ignore that. Ok, I will move it below for the putFeature, so that we will print as stub for that feature so its not ignored. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9501#note_122664

1 0

Re: [PATCH v2 0/2] MR9501: msxml3: Add normalize-line-breaks sax feature.
by Nikolay Sivov (＠nsivov) Nov. 17, 2025

Nov. 17, 2025

This is not implementing actual normalization. I don't think we want to ignore that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9501#note_122663

1 0

Re: [PATCH v3 0/3] MR9446: dmsynth: Fix instrument selection - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2025

Nov. 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9446

1 0

Re: [PATCH v3 0/6] MR9499: msado15: Set cursor position on provider side. - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2025

Nov. 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9499

1 0

Re: [PATCH v2 0/6] MR9488: comctl32/trackbar: Add a helper to get the pen color for drawing tics. - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2025

Nov. 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9488

1 0

Re: [PATCH v2 0/3] MR9490: comctl32/toolbar: Erase the background in TOOLBAR_Refresh() when... - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2025

Nov. 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9490

1 0

Re: [PATCH v2 0/1] MR9497: win32u: Avoid INT_MAX overflow in map_monitor_rect. - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2025

Nov. 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9497

1 0