- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/3] MR8834: server: Use process_vm_writev / process_vm_readv instead of ptrace when available.
by Rémi Bernon Nov. 5, 2025

Nov. 5, 2025

On Wed Nov 5 20:54:11 2025 +0000, Rémi Bernon wrote: > 295bd9bdcbda8e96cbfb51ec2861c340f4ed0db1 causes a wineserver crash on > macOS when running the kernel32:debugger tests. ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x300000000) frame #0: 0x000000010001c44c wineserver`write_process_memory(process=0x00007f8f67f17410, ptr=10880000, size=1, src=<unavailable>, written=0x0000000300000000) at mach.c:542:50 [opt] 539 out: 540 free( (void *)data ); 541 mach_set_error( ret ); -> 542 if (ret == KERN_SUCCESS && written) *written = size; 543 return (ret == KERN_SUCCESS); 544 } 545 warning: wineserver was compiled with optimization - stepping may behave oddly; variables may not be available. (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x300000000) * frame #0: 0x000000010001c44c wineserver`write_process_memory(process=0x00007f8f67f17410, ptr=10880000, size=1, src=<unavailable>, written=0x0000000300000000) at mach.c:542:50 [opt] frame #1: 0x000000010002840e wineserver`req_write_process_memory(req=0x00007f8f77f04ec8, reply=<unavailable>) at process.c:1800:18 [opt] frame #2: 0x000000010003bda1 wineserver`call_req_handler(thread=0x00007f8f77f04d50) at request.c:305:9 [opt] frame #3: 0x000000010003bc21 wineserver`read_request(thread=0x00007f8f77f04d50) at request.c:360:13 [opt] frame #4: 0x000000010004a827 wineserver`thread_poll_event(fd=<unavailable>, event=1) at thread.c:596:30 [opt] frame #5: 0x0000000100011be4 wineserver`main_loop [inlined] fd_poll_event(fd=<unavailable>, event=<unavailable>) at fd.c:510:5 [opt] frame #6: 0x0000000100011bdd wineserver`main_loop [inlined] main_loop_epoll at fd.c:722:39 [opt] frame #7: 0x0000000100011a09 wineserver`main_loop at fd.c:972:5 [opt] frame #8: 0x000000010001d402 wineserver`main(argc=<unavailable>, argv=<unavailable>) at main.c:269:5 [opt] frame #9: 0x0000000200102345 dyld`start + 1909 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8834#note_120930

1 0

Re: [PATCH v5 0/3] MR8834: server: Use process_vm_writev / process_vm_readv instead of ptrace when available.
by Rémi Bernon Nov. 5, 2025

Nov. 5, 2025

295bd9bdcbda8e96cbfb51ec2861c340f4ed0db1 causes a wineserver crash on macOS when running the kernel32:debugger tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8834#note_120929

1 0

[PATCH v4 0/1] MR9375: opengl32: Avoid null pointer dereferences when filtering extensions.
by Tim Clem (＠tclem) Nov. 5, 2025

Nov. 5, 2025

Fixes: 2127e9ae7d90466f3b8883708799047214409832 --- Fixes a crash on macOS. Perhaps the extensions string regularly has a trailing space on other platforms? The previous filter_extensions_list method set `end` differently and avoided this case. -- v4: opengl32: Avoid null pointer dereferences when filtering extensions. https://gitlab.winehq.org/wine/wine/-/merge_requests/9375

4 4

[PATCH 0/3] MR9377: wineandroid, winemac, winex11: Fix ProcessEvents drained return value.
by Rémi Bernon Nov. 5, 2025

Nov. 5, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58915 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9377

1 3

[PATCH v19 0/17] MR7111: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) Nov. 5, 2025

Nov. 5, 2025

relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v19: ntoskrnl: move i386 specific Rtl*ByteSwap() into separate source. ntoskrnl: move _chkstk() / __chkstk() into separate source. msvcrt: move i386 specific _ftol() into separate source. kernel32: move x86-64 specific GetProcAddress() into separate source. kernel32: move i386 specific Interlocked*() into separate source. kernel32: move i386 specific ExitProcess() into separate source. kernelbase: move x86-64 specific GetProcAddress() into separate source. ntdll: move i386 specific Rtl*ByteSwap() into separate source. tools: add LTO quirks. makedep: support skipping/disabling LTO. configure: enable building Wine with LTO. makedep: support LTO builds. winegcc: support LTO builds. winebuild: support LTO builds. tools: helper functions for LTO builds. ntdll: add attribute "used" to a few symbols that should not be discarded. loader: add attribute "used" to a few symbols that should not be discarded. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

1 1

[PATCH v3 0/1] MR9375: opengl32: Avoid null pointer dereferences when filtering extensions.
by Tim Clem (＠tclem) Nov. 5, 2025

Nov. 5, 2025

Fixes: 2127e9ae7d90466f3b8883708799047214409832 --- Fixes a crash on macOS. Perhaps the extensions string regularly has a trailing space on other platforms? The previous filter_extensions_list method set `end` differently and avoided this case. -- v3: opengl32: Avoid null pointer dereferences when filtering extensions. https://gitlab.winehq.org/wine/wine/-/merge_requests/9375

2 2

[PATCH 0/1] MR9372: winemac.drv: Explicitly add an ivar for contentViewMaskLayer.
by Tim Clem (＠tclem) Nov. 5, 2025

Nov. 5, 2025

Required for @synthesize when building with older compilers. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58916 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9372

2 1

Re: [PATCH v2 0/2] MR9369: wininet: Return correct errors and put handle into invalid state when seeking beyond end of file.
by Jacek Caban (＠jacek) Nov. 5, 2025

Nov. 5, 2025

Jacek Caban (@jacek) commented about dlls/wininet/tests/http.c: > > init_events(); > init_status_tests(); > +#if 1 A leftover? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9369#note_120865

1 0

Re: [PATCH v2 0/2] MR9369: wininet: Return correct errors and put handle into invalid state when seeking beyond end of file.
by Jacek Caban (＠jacek) Nov. 5, 2025

Nov. 5, 2025

Jacek Caban (@jacek) commented about dlls/wininet/http.c: > return GetLastError(); > if (!ReadFile(req->req_file->file_handle, buffer, size, &ret_read, NULL)) > return GetLastError(); > + } else if (req->content_pos > req->cache_size) { > + req->invalid_state = TRUE; Do we need a separate mechanism for that? Could we use `hdr->dwError` for this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9369#note_120864

1 0

[PATCH v3 0/5] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Nov. 5, 2025

Nov. 5, 2025

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v3: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 6

[PATCH v2 0/5] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Nov. 5, 2025

Nov. 5, 2025

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v2: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolheap32Snapshot if possible. kernel32: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 6

[PATCH 0/5] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Nov. 5, 2025

Nov. 5, 2025

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 6

[PATCH 0/4] MR9370: msado15: Improvements for Recordset::AddNew and get_RecordCount functions.
by Piotr Caban (＠piotr) Nov. 5, 2025

Nov. 5, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9370

2 4

[PATCH v2 0/2] MR9299: ole32, combase: Add tests for COM context switching and delayed marshaling.
by Vibhav Pant (＠vibhavp) Nov. 5, 2025

Nov. 5, 2025

When `RoGetAgileReference` is used with `AGILEREFERENCE_DELAYEDMARSHAL`, the returned `IAgileReference` also contains a reference to the apartment the object belongs to. Thus, when `IAgileReference::Resolve()` gets called, the object will get marshaled inside the owning apartment, not the caller's apartment. This seems to be made possible by the `IContextCallback` interface. It provides a way to (ab)use the marshaller to execute arbitrary code inside a COM context, which is an additional bit of state nested inside apartments. An apartment can contain multiple COM contexts, and the standard marshaller will keep track of which context a marshaled interface is bound to. All method calls through that marshalled pointer will be wrapped around a context-switch, even when the caller is in the same apartment. Additionally, creating an instance of the class `CLSID_IContextCallback` allows us to create new contexts inside an apartment. C++/WinRT makes use of `IContextCallback` to [implement support for C++ coroutines ](https://github.com/microsoft/cppwinrt/blob/ebace4abb8f48b6b9a612e8b84667e6044976a47/strings/base_coroutine_threadpool.h#L51)(co_await, et al) inside application STA code. Another use of COM contexts seems to be the UI code in WinRT applications, where certain objects can only be `Released`/destructed from the apartment they were created in. (I was able to find another instance of `IContextCallback` usage in the wild [here](https://github.com/Open-Shell/Open-Shell-Menu/blob/4ebeadd949d0550642…, to get an `IAccessible` implementation that has apartment-affinity). -- v2: ole32/tests: Add tests for IContextCallback::ContextCallback and CoDisconnectContext. combase/tests: Add tests for delayed marshaling of objects with apartment affinity. https://gitlab.winehq.org/wine/wine/-/merge_requests/9299

2 2

[PATCH v3 0/6] MR9275: jscript: Semi-implement Typed Arrays.
by Gabriel Ivăncescu Nov. 5, 2025

Nov. 5, 2025

-- v3: jscript: Implement 'set' for Typed Arrays. jscript: Implement 'subarray' for Typed Arrays. jscript: Implement Typed Array construction from objects. jscript: Implement ArrayBuffer.isView. jscript: Implement Typed Array construction on ArrayBuffers. jscript: Add initial implementation of Typed Arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/9275

2 16

[PATCH v2 0/1] MR7897: kernel32/tests: Skip FreeConsole test at Windows 7.
by Bernhard Übelacker Nov. 5, 2025

Nov. 5, 2025

Followup of 13c77bc9e6. [Test pattern page](https://test.winehq.org/data/patterns.html#kernel32:console) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158074) -- v2: kernel32/tests: Skip FreeConsole test at Windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7897

3 7

[PATCH v2 0/1] MR9362: opengl32: Simplify extension tokenization.
by Rémi Bernon Nov. 5, 2025

Nov. 5, 2025

This was requested in !9263 review, but ignored for some reason. -- v2: opengl32: Simplify extension tokenization. https://gitlab.winehq.org/wine/wine/-/merge_requests/9362

1 2

[PATCH 0/1] MR9367: winhttp/tests: Always use secure connection to ws.ifelse.io in websocket tests.
by Paul Gofman (＠gofman) Nov. 5, 2025

Nov. 5, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9367

3 3

[PATCH v2 0/1] MR9067: windows.storage: Redirect SHGetKnownFolderPath() to shell32.
by Andrey Gusev (＠agusev) Nov. 5, 2025

Nov. 5, 2025

Fixes a crash with GamingRepair for Senua's Saga: Hellblade II. -- v2: windows.storage: Redirect SHGetKnownFolderPath() to shell32. https://gitlab.winehq.org/wine/wine/-/merge_requests/9067

3 3

[PATCH v18 0/9] MR7111: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) Nov. 5, 2025

Nov. 5, 2025

relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v18: tools: add LTO quirks makedep: support skipping/disabling LTO configure: enable building Wine with LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds ntdll: add attribute "used" to a few symbols that shouldn't be discarded loader: add attribute "used" to a few symbols that shouldn't be discarded https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

2 9

[PATCH 0/1] MR9362: opengl32: Simplify extension tokenization.
by Rémi Bernon Nov. 5, 2025

Nov. 5, 2025

This was requested in !9263 review, but ignored for some reason. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9362

2 3

[PATCH v17 0/9] MR7111: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) Nov. 5, 2025

Nov. 5, 2025

relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v17: tools: add LTO quirks makedep: support skipping/disabling LTO configure: enable building Wine with LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds ntdll: add attribute "used" to a few symbols that shouldn't be discarded loader: add attribute "used" to a few symbols that shouldn't be discarded https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

2 9

Re: [PATCH v4 0/4] MR9296: dmsynth, dmusic: Reduce memory usage part 1 - approved
by Alexandre Julliard (＠julliard) Nov. 4, 2025

Nov. 4, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9296

1 0

Re: [PATCH v3 0/1] MR9328: dlls/sane.ds: Make comboboxes in property sheet high enough to properly drop down - approved
by Alexandre Julliard (＠julliard) Nov. 4, 2025

Nov. 4, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9328

1 0

Re: [PATCH v4 0/1] MR9347: windowscodecs: Fix off-by-one check in IcoDecoder_GetFrame. - approved
by Alexandre Julliard (＠julliard) Nov. 4, 2025

Nov. 4, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9347

1 0