- Wine-GitLab - list.winehq.org

[PATCH v4 0/2] MR9217: dlls/twain_32: Fix segfault when application unloads and reloads twain_32.dll
by Bernd Herd (＠herdsoft) Oct. 30, 2025

Oct. 30, 2025

# Fault secnario If an application loads twain_32.dll for every scan and unloads it when done with scanning, it very likely crashes when the user chooses to scan a second time within the same process. Unloading twain_32.dll is not uncommon behaviour. # Internal error cause When sane.ds gets loaded the first time, it retrieves the address of the DSM_Entry function from twain_32.dll and stores it in a variable SANE_dsmentry in the sane.ds global data. When the DS gets closed, the sane.ds does not get unloaded due to an old workaround in dlls/twain_32/dsm_ctrl.c:275: ``` twRC = currentDS->dsEntry (pOrigin, DG_CONTROL, DAT_IDENTITY, MSG_CLOSEDS, pData); /* This causes crashes due to still open Windows, so leave out for now. * FreeLibrary (currentDS->hmod); */ ``` When the application program closes the DSM (twain_32.dll) and reloads it, there is a hight probability that it will be loaded in a different memory location. So the exported DSM_Entry function is located at a different address. But the code in dlls/sane.ds/sane_main.c:60 does not update the pointer if SANE_dsmentry is not NULL: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); ``` So SANE_dsmentry still points to where the twain_32.dll was loaded the first time it loaded the sane.ds. Which is now an invalid address. When later the DS wants to notify the application of an event (DS Closed, Image transfered..) it calls SANE_Notify in sane_main.c:357: ``` void SANE_Notify (TW_UINT16 message) { SANE_dsmentry (&activeDS.identity, &activeDS.appIdentity, DG_CONTROL, DAT_NULL, message, NULL); } ``` And here the crash occurs due to the invalid pointer in variable SANE_dsmentry. # Suggested Solution There are many ways how this problem could be solved. The solution suggested here is based on an extension of the TWAIN protocol in Version 2: The DSM transfers the entry points to it's callback functions in a message: DG_CONTROL / DAT_ENTRYPOINT / MSG_SET That message was already implemented in sane.ds and gphoto2.gs. And both also set the flag DF_DS2 in the identitiy information SupportedGroups, so the DSM knows it is allowed to send that message. So this approach is not a workaround, but an additional feature that solves the problem in the way intended according to the TWAIN specification. This also means that the patch should solve the problem in closed source TWAIN drivers a user might install. However [sane.d](http://sane.de)s and gphoto2.ds do not fill the TW_IDENTITY information in the response to the DAT_IDENTITIY / MSG_OPENDS message. This is different from the behaviour observed on windows. For that reason the DF_DS2 flag in SupportedGroups is also not set, and thus a change in sane.ds is neccessary to make the DAT_ENTRYPOINT solution work. This is also not just a workaround but a change of the behaviour so it becomes closer to what is observed on windows. # Test scenario software I've written a small 163 lines C application program to reproduce the erroneous behaviour. It is called unloaddsm.c and I'll attach it to this merge request. It is meant to be cross-compiled with mingw-w64. It loads the DSM, opens the DS (withour showing the UI), closes the DS, unloads DSM, re-loads DSM, re-opens the DS and then displays the UI (User Interface) when the user then clicks "cancel" or presses escape, this causes the call of SANE_Notify that leads to the crash. It also shows the TW_IDENTITY fields that sane.ds did not fill. I ran the same program with a 32-Bit windows TWAIN driver on Windows 10 and there the idendity fields were filled. With the patch applied, the error does not occur any more in sane.ds. ``` Archive: /tmp/unloaddsm.zip Length Date Time Name 5283 2025-10-18 23:31 unloaddsm.c 77104 2025-10-16 14:02 twain.h 161 2025-10-18 15:57 Makefile ``` -- v4: dlls/sane.ds: when opening a DS, return the identitity information of the opened device to the caller. Matches windows behaviour and neccessary for the change in dsm_ctrl.c to work dlls/twain_32: Avoid crash when application unloads twain32_dll and reloads it for a second scan by implementing TWAIN feature DG_CONTROL / DAT_ENTRYPOINT / MSG_SET https://gitlab.winehq.org/wine/wine/-/merge_requests/9217

4 4

[PATCH v3 0/6] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().
by Marc-Aurel Zent (＠mzent) Oct. 30, 2025

Oct. 30, 2025

Some applications rely on this behavior. -- v3: kernel32/tests: Add more tests for waits on pseudo-handles. include: Add more NT pseudo-handle definitions. ntdll: Reject pseudo-handles in NtWaitForMultipleObjects. ntdll: Reimplement NtWaitForSingleObject without NtWaitForMultipleObjects. kernelbase: Reimplement WaitForSingleObject[Ex] on top of NtWaitForSingleObject. kernelbase: Add set_ntwaitstatus() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/9305

3 23

[PATCH v2 0/6] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().
by Marc-Aurel Zent (＠mzent) Oct. 30, 2025

Oct. 30, 2025

Some applications rely on this behavior. -- v2: kernel32/tests: Add more tests for waits on pseudo-handles. include: Add more NT pseudo-handle definitions. ntdll: Reject pseudo-handles in NtWaitForMultipleObjects. ntdll: Reimplement NtWaitForSingleObject without NtWaitForMultipleObjects. kernelbase: Reimplement WaitForSingleObject[Ex] on top of NtWaitForSingleObject. kernelbase: Add set_ntwaitstatus() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/9305

2 6

[PATCH 0/1] MR8800: mfreadwrite/tests: Fix test failures with Windows 7.
by Bernhard Übelacker Oct. 30, 2025

Oct. 30, 2025

[Test pattern page](https://test.winehq.org/data/patterns.html#mfreadwrite:mfplat) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=159453) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8800

3 6

Re: [PATCH v4 0/1] MR9303: ntdll/tests: Add NtRenameKey tests checking subkey after rename. - approved
by zhengyong chen (＠chenzhengyong) Oct. 30, 2025

Oct. 30, 2025

This merge request was approved by zhengyong chen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9303

1 0

[PATCH 0/2] MR9317: msxml3: Update to IXMLDocument2.
by Nikolay Sivov (＠nsivov) Oct. 30, 2025

Oct. 30, 2025

Even though IXMLDocument2 does not inherit from IXMLDocument, it extends it in practice. Return automation type info also points to IID_IXMLDocument2. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9317

2 2

[PATCH v12 0/2] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) Oct. 30, 2025

Oct. 30, 2025

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v12: ntdll: Try isolate wineserver directory. server: check directory access permissions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

2 3

[PATCH 0/3] MR9316: d2d1/tests: Add some property tests for the Gaussian Blur effect.
by Nikolay Sivov (＠nsivov) Oct. 30, 2025

Oct. 30, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9316

2 3

[PATCH v9 0/2] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) Oct. 30, 2025

Oct. 30, 2025

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v9: ntdll: Try isolate wineserver directory. server: check directory access permissions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 4

[PATCH 0/1] MR9309: reg: Make sure empty is big enough.
by Yuxuan Shui (＠yshui) Oct. 30, 2025

Oct. 30, 2025

We access data[1], so empty needs to have a size of 2. Found by ASan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9309

3 2

[PATCH 0/7] MR9315: comctl32/ipaddress: Add a helper to get the theme text state.
by Zhiyi Zhang (＠zhiyi) Oct. 30, 2025

Oct. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9315

3 12

[PATCH v4 0/4] MR9263: opengl32: Unify and simplify context extensions handling.
by Jacek Caban (＠jacek) Oct. 30, 2025

Oct. 30, 2025

-- v4: opengl32: Use stored extensions in filter_extensions. opengl32: Use stored extension list in is_extension_supported. opengl32: Compute supported extensions in make_context_current. https://gitlab.winehq.org/wine/wine/-/merge_requests/9263

2 6

[PATCH v2 0/13] MR9314: Draft: mf/session: Shut down all topologies on session shutdown.
by Conor McCarthy (＠cmccarthy) Oct. 30, 2025

Oct. 30, 2025

Goes atop !9294 -- v2: mf/session: Shut down all topologies on session shutdown. mf/session: Ensure the session object is shut down on release. mf/tests: Add tests for sample grabber sink shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/9314

2 13

[PATCH 0/13] MR9314: Draft: mf/session: Shut down all topologies on session shutdown.
by Conor McCarthy (＠cmccarthy) Oct. 30, 2025

Oct. 30, 2025

Goes atop !9294 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9314

2 13

[PATCH 0/2] MR9312: d2d1: Add support for using IWICBitmapLock with CreateSharedBitmap()
by Jason Wendt (＠jason.wendt) Oct. 29, 2025

Oct. 29, 2025

I found this deficiency while trying to run Paint.NET v4.0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9312

3 6

[PATCH v5 0/1] MR8992: mountmgr.sys: Do not create empty registry nodes for serial or parallel devices.
by Janne Kekkonen (＠Janne) Oct. 29, 2025

Oct. 29, 2025

Empty registry node for parallel devices will cause Realterm to crash. Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598 -- v5: mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

3 4

Re: [PATCH v9 0/1] MR4878: advpack: Ignore lines that begin with '@' in (Un)RegisterOCXs sections. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4878

1 0

Re: [PATCH v5 0/1] MR8858: sane.ds: Adding saving scanner settings to the registry - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8858

1 0

Re: [PATCH v2 0/2] MR9214: dlls/gphoto2.ds: Fix bug. Return the DIB as a GlobalAlloc handle according to TWAIN spec instead of a HBITMAP - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9214

1 0

Re: [PATCH v2 0/6] MR9290: comctl32/header: Add a helper to check if theme is enabled. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9290

1 0

Re: [PATCH v5 0/6] MR9032: opengl32: Support wow64 buffer storage and persistent memory mapping using Vulkan. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9032

1 0

Re: [PATCH v4 0/2] MR9306: msvcrt: Use the correct arguments when a WinRT exception is thrown with _CxxThrowException. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9306

1 0

Re: [PATCH v2 0/1] MR9308: dbghelp: {dwarf} Keep .eh_frame mapped when no CU are present. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9308

1 0

[PATCH 0/3] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().
by Marc-Aurel Zent (＠mzent) Oct. 29, 2025

Oct. 29, 2025

Some applications rely on this behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9305

4 20

Re: [PATCH v3 0/7] MR9302: msxml3/tests: Add some SAX tests for PI nodes. - approved
by Alexandre Julliard (＠julliard) Oct. 29, 2025

Oct. 29, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9302

1 0