- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR9141: include: Pass a PROCESS_INFORMATION to winetest_wait_child_process().
by Elizabeth Figura (＠zfigura) Oct. 20, 2025

Oct. 20, 2025

-- v3: include: Pass a PROCESS_INFORMATION to winetest_wait_child_process(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9141

2 3

Re: [PATCH v2 0/1] MR9233: user32: Move GetWindowDisplayAffinity() stub to win32u. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9233

1 0

Re: [PATCH v2 0/1] MR9232: include: Implement C_ASSERT() using the C23 static_assert() if available. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9232

1 0

Re: [PATCH v2 0/1] MR9231: winemac.drv: Include Carbon.h in macdrv_cocoa.h and remove duplicate definitions. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9231

1 0

Re: [PATCH v3 0/1] MR9230: win32u: Use floats for map_monitor_rect computation. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9230

1 0

Re: [PATCH v4 0/1] MR9204: winewayland: Pass through mouse events for transparent, layered windows. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9204

1 0

Re: [PATCH v2 0/1] MR9219: uxtheme: Add stub for GetThemeStream. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9219

1 0

Re: [PATCH v5 0/1] MR9220: bcrypt: key_export_ecc_public - Add missing break - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9220

1 0

Re: [PATCH v3 0/1] MR9228: opengl32: Update to the current OpenGL spec. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9228

1 0

Re: [PATCH v3 0/1] MR9229: gitlab: Update to llvm-mingw 20251007. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9229

1 0

Re: [PATCH v2 0/3] MR9227: user32/tests: Add more tests for PackDDElParam/UnpackDDElParam(WM_DDE_ACK). - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9227

1 0

Re: [PATCH v2 0/1] MR9223: wine.inf: Create [fonts] section in win.ini for 16-bit apps. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9223

1 0

Re: [PATCH v2 0/1] MR9226: win32u: Reset internal pixel format when pixel format is set. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9226

1 0

Re: [PATCH v2 0/2] MR9225: opengl32: Implement front buffer rendering emulation. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9225

1 0

Re: [PATCH v3 0/3] MR9224: win32u: Restore queue masks after processing driver events. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9224

1 0

Re: [PATCH v2 0/2] MR9213: d2d1/tests: Add some tests for resulting format of the WIC target. - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9213

1 0

Re: [PATCH v2 0/4] MR9216: oleaut32/tests: Enable more tests for VarAdd(). - approved
by Alexandre Julliard (＠julliard) Oct. 20, 2025

Oct. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9216

1 0

[PATCH v3 0/7] MR9136: mshtml: Use a common object implementation for collection enumerators.
by Gabriel Ivăncescu Oct. 20, 2025

Oct. 20, 2025

-- v3: mshtml: Use the common object implementation for HTMLAttributeCollection mshtml: Use the common object implementation for HTMLStyleSheetsCollection mshtml: Use the common object implementation for HTMLRectCollection mshtml: Use the common object implementation for HTMLSelectElement enumerator. mshtml: Use the common object implementation for HTMLFormElement enumerator. mshtml: Use the common object implementation for HTMLDOMChildrenCollection mshtml: Use a common object implementation for HTMLElementCollection https://gitlab.winehq.org/wine/wine/-/merge_requests/9136

2 10

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Elizabeth Figura (＠zfigura) Oct. 20, 2025

Oct. 20, 2025

> Hmm... If the cache update is outside of the lock, more than one thread might have retrieved the sync and try to update the cache concurrently. > > I think in the current state this will break as multiple thread may pass the `if (InterlockedCompareExchange( &cache->refcount, 0, 0 ))` check successfully. Oh duh, I can't read. I'll adjust this patch to get rid of the atomic cmpxchg mapping cache memory as we indeed don't need it anymore with the lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119104

1 0

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Rémi Bernon Oct. 20, 2025

Oct. 20, 2025

On Mon Oct 20 21:11:35 2025 +0000, Rémi Bernon wrote: > Hmm... If the cache update is outside of the lock, more than one thread > might have retrieved the sync and try to update the cache concurrently. > I think in the current state this will break as multiple thread may pass > the `if (InterlockedCompareExchange( &cache->refcount, 0, 0 ))` check successfully. With a separate lock, we still have to only allow one of the thread to cache its sync, and let the others on the stack. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119102

1 0

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Rémi Bernon Oct. 20, 2025

Oct. 20, 2025

On Mon Oct 20 21:05:58 2025 +0000, Elizabeth Figura wrote: > > Nvm, I guess the entire sync retrieval and caching needs to be atomic. > Does it? I'm not sure I see how; I think you're right that the mmap > doesn't need to be in the lock. I don't know that it's really important, > given how rare it'll be in practice, but theoretically it could be > outside the lock. Hmm... If the cache update is outside of the lock, more than one thread might have retrieved the sync and try to update the cache concurrently. I think in the current state this will break as multiple thread may pass the `if (InterlockedCompareExchange( &cache->refcount, 0, 0 ))` check successfully. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119101

1 0

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Elizabeth Figura (＠zfigura) Oct. 20, 2025

Oct. 20, 2025

> Nvm, I guess the entire sync retrieval and caching needs to be atomic. Does it? I'm not sure I see how; I think you're right that the mmap doesn't need to be in the lock. I don't know that it's really important, given how rare it'll be in practice, but theoretically it could be outside the lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119099

1 0

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Rémi Bernon Oct. 20, 2025

Oct. 20, 2025

On Mon Oct 20 20:56:40 2025 +0000, Rémi Bernon wrote: > Sorry to have missed that. > Fwiw I think the lock (and probably a different one, there's no need to > lock the fd cache) should be taken again within `cache_inproc_sync` but > only for the things where it's actually necessary. > It does rather costly calls, like `mmap` and there's things like > `InterlockedCompareExchangePointer` in it which are rather pointless otherwise. Nvm, I guess the entire sync retrieval and caching needs to be atomic. Anyway, still I think the compare exchange looks confusing if it always happens inside a lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119098

1 0

[PATCH 0/1] MR9235: Draft: winex11: Retrieve XIM result as UTF8.
by Bernhard Kölbl Oct. 20, 2025

Oct. 20, 2025

The goal here is to make XIM input locale independent, so changing LC_MESSAGES and LC_CTYPE (to change code pages on PE side) can be done without breaking the IME, when set locale isn't set up on the host system. To achieve this, I switched XmbLookupString to Xutf8LookupString, because it *seems* to achieve what I wrote above. Marked as draft because idk if this makes sense at all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9235

2 2

Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.
by Rémi Bernon Oct. 20, 2025

Oct. 20, 2025

Sorry to have missed that. Fwiw I think the lock (and probably a different one, there's no need to lock the fd cache) should be taken again within `cache_inproc_sync` but only for the things where it's actually necessary. It does rather costly calls, like `mmap` and there's things like `InterlockedCompareExchangePointer` in it which are rather pointless otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119096

1 0