- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Alexandre Julliard (＠julliard) Oct. 17, 2025

Oct. 17, 2025

Superseded by 40807ae73c3c8d424a4ae722042a4ce614d44a45. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_118860

1 0

[PATCH v13 0/2] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) Oct. 17, 2025

Oct. 17, 2025

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v13: mf/tests: Test H.264 decoder alignment. mf/tests: Test H.264 sink media type height alignment. https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

3 4

Re: [PATCH v26 0/1] MR6919: bcp47langs: Add tests for GetUserLanguages.
by Nikolay Sivov (＠nsivov) Oct. 17, 2025

Oct. 17, 2025

On Fri Oct 17 07:58:52 2025 +0000, Nikolay Sivov wrote: > Out pointer "usrlangs" is uninitialized because function is a stub on > Wine, so it looks related. This works for me. [test.diff](/uploads/c704f7f89ed8c3112525a781dd732f6e/test.diff) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6919#note_118855

1 0

[PATCH 0/3] MR9197: comctl32/tests: Move toolbar Unicode format tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9197

3 5

Re: [PATCH v26 0/1] MR6919: bcp47langs: Add tests for GetUserLanguages.
by Nikolay Sivov (＠nsivov) Oct. 17, 2025

Oct. 17, 2025

On Fri Oct 17 07:53:56 2025 +0000, Vijay Kiran Kamuju wrote: > The test failures are unrelated to this change. I will try to check them. Out pointer "usrlangs" is uninitialized because function is a stub on Wine, so it looks related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6919#note_118851

1 0

Re: [PATCH v26 0/1] MR6919: bcp47langs: Add tests for GetUserLanguages.
by Vijay Kiran Kamuju (＠infyquest) Oct. 17, 2025

Oct. 17, 2025

On Fri Oct 17 07:53:56 2025 +0000, Rémi Bernon wrote: > Fwiw the tests are crashing on multiple Linux VMs: https://test.winehq.org/data/patterns.html#bcp47langs:bcp47langs The test failures are unrelated to this change. I will try to check them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6919#note_118850

1 0

Re: [PATCH v2 0/2] MR9162: shell32: Set SFGAO_HASSUBFOLDER correctly for normal shellfolders.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

Fwiw the tests seem to fail on Windows now: https://test.winehq.org/data/patterns.html#shell32:shlfolder -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9162#note_118848

1 0

Re: [PATCH v26 0/1] MR6919: bcp47langs: Add tests for GetUserLanguages.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

Fwiw the tests are crashing on multiple Linux VMs: https://test.winehq.org/data/patterns.html#bcp47langs:bcp47langs -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6919#note_118847

1 0

[PATCH 0/1] MR9196: win32u: Set the process idle event from the client side.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

This should fix winemenubuilder timing out on startup with ntsync. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9196

2 2

[PATCH 0/1] MR9198: server: Target the default or foreground window for internal hardware messages.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

Fixes: 25d80f327d81c901dc8b0d7923a24809d8426799 The default window should be set, but the logic was ignoring it for unknown hardware message bits. Using the foreground window as a fallback could be useful for cursor clipping, like it was before with QS_RAWINPUT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9198

1 1

[PATCH v4 0/1] MR8977: winex11: Use EGL by default for OpenGL rendering.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

When we were able to load it at least. EGL has some advantages, like not requiring a specific pixel format on the windows, it will share most of its problems with winewayland (and wineandroid although we may also assume GL doesn't work anymore there at this point) so anything fixed with it could benefit all. It will also be required for shared resources and compositing when Vulkan is unavailable. This might be a bit early still, I'm not sure it is on par when it comes to child window rendering synchronization. However this doesn't drop GLX either, and instead just changes the default. I think it would be useful to switch early though, at least to have more time to settle (and eventually decide to switch back during code freeze if it proves a bad idea). -- v4: winex11: Use EGL by default for OpenGL rendering. https://gitlab.winehq.org/wine/wine/-/merge_requests/8977

1 2

[PATCH 0/4] MR9195: win32u: Import and export semaphore and fences fds.
by Rémi Bernon Oct. 17, 2025

Oct. 17, 2025

Except for keyed mutexes which will be implemented separately, this should be the last remaining bits to make vulkan shared win32 resources usable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9195

1 4

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

On Fri Oct 17 05:11:27 2025 +0000, Nikolay Sivov wrote: > We can keep it if you like, what I'm saying is that particular value is > not very useful. On second thought, maybe some Winelib applications use the value. Let's leave it be. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118835

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Nikolay Sivov (＠nsivov) Oct. 17, 2025

Oct. 17, 2025

On Fri Oct 17 04:22:02 2025 +0000, Zhiyi Zhang wrote: > Ok. I will remove it. We can keep it if you like, what I'm saying is that particular value is not very useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118831

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

On Thu Oct 16 18:48:00 2025 +0000, Nikolay Sivov wrote: > I wouldn't mind if we removed it instead completely, it doesn't look > useful and we are not going to introduce sdk checks in the headers. > Current MS SDK has it conditional to winxp sdk version, and same could > be done for mingw-w64 headers for compatibility. Ok. I will remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118828

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

On Thu Oct 16 18:47:59 2025 +0000, Nikolay Sivov wrote: > Could you factor this out to a helper that we could use from all three > controls if it's exactly the same? Sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118827

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

On Thu Oct 16 18:47:59 2025 +0000, Nikolay Sivov wrote: > I think this should go to toolbar tests. I will move it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118824

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests.
by Zhiyi Zhang (＠zhiyi) Oct. 17, 2025

Oct. 17, 2025

On Thu Oct 16 18:47:59 2025 +0000, Nikolay Sivov wrote: > Is it only supported for those three controls? Other comctl32 controls, such as the header control, also support CCM_{GET,SET}VERSION. However, only these three controls in Wine support these messages at the moment, so I didn't test other control classes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118823

1 0

[PATCH v3 0/1] MR9126: ntdll: On macOS, use separate mmap() and mprotect() calls when mapping files with PROT_EXEC.
by Brendan Shanks (＠bshanks) Oct. 16, 2025

Oct. 16, 2025

Starting with macOS 10.15, `mmap()` for a file with `PROT_EXEC` fails with `EPERM`. But for some reason, doing separate `mmap()` and then `mprotect()` calls works. This fixes `NtUserRegisterClassExWOW: Failed to get shared session object for window class` errors seen when running a 32-bit EXE lacking the NX compat bit. The shared memory object being used for window classes was being mapped executable, this was failing because of the above, and then `map_file_into_view()` was falling back to `pread()` which doesn't make sense for a shared memory region. (It seems like a bug to use `pread()` in this scenario rather than return an error, although I'm not sure how that could be detected). I don't love the preprocessor black-magic to replace every mmap() call, but it avoids having to modify any other functions. If we want to avoid that, `map_pe_header()` and `map_file_into_view()` are the `mmap()` calls that I know need to be changed. CrossOver has used an almost-identical hack for years. -- v3: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC. https://gitlab.winehq.org/wine/wine/-/merge_requests/9126

2 2

[PATCH v4 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński Oct. 16, 2025

Oct. 16, 2025

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v4: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

1 4

Re: [PATCH v2 0/1] MR9193: mscoree: Update Wine Mono to 10.3.0. - approved
by Alexandre Julliard (＠julliard) Oct. 16, 2025

Oct. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9193

1 0

Re: [PATCH v2 0/6] MR9191: comctl32/tests: Add CCM_SETVERSION tests. - approved
by Alexandre Julliard (＠julliard) Oct. 16, 2025

Oct. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191

1 0

Re: [PATCH v2 0/1] MR9192: activeds: Remove misleading comments. - approved
by Alexandre Julliard (＠julliard) Oct. 16, 2025

Oct. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9192

1 0

Re: [PATCH v3 0/1] MR9186: uxtheme: Add stub for GetThemeBitmap. - approved
by Alexandre Julliard (＠julliard) Oct. 16, 2025

Oct. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9186

1 0

Re: [PATCH v26 0/1] MR6919: bcp47langs: Add tests for GetUserLanguages. - approved
by Alexandre Julliard (＠julliard) Oct. 16, 2025

Oct. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6919

1 0