- Wine-GitLab - list.winehq.org

[PATCH v7 0/5] MR10645: mf/topology_loader: Insert optional nodes after each branch is connected.
by Conor McCarthy (＠cmccarthy) May 1, 2026

May 1, 2026

New tests show each optional node is connected after the nodes on either side are connected. This is an issue in the game Psycho Sleuth (at least in the demo) because it uses a transform which must have its input types enumerated before it will work correctly. This occurs when a decoder is inserted before the transform, but an optional node lies immediately upstream of the transform, and if optional nodes are not handled correctly, the decoder is initially connected to the optional instead of being inserted later. A couple of other issues revealed while making new tests are fixed here too. -- v7: mf/topology_loader: Remove the fixme from topology_loader_Load(). mf/topology_loader: Try to insert optional nodes after resolving the surrounding branch. mf/topology_loader: Resolve topologies by walking down from each source node. mf/topology_loader: Introduce a helper to get the connection semantic flags. mf/tests: Test optional topology nodes. https://gitlab.winehq.org/wine/wine/-/merge_requests/10645

3 8

Re: [PATCH v2 0/1] MR10781: cmd: Fix handling of "ECHO.ON" - approved
by eric pouech (＠epo) May 1, 2026

May 1, 2026

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10781

1 0

[PATCH v4 0/1] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v4: cmd: Add a second set of illegal characters for the quotes strip https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

3 2

[PATCH v6 0/4] MR10680: scrrun: Implement IFile and IFolder Delete and Move methods.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

file_Delete wraps DeleteFileW, honouring the Force flag by clearing readonly attributes. folder_Delete recursively removes contents via the existing delete_file/delete_folder helpers, then RemoveDirectoryW. Both Move methods wrap MoveFileW. -- v6: scrrun: Implement IFolder::Move. scrrun: Implement IFile::Move. scrrun: Implement IFolder::Delete. scrrun: Implement IFile::Delete. https://gitlab.winehq.org/wine/wine/-/merge_requests/10680

3 6

Re: [PATCH v3 0/1] MR10771: msxml6/tests: Add some tests for XMLHTTP API.
by Nikolay Sivov (＠nsivov) May 1, 2026

May 1, 2026

On Fri May 1 10:09:58 2026 +0000, Bernhard Übelacker wrote: > Hello Nikolay, in my ASan gitlab runs I try to use the > "--enable-werror". llvm-mingw started around 2025-03-25 to emit > `warning: variable '...' set but not used.` for several files, which I > currently carry a workaround in [f03a11a3cb](https://gitlab.winehq.org/bernhardu/wine/-/commit/f03a11a3cb957…. > This patches new file dlls/msxml6/tests/httpreq.c in 674900a75b shows > some new such warnings [in this gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/261349#L105). > Because I observed some of this warning got fixed by @jacek (some are > linked in above workarounds commit message) by adding some missing > checks, I guess in this new file are also some checks missing? > And more generally, should these `variable '...' set but not used` be > fixed, even when they do not appear in the regular gcc-mingw builds? Sure, I think we should fix those warnings one way or another. For tests it will most likely mean removing what's unused. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10771#note_138518

1 0

[PATCH v3 0/1] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v3: cmd: Add a second set of illegal characters for the quotes strip https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

2 1

Re: [PATCH v3 0/1] MR10771: msxml6/tests: Add some tests for XMLHTTP API.
by Bernhard Übelacker (＠bernhardu) May 1, 2026

May 1, 2026

Hello Nikolay, in my ASan gitlab runs I try to use the "--enable-werror". llvm-mingw started around 2025-03-25 to emit `warning: variable '...' set but not used.` for several files, which I currently carry a workaround in [f03a11a3cb](https://gitlab.winehq.org/bernhardu/wine/-/commit/f03a11a3cb957…. This patches new file dlls/msxml6/tests/httpreq.c in 674900a75b shows some new such warnings [in this gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/261349#L105). Because I observed some of this warning got fixed by @jacek (some are linked in above workarounds commit message) by adding some missing checks, I guess in this new file are also some checks missing? And more generally, should these `variable '...' set but not used` be fixed, even when they do not appear in the regular gcc-mingw builds? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10771#note_138515

1 0

[PATCH v4 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569)
by Twaik Yont (＠twaik) May 1, 2026

May 1, 2026

Part of !10569. This series prepares wineandroid ioctl dispatch paths for execution on Java-originated threads that do not have a Wine TEB. It does three things: * pass JNIEnv explicitly through the ioctl dispatch path instead of relying on the global jni_env value in handlers * move native window registration from the APC/unixlib callback path to the direct JNI surface_changed callback on the Android UI thread * make logging in device.c context-aware so the same code remains safe both on Wine threads and on Java-only threads The JNIEnv change is a preparatory refactoring. It does not by itself complete the thread model transition, but it removes one of the major implicit dependencies on Wine thread context and makes follow-up changes smaller and easier to review. Moving native window registration to surface_changed removes another dependency on APC-based execution in the desktop process and puts window attachment on the thread that actually receives the Android surface callbacks. A shared lock is used to serialize registration against ioctl dispatch. Finally, logging in device.c is made context-aware. Upcoming changes will run parts of ioctl dispatch on Java-only threads, where the standard Wine TRACE/WARN/FIXME/ERR macros are unsafe because they depend on Wine TEB state. The local logging wrapper preserves normal Wine logging semantics on Wine threads and falls back to Android logging on non-Wine threads, allowing the existing code to keep using the standard logging macros without invasive per-call-site changes. Taken together, these patches remove several implicit Wine-thread-only assumptions from wineandroid ioctl dispatch code and prepare the path for running more of it directly on Java-side threads. -- v4: wineandroid: pass JNIEnv explicitly through ioctl handlers wineandroid: move native window registration to surface_changed wineandroid: use Android logging for ioctl paths https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

2 4

[PATCH v3 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569)
by Twaik Yont (＠twaik) May 1, 2026

May 1, 2026

Part of !10569. This series prepares wineandroid ioctl dispatch paths for execution on Java-originated threads that do not have a Wine TEB. It does three things: * pass JNIEnv explicitly through the ioctl dispatch path instead of relying on the global jni_env value in handlers * move native window registration from the APC/unixlib callback path to the direct JNI surface_changed callback on the Android UI thread * make logging in device.c context-aware so the same code remains safe both on Wine threads and on Java-only threads The JNIEnv change is a preparatory refactoring. It does not by itself complete the thread model transition, but it removes one of the major implicit dependencies on Wine thread context and makes follow-up changes smaller and easier to review. Moving native window registration to surface_changed removes another dependency on APC-based execution in the desktop process and puts window attachment on the thread that actually receives the Android surface callbacks. A shared lock is used to serialize registration against ioctl dispatch. Finally, logging in device.c is made context-aware. Upcoming changes will run parts of ioctl dispatch on Java-only threads, where the standard Wine TRACE/WARN/FIXME/ERR macros are unsafe because they depend on Wine TEB state. The local logging wrapper preserves normal Wine logging semantics on Wine threads and falls back to Android logging on non-Wine threads, allowing the existing code to keep using the standard logging macros without invasive per-call-site changes. Taken together, these patches remove several implicit Wine-thread-only assumptions from wineandroid ioctl dispatch code and prepare the path for running more of it directly on Java-side threads. -- v3: wineandroid: pass JNIEnv explicitly through ioctl handlers wineandroid: move native window registration to surface_changed wineandroid: use Android logging for ioctl paths https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

3 17

[PATCH 0/1] MR10798: shell32: Remove full path from executable file name when trying to retrive App Paths
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Execution from the link can't find DLLs placed at additional paths in `App Paths` due to the assumption that the file name (`szName` parameter) contains only the file name itself, without the path, or that the `App Paths` subkey in the registry can contain the full path. Since registry subkeys cannot contain a backslash, it is safe to remove the path from the file name and use only the file name as the subkey to check and retrieve the path value for the application. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=625 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10798

2 1

[PATCH v8 0/1] MR10509: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

-- v8: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

2 1

[PATCH v7 0/1] MR10509: Draft: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

-- v7: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

2 1

[PATCH v9 0/4] MR10510: vbscript: Implement byte-string functions LenB, LeftB, RightB, MidB, InStrB, AscB, and ChrB.
by Francis De Brabandere (＠francisdb) May 1, 2026

May 1, 2026

These functions operate on raw bytes of the BSTR (UTF-16LE) data. Also fix InStrB registration to accept 2 args minimum, matching Windows. -- v9: vbscript: Implement AscB and ChrB. vbscript: Implement InStrB. vbscript: Implement LeftB, RightB, and MidB. vbscript: Implement LenB. https://gitlab.winehq.org/wine/wine/-/merge_requests/10510

2 5

[PATCH 0/1] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 1, 2026

May 1, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

2 1

[PATCH v3 0/8] MR10791: mf/topology_loader: Implement optional nodes basic support.
by Rémi Bernon (＠rbernon) May 1, 2026

May 1, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10645 -- v3: mf/topology_loader: Force enumerate types when optional node method is set. https://gitlab.winehq.org/wine/wine/-/merge_requests/10791

3 9

[PATCH 0/1] MR10796: imagehlp: Add ReBaseImage64 stub.
by Alex Henrie (＠alexhenrie) May 1, 2026

May 1, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57852 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10796

2 1

[PATCH 0/1] MR10795: d3d9: Add a fake d3d9 device vtbl initialization sequence.
by Elizabeth Figura (＠zfigura) May 1, 2026

May 1, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10795

2 1

[PATCH v2 0/8] MR10791: mf/topology_loader: Implement optional nodes basic support.
by Rémi Bernon (＠rbernon) May 1, 2026

May 1, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10645 -- v2: mf/topology_loader: Force enumerate types when optional node method is set. mf/topology_loader: Try to insert optional nodes after resolving the surrounding branch. https://gitlab.winehq.org/wine/wine/-/merge_requests/10791

4 9

Re: [PATCH v56 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) May 1, 2026

May 1, 2026

On Fri May 1 00:50:51 2026 +0000, eric pouech wrote: > focusing first on flags=**CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO** (which > is IMO the "simplest" to implement) > * native fails to compute digest under certain cases > * when NumberOfRVaAndSizes is 0 > * on some other images, for which I couldn't find a simple trigger; > need to write some tooling for that; but IMO we can leave it for future > work (or at least is orthogonal to next point, which is the most annoying) > * on some images the basereloc directory is zeroed by the MR while > native doesn't do it... (sometimes only when reporting in the callback > the embedding section, or in some other cases for both the NT headers > and the embeddeding section); from the output, it looks like the tests > for zeroing the fields in basereloc miss some cases > * uninformatively from cursory couldn't find a simple trigger pattern > * if you want to dig further, here's a winedump -f of one of the > offending image > [p](/uploads/f232953407e5063c7583c1854db62d2d/p) Can I get the binary? Or where you got it, if I can go there to get it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10295#note_138486

1 0

[PATCH v2 0/2] MR10543: Change default dir to ~/.local/share/wine
by Fatih Bakal (＠Twig) May 1, 2026

May 1, 2026

I switched it to `~/.local/share/wine` to fit XDG. I will edit all the docs and what not if `~/.local/share/wine` is see fit by maintainers. Soo please let me know if it's fit or not ![winexdg](/uploads/cde0c4003db3beabc05ab334ce0c78a4/winexdg.webp){width=900 height=234} If $XDG_DATA_HOME isn't set on the machine + .local doesn't exist it uses the current `$HOME/.wine` Related issue (please see beforehand): https://bugs.winehq.org/show_bug.cgi?id=48955 -- v2: Stop hardcoding https://gitlab.winehq.org/wine/wine/-/merge_requests/10543

4 7

[PATCH 0/1] MR10793: cfgmgr32: Catch invalid handles in CM_Unregister_Notification.
by Tim Clem (＠tclem) April 30, 2026

April 30, 2026

This is effectively the cfgmgr32 version of !10648. And weirdly again it's Valve software having issues. Since CM_[Un]register_Notification was implemented in !7615, Team Fortress 2 and Counter-Strike 2 have been crashing on exit trying to unregister an invalid HCMNOTIFICATION. My investigation really makes it seem like that's their bug, not ours. And either way, as with HDEVNOTIFYs, unregistering invalid HCMNOTIFICATIONs doesn't crash on native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10793

2 1

Re: [PATCH v3 0/4] MR10731: mfmediaengine: Support media engine extensions. - approved
by Alexandre Julliard (＠julliard) April 30, 2026

April 30, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10731

1 0

Re: [PATCH v3 0/2] MR10789: msvcp120: Ensure that segments are not being allocated when segments table is enlarged. - approved
by Alexandre Julliard (＠julliard) April 30, 2026

April 30, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10789

1 0

Re: [PATCH v2 0/1] MR10774: ntdll: Make sure User Syscall Dispatch defines are always defined on Linux. - approved
by Alexandre Julliard (＠julliard) April 30, 2026

April 30, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10774

1 0

Re: [PATCH v2 0/5] MR10786: msxml3: Pass parsed DTD to the DOM. - approved
by Alexandre Julliard (＠julliard) April 30, 2026

April 30, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10786

1 0