- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR9087: win32u: Avoid a crash when unsetting current context. - approved
by Alexandre Julliard (＠julliard) Oct. 2, 2025

Oct. 2, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9087

1 0

[PATCH 0/2] MR9049: winemac.drv: Don't crash when a window with a GL context is minimized
by Tim Clem (＠tclem) Oct. 2, 2025

Oct. 2, 2025

Since 7b28c6d17c7da278307756cfcd0da830e5d39baf, we directly use `NtUserGetClientRect` to get the size of the GL target windows. But that returns an empty rect for minimized windows, and attempting to set a zero size on a CGL context in `-[WineOpenGLContext wine_updateBackingSize:]` causes a Metal assertion. You can see this by minimizing e.g. Geometry Dash or Garry's Mod. We could just not call wine_updateBackingSize if we find a zero dimension for the window, but I think we want to attempt to keep the backing size correct. Perhaps there's a better way to get the client rect of a minimized window than the un-AdjustWindowRect approach I'm using here? If the window is minimized fullscreen, `get_win_data(hwnd)->rects.client` is (-32000, -32000) - (-32000, -32000). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9049

4 6

[PATCH v2 0/8] MR9088: win32u/tests: Test shared resources runtime descriptor format and API interop.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

-- v2: win32u/tests: Test importing shared resources into Vulkan. win32u/tests: Test creating shared resources with Vulkan. win32u/tests: Test creating shared resources with D3D12. win32u/tests: Test creating shared resources with D3D11. win32u/tests: Test creating shared resources with D3D10. win32u/tests: Test importing shared resources into OpenGL. win32u/tests: Test importing shared resources into D3D9Ex. win32u/tests: Test creating shared resources with D3D9Ex. https://gitlab.winehq.org/wine/wine/-/merge_requests/9088

1 9

[PATCH v4 0/1] MR9056: msxml3/element: Implement removeAttributeNode function.
by Reinhold Gschweicher (＠neroburner) Oct. 2, 2025

Oct. 2, 2025

Implement the function `IXMLDOMElement_removeAttributeNode`. Essentially pass the hard work to `IXMLDOMNamedNodeMap_removeNamedItem`. Use the fact, that attribute names are unique in elements. One case that isn't checked is wheter or not the value of the provided attribute match with the one stored in the dom-element. This MR implements according to the tests introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/8928 -- v4: msxml3/element: Implement removeAttributeNode function. https://gitlab.winehq.org/wine/wine/-/merge_requests/9056

2 3

[PATCH v3 0/4] MR8992: mountmgr.sys: Do not create empty registry nodes for serial or parallel devices.
by Janne Kekkonen (＠Janne) Oct. 2, 2025

Oct. 2, 2025

Empty registry node for parallel devices will cause Realterm to crash. Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598 -- v3: mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

3 5

[PATCH 0/8] MR9088: win32u/tests: Test shared resources runtime descriptor format and API interop.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9088

2 9

[PATCH v20 0/4] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) Oct. 2, 2025

Oct. 2, 2025

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v20: shell32: Improvements to shield icon https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

4 6

[PATCH 0/1] MR9090: ntdll: Use Mach COW for write watches support on macOS.
by Marc-Aurel Zent (＠mzent) Oct. 2, 2025

Oct. 2, 2025

This uses the Mach COW mechanism to implement writewatch functionality. Below is the same micro-benchmark @gofman used in his [UFFD MR](https://gitlab.winehq.org/wine/wine/-/merge_requests/7871). ``` Parameters: - number of concurrent threads; - number of pages; - delay between reading / resetting write watches (ms) - random (1) or sequentual (0) page write access; - reset with WRITE_WATCH_FLAG_RESET in GetWriteWatch (1) or in a separate ResetWriteWatch call (0). Result is in the form of <average write to page time, ns> / <average GetWriteWatch() time, mcs> Parameters Windows Mach COW Fallback 6 1080 3 1 1 897 / 80 371 / 12634 66202 / 186 6 1080 3 1 0 855 / 87 369 / 12637 66766 / 187 8 8192 3 1 1 6526 / 268 627 / 113263 111053 / 485 8 8192 3 1 0 1197 / 509 623 / 113810 122921 / 489 8 8192 1 1 1 1227 / 412 636 / 118930 150628 / 388 8 8192 1 1 0 5721 / 144 631 / 120538 146392 / 384 8 64 1 1 1 572 / 7 490 / 1078 1000 / 89 8 64 1 1 0 530 / 13 500 / 1075 1167 / 77 ``` This was all on the same M2 Max machine with Windows being win11 on ARM in a VM running the x64 binary emulated and otherwise Wine through Rosetta with and without this MR. Unlike UFFD which is always better than fallback and comparable to the Windows performance, here good average write to page time is traded for bad average `GetWriteWatch()` time (pretty much in equal ratios). However in real world applications (like the FFXIV + Dalamud mod framework/loader use case) the startup time is reduced from about 25.5s to 23.6s with this change from a cold start, including loading a modern dotnet 9 runtime into the game process and initializing a complex mod collection, with a fairly high GC pressure. This is probably because the `GetWriteWatch()` calls the GC does mostly happen concurrently, whereas in Wines fallback implementation running threads are interrupted and often wait on the global virtual lock in Wine while the segfault is handled and parallel accesses to write watched memory and other VM operations are blocked. Another advantage is that `VPROT_WRITEWATCH` can be used then for other purposes in the future and also Rosetta being a bit finicky sometimes with reported protections with the current implementation, but behaved always as expected so far in my testing with the new one. On native ARM64 the `VM_PROT_COPY`/`SM_COW` mechanism works also as expected on native 16k pages (not that this matters much at the moment). `GetWriteWatch()` with the reset flag also does not need to be transactional (unlike UFFD), since only marked pages are reset here and not the entire range. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9090

3 4

[PATCH v19 0/3] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) Oct. 2, 2025

Oct. 2, 2025

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v19: shell32/tests: Check hIcon value is non-zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

3 5

Re: [PATCH v2 0/1] MR7576: windowscodecs: Remove IWICWineDecoder interface. - approved
by Esme Povirk (＠madewokherd) Oct. 2, 2025

Oct. 2, 2025

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7576

1 0

[PATCH v3 0/3] MR9056: msxml3/element: Implement removeAttributeNode function.
by Reinhold Gschweicher (＠neroburner) Oct. 2, 2025

Oct. 2, 2025

Implement the function `IXMLDOMElement_removeAttributeNode`. Essentially pass the hard work to `IXMLDOMNamedNodeMap_removeNamedItem`. Use the fact, that attribute names are unique in elements. One case that isn't checked is wheter or not the value of the provided attribute match with the one stored in the dom-element. This MR implements according to the tests introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/8928 -- v3: fix formatting of if clause https://gitlab.winehq.org/wine/wine/-/merge_requests/9056

4 7

[PATCH 0/1] MR9087: win32u: Avoid a crash when unsetting current context.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9087

1 1

[PATCH v3 0/7] MR9086: server: Continuously poll on queue fd for driver events.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

Allowing to use a simple event-like sync for the message queues. -- v3: server: Use an internal event sync for message queues. server: Remove mostly unnecessary thread own queue check. server: Continuously poll on queue fd for driver events. win32u: Notify wineserver after processing every driver events. win32u: Return TRUE from ProcessEvents after emptying the event queue. win32u: Check for pending hardware messages after processing events. server: Use a dedicated internal bit for queued hardware messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/9086

1 8

[PATCH v2 0/1] MR8914: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace.
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 2, 2025

Oct. 2, 2025

-- v2: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace. https://gitlab.winehq.org/wine/wine/-/merge_requests/8914

3 2

[PATCH v2 0/2] MR9084: d2d1: Implement D2D1CreateDeviceContext().
by Dmitry Timoshkov (＠dmitry) Oct. 2, 2025

Oct. 2, 2025

-- v2: d2d1: Add a test for D2D1CreateDeviceContext(). d2d1: Implement D2D1CreateDeviceContext(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9084

3 4

[PATCH v2 0/6] MR9086: server: Continuously poll on queue fd for driver events.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

Allowing to use a simple event-like sync for the message queues. -- v2: server: Use an internal event sync for message queues. server: Remove mostly unnecessary thread own queue check. server: Continuously poll on queue fd for driver events. win32u: Notify wineserver after processing every driver events. win32u: Return TRUE from ProcessEvents after emptying the event queue. win32u: Check for pending hardware messages after processing events. https://gitlab.winehq.org/wine/wine/-/merge_requests/9086

1 7

[PATCH 0/6] MR9086: server: Continuously poll on queue fd for driver events.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

Allowing to use a simple event-like sync for the message queues. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9086

1 6

Re: [PATCH v2 0/1] MR9085: iphlpapi: Give GetBestRoute2 a SOCKETADDR_INET.
by Yuxuan Shui (＠yshui) Oct. 2, 2025

Oct. 2, 2025

On Wed Oct 1 23:57:24 2025 +0000, Paul Gofman wrote: > I think the bug here is most likely in GetBestInterface() and should be > fixed there (by using SOCKADDR_INET instead of struct sockaddr_in), and > likely no bug in GetBestRoute2. > TL;DL; Note GetBestRoute2 even zeroes output bestaddress in full and > that is backed by the tests. Whether GetBestRoute2 accesses src and dst > in full or shorter part in case of ipv4 is currently not tested, but I > think it more likely does on Windows (and if I didn't have to fixup dst > address in the concerned place I would just do 'connect( s, (struct > sockaddr *)dst, sizeof(*dst) )' and that access would happen in ws2_32 > where it would copy the address for DeviceIoControl). That > 'SOCKADDR_INET *' passed for dst, not a void pointer with explicit > length, so from general sense it is totally valid to access the whole > structure, and the implementation would naturally do it if it would, e. > g., passing the address to nsiproxy or ws2_32 without interpreting here. > Small chance that it doesn't access it on Windows of course, but I'd > suggest we don't overdo it by testing this implementation detail on > Windows in the absense of practical motivation, avoid adding extra code > to GetBestRoute2 and just use the SOCKADDR_INET structure in GetBestInterface(). updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9085#note_117392

1 0

Re: [PATCH v3 0/3] MR9078: More debugging related fixes & enhancements. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9078

1 0

Re: [PATCH v2 0/4] MR9071: server: Introduce an internal queue bits field. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9071

1 0

Re: [PATCH v2 0/6] MR9072: win32u: Implement D3DKMT object sharing through NT handles. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9072

1 0

Re: [PATCH v2 0/5] MR9073: Cmd engine rewrite (part XXXVII) - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9073

1 0

Re: [PATCH v3 0/1] MR9077: imm32: ensure HIMC is unlocked in ImmGenerateMessage - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9077

1 0

Re: [PATCH v3 0/1] MR9014: server: Create an inproc sync for user APC signaling. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9014

1 0

Re: [PATCH v3 0/3] MR9083: xmllite/writer: Remove now unnecessary helper. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9083

1 0