- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) Sept. 25, 2025

Sept. 25, 2025

Welcome to WineHQ, Matthias! Thanks for your contribution. Does this patch fix any known Windows application on Wine? Or is this a refactoring change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116851

1 0

[PATCH v2 0/2] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) Sept. 25, 2025

Sept. 25, 2025

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- v2: cmd/tests: Add DIR test for /o set in DIRCMD environment variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 6

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) Sept. 25, 2025

Sept. 25, 2025

On Tue Jul 29 18:40:30 2025 +0000, Joel Holdsworth wrote: > The > [16x16](https://git.golem.linux.it/matteobin/tango-icon-theme/src/branch/master/16x16/status/network-wireless-encrypted.png) > version will required tweaking in a pixel editor. Please review the svg changes again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116840

1 0

[PATCH v14 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) Sept. 25, 2025

Sept. 25, 2025

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v14: shell32: Try to lookup icon shell32: Add shield icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

2 2

[PATCH v2 0/1] MR9033: comdlg32: Filedialog stores location when closed.
by Janne Kekkonen (＠Janne) Sept. 24, 2025

Sept. 24, 2025

Filedialog location is stored when dialog is closed. When dialog is reopenned it opens to same location. Location info is stored as long as the application is running. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40738 -- v2: comdlg32: Filedialog stores location when closed. https://gitlab.winehq.org/wine/wine/-/merge_requests/9033

2 2

[PATCH 0/5] MR9033: comdlg32: Filedialog stores location when closed.
by Janne Kekkonen (＠Janne) Sept. 24, 2025

Sept. 24, 2025

Filedialog location is stored when dialog is closed. When dialog is reopenned it opens to same location. Location info is stored as long as the application is running. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40738 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9033

3 7

[PATCH 0/2] MR9054: winebth.sys: Remove redundant locks + Fix potential deadlocks while performing operations that block on the DBus event loop.
by Vibhav Pant (＠vibhavp) Sept. 24, 2025

Sept. 24, 2025

Disconnecting and removing remote devices hold device_list_cs before blocking on the DBus event loop, which may cause a deadlock if we receive a message from BlueZ whose handler also attempts to enter device_list_cs (Like BLUETOOTH_WATCHER_EVENT_TYPE_DEVICE_PROPERTIES_CHANGED). To fix this, the device/radio handle is duplicated once found, device_list_cs is released, and the DBus method call is made using the duplicate handle(s), which are then freed normally. Also, replace the two locks in `bluetooth_radio` with `device_list_cs` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9054

2 2

[PATCH 0/1] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) Sept. 24, 2025

Sept. 24, 2025

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 2

Re: [PATCH v2 0/1] MR9042: wined3d: Use malloc() for the private store. - approved
by Alexandre Julliard (＠julliard) Sept. 23, 2025

Sept. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9042

1 0

Re: [PATCH v3 0/2] MR9013: propsys: Add PropVariantToFileTime() semi-stub. - approved
by Alexandre Julliard (＠julliard) Sept. 23, 2025

Sept. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9013

1 0

Re: [PATCH v2 0/7] MR9044: xmllite/writer: Improve error hanlding in WriteCData(). - approved
by Alexandre Julliard (＠julliard) Sept. 23, 2025

Sept. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9044

1 0

Re: [PATCH v2 0/2] MR9039: Include defines - approved
by Alexandre Julliard (＠julliard) Sept. 23, 2025

Sept. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9039

1 0

[PATCH 0/1] MR9050: inf: Add Windows Media Player related registry keys.
by Patrick Hibbs (＠hibbsncc1701) Sept. 23, 2025

Sept. 23, 2025

Some apps (Mega Man X DiVE Offline, steam appid: 2183650), explicitly check for these keys, and throw error dialogs if they aren't found in the registry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57703 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9050

2 1

[PATCH v3 0/1] MR9038: Draft: msi: implement MsiProvideAssembly[AW]()
by Ratchanan Srirattanamet (＠ratchanan.sr) Sept. 23, 2025

Sept. 23, 2025

TODO: - make awstring version of MsiProvideComponent() and use that. - Actually implement MsiProvideAssemblyA() using the above. - Write conformance test? Dependency: - Have ACTION_PublishAssemblies() record feature (https://gitlab.winehq.org/wine/wine/-/merge_requests/9037) - Have MsiEnumFeatures() fixed. Currently it seems to just look for features at the wrong place and thus is useless for this purpose. (https://gitlab.winehq.org/wine/wine/-/merge_requests/9041) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58578 -- v3: [WIP] msi: implement MsiProvideAssembly[AW]() https://gitlab.winehq.org/wine/wine/-/merge_requests/9038

2 1

[PATCH 0/2] MR9048: libs/fluidsynth: Fix data race in g_get_monotonic_time().
by Jinoh Kang (＠iamahuman) Sept. 23, 2025

Sept. 23, 2025

Fixes: f768d6b31bebc35fbaf751d0cd57c8bd302a8d60 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9048

3 3

[PATCH 0/9] MR9023: libs/fluidsynth: Miscellaneous fixes in glib stubs.
by Jinoh Kang (＠iamahuman) Sept. 23, 2025

Sept. 23, 2025

Mostly for vendoring of future fluidsynth versions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9023

5 19

[PATCH v3 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) Sept. 23, 2025

Sept. 23, 2025

-- v3: windows.devices.enumeration: Implement IDeviceInformationStatics::{FindAllAsyncAqsFilterAndAdditionalProperties, CreateWatcherAqsFilterAndAdditionalProperties}. windows.devices.enumeration: Implement IDeviceInformation::get_Properties. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::FindAllAsyncAqsFilterAndAdditionalProperties. windows.devices.enumeration/tests: Add tests for device properties for IDeviceInformation objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

2 4

[PATCH 0/1] MR9047: secur32: Add QuerySecurityContextToken() stub implementation to the LSA wrapper.
by Dmitry Timoshkov (＠dmitry) Sept. 23, 2025

Sept. 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9047

2 1

[PATCH 0/2] MR9046: ws2_32/tests: Add a simple test for WSAProviderConfigChange().
by Dmitry Timoshkov (＠dmitry) Sept. 23, 2025

Sept. 23, 2025

This test replicates what Microsoft-MPI (https://github.com/microsoft/Microsoft-MPI/tree/master/src) and its backend NetworkDirect (https://github.com/microsoft/NetworkDirect/blob/master/src/ndutil/ndfrmwrk.…) depend on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9046

2 2

[PATCH v2 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) Sept. 23, 2025

Sept. 23, 2025

-- v2: windows.devices.enumeration: Implement IDeviceInformationStatics::{FindAllAsyncAqsFilterAndAdditionalProperties, CreateWatcherAqsFilterAndAdditionalProperties}. windows.devices.enumeration: Implement IDeviceInformation::get_Properties. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::FindAllAsyncAqsFilterAndAdditionalProperties. https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

2 4

[PATCH 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) Sept. 23, 2025

Sept. 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

2 4

[PATCH v4 0/5] MR8969: opengl32, win32u: Fix 16-bit PFD_DRAW_TO_BITMAP rendering.
by Zowie van Dillen (＠zowie) Sept. 23, 2025

Sept. 23, 2025

This MR fixes 16-bit PFD_DRAW_TO_BITMAP rendering, as tested with SimGolf and Civilization 3. The fix isn't super performant since it involves a lot of back-and-forth between CPU and GPU, which is mostly noticeable when moving staff around in SimGolf — it slows to around two or three fps —, but on the plus side it does work, which is a straight upgrade over the current version of Wine. Couple of notes: * The third commit touches several different subsystems because I had to add a constant that's visible from both opengl32 and win32u. I wasn't sure how to write this down in the commit message. * There's a bug in LLVMpipe where a 32-bit pbuffer will cause it to crash. I opened an issue for it here: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13890. I needed a 32-bit pbuffer to make this work, so I added a special check that effectively disables 16-bit bitmap rendering for LLVMpipe. * I also had to use a workaround to make blitting & OpenGL rendering work together. I wrote about it pretty extensively below. ## Combining blitting & OpenGL rendering Something that's difficult about bitmap rendering is that it allows programs to combine OpenGL drawing with direct blitting onto bitmap memory. That's difficult to imitate with the pbuffer-based implementation because there's no way to replicate memory edits on the bitmap to the GPU-based pbuffer (since there's no API calls involved in the memory edit). This had to work to make the games actually work, so I used this workaround: Each time after overwriting the bitmap from the pbuffer, we clear the pbuffer with transparent. Also instead of "overwriting" the bitmap, we instead blend the pbuffer's pixels onto the bitmap. That way we're effectively overlaying the most recent OpenGL drawings on top of the bitmap. I'm pretty confident that that approach would also help with 32-bit and 24-bit bitmap rendering, but I don't know of any programs that use 32-bit or 24-bit bitmap rendering, so I wasn't able to check. I've just left 32-bit and 24-bit bitmaps as they were. While the workaround works really well for the games, I did have to edit another test because it used glReadPixels on 16-bit bitmaps. glReadPixels will grab pixels from the transparent-background pbuffer instead of the bitmap, which gives the wrong result. I'm not under the impression that any consumer programs use bitmap rendering together with glReadPixels (it doesn't make as much sense when you could just directly read the pixels from the bitmap), but it's possible to add a wrap_glReadPixels that grabs pixels from the bitmap in case of a 16-bit memory DC. It's not important to read but I wanted to write it down for the record: I also tried another workaround to make combining blitting & OpenGL work. The thought was to overwrite the pbuffer with the bitmap just before OpenGL draws to the pbuffer, to keep them in sync. It probably would have worked out if it was possible to add something to the front of the OpenGL command buffer in a glFinish/glFlush call — then I could have inserted glDrawPixels in the front, before all of the program's rendering operations —, but it's only possible to add things to the end of the command buffer unfortunately. I tried adding a wrapper to glBegin and glClear, which checks if they were the first render operation after a glFlush or glFinish. Unfortunately that didn't work at all. I'm guessing that Civ 3 and SimGolf still do direct bitmap edits after the first call to glBegin, so by the time the program gets to glFinish/glFlush the pixels that were uploaded in the glDrawPixels command are already stale (although I didn't really check). Anyhow, that approach was pretty fruitless. -- v4: win32u: Fix garbled 24-bit bitmap rendering win32u: Add support for 16-bit bitmaps to set_dc_pixel_format and flush_memory_dc. opengl32: Return a fake pixel format when requesting 16-bit bitmap rendering. opengl32/tests: Extend 16-bit bitmap rendering test. winex11: Refine PFD_DRAW_TO_BITMAP requirements. https://gitlab.winehq.org/wine/wine/-/merge_requests/8969

3 14

[PATCH 0/4] MR9043: win32u: Implement NtGdiDdDDIQueryResourceInfo.
by Rémi Bernon Sept. 23, 2025

Sept. 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9043

2 5

[PATCH 0/7] MR9044: xmllite/writer: Improve error hanlding in WriteCData().
by Nikolay Sivov (＠nsivov) Sept. 23, 2025

Sept. 23, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9044

2 7

[PATCH 0/1] MR9042: wined3d: Use malloc() for the private store.
by Elizabeth Figura (＠zfigura) Sept. 23, 2025

Sept. 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9042

2 1