- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR8974: dmsynth: Don't force enable DMUS_EFFECT_REVERB.
by Anton Baskanov (＠baskanov) Sept. 17, 2025

Sept. 17, 2025

On Wed Sep 17 02:55:19 2025 +0000, Michael Stefaniuc wrote: > Looks good. > Do you have a game / application that tripped over the DMUS_EFFECT_REVERB?\ > Pure interest as it seems I had botched the test that ended up forcing > the DMUS_EFFECT_REVERB on. No, I'm just writing some synthesis tests, and it's getting in the way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8974#note_116030

1 0

Re: [PATCH v4 0/11] MR8961: dwrite: Create font collections using font set objects. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8961

1 0

Re: [PATCH v2 0/4] MR8974: dmsynth: Don't force enable DMUS_EFFECT_REVERB. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8974

1 0

Re: [PATCH v2 0/1] MR8979: win32u/tests: Fix missing test message context pop. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8979

1 0

Re: [PATCH v3 0/4] MR8981: dwrite: Always initialize 'contours' flag. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8981

1 0

Re: [PATCH v4 0/1] MR8975: winex11: Always notify the surface that it has been presented. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8975

1 0

Re: [PATCH v6 0/1] MR8971: make_unicode: Add some halfwidth mapping exceptions. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2025

Sept. 16, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8971

1 0

[PATCH 0/5] MR8978: mmdevapi/tests: Rewrite capturing tests, part 2/4.
by Giovanni Mascellani (＠giomasce) Sept. 16, 2025

Sept. 16, 2025

Patch 4/5 has `broken(1)` which is probably not very nice, but I don't know how to handle that otherwise. I would say it's a property that we want to enforce for our implementation; at the same time it breaks on older Windows builds without much logic, AFAICT. I would constrain the `brokn()` on the Windows version, but my understanding is that this is not allowed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8978

3 6

[PATCH v4 0/28] MR8955: ntdll: NtSetEventBoostPriority stub regression fixes for bug #58688
by Stian Low (＠stianlow) Sept. 16, 2025

Sept. 16, 2025

NtSetEventBoostPriority stub regression fixes for: https://bugs.winehq.org/show_bug.cgi?id=58688 Regressive commit: ed9f31120b68e7d684c1544c05d94c38b25cb759 Other stubs were also changed by regress commit and may still be broken. I'll test the other stubs and fix if necessary. In the meantime I'm submitting this merge for review in case I missed anything that may be needed for the other stub fixes. -- v4: ntdll: ZwSetEventBoostPriority typo correction for bug #58688 This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/8955

3 9

[PATCH v2 0/2] MR8970: kernel32/kernelbase: Implemented NUMA functions and improved affinity support
by Danny Waser (＠wasertech) Sept. 16, 2025

Sept. 16, 2025

This merge request implements several NUMA functions previously stubbed in kernel32 and kernelbase, adds a basic NUMA node discovery/topology layer, and enriches the associated tests. It also improves the traceability of SetThreadGroupAffinity. ## Context / Motivation Some Windows applications (game engines, middleware, runtimes) query the NUMA API to adapt memory allocation or thread distribution. The lack of an implementation returned errors (ERROR_CALL_NOT_IMPLEMENTED) or unhelpful values, which could degrade the internal heuristics of these programs. This first implementation provides: - A logical topology derived from GetLogicalProcessorInformation. - A reasonable approximation of available memory per node. - Consistent processor masks for the present nodes. It prepares for future optimizations (targeted memory allocation, better scheduling strategies) without modifying the existing behavior of generic allocations. ## Main Changes - `kernel32/process.c`: - Implementation of GetNumaNodeProcessorMask, GetNumaAvailableMemoryNode / Ex, GetNumaProcessorNode / Ex, GetNumaProximityNode. - Parameter validation and consistent error propagation (ERROR_INVALID_PARAMETER). - `kernelbase/memory.c`: - New NUMA infrastructure (topology cache, lazy initialization, dedicated critical lock). - Topology reading via GetLogicalProcessorInformation. - Runtime options via environment variables: - WINE_NUMA_FORCE_SINGLE: Force a single logical node. - WINE_NUMA_CONTIG: Remap masks to produce contiguous blocks. - Implementations of GetNumaHighestNodeNumber, GetNumaNodeProcessorMaskEx, GetNumaProximityNodeEx. - Robust fallback: if no NUMA info → single node. - `kernelbase/thread.c`: - Added detailed traces in SetThreadGroupAffinity (removed the redundant DECLSPEC_HOTPATCH here). - Tests (`dlls/kernel32/tests/process.c`): - Added a new test, test_NumaBasic, covering: - GetNumaHighestNodeNumber - GetNumaNodeProcessorMaskEx (nodes 0 and 1) - GetNumaProximityNodeEx - Tolerant behavior: accepts `ERROR_INVALID_FUNCTION` / `ERROR_INVALID_PARAMETER` depending on the platform. - Added the `WINE_DEFAULT_DEBUG_CHANNEL(numa)` debug channel for the subsystem. ## Assumptions / Limitations - Support for a single processor group (Group = 0) for now. - Memory approximation: equal division of available physical memory (improvable later with internal counters per node). - Proximity = node (simplistic direct mapping). - No impact yet on VirtualAlloc / Heap allocation by node. ## Security / Concurrency - Initialization protected by dedicated critical section (numa_cs). - Thread-safe lazy read. - Table bounded to 64 nodes (historical Windows limit). ## Compatibility Impact - Improves compatibility with software probing the NUMA API. - Low risk of regression: previously failed paths now return TRUE with consistent data. - In case of topology collection failure → single-node fallback (conservative behavior). ## Validation / Tests - New test_NumaBasic added and integrated into the process suite. - Traces (numa channel) allow for detection diagnostics. - Invalid parameters tested (NULL, nodes out of range). - Works in environments without real NUMA via fallback. ## Environment Variables (quick documentation) - WINE_NUMA_FORCE_SINGLE=1: Forces a single node (mask covering all CPUs). - WINE_NUMA_CONTIG=1: Reallocates compact bit blocks per node (useful if the topology returns sparse masks). ## Potential Next Steps (not included) - Implement true memory tracking per node (via allocation hooks). - Multi-group support (PROCESSOR_GROUP_INFO). - Improved VirtualAllocExNuma / First-touch implementation. - More accurate proximity-to-node mapping on complex NUMA platforms. - Dedicated tests for environment variables. ## Potential Risks / Regressions - Applications relying on the absence of an API may slightly change their strategy (low). - Masks remapped with WINE_NUMA_CONTIG could surprise a profiling tool (opt-in option). - Memory approximation too coarse for very fine-grained heuristics (no functional regression expected). ## Request for Review - Verify logging conventions and TRACE_(numa) usage. - Verify the relevance of removing DECLSPEC_HOTPATCH on SetThreadGroupAffinity (alignment with local conventions). - Opinion on error granularity (ERROR_INVALID_PARAMETER vs. ERROR_INVALID_FUNCTION) for more accurate mimicry. Once the kernel can handle those functions directly (in a NUMA module i.e.) we could use this implementation as a fallback when the kernel doesn't support NUMA natively (when the module cannot be loaded). -- v2: kernelbase: Improve initialization of NUMA information to handle pathological cases https://gitlab.winehq.org/wine/wine/-/merge_requests/8970

5 22

[PATCH v2 0/6] MR8960: mshtml: Implement XDomainRequest.
by Gabriel Ivăncescu Sept. 16, 2025

Sept. 16, 2025

-- v2: mshtml: Implement contentType for XDomainRequest. mshtml: Implement timeout for XDomainRequest. mshtml: Implement XDomainRequest.open(). mshtml: Add XDomainRequest factory implementation. mshtml: Factor out XMLHttpRequest constructor init. mshtml: Factor out XMLHttpRequest creation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8960

2 9

[PATCH v2 0/11] MR8961: Draft: dwrite: Create font collections using font set objects.
by Nikolay Sivov (＠nsivov) Sept. 16, 2025

Sept. 16, 2025

-- v2: dwrite: Reuse font set entries to return set instances for collections. dwrite/tests: Add a small test for EUDC collection. dwrite: Cache set elements for returned system sets. dwrite: Remove nested structures in fontset entries. dwrite: Simplify collection initialization helper. dwrite: Create custom collections using font sets. dwrite: Create both WWS and typographic system collections using system font set. dwrite: Mark system font sets. dwrite: Remove system collection marker. dwrite: Check against local file loader in ConvertFontToLOGFONT(). dwrite/tests: Add some more tests for ConvertFontToLOGFONT(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8961

3 12

[PATCH v2 0/1] MR8906: Draft: dwrite: Cache fontset entries when one is created from a collection.
by Tim Clem (＠tclem) Sept. 16, 2025

Sept. 16, 2025

Motivation is Ubisoft Connect, which calls IDWriteFontCollection::GetFontSet many times on the system font collection, and then GetMatchingFonts on those sets. Without a change like this, each set created by GetFontSet has a separate cache of `dwrite_fontset_entry`s, so the GetMatchingFonts calls rescan every font on the system (via dwritefontset_GetMatchingFonts -> fontset_entry_is_matching -> fontset_entry_get_property, which does not find cached properties and thus makes a new file stream). Perhaps it makes sense to not have the `owns_entries` flag in all the dwrite_fontset initializers, and just set it as needed in IDWriteFontCollection::GetFontSet? (And perhaps to invert it to `unowned_entries` or something, so the calloc initialization sets the most common value?) -- v2: dwrite: Reuse entries when a font set is created from a collection. https://gitlab.winehq.org/wine/wine/-/merge_requests/8906

3 8

[PATCH 0/4] MR8974: dmsynth: Don't force enable DMUS_EFFECT_REVERB.
by Anton Baskanov (＠baskanov) Sept. 16, 2025

Sept. 16, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8974

3 6

[PATCH v13 0/5] MR8890: windows.devices.enumeration: Add support for parsing AQS filter strings.
by Vibhav Pant (＠vibhavp) Sept. 16, 2025

Sept. 16, 2025

-- v13: maintainers: Add a section for Windows.Devices.Enumeration. windows.devices.enumeration: Support parsing AQS filters in IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. https://gitlab.winehq.org/wine/wine/-/merge_requests/8890

3 9

Re: [PATCH v12 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy Sept. 16, 2025

Sept. 16, 2025

On Tue Sep 16 12:48:37 2025 +0000, eric pouech wrote: > Kept translation matches the removed fuzzy entry, not the kept msgid. The fuzzy matches must be deleted for the translation to take effect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857#note_115962

1 0

Re: [PATCH v12 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy Sept. 16, 2025

Sept. 16, 2025

On Tue Sep 16 12:48:37 2025 +0000, Nikolay Sivov wrote: > Here it's fine to remove it, because original text does not have it. The “fuzzy” translations block the translation after the fact. It would be better to delete the fuzzy translations and do a side-by-side translation so that everything is taken into account. For example, in “winecfg,” under “integration with the desktop,” you will see what I mean. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857#note_115961

1 0

[PATCH v11 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy Sept. 16, 2025

Sept. 16, 2025

-- v11: Update modify fr.po https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 9

[PATCH v10 0/8] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy Sept. 16, 2025

Sept. 16, 2025

-- v10: Remove .gitkeep https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 12

[PATCH v17 0/10] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) Sept. 16, 2025

Sept. 16, 2025

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v17: ntoskrnl/tests: Use the 'Nt' version of the CancelIo APIs. ntoskrnl/tests: Test the thread ID the cancellation routine runs from. ntoskrnl/tests: Add more cancellation tests. ntoskrnl/tests: Fix tests on current Windows 10 / 11. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile(). server: Factor out a cancel_async() function. server: Introduce a find_async_from_user helper. ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

3 10

[PATCH 0/1] MR8977: winex11: Use EGL by default for OpenGL rendering.
by Rémi Bernon Sept. 16, 2025

Sept. 16, 2025

When we were able to load it at least. EGL has some advantages, like not requiring a specific pixel format on the windows, it will share most of its problems with winewayland (and wineandroid although we may also assume GL doesn't work anymore there at this point) so anything fixed with it could benefit all. It will also be required for shared resources and compositing when Vulkan is unavailable. This might be a bit early still, I'm not sure it is on par when it comes to child window rendering synchronization. However this doesn't drop GLX either, and instead just changes the default. I think it would be useful to switch early though, at least to have more time to settle (and eventually decide to switch back during code freeze if it proves a bad idea). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8977

2 4

[PATCH 0/1] MR8975: winex11: Always notify the surface that it has been presented.
by Rémi Bernon Sept. 16, 2025

Sept. 16, 2025

It might not be offscreen but it might have been detached if multiple client surfaces are involved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58602 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8975

1 2

[PATCH 0/5] MR8976: server: Move more class info to the shared memory.
by Rémi Bernon Sept. 16, 2025

Sept. 16, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8976

1 6

Re: [PATCH v16 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Tomas-Mendes-ai (＠Tomas-Mendes-ai) Sept. 16, 2025

Sept. 16, 2025

Hello @julliard , I've had this merge request open for some time now. Please let me know if there's anything I can do to expedite its acceptance. Much appreciated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_115951

1 0

[PATCH v15 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Tomas-Mendes-ai (＠Tomas-Mendes-ai) Sept. 16, 2025

Sept. 16, 2025

Current implementation of system.fill_battery_state only reads "charge\__" and "current\__" attributes. Some batteries expose different attributes, namely "power\__" and "energy\__". Added the required logic to support both types. Further, when rewriting the function I also added support for systems with multiple batteries. Windows documentation was not clear but from what I gathered struct SYSTEM_BATTERY_STATE sets Charging and Discharging if ANY battery is charging/discharging. So, to check if the overall system is charging/discharging only Rate can be used. Also cleaned the code related to "AC". There was a "fixme" there which I didn't fully undertand as SYSTEM_BATTERY_STATE.AcOnLine == True if any AC is present, so the proper logic was already implemented -- v15: ntdll: improve readibility of linux_battery capacity units ntdll: Support multi-battery systems and batteries that expose energy_* and power_* ntdll: Add enum, struct for battery status, information ntdll: Fix test with proper battery EstimatedTime expected value ntdll: Update tests to use just Rate for charging logic https://gitlab.winehq.org/wine/wine/-/merge_requests/8460

2 5