- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR8918: wineboot: Fix a memory leak in create_computer_name_keys.
by Alex Henrie (＠alexhenrie) Sept. 9, 2025

Sept. 9, 2025

If the canonical hostname was "localhost", the address info was not freed. Don't bother checking whether ai_canonname is NULL because if there is no canonical name, getaddrinfo must set ai_canonname to the input name. Fixes: ca5a6d07dc92ba631b178ec175e6b3fd5295e3d6 -- v3: wineboot: Fix a memory leak in create_computer_name_keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/8918

3 2

Re: [PATCH v2 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Reinhold Gschweicher (＠neroburner) Sept. 9, 2025

Sept. 9, 2025

On Tue Sep 9 08:58:52 2025 +0000, Nikolay Sivov wrote: > Hi, > Have you found an application that's using this method? Yes, its called "RiSCAN PRO" from the company "RIEGL GmbH" The product page can be found here: http://www.riegl.com/products/software-packages/riscan-pro/ (unfortunately one needs an account to download the software, and to install one needs to get a `tar.exe` into `system32` and `syswow64` as the installer uses `tar.exe` to extract zip files, but that is a different issue :grin: ) RiSCAN PRO under `wine-10.13` can't save a project and errors with the following message: ``` 2025-08-19 08:25:47+730 [x] Cannot save project: Not implemented ``` With the following wine-debugging messages: ``` 0148:fixme:msxml:domelem_removeAttributeNode (000072400CD21600)->(000072400CD217C0 00007FFFFE1FE0F8) ``` The project file is in xml format. The program itself is a Delphi Program and it seems to use `msxml.dll` to modify its project file -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115432

1 0

[PATCH v2 0/2] MR8920: cmd: Fix some TYPE command behavior (one more try).
by Joe Souza (＠JoeS209) Sept. 9, 2025

Sept. 9, 2025

Giving this one final shot. If this is not deemed acceptable, I will abandon the effort and just move on to other things, no hard feelings. This is IMO a cleaner, more conservative/less invasive change. What is fixed: - Bug #56381, "TYPE c:\windows\winhelp.exe >foo", i.e. binary mode operation. I would probably consider this the main reason for this change. I'm trying to get the compiler mentioned in the bug report working. - Ctrl-Z termination of TYPE output to the console. - "TYPE con >foo", with Ctrl-Z handling, functionally equivalent to "COPY con foo". -- v2: cmd/tests: Add tests to check for TYPE truncation in binary mode. cmd: Fix some TYPE command behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/8920

3 7

[PATCH 0/5] MR8930: Fix check for early IRP cancellation
by Matteo Bruni (＠Mystral) Sept. 9, 2025

Sept. 9, 2025

This matches https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/using-a-d… and, as far as I can see, is the intended idea and what the comment implies. The idea, as I understand it, is to avoid a TOCTOU hazard by first setting the cancel routine and only afterwards checking the Cancel flag. If it's set while the previous cancel routine (returned by the second IoSetCancelRoutine call) is not NULL, that means it's been enabled before our first IoSetCancelRoutine call and we have to take care of it. Conversely, if there is no previous routine set, it must mean that ntoskrnl has removed the routine we just set and it's going to call it, or has already called it (and it's probably now trying to acquire the spinlock). In that case we leave handling the cancellation to the routine and do nothing special here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8930

5 8

[PATCH v3 0/7] MR8934: win32u: Hook VK_KHR_external_(semaphore|fence)_win32 related functions.
by Rémi Bernon Sept. 9, 2025

Sept. 9, 2025

-- v3: win32u: Hook VK_KHR_external_fence_win32 related functions. win32u: Hook VK_KHR_external_semaphore_win32 related functions. win32u: Hook VK_KHR_win32_keyed_mutex related functions. win32u: Hook vkQueueSubmit and vkQueueSubmit2 functions. winevulkan: Move command buffer wrapper to vulkan_driver.h. winevulkan: Force copying the VkSubmitInfo(2) struct chains. winevulkan: Force copying wrapped handle arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8934

1 7

Re: [PATCH v2 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Nikolay Sivov (＠nsivov) Sept. 9, 2025

Sept. 9, 2025

Hi, Have you found an application that's using this method? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115425

1 0

[PATCH 0/1] MR8937: windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) Sept. 9, 2025

Sept. 9, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8937

3 5

[PATCH 0/5] MR1035: oleaut32/tests: Use IMallocSpy to test VariantClear(VT_RECORD).
by Kevin Puetz (＠puetzk) Sept. 9, 2025

Sept. 9, 2025

Salvage tests and fix a leak found in another review: see https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9175 points 1 and 2. 3. is why !897 was reverted. This does not contain the (incorrect) changes to VariantCopyInd, but instead fixes the leak identified in VariantClear (VT_RECORD needs to free pvRecord), and the wrong allocator being used in VariantCopy (it should have been IMalloc, rather than `HeapAlloc`, as shown by the fact IMallocSpy observes these allocations). This also cleans up some dubious behavior by the test IRecordInfoImpl, which was modifying a VARIANT that it did not own or receive as an argument in the middle of VariantClear. This was likely undefined behavior, and in any case concealed the heap leak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1035

4 12

Re: [PATCH v2 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Reinhold Gschweicher (＠neroburner) Sept. 9, 2025

Sept. 9, 2025

rebased onto 3cfbf9e3cd99dd01d3215c6952ae18ce88207d22 which fixes the pipelines :tada: Updated WineTestBot run (all green :white_check_mark: ): https://testbot.winehq.org/JobDetails.pl?Key=159816 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115416

1 0

[PATCH v15 0/6] MR8829: windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance().
by Mohamad Al-Jaf (＠maljaf) Sept. 9, 2025

Sept. 9, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v15: windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). windows.media.playback.backgroundmediaplayer: Add IBackgroundMediaPlayerStatics stub. include: Add IMediaPlayer definition. widl: Support additional deprecated declarations. windows.media.playback.backgroundmediaplayer: Add stub dll. include: Add windows.media.playback.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

3 10

[PATCH v4 0/5] MR8922: win32u/tests: Test D3DKMT object creation and sharing.
by Rémi Bernon Sept. 9, 2025

Sept. 9, 2025

-- v4: win32u/tests: Test D3DKMT objects NT handle sharing. win32u/tests: Test D3DKMT allocation object creation. win32u/tests: Test D3DKMT keyed mutex object creation. win32u/tests: Test D3DKMT synchronization object creation. win32u: Stub NtGdiDdDDIOpenNtHandleFromName. https://gitlab.winehq.org/wine/wine/-/merge_requests/8922

1 6

[PATCH v2 0/7] MR8934: win32u: Hook VK_KHR_external_(semaphore|fence)_win32 related functions.
by Rémi Bernon Sept. 9, 2025

Sept. 9, 2025

-- v2: win32u: Hook VK_KHR_external_fence_win32 related functions. win32u: Hook VK_KHR_external_semaphore_win32 related functions. win32u: Hook VK_KHR_win32_keyed_mutex related functions. win32u: Hook vkQueueSubmit and vkQueueSubmit2 functions. winevulkan: Move command buffer wrapper to vulkan_driver.h. winevulkan: Force copying the VkSubmitInfo(2) struct chains. winevulkan: Force copying wrapped handle arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8934

1 7

[PATCH v2 0/1] MR8918: wineboot: Fix a memory leak in create_computer_name_keys.
by Alex Henrie (＠alexhenrie) Sept. 9, 2025

Sept. 9, 2025

If the canonical hostname was "localhost", the address info was not freed. Don't bother checking whether ai_canonname is NULL because if there is no canonical name, getaddrinfo must set ai_canonname to the input name. Fixes: ca5a6d07dc92ba631b178ec175e6b3fd5295e3d6 -- v2: wineboot: Fix a memory leak in create_computer_name_keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/8918

2 2

[PATCH 0/1] MR8918: wineboot: Fix a memory leak in create_computer_name_keys.
by Alex Henrie (＠alexhenrie) Sept. 9, 2025

Sept. 9, 2025

If the canonical hostname was "localhost", the address info was not freed. Also, since we're touching the same line that defines the address info hints, make the hints `static const` so that the compiler knows it's safe to put them in read-only memory if it wants. Fixes: ca5a6d07dc92ba631b178ec175e6b3fd5295e3d6 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8918

4 7

Re: [PATCH v4 0/7] MR8749: wintypes: Implement a generic IMap<HSTRING, IInspectable>. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8749

1 0

Re: [PATCH v2 0/1] MR8924: oleaut32: Fix UDT record block leak in VariantClear(). - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8924

1 0

Re: [PATCH v2 0/5] MR8923: windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8923

1 0

Re: [PATCH v2 0/3] MR8921: win32u: Fix missing NULL initialization of NtAllocateVirtualMemory parameter. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8921

1 0

Re: [PATCH v2 0/1] MR8919: ntdll: Fix the build of check_invalid_gsbase() on FreeBSD - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8919

1 0

Re: [PATCH v2 0/1] MR8917: gdi32: From Windows 2000 FixBrushOrgEx() is a NOP. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8917

1 0

Re: [PATCH v3 0/4] MR8401: gdi32: Use the maximum number of colours when biClrUsed is zero. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8401

1 0

Re: [PATCH v2 0/1] MR8913: iphlpapi: Add stub for GetPerTcp6ConnectionEStats. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8913

1 0

Re: [PATCH v5 0/1] MR4820: dlls/winmm: waveOutGetID: Return correct id for WAVE_MAPPER. - approved
by Alexandre Julliard (＠julliard) Sept. 8, 2025

Sept. 8, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4820

1 0

[PATCH v3 0/5] MR8905: mshtml: Implement toJSON() for Performance* objects.
by Gabriel Ivăncescu Sept. 8, 2025

Sept. 8, 2025

-- v3: mshtml: Implement toJSON() for Performance. mshtml: Implement toJSON() for PerformanceNavigation. mshtml: Implement toJSON() for PerformanceTiming. mshtml: Don't expose toString from Performance* objects' prototypes in mshtml: Expose toJSON only in IE9+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/8905

2 6

[PATCH v12 0/10] MR7797: Draft: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) Sept. 8, 2025

Sept. 8, 2025

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v12: ntoskrnl/tests: Use the 'Nt' version of the CancelIo APIs. ntoskrnl/tests: Test the thread ID the cancellation routine runs from. ntoskrnl/tests: Add more cancellation tests. ntoskrnl/tests: Fix tests on current Windows 10 / 11. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile(). server: Factor out a cancel_async() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 12