- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR7447: oleaut32: Implement (S|G)etVarConversionLocaleSetting()
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

Partial, as per documentation, implement fixing as the default locale. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Implement (S|G)etVarConversionLocaleSetting() https://gitlab.winehq.org/wine/wine/-/merge_requests/7447

3 2

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Test commit should go first, with todo's. Second commit will then remove todo's. Note that there are whitespace warnings when applying patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115153

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > if (open_classes_key(HKEY_CLASSES_ROOT, buf, MAXIMUM_ALLOWED, &xhkey)) > { > - free(buf); > - WARN("couldn't open key for ProgID %s\n", debugstr_w(progid)); > - return CO_E_CLASSSTRING; > + lstrcpyW(buf, progid); > + lstrcatW(buf, L"\\CurVer"); > + if (RegQueryValueW(HKEY_CLASSES_ROOT, buf, buf3, &buf3len)) > + { > + free(buf); > + WARN("couldn't query CurVer value for ProgID %s\n", debugstr_w(progid)); > + return CO_E_CLASSSTRING; > + } > + > + lstrcpyW(buf, buf3); > + lstrcatW(buf, L"\\CLSID"); Size of 'buf' has no relation to size of 'buf3', so you can't assume you can copy things and not overrun it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115152

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > > static HRESULT clsid_from_string_reg(LPCOLESTR progid, CLSID *clsid) > { > - WCHAR buf2[CHARS_IN_GUID]; > + WCHAR buf2[CHARS_IN_GUID],buf3[CHARS_IN_GUID]; > LONG buf2len = sizeof(buf2); > + LONG buf3len = sizeof(buf3); Those should be renamed to something more intuitive. Also buf3 here does not contain a stringified GUID but ProgID, so using CHARS_IN_GUID length is incorrect. What happens if ProgID referenced with CurVer itself contains another CurVer, is it followed? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115151

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ This comment does not belong to this new test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115150

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) Sept. 7, 2025

Sept. 7, 2025

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ > + StringFromGUID2(&CLSID_non_existent, clsidstr, ARRAYSIZE(clsidstr)); > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest\\CurVer", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)L"MyApp.DocumentTest.1", (wcslen(L"MyApp.DocumentTest.1") + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest.1\\CLSID", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)clsidstr, (wcslen(clsidstr) + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + hr = CLSIDFromProgID(L"MyApp.DocumentTest", &clsid); > + ok(hr == S_OK, "CLSIDFromProgID failed with error 0x%08lx\n", hr); > + ok(IsEqualCLSID(&clsid, &CLSID_non_existent), "got wrong clsid %s\n", wine_dbgstr_guid(&clsid)); This needs a test for when both CurVer and CLSID are present. The test should clean up entries it creates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115149

1 0

[PATCH v3 0/1] MR8650: urlmon/tests: fixed argument size passed to GetTempPathW
by Marcus Meissner (＠msmeissn) Sept. 7, 2025

Sept. 7, 2025

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- v3: urlmon/tests: fixed argument size passed to GetTempPathW https://gitlab.winehq.org/wine/wine/-/merge_requests/8650

3 3

[PATCH v4 0/3] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v4: dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

3 5

[PATCH v3 0/10] MR7449: oleaut32: Fix methods relating typeinfo substructures around names, guids and friends
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

- Clean up method implementations to be consistent and pass tests. - Factor out common code. - Validate arguments. - Correctly match szNameBuf user passed strings as case-insensitive as per documentation. - Match method parameter identifiers to be as per documentation. - Rewrite where required to use common helpers. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Factor out TLB_get_typeinfo_by_guid() https://gitlab.winehq.org/wine/wine/-/merge_requests/7449

3 12

[PATCH v11 0/24] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v11: dlls/oleaut32: ptr_size should be a ULONG This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

2 2

[PATCH v7 0/2] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) Sept. 7, 2025

Sept. 7, 2025

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v7: win32u: Fix ExtCreateRegion when parameters are wrong. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

4 6

[PATCH 0/1] MR8917: gdi32: From Windows 2000 FixBrushOrgEx() is a NOP.
by Huw Davies (＠huw) Sept. 7, 2025

Sept. 7, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8917

2 2

[PATCH v2 0/4] MR8401: gdi32: Use the maximum number of colours when biClrUsed is zero.
by Zhiyi Zhang (＠zhiyi) Sept. 7, 2025

Sept. 7, 2025

Fix a regression from 225004e1. According to MSDN, if the biClrUsed field is zero, the bitmap should use the maximum number of colours corresponding to the value of the biBitCount member for the compression mode specified by biCompression. -- v2: Revert "wineps: Use the correct colours when a monochrome bitmap without a colour table is the source." gdi32/tests: Test recording SetDIBitsToDevice() for bitmaps with zero biClrUsed field in EMFs. gdi32/tests: Test recording StretchDIBits() for bitmaps with zero biClrUsed field in EMFs. https://gitlab.winehq.org/wine/wine/-/merge_requests/8401

3 7

[PATCH 0/1] MR8913: iphlpapi: Add stub for GetPerTcp6ConnectionEStats.
by Louis Lenders (＠xe) Sept. 7, 2025

Sept. 7, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58635 This fixes the follow-up bug in CapCut: after clicking "Create Project" there's a crash into unimplemented call to GetPerTcp6ConnectionEStats. With this patch in place bug 58635 is fixed, no more craches appear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8913

3 2

[PATCH v4 0/1] MR4820: dlls/winmm: waveOutGetID: Return correct id for WAVE_MAPPER.
by Carlo Bramini (＠carlo-bramini) Sept. 7, 2025

Sept. 7, 2025

Fixes bug 52592. https://bugs.winehq.org/show_bug.cgi?id=52592 -- v4: dlls/winmm: waveOutGetID: Return correct id for WAVE_MAPPER. https://gitlab.winehq.org/wine/wine/-/merge_requests/4820

3 2

[PATCH 0/1] MR8915: d3dx10_33/tests: Enable tests.
by Matteo Bruni (＠Mystral) Sept. 6, 2025

Sept. 6, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8915

2 1

Re: [PATCH v3 0/4] MR8908: wbemprox: Add MSFT_PhysicalDisk table and improve class_object_Next().
by Bernhard Übelacker Sept. 6, 2025

Sept. 6, 2025

@gofman, that uint16 patch probably silences also an [ASan complaint](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-…, which I did not dare to [submit a patch](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_w… for yet, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8908#note_115056

1 0

[PATCH v4 0/2] MR8862: mmdevapi/tests: Rewrite capturing tests.
by Giovanni Mascellani (＠giomasce) Sept. 6, 2025

Sept. 6, 2025

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916) and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- v4: mmdevapi/tests: Remove a flaky test. https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

3 4

Re: [PATCH v5 0/1] MR7529: msxml3: Correct looping of Document Element properties. - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7529

1 0

Re: [PATCH v2 0/7] MR8900: Comment or define undefined WinRT member interfaces (2/2) - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8900

1 0

Re: [PATCH v3 0/4] MR8908: wbemprox: Add MSFT_PhysicalDisk table and improve class_object_Next(). - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8908

1 0

Re: [PATCH v4 0/8] MR8705: d3dx10: Exclusively use shared code to implement get_image_info(). - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8705

1 0

Re: [PATCH v2 0/1] MR8912: msi: Allow pre-2.0 assemblies to be installed using 2.0 fusion. - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8912

1 0

Re: [PATCH v4 0/1] MR8838: iphlpapi: Add stub for SetPerTcp6ConnectionEStats. - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8838

1 0

Re: [PATCH v4 0/6] MR8909: win32u: Hook VK_KHR_external_memory_win32 functions. - approved
by Alexandre Julliard (＠julliard) Sept. 5, 2025

Sept. 5, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8909

1 0