- Wine-GitLab - list.winehq.org

[PATCH v5 0/2] MR10451: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED
by Piotr Pawłowski (＠DEATH) April 14, 2026

April 14, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59456 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55707 -- v5: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED https://gitlab.winehq.org/wine/wine/-/merge_requests/10451

3 10

Re: [PATCH v11 0/3] MR10225: libs/xml2: Tolerate embedded XML declarations inside elements.
by Lucas Persson (＠luben93) April 14, 2026

April 14, 2026

sure i can have a look if i get further now, you found the correct installers. i was using this harness to setup the correct env vars to get the installer to render https://gitlab.winehq.org/-/snippets/34 last time i got to ![Screenshot_20260414_154327-2.png](/uploads/6840a95c6f745e703e24dde64df515b4/Screenshot_20260414_154327-2.png){width=333 height=532} when testing, this was the deepest i got in the install process with ``` ACCCx5_2_1_441 ``` and i also got stuck at a similar screen on the same error code, but with the newer web rendered ``` ACCCx5_5_0_617 ``` for the new webrendered screen i needed to manually download `msedgewebview2` from some microsoft update site i can also find some logs if that helps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10225#note_136087

1 0

[PATCH v8 0/4] MR10611: LPC: Implement proper LPC system
by Rose Hellsing (＠axtlos) April 14, 2026

April 14, 2026

Until now, LPC was just a stub, any application that relied on LPC for communication would fail. This change implements parts of LPC, to allow for IPC between programs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=30069 - fully fixed, sqlservr is able to run as expected Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59494 - partially fixed, starmoney doesn't flat out crash anymore, but it doesn't start fully, possibly because it uses the ALPC system which was introduced in Windows Vista, the version Starmoney 10 was advertised for -- v8: wow64: Implement LPC port wrappers and remove todo_wine from tests https://gitlab.winehq.org/wine/wine/-/merge_requests/10611

2 4

[PATCH v4 0/2] MR10451: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED
by Piotr Pawłowski (＠DEATH) April 14, 2026

April 14, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59456 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55707 -- v4: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED comctl32/tests/treeview: Enabled test_select() for comctl32 v6, made test for TVN_ITEMCHANGING & TVN_ITEMCHANGED https://gitlab.winehq.org/wine/wine/-/merge_requests/10451

2 2

[PATCH v3 0/2] MR10451: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED
by Piotr Pawłowski (＠DEATH) April 14, 2026

April 14, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59456 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55707 -- v3: comctl32/treeview: Implemented TVN_ITEMCHANGING & TVN_ITEMCHANGED comctl32/tests/treeview: Enabled test_select() for comctl32 v6, made test for TVN_ITEMCHANGING & TVN_ITEMCHANGED https://gitlab.winehq.org/wine/wine/-/merge_requests/10451

3 13

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 14, 2026

April 14, 2026

On Tue Apr 14 10:17:24 2026 +0000, Rémi Bernon wrote: > Are we truly confident that this should be a per-thread list of pointer > (and I assume, later, frame history)? If there isn't already we will > need tests to make sure it is and that querying pointer info and pointer > history from a thread that has never processed any message indeed > returns an error. Fwiw we already maintain a list of pointers on > wineserver side, I suspect it should perhaps work globally instead. i'm pretty sure, we have two tests, `test_NtUserGetPointerInfoList_thread` and `test_GetPointerInfo_thread`, both spawn a thread after already receiving pointer events on the main thread, create a new window, and expect to get no pointer info at all additionally the docs say: > If the calling thread does not own the window to which the pointer message has been delivered, this function fails with the last error set to ERROR_ACCESS_DENIED. Note that this may be the window to which the input was originally delivered or it may be a window to which the message was forwarded. (though i am yet to see it throw an ACCESS_DENIED instead of NOACCESS or INVALID_PARAMETER, i'm guessing some specialcasing for MouseInPointer) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136057

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 14, 2026

April 14, 2026

On Tue Apr 14 10:17:23 2026 +0000, Rémi Bernon wrote: > It will probably need to be done without adding todo_wine, these tests > more or less closely mimic some application calls, and it will break > what currently works if these tests don't pass anymore. the two todos on success status (lines user32/tests/input.c:5419 and win32u/tests/win32u.c:1810) are because X11 is sending a EnterNotify event when windows open (even though we set the cursor position to 500, 500, outside the window bounds) which winex11.drv converts into a mouse event, that then becomes a pointer event, so we end up with a pointer in history that we shouldn't really --- the todos on GetLastError is because i can't really tell yet what causes INVALID_PARAMETER versus NOACCESS -- as per win32u/tests/win32u.c:1872..1890 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136056

1 0

[PATCH v2 0/1] MR10591: winebth.sys: Support building with dbus older than 1.12.
by Vitaly Lipatov (＠lav) April 14, 2026

April 14, 2026

DBUS_MESSAGE_ITER_INIT_CLOSED and dbus_message_iter_abandon_container_if_open were added in dbus 1.12. Provide a fallback definition for the macro and load the function optionally via dlsym to allow building on systems with older dbus. -- v2: winebth.sys: Support building with dbus older than 1.12. https://gitlab.winehq.org/wine/wine/-/merge_requests/10591

2 2

[PATCH v9 0/5] MR9992: Draft: Introduce ImeToAsciiEx() user driver function for use in winemac
by Marc-Aurel Zent (＠mzent) April 14, 2026

April 14, 2026

-- v9: win32u: Remove builtin WINE_IME_PROCESS_KEY driver call. winemac: Move macdrv_ImeProcessKey logic to ImeProcessKey and macdrv_ImeToAsciiEx. winemac: Implement and use macdrv_ImeToAsciiEx(). win32u: Move IME processing to ImeToAsciiEx. win32u: Introduce new ImeToAsciiEx user driver call. https://gitlab.winehq.org/wine/wine/-/merge_requests/9992

3 9

[PATCH v7 0/1] MR10589: vbscript: Add missing runtime error constants and tests.
by Francis De Brabandere (＠francisdb) April 14, 2026

April 14, 2026

Add VBSE_DUPLICATE_KEY (457) and VBSE_CLASS_NOT_DEFINED (506) error code definitions with their string resources, and add tests for runtime errors 11, 94, 429, 451, 457, and 506. Errors 94 and 506 are marked todo_wine as Wine currently returns incorrect error codes for those cases. Error 28 (out of stack space) is included commented out as Wine crashes with a stack overflow instead of raising the error. -- v7: vbscript: Add missing runtime error constants and tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10589

2 1

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > + return pointer; > +} > + > +static struct pointer *find_pointerid(UINT32 id) { > + struct pointer_thread_data *thread_data = get_pointer_thread_data(); > + struct pointer *pointer; > + > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} Are we truly confident that this should be a per-thread list of pointer (and I assume, later, frame history)? If there isn't already we will need tests to make sure it is and that querying pointer info and pointer history from a thread that has never processed any message indeed returns an error. Fwiw we already maintain a list of pointers on wineserver side, I suspect it should perhaps work globally instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136039

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} > + > +static POINT pixel_to_himetric(POINT px) { > + UINT dpi = HIMETRIC / get_system_dpi(); > + > + return (POINT) { > + .x = px.x * dpi, > + .y = px.y * dpi, > + }; We don't use these constructs in Wine yet. It's perhaps acceptable to introduce new usages but it will only make it more difficult to get your patches accepted if you add extra portability questions to be considered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136038

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > +#define HIMETRIC 2540 > + > +static LONG last_frame = 0; > + > +struct pointer { > + UINT32 id; > + struct list entry; > + POINTER_INPUT_TYPE type; > + POINTER_INFO info; > +}; > + > +struct pointer_thread_data { > + struct list known_pointers; > +}; > + There's various style inconsistencies, it will need to be fixed to match win32u code style (spaces in paren, allman braces, etc...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136037

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/user32/tests/input.c: > > memset( &pointer_info, 0xcd, sizeof(pointer_info) ); > ret = pGetPointerInfo( 1, &pointer_info ); > + todo_wine > ok( !ret, "GetPointerInfo succeeded\n" ); > + todo_wine > ok( GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError() ); It will probably need to be done without adding todo_wine, these tests more or less closely mimic some application calls, and it will break what currently works if these tests don't pass anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136036

1 0

[PATCH 0/1] MR10657: cfgmgr32: Fix querying unnamed properties.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10657

2 1

[PATCH 0/1] MR10656: opengl32: Check for GL_EXT_memory_object_fd before filtering extensions.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Fixes: 97f2945b4ca7e3d72e9692592b373dd89b6003f9 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10656

2 1

[PATCH v5 0/1] MR7494: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value.
by Alistair Leslie-Hughes (＠alesliehughes) April 14, 2026

April 14, 2026

0024:trace:msxml:domdoc_put_preserveWhiteSpace (068F0520)->(1) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=21940 -- v5: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7494

2 1

[PATCH v3 0/2] MR10010: odbc32 asci fallbacks.
by Alistair Leslie-Hughes (＠alesliehughes) April 14, 2026

April 14, 2026

-- v3: odbc32: SQLPrepareW add ansi fallback odbc32: SQLNativeSqlW add ansi fallback https://gitlab.winehq.org/wine/wine/-/merge_requests/10010

2 2

[PATCH 0/3] MR10646: msxml3: Add support of GB2312.
by Jactry Zeng (＠jactry) April 14, 2026

April 14, 2026

Superseded MR !3928. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10646

3 9

[PATCH 0/1] MR10655: winecfg: Support 7.1 speaker config.
by Mohamad Al-Jaf (＠maljaf) April 13, 2026

April 13, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56664 ![winecfg-7.1](/uploads/19fe1fad54748bb3731bafa8f2288f45/winecfg-7.1.png){width=357 height=452} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10655

3 2

Re: [PATCH v2 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 13, 2026

April 13, 2026

On Tue Apr 14 03:14:19 2026 +0000, Yuxuan Shui wrote: > > ... by calling `IMF2DBuffer::Lock`. ... > Sorry, I meant `IMF2DBuffer::Lock2D` There really is no way to get pitch info from an `IMFMediaBuffer`, right? Am I missing something? Slight correction (and additional context) to my comment: The video I used to test is a 162x120 video. If I set the output pixel format to YV12: - When locked with `IMFMediaBuffer_Lock`, the Y plane size is 176x128, clearly aligned up to 16 bytes. - When locked with `IMF2DBuffer2_Lock2DSize`, the returned pitch is 256 bytes and Y plane size is 256x128. So if `IMF2DBuffer` is not available, how does a game figure out what the real pitch of the buffer returned by `IMFMediaBuffer_Lock` is? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654#note_136016

1 0

Re: [PATCH v2 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 13, 2026

April 13, 2026

> ... by calling `IMF2DBuffer::Lock`. ... Sorry, I meant `IMF2DBuffer::Lock2D` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654#note_136015

1 0

[PATCH 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 13, 2026

April 13, 2026

YV12, NV12, I420 formats has min alignment of 2 bytes for Y plane stride on native, but winegstreamer uses 4 bytes. Additionally YV12 and I420 expect U and V plane stride to be exactly 1/2 of the Y plane stride, yet winegstreamer also aligns those to 4 bytes. This breaks some games. This commit adds a custom buffer pool to wg_parser which affords us control over what stride to use, just like wg_transform. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654

2 5

[PATCH 0/1] MR10653: gdiplus: Assume bitmaps are top-down in image-reading code.
by Esme Povirk (＠madewokherd) April 13, 2026

April 13, 2026

Noticed when looking at https://bugs.winehq.org/show_bug.cgi?id=40409, but I don't think this noticeably improves performance. Still, it cuts down on some extra work and simplifies the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10653

2 1

[PATCH 0/5] MR10652: gdiplus: Rewrite GdipCreateBitmapFromGdiDib.
by Esme Povirk (＠madewokherd) April 13, 2026

April 13, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40409 The main thing that changes here is that we reference bits directly instead of copying to an intermediate HBITMAP. Most of the tests are to make sure we don't regress anything by parsing BITMAPINFOHEADER directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10652

2 5