- Wine-GitLab - list.winehq.org

[PATCH v17 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) April 13, 2026

April 13, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v17: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling ntdll: Block SIGUSR1 when the thread context is being modified ntdll: Fix thread stops inside __wine_syscall_dispatcher https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

4 10

[PATCH v36 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v36: imagehlp: Fix ImageGetDigestStream https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v35 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v35: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v34 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v34: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 3

[PATCH v4 0/1] MR10340: comctl32/tooltips: suppress icon and title when title is NULL or empty.
by Larry Starr (＠starrl) April 13, 2026

April 13, 2026

Per MSDN, TTM_SETTITLE with a NULL or empty title string should suppress both the title row and any associated icon. Previously an empty string was treated the same as a non-empty title, causing the icon to still be displayed and the tooltip to be incorrectly sized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58236 Signed-off-by: Larry Starr <Larry_A_Starr(a)yahoo.com> -- v4: comctl32/tooltips: suppress icon and title when title is NULL or empty. https://gitlab.winehq.org/wine/wine/-/merge_requests/10340

3 8

[PATCH v5 0/8] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Jan Robert Gerigk (＠RgSg86) April 13, 2026

April 13, 2026

Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=59604 Implement CM_Get_Parent by storing device tree relationship properties when ntoskrnl enumerates child devices via IRP_MN_QUERY_DEVICE_RELATIONS: - DEVPKEY_Device_Parent on each child device - DEVPKEY_Device_Children on the parent device - DEVPKEY_Device_Siblings on each child device CM_Get_Parent reads DEVPKEY_Device_Parent through SetupDiGetDevicePropertyW. Also fix SETUPDI_EnumerateMatchingInterfaces to remove devices without interfaces from DIGCF_DEVICEINTERFACE enumeration results. --\> no more phantom devices Based on discussion with Rémi Bernon (Bug 59604) Tested on a fresh Wine 11.6 setup with KNX ETS 6.4.1: A USB HID license dongle (VID 2A07, PID 0102) is now correctly identified through CM_Get_Parent device tree navigation. -- v5: ntoskrnl/tests: Add DEVPKEY_Device_Parent test. setupapi/tests: Add CM_Get_Parent tests. cfgmgr32: Implement CM_Get_Parent using DEVPKEY_Device_Parent property. cfgmgr32: Read device properties stored as registry subkeys. https://gitlab.winehq.org/wine/wine/-/merge_requests/10604

2 8

[PATCH v4 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 13, 2026

April 13, 2026

-- v4: win32u: Implement NtUserGetPointerInfoList. win32u: Update pointerid 1 from mouse_in_pointer events. win32u: Implement NtUserGetPointerType. win32u: Keep track of pointer types. win32u: Preallocate pointerId 1 for the mouse pointer. win32u: Keep per-thread list of known pointers. win32u: Move process_pointer_message to pointer.c. win32u: Implement NtUserGetPointerDeviceRects for INVALID_HANDLE_VALUE. https://gitlab.winehq.org/wine/wine/-/merge_requests/10649

2 10

[PATCH v3 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 13, 2026

April 13, 2026

-- v3: win32u: Implement NtUserGetPointerInfoList. win32u: Update pointerid 1 from mouse_in_pointer events. win32u: Implement NtUserGetPointerType. win32u: Keep track of pointer types. win32u: Preallocate pointerId 1 for the mouse pointer. win32u: Keep per-thread list of known pointers. win32u: Move process_pointer_message to pointer.c. win32u: Implement NtUserGetPointerDeviceRects for INVALID_HANDLE_VALUE. https://gitlab.winehq.org/wine/wine/-/merge_requests/10649

2 10

[PATCH v2 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 13, 2026

April 13, 2026

-- v2: win32u: Implement NtUserGetPointerInfoList. win32u: Update pointerid 1 from mouse_in_pointer events. https://gitlab.winehq.org/wine/wine/-/merge_requests/10649

2 10

[PATCH 0/2] MR10625: mountmgr.sys, ntdll: Fall back to statfs if "important" free space is 0 on macOS.
by Tim Clem (＠tclem) April 13, 2026

April 13, 2026

CFURLCopyResourcePropertyForKey(kCFURLVolumeAvailableCapacityForImportantUsageKey) fails silently and returns 0 free bytes if the volume is not APFS. --- If the volume actually does have no free space, statfs will concur, and we should fall back to it. Thanks to Dean Greer for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10625

3 3

[PATCH v2 0/1] MR10648: sechost: Catch invalid HDEVNOTIFY arguments to I_ScUnregisterDeviceNotification.
by Tim Clem (＠tclem) April 13, 2026

April 13, 2026

Steam has started unregistering an invalid handle on shutdown, resulting in a crash. On native, invalid handles are detected. I independently tested that these errors are caught at the sechost level, not just in user32. Native distinguishes between valid pointers that are not valid HDEVNOTIFYs and access violations, so I added a magic value to the struct so we can detect that scenario. -- v2: sechost: Catch invalid HDEVNOTIFY arguments to I_ScUnregisterDeviceNotification. https://gitlab.winehq.org/wine/wine/-/merge_requests/10648

2 1

[PATCH 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) April 13, 2026

April 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649

2 10

[PATCH 0/8] MR10643: amstream: Test and fix QueryAccept on ddraw stream.
by Brendan McGrath (＠redmcg) April 13, 2026

April 13, 2026

This MR adds a number of new tests for the `IPin::QueryAccept` function on the Direct Draw media stream. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10643

3 9

[PATCH 0/1] MR10648: sechost: Catch invalid HDEVNOTIFY arguments to I_ScUnregisterDeviceNotification.
by Tim Clem (＠tclem) April 13, 2026

April 13, 2026

Steam has started unregistering an invalid handle on shutdown, resulting in a crash. On native, invalid handles are detected. I independently tested that these errors are caught at the sechost level, not just in user32. Perhaps the magic value is overkill, but we do it in some similar situations and it felt better than attempting to immediately dive into the list entry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10648

2 1

[PATCH v21 0/1] MR10244: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) April 13, 2026

April 13, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts ~~There are still quite some compiler issues left but~~ this addresses the biggest parser issues. -- v21: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

Re: [PATCH v4 0/8] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Elizabeth Figura (＠zfigura) April 13, 2026

April 13, 2026

Thanks for bearing with feedback, I apologize that it was a lot. > While switching to cfgmgr32 s internal APIs (devnode_get_device + get_device_property), I found that query_property cannot read properties stored by SetupDiSetDevicePropertyW. It tries to read them as flat value names, but setupapi stores them as registry subkey hierarchies (Properties{GUID}\\XXXX with the data in the default value). Added a fallback to open the property subkey when the flat lookup fails. I don't think it should be a fallback, rather the cfgmgr32 behaviour just sounds wrong and should be fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_135977

1 0

[PATCH 0/1] MR10647: configure: Use alsa library search paths in the alsa library check.
by Matteo Bruni (＠Mystral) April 13, 2026

April 13, 2026

Fixes the alsa-lib check on FreeBSD. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10647

2 1

[PATCH 0/8] MR10645: mf/topology_loader: Insert optional nodes after each branch is connected.
by Conor McCarthy (＠cmccarthy) April 13, 2026

April 13, 2026

New tests show each optional node is connected after the nodes on either side are connected. This is an issue in the game Psycho Sleuth (at least in the demo) because it uses a transform which must have its input types enumerated before it will work correctly. This occurs when a decoder is inserted before the transform, but an optional node lies immediately upstream of the transform, and if optional nodes are not handled correctly, the decoder is initially connected to the optional instead of being inserted later. A couple of other issues revealed while making new tests are fixed here too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10645

2 8

[PATCH v3 0/4] MR10624: odbc32: Add odbc v3 test driver and use it in tests.
by Piotr Caban (＠piotr) April 13, 2026

April 13, 2026

-- v3: odbc32: Use test driver in SQLExecDirect tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10624

3 5

[PATCH 0/1] MR10644: include: Don't use _MSC_VER if it isn't defined.
by Rémi Bernon (＠rbernon) April 13, 2026

April 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10644

3 7

[PATCH v2 0/4] MR10624: odbc32: Add odbc v3 test driver and use it in tests.
by Piotr Caban (＠piotr) April 13, 2026

April 13, 2026

-- v2: odbc32: Use test driver in SQLExecDirect tests. odbc32: Use test driver in SQLBrowseConnect tests. odbc32: Use test driver in SQLDriverConnect tests. odbc32: Add odbc v3 test driver and use it in SQLConnect tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10624

2 5

[PATCH 0/3] MR10487: winewayland: Fix display freeze for games that fake-minimize
by Cooper Morgan (＠Cwooper) April 13, 2026

April 13, 2026

CryEngine games (e.g., Hunt: Showdown) fake-minimize during startup in exclusive fullscreen by setting WS_MINIMIZE and moving to (-32000,-32000). The driver sent xdg_toplevel_unset_fullscreen, causing the compositor to respond with a 0x0 configure that the surface never recovered from. - Fix a use-after-release on data-\>rects in wayland_configure_window - Detect WS_MINIMIZE and call xdg_toplevel_set_minimized instead of unsetting fullscreen/maximized - Handle restore by acking the configure and sending SC_RESTORE when the window is at the sentinel position with WS_MINIMIZE set Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=59577 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10487

3 6

[PATCH 0/4] MR10624: odbc32: Add odbc v3 test driver and use it in tests.
by Piotr Caban (＠piotr) April 13, 2026

April 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10624

3 6

[PATCH v4 0/3] MR10364: dinput: Add support for generating consistent guidInstance values for devices.
by Connor McAdams (＠cmcadams) April 13, 2026

April 13, 2026

This MR adds support for creating `guidInstance` values for joystick devices in a way that matches native behavior. Our current method of creating a `guidInstance` value uses the device's rawinput handle, which changes each time a controller is plugged in. Fixes a bug in Rocket League where a controller plug/unplug cycle results in a new controller being detected each time. The process is like this: - Controller is connected, the game gets its `guidInstance` value from `EnumDevices()`, stores it and associates it with player 1. - Controller is disconnected. - The same controller is reconnected, the game calls `EnumDevices()`, and finds a new `guidInstance` value. - It then assumes this is a new controller, creates a new player, and behaves as though player 1's controller is unplugged. This MR implements `guidInstance` in a way that matches native, and ensures that the `guidInstance` value remains consistent. Doing things this way also makes it easier to add support for `DIPROP_JOYSTICKID` and `GUID_Joystick` in a future MR. I've implemented those in a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/tree/WIP/dinput-instance-gu… using this system. -- v4: dinput: Properly implement guidInstance for joystick devices. dinput: Create registry entries for HID joysticks. dinput: Only pass instance name string to device_instance_is_disabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10364

3 12

[PATCH v2 0/3] MR10620: winex11: Serialize _NET_WM_FULLSCREEN_MONITORS changes by expecting a ConfigureNotify.
by Rémi Bernon (＠rbernon) April 13, 2026

April 13, 2026

When window has the _NET_WM_STATE_FULLSCREEN bit set. -- v2: winex11: Serialize _NET_WM_FULLSCREEN_MONITORS changes by expecting a ConfigureNotify. winex11: Update _NET_WM_FULLSCREEN_MONITORS before requesting _NET_WM_STATE_FULLSCREEN. winex11: Track actual _NET_WM_FULLSCREEN_MONITORS property updates. https://gitlab.winehq.org/wine/wine/-/merge_requests/10620

3 6