- Wine-GitLab - list.winehq.org

[PATCH v10 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i).
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Treat '(' after tEMPTYBRACKETS as an argument list opener in the lexer, so that expressions like GetArr()(0) or dict.Keys()(i) parse correctly. Also dereference VT_BYREF|VT_VARIANT results in vcall so chained indexing on call results works at runtime. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58051 This includes some of the work done in !10308, preferably that one is merged first. -- v10: vbscript: Support chained call syntax like dict.Keys()(i). https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

2 1

[PATCH v8 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i).
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Treat '(' after tEMPTYBRACKETS as an argument list opener in the lexer, so that expressions like GetArr()(0) or dict.Keys()(i) parse correctly. Also dereference VT_BYREF|VT_VARIANT results in vcall so chained indexing on call results works at runtime. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58051 This includes some of the work done in !10308, preferably that one is merged first. -- v8: vbscript: Support chained call syntax like dict.Keys()(i). https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

3 3

[PATCH v11 0/3] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with string resources and test entries. Fix 6 of the 12 tests by adding error productions for mismatched End keywords in blocks (1012, 1015, 1016, 1022, 1029, 1050). The remaining 6 tests (1006, 1007, 1040, 1052, 1058) are todo_wine pending further parser work. -- v11: vbscript: Return specific errors for unclosed parens, multiple defaults, and default on Property Let/Set. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

2 3

[PATCH v10 0/3] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with string resources and test entries. Fix 6 of the 12 tests by adding error productions for mismatched End keywords in blocks (1012, 1015, 1016, 1022, 1029, 1050). The remaining 6 tests (1006, 1007, 1040, 1052, 1058) are todo_wine pending further parser work. -- v10: vbscript: Return specific errors for unclosed parens, multiple defaults, and default on Property Let/Set. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

2 3

[PATCH v9 0/3] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with string resources and test entries. Fix 6 of the 12 tests by adding error productions for mismatched End keywords in blocks (1012, 1015, 1016, 1022, 1029, 1050). The remaining 6 tests (1006, 1007, 1040, 1052, 1058) are todo_wine pending further parser work. -- v9: vbscript: Return specific errors for unclosed parens, multiple defaults, and default on Property Let/Set. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

2 3

[PATCH v8 0/2] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with their string resources, and 12 todo_wine test entries covering the error codes that can be safely triggered. -- v8: vbscript: Return specific errors for mismatched End keywords in blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

2 2

Re: [PATCH v2 0/0] MR10601: Draft: oleaut32: Propagate dispatch errors from VARIANT_FromDisp. - closed
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

This merge request was closed by Francis De Brabandere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10601

1 0

Re: [PATCH v2 0/0] MR10601: Draft: oleaut32: Propagate dispatch errors from VARIANT_FromDisp.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Wrong assumptions, closing -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10601#note_135500

1 0

[PATCH 0/2] MR10603: win32u/freetype: fix tmExternalLeading for CFF fonts
by Arie Miller (＠Arimil) April 8, 2026

April 8, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on both Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width=801 height=600} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width=767 height=572} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `` GetTextMetricsA `` and `` GetTextMetricsW `` to point to a custom implementation that always set `` tmExternalLeading ``. The LLM determined that `` GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender) ``, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set \``` tmExternalLeading` `` to 0. The test case for this fix was LLM generated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

2 2

[PATCH v2 0/2] MR10577: Fix build with old clang (<13).
by Vitaly Lipatov (＠lav) April 8, 2026

April 8, 2026

When clang < 13 cross-compiles for Windows, it sets _MSC_VER to 1911 (< 1912). The #if/#elif chain in __config checked _MSC_VER < 1912 first, which prevented the elif branch from defining _LIBCPP_DEFER_NEW_TO_VCRUNTIME. This caused placement new/delete to be defined in both vcruntime_new.h and the libc++ <new> header, resulting in redefinition errors. Since Wine always provides aligned allocation operators in vcruntime_new.h, simply remove the _MSC_VER < 1912 cases and always define _LIBCPP_DEFER_NEW_TO_VCRUNTIME when using the Microsoft ABI with vcruntime. Also add fall back to the wmemchr() call or manual loop on clang < 13. -- v2: include: Avoid __builtin_wmemchr with clang < 13. include: Fix _LIBCPP_DEFER_NEW_TO_VCRUNTIME not being set with old clang. https://gitlab.winehq.org/wine/wine/-/merge_requests/10577

3 4

Re: [PATCH v4 0/1] MR10581: winealsa.drv: Simulate blocking calls midiOutLongMsg.
by Akihiro Sagawa (＠sgwaki) April 8, 2026

April 8, 2026

On Wed Apr 8 12:06:41 2026 +0000, Steven Don wrote: > That is correct. The corresponding `snd_rawmidi_drain()` in the Rawmidi > API would work, but Wine does not use the Rawmidi API, but the Sequencer > API. When using the sequencer, `snd_seq_ev_set_direct()` marks the SysEx > data for immediate out of band delivery (which is indeed preferable for > SysEx data) bypassing the output queue, but that also means > `snd_seq_drain_output()` and `snd_seq_sync_output_queue()` are ineffective. > For what it's worth, I also tried disabling the set-direct call and > adding the drain and sync calls, but there was no observable change in behaviour. Thanks for the explanation, I understand now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10581#note_135482

1 0

[PATCH 0/1] MR10601: oleaut32: Propagate dispatch errors from VARIANT_FromDisp.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

When IDispatch::Invoke(DISPID_VALUE) fails in VARIANT_FromDisp, propagate FACILITY_DISPATCH errors (like DISP_E_MEMBERNOTFOUND) instead of always replacing them with DISP_E_TYPEMISMATCH. This matches Windows behavior where accessing the default property of a dispatch object without one returns error 438 through VariantChangeType, not error 13. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10601

2 1

[PATCH v2 0/1] MR10598: winex11: Use unsigned long for monitor indices generation.
by Rémi Bernon (＠rbernon) April 8, 2026

April 8, 2026

Avoiding invisible padding in the structure that could make memcmp to constantly fail when comparing old / new values. -- v2: winex11: Use unsigned long for monitor indices generation. https://gitlab.winehq.org/wine/wine/-/merge_requests/10598

3 2

[PATCH 0/1] MR10598: winex11: Use unsigned long for monitor indices generation.
by Rémi Bernon (＠rbernon) April 8, 2026

April 8, 2026

Avoiding invisible padding in the structure that could make memcmp to constantly fail when comparing old / new values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10598

3 3

[PATCH v3 0/8] MR10599: msxml3/tests: Add some more xml() tests.
by Nikolay Sivov (＠nsivov) April 8, 2026

April 8, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: msxml3: Rework DOM API. https://gitlab.winehq.org/wine/wine/-/merge_requests/10599

2 9

Re: [PATCH v6 0/0] MR10374: vbscript: Throw proper error for undefined variables with Option Explicit.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

This was already fixed on master, nothing left here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10374#note_135471

1 0

Re: [PATCH v6 0/0] MR10374: vbscript: Throw proper error for undefined variables with Option Explicit. - closed
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

This merge request was closed by Francis De Brabandere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10374

1 0

[PATCH v11 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v11: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

[PATCH v4 0/1] MR10383: vbscript: Support element access on public array properties of class instances.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

On Windows, public array properties declared in a class (e.g. "Public arr(3)") can be accessed element-wise from outside the class using obj.arr(i) for both reading and writing. Wine failed to handle this because invoke_variant_prop() used V_ARRAY() which does not work for VT_ARRAY|VT_BYREF|VT_VARIANT arrays, and the property put path did not support indexed arguments at all. Fix both by adding a helper to extract the SAFEARRAY from either BYREF or direct array variants, and implementing indexed array element writes in the property put path. -- v4: vbscript: Support element access on public array properties of class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10383

2 1

[PATCH v2 0/1] MR10491: vbscript: Return error 1054 for Property Let/Set without arguments.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add error productions in PropertyDecl that detect when Property Let or Property Set is declared without a parameter list. Windows returns error 1054 (Property Let/Set needs at least one argument) in this case. Previously Wine fell through to the generic E_FAIL path, returning error code 16389. -- v2: vbscript: Return error 1054 for Property Let/Set without arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/10491

2 1

[PATCH v3 0/1] MR10495: Draft: vbscript: Return error 1010 for keyword used where identifier expected in Dim.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

When a reserved keyword like If appears after Dim where an identifier is expected (e.g. "Dim If"), Windows returns error 1010 ("expected identifier"). Add an error production in DimDeclList that sets the correct VBSE_EXPECTED_IDENTIFIER error code. -- v3: vbscript: Return error 1010 for keyword used where identifier expected in Dim. https://gitlab.winehq.org/wine/wine/-/merge_requests/10495

2 1

[PATCH v5 0/1] MR10493: vbscript: Return error 1048 for Property declaration outside a Class.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

When Property Get appears at global scope (outside a Class block), Windows returns error 1048 ("must be defined inside a Class"). Detect the tGET token in parser_error() — it is only valid after tPROPERTY inside a PropertyDecl, so encountering it at statement level means a Property was used outside a class context. -- v5: vbscript: Return error 1048 for Property declaration outside a Class. https://gitlab.winehq.org/wine/wine/-/merge_requests/10493

2 1

[PATCH v3 0/1] MR10510: vbscript: Implement byte-string functions LenB, LeftB, RightB, MidB, InStrB, AscB, and ChrB.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

These functions operate on raw bytes of the BSTR (UTF-16LE) data. Also fix InStrB registration to accept 2 args minimum, matching Windows. -- v3: vbscript: Implement byte-string functions LenB, LeftB, RightB, MidB, InStrB, AscB, and ChrB. https://gitlab.winehq.org/wine/wine/-/merge_requests/10510

2 1

[PATCH v2 0/1] MR10600: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

For VT_DISPATCH arguments, call the object's default property (DISPID_VALUE) to get a string value instead of returning the object via VariantCopy (Eval) or returning type mismatch (Execute/ ExecuteGlobal). This matches Windows behavior where passing a dispatch object without a default property fails with error 438, and objects with a default property have it invoked to obtain the string to evaluate or execute. -- v2: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10600

2 1

[PATCH v7 0/1] MR10588: vbscript: Add missing compiler error constants, messages, and todo tests.
by Francis De Brabandere (＠francisdb) April 8, 2026

April 8, 2026

Add 13 missing VBSE error code definitions (1006, 1007, 1012, 1015, 1016, 1022, 1029, 1030, 1040, 1050, 1051, 1052, 1058) with their string resources, and 12 todo_wine test entries covering the error codes that can be safely triggered. -- v7: vbscript: Add missing compiler error constants, messages, and todo tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10588

2 1