- Wine-GitLab - list.winehq.org

[PATCH 0/2] MR10785: msvcrt: Only reject negative timestamps with EINVAL in ctime_s
by Hendrik Borchardt (＠hborchardt) April 30, 2026

April 30, 2026

0 needs to be an allowed value, and negative values should not halt the program but just return EINVAL. This behavior has been observed with the following python script: ```python import ctypes ucrt = ctypes.CDLL("ucrtbase.dll") buf = ctypes.create_string_buffer(26) for i in [1, 0, -1]: print(f"_ctime64_s for time {i}:") t = ctypes.c_int64(i) err = ucrt._ctime64_s(buf, ctypes.c_size_t(26), ctypes.byref(t)) if err == 0: print(buf.value.decode()) else: print(f"Error: {err}") for i in [1, 0, -1]: print(f"_ctime32_s for time {i}:") t = ctypes.c_int32(i) err = ucrt._ctime32_s(buf, ctypes.c_size_t(26), ctypes.byref(t)) if err == 0: print(buf.value.decode()) else: print(f"Error: {err}") # _ctime64_s for time 1: # Thu Jan 1 01:00:01 1970 # # _ctime64_s for time 0: # Thu Jan 1 01:00:00 1970 # # _ctime64_s for time -1: # Error: 22 # # _ctime32_s for time 1: # Thu Jan 1 01:00:01 1970 # # _ctime32_s for time 0: # Thu Jan 1 01:00:00 1970 # # _ctime32_s for time -1: # Error: 22 ``` The bug https://bugs.winehq.org/show_bug.cgi?id=57261 is solved by this, because mongodb tries to pretty-print a 0 timestamp, and sets up its own invalid_parameter_handler, which crashes due to NULL arguments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10785

2 2

[PATCH v11 0/6] MR10775: vbscript: Fix and expand test coverage for BSTR comparison. (alternate)
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Alternate version of !10766 This replaces runtime VT_RESERVED tracking with compile-time is_literal_expr at the AST level: comparison opcodes (equal/nequal/gt/gteq/lt/lteq/case) carry a flag arg with bit 0 = left-literal, bit 1 = right-literal, and var_cmp dispatches on those flags. No runtime stripping, no OP_strip_reserved, and Const references stay non-literal because they're EXPR_MEMBER nodes even though the value is inlined. -- v11: vbscript: Reject Automation types not supported in VBScript on compare. https://gitlab.winehq.org/wine/wine/-/merge_requests/10775

2 7

[PATCH v55 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 30, 2026

April 30, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v55: imagehlp: Fix ImageGetDigestStream https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

3 4

[PATCH v10 0/5] MR10775: Draft: vbscript: Fix and expand test coverage for BSTR comparison. (alternate)
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Alternate version of !10766 This replaces runtime VT_RESERVED tracking with compile-time is_literal_expr at the AST level: comparison opcodes (equal/nequal/gt/gteq/lt/lteq/case) carry a flag arg with bit 0 = left-literal, bit 1 = right-literal, and var_cmp dispatches on those flags. No runtime stripping, no OP_strip_reserved, and Const references stay non-literal because they're EXPR_MEMBER nodes even though the value is inlined. -- v10: vbscript/tests: Cover BSTR comparison with dispatch-only numeric VTs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10775

2 5

[PATCH v9 0/5] MR10775: Draft: vbscript: Fix and expand test coverage for BSTR comparison. (alternate)
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Alternate version of !10766 This replaces runtime VT_RESERVED tracking with compile-time is_literal_expr at the AST level: comparison opcodes (equal/nequal/gt/gteq/lt/lteq/case) carry a flag arg with bit 0 = left-literal, bit 1 = right-literal, and var_cmp dispatches on those flags. No runtime stripping, no OP_strip_reserved, and Const references stay non-literal because they're EXPR_MEMBER nodes even though the value is inlined. -- v9: vbscript/tests: Cover BSTR comparison with dispatch-only numeric VTs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10775

2 5

[PATCH v7 0/1] MR10674: vbscript: Coerce VT_EMPTY operands before Var* calls.
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Native VBScript treats Empty as VT_I4 in And/Or/Xor/Eqv/Imp/Not and as VT_I2 in Mod. Pre-coerce in the interp_* handlers so the result types match and VarMod's VT_EMPTY→VT_I4 shortcut is bypassed. props to @jsm174 for finding this issue: https://github.com/vpinball/libwinevbs/commit/7e877fafe34483623ca33d26ab76f… -- v7: vbscript: Coerce VT_EMPTY operands before Var* calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/10674

2 1

[PATCH v12 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

VarAnd only inspected the non-Null operand one way and left V_BOOL/V_I4 uninitialized. VarImp treated VT_UI1 0xFF as VARIANT_TRUE (it isn't) and its VT_CY -1 check compared unscaled .int64 to -1 instead of -10000. props to @jsm174 for this one: https://github.com/vpinball/libwinevbs/commit/7e877fafe34483623ca33d26ab76f… -- v12: vbscript/tests: Add Null handling smoke tests for logical operators. vbscript: Match native UI1 Imp Null behavior. oleaut32: Fix VT_DATE Null handling in VarImp. oleaut32: Fix VT_CY Null handling in VarImp. oleaut32: Fix Null handling in VarAnd. https://gitlab.winehq.org/wine/wine/-/merge_requests/10673

2 5

[PATCH v6 0/1] MR10509: Draft: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

-- v6: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

2 1

[PATCH v18 0/4] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v18: vbscript: Pass script LCID to VariantChangeType in to_system_time helper. vbscript: Pass script LCID to VariantChangeType in to_string helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 5

[PATCH v8 0/5] MR10775: Draft: vbscript: Fix and expand test coverage for BSTR comparison. (alternate)
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Alternate version of !10766 This replaces runtime VT_RESERVED tracking with compile-time is_literal_expr at the AST level: comparison opcodes (equal/nequal/gt/gteq/lt/lteq/case) carry a flag arg with bit 0 = left-literal, bit 1 = right-literal, and var_cmp dispatches on those flags. No runtime stripping, no OP_strip_reserved, and Const references stay non-literal because they're EXPR_MEMBER nodes even though the value is inlined. -- v8: vbscript/tests: Cover BSTR comparison with dispatch-only numeric VTs. vbscript: Match native BSTR-vs-numeric and BSTR-vs-Boolean comparison. vbscript/tests: Cover BSTR comparison literal vs non-literal dispatch. vbscript/tests: Cover BSTR comparison with VT_BYREF and additional numeric VTs. vbscript/tests: Add coverage for BSTR vs numeric comparison. https://gitlab.winehq.org/wine/wine/-/merge_requests/10775

2 5

[PATCH v17 0/4] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v17: vbscript: Pass script LCID to VariantChangeType in to_system_time helper. vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

3 7

[PATCH v2 0/4] MR10755: dinput: Add proper support for DIPROP_JOYSTICKID and GUID_Joystick.
by Connor McAdams (＠cmcadams) April 30, 2026

April 30, 2026

This was also attempted in MR !6878. -- v2: dinput: Add support for GUID_Joystick. dinput/tests: Add tests for GUID_Joystick. dinput: Add support for DIPROP_JOYSTICKID. https://gitlab.winehq.org/wine/wine/-/merge_requests/10755

3 11

[PATCH v7 0/5] MR10775: Draft: vbscript: Fix and expand test coverage for BSTR comparison. (alternate)
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Alternate version of !10766 This replaces runtime VT_RESERVED tracking with compile-time is_literal_expr at the AST level: comparison opcodes (equal/nequal/gt/gteq/lt/lteq/case) carry a flag arg with bit 0 = left-literal, bit 1 = right-literal, and var_cmp dispatches on those flags. No runtime stripping, no OP_strip_reserved, and Const references stay non-literal because they're EXPR_MEMBER nodes even though the value is inlined. -- v7: vbscript/tests: Cover BSTR comparison with dispatch-only numeric VTs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10775

2 5

[PATCH v14 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v14: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

[PATCH 0/5] MR10784: opengl32: Test and fix the default framebuffer behavior.
by Rémi Bernon (＠rbernon) April 30, 2026

April 30, 2026

Query functions are broken when front buffer rendering emulation is used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10784

2 5

[PATCH v16 0/4] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v16: vbscript: Pass script LCID to VariantChangeType in to_system_time helper. vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

4 7

[PATCH v2 0/3] MR10783: vbscript: Match native semantics for empty parens on non-callable values
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Native VBScript distinguishes bare member access from with-parens access and rejects the latter on non-callable values: - `obj.scalarProp()` / `obj.arrayProp()` on a class instance variant property — error 5 (Invalid procedure call) - `x()` on a Dim scalar variable — error 13 (Type mismatch) - `arr()` on a Dim array — error 9 (Subscript out of range) -- v2: vbscript: Delegate do_icall is_call branch to variant_call. vbscript: Raise illegal-func-call on empty parens of class variant property. vbscript/tests: Cover empty parens on properties, Dim variables, and arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/10783

2 3

[PATCH 0/3] MR10783: vbscript: Match native semantics for empty parens on non-callable values
by Francis De Brabandere (＠francisdb) April 30, 2026

April 30, 2026

Native VBScript distinguishes bare member access from with-parens access and rejects the latter on non-callable values: - `obj.scalarProp()` / `obj.arrayProp()` on a class instance variant property — error 5 (Invalid procedure call) - `x()` on a Dim scalar variable — error 13 (Type mismatch) - `arr()` on a Dim array — error 9 (Subscript out of range) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10783

2 3

[PATCH v2 0/1] MR10782: win32u: Stub NtUserInitializeTouchInjection.
by Rémi Bernon (＠rbernon) April 30, 2026

April 30, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10778 -- v2: win32u: Stub NtUserInitializeTouchInjection. https://gitlab.winehq.org/wine/wine/-/merge_requests/10782

2 1

Re: [PATCH 0/1] MR10782: win32u: Stub NtUserInitializeTouchInjection. - approved
by Rémi Bernon (＠rbernon) April 30, 2026

April 30, 2026

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10782

1 0

[PATCH v2 0/5] MR10763: opengl32: Generate code to call the get_integer hooks.
by Rémi Bernon (＠rbernon) April 30, 2026

April 30, 2026

-- v2: opengl32: Generate code to call the get_integer hooks. opengl32: Move context thread id checks to the PE side. opengl32: Implement wglCreateContext with wglCreateContextAttribsARB. opengl32: Implement wglMakeCurrent with wglMakeContextCurrentARB. opengl32: Generate a thunks.h file for extern declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10763

2 5

[PATCH 0/2] MR10715: mf: Call GetCorrelatedTime without critical section.
by Brendan McGrath (＠redmcg) April 30, 2026

April 30, 2026

This MR addresses two issues: 1. the MR presentation clock's periodic callback continuing to be called after it was shutdown; and 2. a deadlock that could occur when calling GetCorrelatedTime in parallel with a session shutdown The deadlock occurs when SAR is the time source. A call to GetCorrelatedTime will result in an attempt to acquire SAR's critical section. This means this thread will hold the presentation clock critical section and then attempt to obtain SARs critical section. However, if SAR is in the process of shutdown in a parallel thread, then that thread will already hold the SAR critical section and call IMFPresentationClock::RemoveClockStateSink. This will attempt to acquire the presentation clock critical section. In other words, we have two threads trying to acquire the same two critical sections in the opposite order. The result is both threads waiting on the other and thus a deadlock. This commit resolves the deadlock by ensuring the presentation clock does not hold its own critical section when calling GetCorrelatedTime. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10715

3 6

[PATCH v2 0/2] MR10606: mf/session: Support asynchronous transforms.
by Conor McCarthy (＠cmccarthy) April 30, 2026

April 30, 2026

-- v2: mf/session: Support asynchronous transforms. mf/test: Add asynchronous transform tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10606

2 3

[PATCH v7 0/2] MR10340: comctl32/tooltips: suppress icon and title when title is NULL or empty.
by Larry Starr (＠starrl) April 29, 2026

April 29, 2026

Per MSDN, TTM_SETTITLE with a NULL or empty title string should suppress both the title row and any associated icon. Previously an empty string was treated the same as a non-empty title, causing the icon to still be displayed and the tooltip to be incorrectly sized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58236 Signed-off-by: Larry Starr <Larry_A_Starr(a)yahoo.com> -- v7: comctl32/tooltips: suppress icon and title when title is NULL or empty. comctl32/tooltips/tests: add regression test for TTM_SETTITLE with NULL or empty title. https://gitlab.winehq.org/wine/wine/-/merge_requests/10340

2 2

Re: [PATCH v8 0/1] MR10383: vbscript: Support element access on public array properties of class instances.
by Francis De Brabandere (＠francisdb) April 29, 2026

April 29, 2026

On Wed Apr 29 22:41:16 2026 +0000, Francis De Brabandere wrote: > changed this line in [version 7 of the diff](/wine/wine/-/merge_requests/10383/diffs?diff_id=264221&start_sha=8927d9776b70303de87da8ac48e87dee680c3d54#19e0bfbc7699f0fd97292b7764d96290529571cd_214_200) Strange, anyway, removed and added some extra tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10383#note_138290

1 0