- Wine-GitLab - list.winehq.org

[PATCH v6 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v6: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 3

[PATCH v5 0/6] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 29, 2026

March 29, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- v5: gdiplus: Make function which using GdipGetImage* more reboust gdiplus: Fix GdipGetImageHeight gdiplus: Fix GdipGetImageWidth gdiplus: Fix GdipGetImageVerticalResolution gdiplus: Fix GdipGetImageHorizontalResolution https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 6

[PATCH 0/1] MR10502: oleaut32: Implement SLTG union type processing.
by Wolfgang Hartl (＠wolfo.dev) March 29, 2026

March 29, 2026

https://bugs.winehq.org/show_bug.cgi?id=59590 When MS-Money 2000 loads INV7.OCX the message "02c0:fixme:ole:ITypeLib2_Constructor_SLTG Not processing typekind 7" is shown. I implemented the processing for TKIND_UNION for SLTG typelibs - SLTG_ProcessUnion(). Testing: 1. With MS-Money 2000. After patching the message is gone. 2. With dumping a small tlb in SLTG format that contains a simple union type. The type is shown with the patch applied. Please see details and the logs in the bug comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10502

2 1

[PATCH v4 0/6] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 29, 2026

March 29, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- v4: gdiplus: Make function which using GdipGetImage* more reboust https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 6

[PATCH v3 0/6] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 29, 2026

March 29, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- v3: gdiplus: Make function which using GdipGetImage* more reboust https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 6

[PATCH v3 0/1] MR10500: vbscript: Defer For loop control variable assignment until all expressions are evaluated.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

On Windows, when a For loop expression (from, to, or step) fails with On Error Resume Next, the control variable is not modified and error 92 (For loop not initialized) is set at the next iteration. Wine previously assigned the from value before evaluating to/step. Restructure compile_forto_statement to evaluate all three expressions before assigning to the control variable. On expression failure, error recovery enters the body with empty sentinel values so that OP_step detects the uninitialized state and sets error 92. Also return error 92 from OP_incc when VarAdd fails. -- v3: vbscript: Defer For loop control variable assignment until all expressions are evaluated. https://gitlab.winehq.org/wine/wine/-/merge_requests/10500

2 1

[PATCH v2 0/1] MR10500: vbscript: Defer For loop control variable assignment until all expressions are evaluated.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

On Windows, when a For loop expression (from, to, or step) fails with On Error Resume Next, the control variable is not modified and error 92 (For loop not initialized) is set at the next iteration. Wine previously assigned the from value before evaluating to/step. Restructure compile_forto_statement to evaluate all three expressions before assigning to the control variable. On expression failure, error recovery enters the body with empty sentinel values so that OP_step detects the uninitialized state and sets error 92. Also return error 92 from OP_incc when VarAdd fails. -- v2: vbscript: Defer For loop control variable assignment until all expressions are evaluated. https://gitlab.winehq.org/wine/wine/-/merge_requests/10500

2 1

[PATCH 0/1] MR10500: vbscript: Defer For loop control variable assignment until all expressions are evaluated.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

On Windows, when a For loop expression (from, to, or step) fails with On Error Resume Next, the control variable is not modified and error 92 (For loop not initialized) is set at the next iteration. Wine previously assigned the from value before evaluating to/step. Restructure compile_forto_statement to evaluate all three expressions before assigning to the control variable. On expression failure, error recovery enters the body with empty sentinel values so that OP_step detects the uninitialized state and sets error 92. Also return error 92 from OP_incc when VarAdd fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10500

2 1

[PATCH v18 0/1] MR10244: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts There are still quite some compiler issues left but this addresses the biggest parser issues. -- v18: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

[PATCH 0/1] MR10497: vbscript: Return specific error codes for unterminated block statements.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When a block statement reaches EOF without its closing keyword, Windows returns a specific error code. Add error productions in the bison grammar for four unterminated block types: - If without End If (error 1014) - While without Wend (error 1018) - Do without Loop (error 1019) - For/For Each without Next (error 1020) Previously these all fell through to the generic E_FAIL path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10497

2 1

[PATCH 0/1] MR10496: vbscript: Return error 1045 for non-literal constant expressions.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When a Const declaration uses a non-literal expression (e.g. "Const x = 1 + \"a\""), Windows parses the full expression and then rejects it with error 1045 ("expected literal constant"). Change ConstDecl to accept Expression instead of ConstExpression, and validate in new_const_decl() that the expression is a literal or negated numeric literal. Remove the now-unused ConstExpression rule. This fixes both the error code (was generic E_FAIL/16389) and the error character position (now points to the end of the expression). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10496

2 1

[PATCH 0/1] MR10495: vbscript: Return error 1010 for keyword used where identifier expected in Dim.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When a reserved keyword like If appears after Dim where an identifier is expected (e.g. "Dim If"), Windows returns error 1010 ("expected identifier"). Add an error production in DimDeclList that sets the correct VBSE_EXPECTED_IDENTIFIER error code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10495

2 1

[PATCH 0/1] MR10494: vbscript: Return error 1005 for missing opening parenthesis in Sub/Function.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When a Sub or Function declaration has a closing parenthesis without a matching opening one (e.g. "Sub x)"), Windows returns error 1005 ("expected '('"). Add error productions in FunctionDecl that detect this and set the correct VBSE_EXPECTED_LPAREN error code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10494

2 1

[PATCH v4 0/2] MR10438: configure: fail early on invalid Gradle/SDK
by Twaik Yont (＠twaik) March 29, 2026

March 29, 2026

This change is motivated by the long-standing issue that most Linux distributions ship an outdated Gradle, which is often too old for modern Android builds. In typical Android projects this is solved by using the Gradle wrapper, which ensures a compatible Gradle version is downloaded and used automatically. However, Wine cannot rely on the Gradle wrapper for this purpose, and integrating automatic downloads into the build system is not acceptable, since the build process must not fetch external resources. As a result, Gradle and the Android SDK effectively become external prerequisites that must be provided by the user or by higher-level build scripts. Previously, missing or outdated dependencies would only surface later during the build, often resulting in confusing or hard-to-diagnose errors. This change makes these requirements explicit and enforces them at configure time: - `gradle` is detected, its version is checked, and the resolved path is cached. - `ANDROID_HOME` is required and validated against the expected SDK layout. - A minimal sanity check ensures that a usable `build-tools` installation is present. This allows the build to fail early with clear error messages if the environment is not properly set up, instead of failing deep inside the Gradle build. Additionally, `GRADLE` and `ANDROID_HOME` are cached by configure, so they do not need to be re-specified when invoking make or even present in environment. -- v4: wineandroid: print hint for full APK build when using dummy target https://gitlab.winehq.org/wine/wine/-/merge_requests/10438

3 9

[PATCH v4 0/1] MR10493: vbscript: Return error 1048 for Property declaration outside a Class.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When Property Get appears at global scope (outside a Class block), Windows returns error 1048 ("must be defined inside a Class"). Detect the tGET token in parser_error() — it is only valid after tPROPERTY inside a PropertyDecl, so encountering it at statement level means a Property was used outside a class context. -- v4: vbscript: Return error 1048 for Property declaration outside a Class. https://gitlab.winehq.org/wine/wine/-/merge_requests/10493

2 1

[PATCH v3 0/1] MR10493: vbscript: Return error 1048 for Property declaration outside a Class.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When Property Get appears at global scope (outside a Class block), Windows returns error 1048 ("must be defined inside a Class"). Detect the tGET token in parser_error() — it is only valid after tPROPERTY inside a PropertyDecl, so encountering it at statement level means a Property was used outside a class context. -- v3: vbscript: Return error 1048 for Property declaration outside a Class. https://gitlab.winehq.org/wine/wine/-/merge_requests/10493

2 1

[PATCH 0/1] MR10493: vbscript: Return error 1048 for Property declaration outside a Class.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

When Property Get appears at global scope (outside a Class block), Windows returns error 1048 ("must be defined inside a Class"). Detect the tGET token in parser_error() — it is only valid after tPROPERTY inside a PropertyDecl, so encountering it at statement level means a Property was used outside a class context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10493

2 1

[PATCH 0/7] MR10492: include: Add some ALPC definitions.
by Zhiyi Zhang (＠zhiyi) March 29, 2026

March 29, 2026

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10492

2 7

[PATCH 0/1] MR10491: vbscript: Return error 1054 for Property Let/Set without arguments.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Add error productions in PropertyDecl that detect when Property Let or Property Set is declared without a parameter list. Windows returns error 1054 (Property Let/Set needs at least one argument) in this case. Previously Wine fell through to the generic E_FAIL path, returning error code 16389. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10491

2 1

[PATCH 0/1] MR10490: vbscript: Return specific error codes for integer constant and Property declarations.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Add error productions in the bison grammar for two cases: - Expected integer constant in Dim array bounds (error 1026) e.g. Dim x("a") where a numeric value is required. - Expected Let, Set, or Get after Property keyword (error 1049) e.g. Property x without specifying the accessor type. Previously these fell through to the generic E_FAIL path in parser_error(). Now each sets the correct VBSE_EXPECTED_* error code via MAKE_VBSERROR before aborting the parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10490

2 1

[PATCH 0/1] MR10489: vbscript: Return specific error codes for missing keywords in parser.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Add error productions in the bison grammar for five cases where a specific keyword is expected after a recognized prefix: - Expected '=' after identifier in Const declaration (error 1011) - Expected 'To' after expression in For loop (error 1013) - Expected 'Then' after expression in If statement (error 1017) - Expected 'Case' after Select (error 1021) - Expected 'In' after identifier in For Each loop (error 1046) Previously these all fell through to the generic E_FAIL path in parser_error(). Now each sets the correct VBSE_EXPECTED_* error code via MAKE_VBSERROR before aborting the parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10489

2 1

[PATCH v2 0/1] MR10469: comctl32/imagelist: Allow for larger initial image count.
by Alistair Leslie-Hughes (＠alesliehughes) March 29, 2026

March 29, 2026

I have an application that uses 970+ as an valid initial value, and causes random crashes when restricted to 256. -- v2: comctl32/imagelist: Allow for larger initial image count. https://gitlab.winehq.org/wine/wine/-/merge_requests/10469

3 3

[PATCH 0/1] MR10469: comctl32/imagelist: Allow for larger initial image count.
by Alistair Leslie-Hughes (＠alesliehughes) March 29, 2026

March 29, 2026

I have an application that uses 970+ as an valid initial value, and causes random crashes when restricted to 256. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10469

3 4

Re: [PATCH v9 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 28, 2026

March 28, 2026

On Mon Mar 9 13:26:34 2026 +0000, Theodoros Chatzigiannakis wrote: > * I addressed the issue with the test, it should fail without the fix now. > * Regarding the tables, that distinction was indeed a bit too arbitrary. > Now it's based on detecting the actual data size mismatch. @hans Have you had a chance to take another look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10114#note_134237

1 0

[PATCH 0/1] MR10486: vbscript: Fix error character positions for Exit and Dim statements.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

For invalid Exit statements (e.g. Exit Do outside a Do loop), point the error position at the keyword after Exit (Do/For/Function/Property/Sub) instead of at Exit itself, matching Windows. For duplicate Dim declarations, store the identifier location in dim_decl_t and use it as the error position, so the error points at the duplicate name instead of the Dim keyword. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10486

2 1