- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10485: vbscript: Return proper errors for orphan Loop and Next keywords.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

When Loop or Next appear outside their enclosing Do/For blocks, Windows returns specific error codes: 1038 ("loop without do") and 1055 ("unexpected Next"). Detect these tokens in parser_error() and set the proper HRESULT instead of the generic E_FAIL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10485

2 1

[PATCH 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

[PATCH v2 0/4] MR10104: user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled
by Ivan Ivlev (＠iviv) March 28, 2026

March 28, 2026

Edit control does not release mouse capture after WM_LBUTTONDOWN has been processed two times in a row. This MR fixes this issue by releasing capture and setting it again on WM_LBUTTONDOWN if window was already captured. I have stumbled upon the app in which edit control process WM_LBUTTONDOWN twice on one mouse click. While in windows it causes no problem, wine edit does not release capture, so other buttons inside this app become unclickable. It happens because when WM_LBUTTONDOWN is processed twice, WM_CAPTURECHANGED is sent and bCaptureState is set to FALSE, then EDIT_WM_LButtonUp does not release capture because bCaptureState is already FALSE. Thing about tests: I have added test case for this problem to be visible. I also had to use todo_wine because SendMessageA for WM_LBUTTONDOWN and WM_LBUTTONUP returns 0 in wine and 1 in windows (which is not the case for combobox test, where SendMessageА for WM_LBUTTONDOWN also returns 1 in wine). -- v2: comctl32_v6/edit: Reset capture on WM_LBUTTONDOWN if already enabled user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled comctl32/tests/edit.c: Test WM_LBUTTONDOWN processing user32/tests/edit.c: Test WM_LBUTTONDOWN processing https://gitlab.winehq.org/wine/wine/-/merge_requests/10104

3 6

[PATCH 0/1] MR10483: vbscript: Return "Illegal assignment" error for Const and function assignment.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Assigning to a Const variable or a function/sub name should return error 501 (Illegal assignment), not 445 (Object doesn't support this action). Change the REF_CONST and REF_FUNC cases in assign_ident() to use MAKE_VBSERROR(VBSE_ILLEGAL_ASSIGNMENT). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10483

2 1

[PATCH v5 0/5] MR10060: Draft: comdlg32: Use XDG Desktop Portal for native file dialogs
by Alexander Wilms (＠Alexander-Wilms) March 28, 2026

March 28, 2026

This adds XDG desktop portal integration for Wine file dialogs, with compatibility fallbacks, and solves https://bugs.winehq.org/show_bug.cgi?id=51134 I used an LLM to create the patches, the wiki does not contain an LLM policy, so I don't know if this is eligible to be merged at all. I used the following sources: - https://github.com/MicrosoftDocs/win32 which contains the markdown sources for e.g. - https://learn.microsoft.com/en-us/windows/win32/menurc/resource-compiler - https://github.com/MicrosoftDocs/sdk-api which contains the markdown sources for e.g. - https://learn.microsoft.com/en-us/windows/win32/api/commdlg/nf-commdlg-geto… - https://github.com/flatpak/xdg-desktop-portal - https://github.com/notepad-plus-plus/notepad-plus-plus to determine what calls are made when choosing Save As, since it initially didn't work - Wine logs from manual testing after adding extensive TRACE calls: - Wine `notepad.exe`: `GetOpenFileNameW` / `GetSaveFileNameW` via portal - Wine `wordpad.exe`: `GetOpenFileNameW` / `GetSaveFileNameW` via portal - [`hammerplusplus.exe`](https://ficool2.github.io/HammerPlusPlus-Website/index.html) (32-bit): `IFileDialog` (`IFileDialog2_fnShow`) Open/Save As via portal - `SumatraPDF.exe`: Open via `GetOpenFileNameW` in auto; Save As uses `GetSaveFileNameW` and falls back in case of the auto policy, but uses portal when forced (WINE_FORCE_PORTAL=1) - `notepad++.exe`: `IFileDialog` (`IFileDialog2_fnShow`) Save As via portal after result-path handling fixes Implementation: - Add a portal backend in `comdlg32` for file open/save requests - Add portal handling for `GetOpenFileNameW`, `GetOpenFileNameA`, `GetSaveFileNameW`, and `GetSaveFileNameA` when requests are compatible with portal features - Route compatible `IFileDialog`/`IFileOpenDialog`/`IFileSaveDialog` paths through the portal - Keep native Wine dialogs in case of unsupported/customized dialog options - Add a combobox to `winecfg` to select the policy for XDG Desktop Portal file dialogs: auto / always / never ![image](/uploads/2a1ded4968485e84aebfc1f0ceed0aa4/image.png){width=900 height=486} ![image](/uploads/0c70d44a21fd9334de55ce64ccb4fa9b/image.png){width=900 height=486} ![image](/uploads/5f3821abbf42809cafd5edbcb343b0f8/image.png){width=485 height=600} -- v5: shell32: route SHBrowseForFolderW through portal when compatible comdlg32/tests: add IFileOpenDialog FOS_PICKFOLDERS runtime check winecfg: add portal file dialog policy and UI comdlg32: route IFileDialog through portal when compatible comdlg32: add XDG desktop portal backend for file dialogs https://gitlab.winehq.org/wine/wine/-/merge_requests/10060

4 8

[PATCH 0/2] MR10482: urlmon: Implement IsValidURL().
by Nello De Gregoris (＠bluechxin) March 28, 2026

March 28, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59552 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10482

2 2

Re: [PATCH v3 0/5] MR10255: dsound: Speed up resampling, part 4
by Anton Baskanov (＠baskanov) March 28, 2026

March 28, 2026

On Sat Mar 28 12:10:20 2026 +0000, Bernhard Übelacker wrote: > Hello Anton Baskanov, unfortunately a git bisect for [bug > #59548](https://bugs.winehq.org/show_bug.cgi?id=59548) about a crash in > function `downsample` is pointing at commit 97f3bffa60b173c43ceef6c96ed5d9a46fccef12. Thanks! Should be fixed by !10479. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255#note_134226

1 0

[PATCH 0/1] MR10481: mscms: Add WcsGetCalibrationManagementState stub.
by Gijs Vermeulen (＠gverm) March 28, 2026

March 28, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59576 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10481

2 1

[PATCH 0/5] MR10480: gdiplus: Fix GdipGetImage* functions
by Bartosz Kosiorek (＠gang65) March 28, 2026

March 28, 2026

In case HEMF (Handle to an Enhanced Metafile) is missing, we should return InvalidParameter. Additionally bounds were fixed for GdipGetImageBounds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10480

2 5

[PATCH v5 0/2] MR10463: winemac: Replace OSAtomic functions with builtin __atomic counterparts.
by Marc-Aurel Zent (＠mzent) March 28, 2026

March 28, 2026

This fixes deprecated build warnings: `wine/dlls/winemac.drv/cocoa_event.m:280:21: warning: 'OSAtomicDecrement32Barrier' is deprecated: first deprecated in macOS 10.12` Also relaxes memory barriers where appropriate. -- v5: winemac: Relax builtin __atomic memory barriers. winemac: Replace OSAtomic functions with builtin __atomic counterparts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10463

2 2

[PATCH v4 0/2] MR10463: winemac: Replace OSAtomic functions with builtin __atomic counterparts.
by Marc-Aurel Zent (＠mzent) March 28, 2026

March 28, 2026

This fixes deprecated build warnings: `wine/dlls/winemac.drv/cocoa_event.m:280:21: warning: 'OSAtomicDecrement32Barrier' is deprecated: first deprecated in macOS 10.12` Also relaxes memory barriers where appropriate. -- v4: winemac: Relax builtin __atomic memory barriers. winemac: Replace OSAtomic functions with builtin __atomic counterparts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10463

2 4

[PATCH v6 0/2] MR10460: msvcrt: Add support for %Z printf specifier.
by Trung Nguyen (＠trungnt2910) March 28, 2026

March 28, 2026

This specifier allows printing the `UNICODE_STRING` and `ANSI_STRING` structures. It is useful for running unit tests for kernel mode or shared components on WINE. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59563 -- v6: msvcrt/tests: Add tests for %Z printf specifier. msvcrt: Add support for %Z printf specifier. https://gitlab.winehq.org/wine/wine/-/merge_requests/10460

2 2

[PATCH v5 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v5: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 1

[PATCH v6 0/1] MR10362: vbscript: Support chained call syntax like dict.Keys()(i).
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Treat '(' after tEMPTYBRACKETS as an argument list opener in the lexer, so that expressions like GetArr()(0) or dict.Keys()(i) parse correctly. Also dereference VT_BYREF|VT_VARIANT results in vcall so chained indexing on call results works at runtime. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58051 This includes some of the work done in !10308, preferably that one is merged first. -- v6: vbscript: Support chained call syntax like dict.Keys()(i). https://gitlab.winehq.org/wine/wine/-/merge_requests/10362

2 1

Re: [PATCH v3 0/1] MR9796: winebus: Adjust hatswitch encoding to follow T300RS and G29
by SeongChan Lee (＠foriequal0) March 28, 2026

March 28, 2026

On Tue Jan 6 14:49:20 2026 +0000, Tomasz Pakuła wrote: > Probably because this should always be handled dynamically. It then > doesn't matter what the min and max value is. It's just that with the > input plugins, developer have to do HID manually for no good reason and > they don't have the know-how. I've checked with a controller that can switch between X-Input mode and D-Input mode. X-Input had no problem with it, but it broke D-Input mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9796#note_134197

1 0

[PATCH v2 0/1] MR10471: Draft: unwind: fix some invalid `reinterpret_cast`s
by Safocl Stollmannovic (＠safocl88) March 28, 2026

March 28, 2026

Performing type `reinterpret-cast`s between pointers to types that are not _pointers-interconvertible_ and then using the results is incorrect usage. Only the “array of N unsigned char” or of type “array of N std::byte” types can used as storage (in general case). To convert a pointer to a structure object containing a byte array into a pointer to an object explicitly created in that storage, std::launder must be called on that "newly typed" pointer. Accessing an explicitly created object in such a byte store through a pointer to an object of the structure type that contains the given byte array requires calling std::launder. ```cpp struct S { unsigned char data[_LIBUNWIND_CURSOR_SIZE * sizeof(uint64_t)]; } s; struct S2 { int i; }; new(s.data) S2(42); auto s2_ptr1 = reinterpret_cast<S2*>(s.data); auto s2_ptr2 = reinterpret_cast<S2*>(s); // this pointer is not changed ([expr.static.cast#12]) and points to s (struct S) auto s2_ptr3 = std::launder(reinterpret_cast<S2*>(s)); int i1 = s2_ptr1->i; // OK int i3 = s2_ptr3->i; // OK (?) int i2 = s2_ptr2->i; // this is undefined behavior ``` Also a pointer to object of type uint16\[2\] cannot be reinterpreted as uint32 -- this is undefined behavior (https://godbolt.org/z/vY1zKEvo6) https://eel.is/c++draft/intro.object#3 https://eel.is/c++draft/basic.compound#5 https://eel.is/c++draft/basic.compound#6 https://eel.is/c++draft/basic.lval#11 https://eel.is/c++draft/expr.static.cast#12 https://eel.is/c++draft/expr.reinterpret.cast#7 https://en.cppreference.com/w/cpp/utility/launder.html https://en.cppreference.com/w/cpp/language/reinterpret_cast.html -- v2: unwind: fix some invalid `reinterpret_cast`s https://gitlab.winehq.org/wine/wine/-/merge_requests/10471

3 13

Re: [PATCH v5 0/2] MR10460: msvcrt: Add support for %Z printf specifier.
by Trung Nguyen (＠trungnt2910) March 28, 2026

March 28, 2026

Tests passing now :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10460#note_134191

1 0

Re: [PATCH v3 0/5] MR10255: dsound: Speed up resampling, part 4
by Bernhard Übelacker (＠bernhardu) March 28, 2026

March 28, 2026

Hello Anton Baskanov, unfortunately a git bisect for [bug #59548](https://bugs.winehq.org/show_bug.cgi?id=59548) about a crash in function `downsample` is pointing at commit 97f3bffa60b173c43ceef6c96ed5d9a46fccef12. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255#note_134189

1 0

[PATCH v4 0/3] MR10460: msvcrt: Add support for %Z printf specifier.
by Trung Nguyen (＠trungnt2910) March 27, 2026

March 27, 2026

This specifier allows printing the `UNICODE_STRING` and `ANSI_STRING` structures. It is useful for running unit tests for kernel mode or shared components on WINE. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59563 -- v4: Update 2 files https://gitlab.winehq.org/wine/wine/-/merge_requests/10460

2 4

[PATCH v8 0/1] MR10405: vbscript: Return proper error for undefined variables with Option Explicit.
by Francis De Brabandere (＠francisdb) March 27, 2026

March 27, 2026

When Option Explicit is set and an undefined variable is used, return VBS error 500 (Variable is undefined) with the variable name in the description, matching Windows behavior. Previously Wine returned E_FAIL with no description. -- v8: vbscript: Return proper error for undefined variables with Option Explicit. https://gitlab.winehq.org/wine/wine/-/merge_requests/10405

2 1

[PATCH v6 0/1] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) March 27, 2026

March 27, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store the identifier location in const_decl_t and dim_decl_t so errors point to the duplicate name, not the keyword. -- v6: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH v6 0/1] MR10449: vbscript: Implement the Erase statement.
by Francis De Brabandere (＠francisdb) March 27, 2026

March 27, 2026

Erase reinitializes fixed-size arrays (clearing all elements to their default values) and deallocates dynamic arrays (setting them back to an uninitialized state). -- v6: vbscript: Implement the Erase statement. https://gitlab.winehq.org/wine/wine/-/merge_requests/10449

2 2

Re: [PATCH v2 0/1] MR10478: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) March 27, 2026

March 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10478

1 0

Re: [PATCH v2 0/1] MR10475: d2d1: Allow value NULL in d2d_effect_SetInput. - approved
by Alexandre Julliard (＠julliard) March 27, 2026

March 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10475

1 0

Re: [PATCH v2 0/1] MR10476: d3d9/tests: Improve yuv_color_test() on Nvidia drivers. - approved
by Alexandre Julliard (＠julliard) March 27, 2026

March 27, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10476

1 0