- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10455: vbscript: Return "Object required" error (424) instead of E_FAIL/E_NOTIMPL.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Fix several interpreter code paths that returned wrong error codes when an object was expected but not provided: - stack_pop_disp: E_FAIL -> 424 for non-dispatch types. - do_mcall: E_FAIL -> 424 when calling a member on Nothing. - interp_assign_member: E_FAIL -> 424 for Nothing.Prop = value. - interp_set_member: E_FAIL -> 424 for Set Nothing.Child = obj. - interp_is: E_NOTIMPL -> 424 for non-object Is operands. Also add OP_with opcode to validate the With expression is a dispatch object at entry time, matching Windows behavior where With on non-object types (integers, strings, Empty, Null, booleans) raises error 424 immediately, while With Nothing succeeds. -- v2: vbscript: Return "Object required" error (424) instead of E_FAIL/E_NOTIMPL. https://gitlab.winehq.org/wine/wine/-/merge_requests/10455

3 2

Re: [PATCH v3 0/1] MR10446: vbscript: Fix crash in ReDim on uninitialized dynamic arrays. - approved
by Alexandre Julliard (＠julliard) March 26, 2026

March 26, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10446

1 0

Re: [PATCH v10 0/1] MR10444: vbscript: Implement GetRef. - approved
by Alexandre Julliard (＠julliard) March 26, 2026

March 26, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10444

1 0

Re: [PATCH v15 0/4] MR10386: vbscript: Return proper error codes for compile errors. - approved
by Alexandre Julliard (＠julliard) March 26, 2026

March 26, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10386

1 0

[PATCH v15 0/7] MR10263: windows.web: Support JSON array and object parsing
by Olivia Ryan (＠olivi-r) March 26, 2026

March 26, 2026

Implements JsonArray, JsonObject value getters and extends JsonValue.Parse to support arrays and objects. -- v15: windows.web: Support boolean & number value creation windows.web: Support object parsing windows.web: JsonObject typed getters windows.web: Add object mapping windows.web: Support array parsing windows.web: JsonArray element getters windows.web: Stub IJsonArray https://gitlab.winehq.org/wine/wine/-/merge_requests/10263

3 9

[PATCH v6 0/1] MR10461: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v6: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v3 0/1] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store the identifier location in const_decl_t and dim_decl_t so errors point to the duplicate name, not the keyword. -- v3: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH v5 0/1] MR10461: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v5: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v4 0/1] MR10461: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v4: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v2 0/1] MR10464: Draft: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store the identifier location in const_decl_t and dim_decl_t so errors point to the duplicate name, not the keyword. -- v2: vbscript: Return "Name redefined" error for duplicate declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH v6 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Chris Kadar (＠nspitko) March 26, 2026

March 26, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59534 Signed-off-by: Chris Kadar fireslash(a)fireslash.net -- v6: cabinet: Add stubs for compressor/decompressor https://gitlab.winehq.org/wine/wine/-/merge_requests/10352

3 4

Re: [PATCH v2 0/1] MR10463: winemac: Replace OSAtomic functions with builtin __atomic counterparts.
by Jinoh Kang (＠iamahuman) March 26, 2026

March 26, 2026

If we're relaxing fences, maybe we should use acqrel for decrement too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10463#note_133915

1 0

[PATCH v2 0/9] MR10457: windows.web: Support JSON array and object parsing
by Rémi Bernon (＠rbernon) March 26, 2026

March 26, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10263. -- v2: windows.web: Implement JsonObject typed getters. windows.web: Support boolean & number value creation. windows.web: Implement JsonArray element getters. windows.web: Support json object parsing. windows.web: Add a IMap_HSTRING_IInspectable to json objects. windows.web: Support json array parsing. https://gitlab.winehq.org/wine/wine/-/merge_requests/10457

3 11

[PATCH v5 0/2] MR10321: mfsrcsnk: Parse pixel aspect ratio from the avcC atom.
by Yuxuan Shui (＠yshui) March 26, 2026

March 26, 2026

More specifically the SPS bytes in the avcC atom. Note this only fixes the problem for winedmo but not gstreamer. This is because gstreamer 1) does not parse the SPS, 2) will set pixel-aspect-ratio in caps regardless if a pasp atom is present. So there is no way for us to distinguish between 1) pasp being present and having an aspect ratio of 1:1, and 2) pasp not being present but pixel-aspect-ratio having been set to 1:1 by gstreamer as fallback. And because this is the case, I made sure winedmo is tested separately. In winedmo's case, if pasp is not present, we can set the PixelAspectRatio.Denominator in MFVIDEOFORMAT to 0 to distinguish. -- v5: mfsrcsnk: Parse pixel aspect ratio from the avcC atom. https://gitlab.winehq.org/wine/wine/-/merge_requests/10321

4 10

[PATCH 0/1] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store the identifier location in const_decl_t and dim_decl_t so errors point to the duplicate name, not the keyword. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

2 1

[PATCH 0/9] MR10457: windows.web: Support JSON array and object parsing
by Rémi Bernon (＠rbernon) March 26, 2026

March 26, 2026

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/10263. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10457

4 11

Re: [PATCH v2 0/1] MR10463: winemac: Replace OSAtomic functions with builtin __atomic counterparts.
by Marc-Aurel Zent (＠mzent) March 26, 2026

March 26, 2026

On Thu Mar 26 16:46:27 2026 +0000, Tim Clem wrote: > Hm... I have to admit I don't know anything about the appropriate memory > ordering here. Seems like the old OSAtomics probably map to > `__ATOMIC_SEQ_CST`? Maybe @bshanks would have more knowledge. Yeah they do... The `&event->event->deliver` one is inside a lock anyhow (and its use is kind of strange, but any comparison to it is happening inside the event lock too). The other uses of `__ATOMIC_RELAXED` are for increasing refcounts, which are always starting at 1, and the only point a full barrier should be needed is to check for destruction, where we still have `__ATOMIC_SEQ_CST`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10463#note_133901

1 0

Re: [PATCH v2 0/1] MR10463: winemac: Replace OSAtomic functions with builtin __atomic counterparts.
by Tim Clem (＠tclem) March 26, 2026

March 26, 2026

Hm... I have to admit I don't know anything about the appropriate memory ordering here. Seems like the old OSAtomics probably map to `__ATOMIC_SEQ_CST`? Maybe @bshanks would have more knowledge. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10463#note_133900

1 0

[PATCH 0/1] MR10462: vbscript: Return type mismatch when calling non-dispatch variable as statement.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

When a non-dispatch variable (integer, string, empty, etc.) is used as a statement with no arguments, return VBSE_TYPE_MISMATCH (error 13) instead of E_NOTIMPL. This matches native Windows VBScript behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10462

2 1

[PATCH v2 0/1] MR10450: vbscript: Return correct error for array dimension mismatch and NULL array access.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Return VBSE_OUT_OF_BOUNDS (error 9, "Subscript out of range") instead of E_FAIL for array dimension mismatch in array_access() and for NULL SAFEARRAY access in variant_call() and do_mcall(), matching native Windows behavior. -- v2: vbscript: Return correct error for array dimension mismatch and NULL array access. https://gitlab.winehq.org/wine/wine/-/merge_requests/10450

3 5

[PATCH 0/1] MR10455: vbscript: Return "Object required" error (424) instead of E_FAIL/E_NOTIMPL.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Fix several interpreter code paths that returned wrong error codes when an object was expected but not provided: - stack_pop_disp: E_FAIL -> 424 for non-dispatch types. - do_mcall: E_FAIL -> 424 when calling a member on Nothing. - interp_assign_member: E_FAIL -> 424 for Nothing.Prop = value. - interp_set_member: E_FAIL -> 424 for Set Nothing.Child = obj. - interp_is: E_NOTIMPL -> 424 for non-object Is operands. Also add OP_with opcode to validate the With expression is a dispatch object at entry time, matching Windows behavior where With on non-object types (integers, strings, Empty, Null, booleans) raises error 424 immediately, while With Nothing succeeds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10455

3 5

[PATCH v3 0/1] MR10461: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v3: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v2 0/1] MR10461: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning a lightweight ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL). This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v2: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1

[PATCH v2 0/1] MR10446: vbscript: Fix crash in ReDim on uninitialized dynamic arrays.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Dim arr() followed by ReDim arr(N) crashed due to a NULL SAFEARRAY pointer dereference. -- v2: vbscript: Fix crash in ReDim on uninitialized dynamic arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/10446

3 2

[PATCH 0/1] MR10461: Draft: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) March 26, 2026

March 26, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning a lightweight ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL). This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partialy based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 1