- Wine-GitLab - list.winehq.org

[PATCH 0/4] MR10413: windows.devices.radios: Implement IRadioStatics::GetRadiosAsync().
by Mohamad Al-Jaf (＠maljaf) March 23, 2026

March 23, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59516 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10413

3 5

[PATCH v2 0/1] MR10358: comctl32:Add TrueType font support for vertically tab text.
by Maotong Zhang (＠xiaotong) March 23, 2026

March 23, 2026

Wine-Bug:https://bugs.winehq.org/show_bug.cgi?id=50582 -- v2: comctl32:Add TrueType font support for vertically tab text. https://gitlab.winehq.org/wine/wine/-/merge_requests/10358

4 6

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Rémi Bernon March 23, 2026

March 23, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/class.c: > - SERVER_START_REQ( destroy_class ) > - { > - req->instance = wine_server_client_ptr( instance ); > - wine_server_add_data( req, name->Buffer, name->Length ); > - wine_server_call( req ); > - } > - SERVER_END_REQ; > - free( class ); > + > + /** > + * If we fail to get the shared object, the class must be destroyed and freed by other thread, > + * so we must not free it here. > + */ > + NtUserDestroyCursor( sm_icon, 0 ); > + user_unlock(); > return 0; I don't think that's true? With the new user_lock scope, class creation and insertion in the process linked list happens atomically. Symmetrically, class destruction and removal from the process class list also happens atomically. So only scenario that `find_shared_session_object` can fail, is some general critical error. I don't think we care that much about what happens in that case, but it seems to me that class pointer is exclusively owned by the calling thread in all case until the class is inserted in the process list and user critical section exited, and the pointer can and should always be freed on error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133371

1 0

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Rémi Bernon March 23, 2026

March 23, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/class.c: > SERVER_END_REQ; > if (!ret) > { > + NtUserDestroyCursor( sm_icon, 0 ); > free( class ); > + user_unlock(); > return 0; > } I'd move `NtUserDestroyCursor` outside of the user lock, as creation happens outside of it as well, and introduce a `goto failed;` here to share the error path with the other error below: ``` failed: user_unlock(); NtUserDestroyCursor( sm_icon, 0 ); free( class ); return 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133370

1 0

[PATCH v13 0/7] MR10263: windows.web: Support JSON array and object parsing
by Olivia Ryan (＠olivi-r) March 23, 2026

March 23, 2026

Implements JsonArray, JsonObject value getters and extends JsonValue.Parse to support arrays and objects. -- v13: windows.web: Support boolean & number value creation windows.web: JsonObject typed getters https://gitlab.winehq.org/wine/wine/-/merge_requests/10263

3 9

[PATCH v2 0/2] MR10303: SDK compliance (2)
by eric pouech (＠epo) March 23, 2026

March 23, 2026

This serie ensures a couple of Wine include files are properly defined when included from C++ code. It mainly adds a extern "C" { ... } around the various definitions. The list of modified files has been determined by: - checking Wine headers without extern "C" instruction, while SDK one has it, - not all files matching that criteria have been patched (eg DDK files have been left out) - some files have been patched even if their current content doesn't require it (ie no variable nor extern function definition), esp. when their SDK equivalent has a lot of such definitions (so that the c++ guard is not forgotten when the header file is updated), - search criteria is also not 100% accurate (eg missing EXTERN_C macro). Been triggered by bcrypt.h failing to be used in C++ code (didn't test for the others). -- v2: include: Don't use C++ keywords. include: Add missing extern "C" wrappers. https://gitlab.winehq.org/wine/wine/-/merge_requests/10303

3 3

[PATCH v2 0/3] MR10388: dwrite: Fail loading unsupported COLRv1 fonts.
by Paul Gofman (＠gofman) March 23, 2026

March 23, 2026

-- v2: dwrite: Fail loading unsupported COLRv1 fonts. dwrite: Move opentype_get_font_table() up. dwrite: Fix second chance fonts handling in fallback_map_characters(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10388

3 5

[PATCH v4 0/2] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 23, 2026

March 23, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v4: comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

3 6

Re: [PATCH v2 0/1] MR10340: comctl32/tooltips: suppress icon and title when title is NULL or empty.
by Zhiyi Zhang (＠zhiyi) March 23, 2026

March 23, 2026

Please fix the CI failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10340#note_133352

1 0

[PATCH 0/5] MR10429: msxml3/tests: Add some more DOM tests.
by Nikolay Sivov (＠nsivov) March 23, 2026

March 23, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10429

2 5

[PATCH 0/1] MR10381: mmdevapi: Don't assume WAVEFORMATEX is a WAVEFORMATEXTENSIBLE.
by Yuxuan Shui (＠yshui) March 23, 2026

March 23, 2026

IAudioClient_IsFormatSupported is given a WAVEFORMATEX, we can't assume it's a WAVEFORMATEXTENSIBLE without checking its cbSize. For example, WINMM_TestFormat only passes a WAVEFORMATEX. Found by ASan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10381

3 4

[PATCH v14 0/6] MR10419: Draft: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 23, 2026

March 23, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v14: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 6

[PATCH v13 0/6] MR10419: Draft: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 23, 2026

March 23, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v13: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 6

[PATCH v3 0/1] MR10326: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan).
by Bernhard Übelacker March 23, 2026

March 23, 2026

The function `validate_fmt` may receive a pointer which got just reserved memory for the `WAVEFORMATEX`. Unfortunately the assignment `fmt2 = *fmt` always copies the size of `WAVEFORMATEXTENSIBLE`. CC: @giomasce (I currently cannot point to a specific commit, but this may also be related to the recent changes?) <details> <summary>ASan details [gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/237050#L2464)</summary> ``` ==qcap_test.exe==728==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0022c122 at pc 0x785f4342 bp 0x0022bf4c sp 0x0022bb1c READ of size 40 at 0x0022c122 thread T0 #0 0x785f4341 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x778957a5 in validate_fmt /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 #2 0x77896d1e in client_IsFormatSupported /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:881:10 #3 0x783e3624 in IAudioClient_IsFormatSupported /builds/bernhardu/wine/build64/include/audioclient.h:406:12 #4 0x783e5cd7 in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:454:10 #5 0x783e5928 in WINMM_GetSupportedFormats /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:504:14 #6 0x783e553b in WINMM_InitMMDevice /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:524:35 #7 0x783e4e9b in WINMM_EnumDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:610:17 #8 0x783d30e8 in WINMM_InitMMDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:856:10 #9 0x7be4a996 in RtlRunOnceExecuteOnce /builds/bernhardu/wine/build64/../dlls/ntdll/sync.c:462:10 ... Address 0x0022c122 is located in stack of thread T0 at offset 34 in frame #0 0x783e5c0f in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:442 This frame has 2 object(s): [16, 34) 'fmt' (line 443) <== Memory access at offset 34 overflows this variable [80, 84) 'junk' (line 443) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 in validate_fmt ``` </details> -- v3: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/10326

2 6

[PATCH v8 0/1] MR10386: vbscript: Return proper error codes for compile errors.
by Francis De Brabandere (＠francisdb) March 23, 2026

March 23, 2026

Add error_code field to parse error tests, using negative values for codes that Wine does not yet return correctly (todo_wine), matching the existing pattern for error_char. Return MAKE_VBSERROR with proper error codes instead of E_FAIL for name redefinition, invalid exit statements, and invalid parenthesized call statements. -- v8: vbscript: Return proper error codes for compile errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/10386

2 1

[PATCH v11 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 23, 2026

March 23, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v11: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 6

[PATCH v7 0/1] MR10386: Draft: vbscript: Add tests for specific compile error codes.
by Francis De Brabandere (＠francisdb) March 23, 2026

March 23, 2026

Add error code definitions and string resources for compile errors (1002-1057) and todo_wine tests to verify the error codes returned via OnScriptError. Currently Wine returns error code 0 (generic syntax error) for most cases instead of the specific codes Windows returns. -- v7: vbscript: Return proper error codes for compile errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/10386

2 1

[PATCH v6 0/1] MR10386: vbscript: Add tests for specific compile error codes.
by Francis De Brabandere (＠francisdb) March 23, 2026

March 23, 2026

Add error code definitions and string resources for compile errors (1002-1057) and todo_wine tests to verify the error codes returned via OnScriptError. Currently Wine returns error code 0 (generic syntax error) for most cases instead of the specific codes Windows returns. -- v6: vbscript: Add tests for specific compile error codes. https://gitlab.winehq.org/wine/wine/-/merge_requests/10386

2 3

[PATCH v2 0/1] MR10408: mf: Add stub for MFCreateDeviceSource().
by eric pouech (＠epo) March 23, 2026

March 23, 2026

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: mf: Add stub for MFCreateDeviceSource(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10408

3 4

[PATCH v10 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 23, 2026

March 23, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v10: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 6

[PATCH 0/1] MR10427: windows.ui.core.textinput: Add CoreTextServicesManager stubbed interface
by Alistair Leslie-Hughes (＠alesliehughes) March 23, 2026

March 23, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10427

2 1

[PATCH 0/5] MR10426: winhttp: Fix querying available data for chunked transfers.
by Hans Leidekker (＠hans) March 23, 2026

March 23, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10426

2 5

[PATCH v9 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 23, 2026

March 23, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v9: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling ntdll: Block SIGUSR1 when the thread context is being modified ntdll: Fix thread stops inside __wine_syscall_dispatcher https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 7

[PATCH v25 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 23, 2026

March 23, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v25: kernel32: Fix string termination of GetModuleFileName https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v13 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 23, 2026

March 23, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v13: imagehlp: Fix ImageGetDigestStream. Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2