- Wine-GitLab - list.winehq.org

[PATCH v12 0/3] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 23, 2026

March 23, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v12: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections imagehlp: Fix ImageGetDigestStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 3

[PATCH v3 0/3] MR2343: Collection of small fixes for Fusion 360
by novenary * (＠novenary) March 22, 2026

March 22, 2026

This fixes various problems I've run into while trying to use Fusion 360 in wine. - stacking issues in unmanaged mode - I also attempted to apply the same fix for managed mode, but it looks difficult to do this in a way that plays well with window managers; I think it's best left up to them to keep override_redirect windows at the top of the stack) - when the window manager sets our state to withdrawn, tell the window that it's been minimized, since the semantics are very similar - the last one is a hack because I don't really know what to do about it, when clicking on the floating popups, they gain focus, which causes wine to incorrectly make them managed and that breaks everything -- v3: winex11: don't let captionless popups be managed winex11: pass ICCCM withdrawn state as minimized winex11: restack a window's owned popups above it https://gitlab.winehq.org/wine/wine/-/merge_requests/2343

5 7

[PATCH v11 0/2] MR10207: comctl32/treeview: Cycle all state images from custom image list when toggling checkboxes
by Piotr Pawłowski March 22, 2026

March 22, 2026

Bug and test program- https://bugs.winehq.org/show_bug.cgi?id=59486 This bug breaks foobar2000 advanced preferences - radiocheckboxes work only because I have very specific hack around this Wine behavior. My next treeview patch, fixing TVM_ITEMCHANGING, depends on this one and will be made a MR after this is merged. -- v11: comctl32/treeview: Cycle all state images from custom image list when toggling checkboxes Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59486 comctl32/tests: Test cycling all state images from custom image list when toggling checkboxes https://gitlab.winehq.org/wine/wine/-/merge_requests/10207

1 2

[PATCH 0/2] MR10422: win32u: Handle UTF-16 surrogate pairs in GDI text rendering
by Jan Robert Gerigk (＠RgSg86) March 22, 2026

March 22, 2026

Fixes Bug 59544. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10422

3 5

[PATCH 0/1] MR10420: mountmgr.sys: Initialize threading support for DBus before calling DBus functions.
by Vibhav Pant (＠vibhavp) March 22, 2026

March 22, 2026

As per DBus documentation for `dbus_threads_init_default`[^1], threading support must be initialized _before_ any libdbus methods are called. `winebth.sys` also does the same in `bluez_dbus_init`[^2]. [^1]: https://dbus.freedesktop.org/doc/api/html/group__DBusThreads.html#ga33b6cf3… [^2]: https://gitlab.winehq.org/wine/wine/-/blob/1dbc94083d1b508c3708c857b1715f9d… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10420

4 4

[PATCH v3 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values
by Vibhav Pant (＠vibhavp) March 22, 2026

March 22, 2026

Characteristic values represent data that can be read from or written to. The `winebluetooth_gatt_characteristic_value` struct gets used to send the buffer from Unix to PE land, and has the following structure: ```c #define WINEBLUETOOTH_CHARACTERISTIC_INLINE_SIZE 256 struct winebluetooth_gatt_characteristic_value { UINT32 size; union { BYTE buf[WINEBLUETOOTH_CHARACTERISTIC_INLINE_SIZE]; UINT_PTR handle; }; }; ``` For values <= 256 bytes, the value gets stored inline in `buf`, and copying is trivial. Otherwise, `handle` stores the DBus message containing the value and the `bluetooth_gatt_characteristic_value_move` unixlib function performs a copy and frees the associated DBus message. -- v3: bluetoothapis/tests: Add tests for BluetoothGATTGetCharacteristicValue. bluetoothapis: Implement BluetoothGATTGetCharacteristicValue. winebth.sys: Implement IOCTL_WINEBTH_GATT_SERVICE_READ_CHARACTERISITIC_VALUE. winebth.sys: Update the cached GATT characteristic value on receiving a PropertiesChanged signal for a GATT characteristic value from BlueZ. winebth.sys: Store GATT characteristic value cached by the Unix Bluetooth service on the PE driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/10208

2 7

[PATCH v10 0/4] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v10: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP/IP values from GetThreadContext(). ntdll: Avoid exposing non-user rsp in normal syscall return path https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 4

[PATCH v9 0/4] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v9: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP values from GetThreadContext(). ntdll: Avoid exposing non-user rsp in normal syscall return path https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 4

[PATCH v8 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v8: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 5

Re: [PATCH v7 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

It seems the %eip test is broken on i386 (which is not surprising since it does not implement this fix). I split off the check in the test and marked it as `todo_wine` on that plaform. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10419#note_133226

1 0

[PATCH v4 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v4: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP/IP values from GetThreadContext(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 5

[PATCH v3 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v3: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP/IP values from GetThreadContext(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 5

[PATCH v2 0/3] MR10354: wineandroid: update Android build to work with modern toolchains
by Twaik Yont (＠twaik) March 22, 2026

March 22, 2026

Update the Android project and build logic to work with recent Gradle and Android SDK versions, adjust types for consistency, separate APK generation from the default build, and add the required staging steps to prepare assets and libraries before building the APK. These changes allow Wine to be built with NDK r29 and modern Android build tools. The resulting build runs on Android 7 and later (only devices using the legacy gralloc interface). The build process still remains somewhat non-standard, so a build script and screenshot are provided for reference. <details> <summary>Screenshot</summary> ![image](/uploads/c82b589e6de36d88c340317f6fc80b50/image.png){width=792 height=600} </details> [wineandroid-builder.tar.gz](/uploads/0b47ae812cfcd2d64f71aa9dee7042f6/wineandroid-builder.tar.gz) -- v2: wineandroid: remove APK from default build and add staging checks wineandroid: use BOOL for is_desktop flag wineandroid: update Android project for modern Gradle plugin https://gitlab.winehq.org/wine/wine/-/merge_requests/10354

3 11

[PATCH v2 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v2: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP/IP values from GetThreadContext(). ntdll: Fix thread stops inside __wine_syscall_dispatcher https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 5

[PATCH v10 0/2] MR10207: comctl32/treeview: Cycle all state images from custom image list when toggling checkboxes
by Piotr Pawłowski March 22, 2026

March 22, 2026

Bug and test program- https://bugs.winehq.org/show_bug.cgi?id=59486 This bug breaks foobar2000 advanced preferences - radiocheckboxes work only because I have very specific hack around this Wine behavior. My next treeview patch, fixing TVM_ITEMCHANGING, depends on this one and will be made a MR after this is merged. -- v10: comctl32/treeview: Cycle all state images from custom image list when toggling checkboxes comctl32/tests: Test cycling all state images from custom image list when toggling checkboxes https://gitlab.winehq.org/wine/wine/-/merge_requests/10207

2 5

[PATCH v8 0/4] MR10232: ntdll: Avoid exposing non-user rsp in normal syscall return path
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When rsp is outside the kernel stack, the SIGUSR1 handler considers the context "out of syscall" and reports the real register values to wineserver. rsp pointing into the syscall frame is used for iret returns. Commit 0a5f7a710365 moved this earlier in the return path, creating a window in the regular direct return path where rsp points neither to the kernel stack, nor to the expected user stack. When a thread is interrupted by SIGUSR1 within this window, this exposes a bogus stack pointer to GetThreadContext(), breaking the garbage collector in Unity applications. Fix the regression by first switching to the real user stack (needed so we don't break things by touching other registers), then, only if an iret path is coming up, switching to the syscall frame pointer. This fixes the regression introduced by 0a5f7a710365, since GetThreadContext() will now observe the proper stack pointer during regular syscall returns. Further work would be needed to solve other corner cases and ensure that the register context returned by GetThreadContext() behaves exactly as on Windows (with no kernel-mode context info ever returned), but that is a larger/more invasive change. Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 Signed-off-by: Hoshino Lina lina(a)lina.yt -- v8: gitlab: Run ntdll tests with win64 architecture. ntdll: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for bogus SP values from GetThreadContext(). ntdll: Avoid exposing non-user rsp in normal syscall return path https://gitlab.winehq.org/wine/wine/-/merge_requests/10232

2 6

[PATCH 0/5] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) March 22, 2026

March 22, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

2 5

[PATCH 0/1] MR10418: d2d1/geometry: Check for null user transform when streaming.
by Nikolay Sivov (＠nsivov) March 22, 2026

March 22, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59551 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10418

2 1

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) March 21, 2026

March 21, 2026

On Sat Mar 21 17:06:50 2026 +0000, bhe69 wrote: > @nsivov I'm sorry to tell you that this is not fixed, it rather broke > some more :-( > Up to wine-staging 11.1 the preview was working, as shown in [comment by > kralo](https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_91181). > Starting with wine-staging 11.2 up to 11.5 the preview is showing blank > pages again. In addition, there is now a memory leak, as scrolling the > blank pages quickly fills up the RAM, and it is not released when > closing the preview window. I double checked with (non-staging) wine > 11.5 with the same effect. > Could you please look into this again, what is the difference to > original @d1saster PR? Please open a bug report for this, at bugs.winehq.org. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_133192

1 0

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by bhe69 (＠bhe69) March 21, 2026

March 21, 2026

On Sat Mar 21 17:06:50 2026 +0000, Nikolay Sivov wrote: > This is now fixed with !10043. @nsivov I'm sorry to tell you that this is not fixed, it rather broke some more :-( Up to wine-staging 11.1 the preview was working, as shown in [comment by kralo](https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_91181). Starting with wine-staging 11.2 up to 11.5 the preview is showing blank pages again. In addition, there is now a memory leak, as scrolling the blank pages quickly fills up the RAM, and it is not released when closing the preview window. I double checked with (non-staging) wine 11.5 with the same effect. Could you please look into this again, what is the difference to original @d1saster PR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_133191

1 0

[PATCH 0/1] MR10414: po: update Polish translation
by Adam Markowski (＠AMark) March 21, 2026

March 21, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10414

2 1

[PATCH v2 0/1] MR10390: winhttp: Support Qyuery option WINHTTP_OPTION_SECURITY_INFO
by Alistair Leslie-Hughes (＠alesliehughes) March 21, 2026

March 21, 2026

-- v2: winhttp: Support Query option WINHTTP_OPTION_SECURITY_INFO. https://gitlab.winehq.org/wine/wine/-/merge_requests/10390

3 2

[PATCH v2 0/1] MR10395: crypt32: Don't access CERT_CHAIN_ENGINE_CONFIG::dwExclusiveFlags without checking size.
by Yuxuan Shui (＠yshui) March 21, 2026

March 21, 2026

Found by ASan. Example in test `crypt32:chain`, `testCreateCertChainEngine`. Pointer to a `CERT_CHAIN_ENGINE_CONFIG_NO_EXCLUSIVE_ROOT` is passed to `CertCreateCertificateChainEngine`. Accessing `dwExclusiveFlags` unconditionally is out-of-bound. -- v2: crypt32: Don't access CERT_CHAIN_ENGINE_CONFIG::dwExclusiveFlags without checking size. https://gitlab.winehq.org/wine/wine/-/merge_requests/10395

3 3

[PATCH 0/1] MR10409: mfplat: Add stub for MFSerializeAttributesToStream.
by eric pouech (＠epo) March 21, 2026

March 21, 2026

And also MFDeserializeAttributesToStream. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10409

3 5

[PATCH 0/2] MR10412: windowscodecs/tests: Add conversion tests for Gray2, Gray4 and Gray16 pixel formats.
by Jan Robert Gerigk (＠RgSg86) March 21, 2026

March 21, 2026

windowscodecs/tests: Add conversion tests for 2bppGray, 4bppGray and 16bppGray pixel formats. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10412

2 2