- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10333: Draft: vbscript: Refactor ElseIf and Else grammar rules to avoid reduce/reduce conflicts.
by Francis De Brabandere (＠francisdb) March 14, 2026

March 14, 2026

@jacek let's tackle this first, I will then rework the other parser based MR's -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10333#note_132266

1 0

[PATCH 0/1] MR10333: Draft: vbscript: Refactor ElseIf and Else grammar rules to avoid reduce/reduce conflicts.
by Francis De Brabandere (＠francisdb) March 14, 2026

March 14, 2026

Introduce StatementsBody, InlineStatements and InlineStatements_opt non-terminals whose FIRST sets do not overlap with StSep. This allows splitting ElseIf into multi-line (strict, requires statement separator) and inline (lenient, allows trailing End If) forms, and splitting Else_opt into separator and inline forms that naturally reject "Else End If" without a semantic check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10333

2 1

[PATCH v8 0/3] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 14, 2026

March 14, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- v8: mfmediaengine: Keep the last presentation sample on flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

3 7

Re: [PATCH v2 0/1] MR10323: mxsml3/tests: Add tests for put_text.
by Nikolay Sivov (＠nsivov) March 14, 2026

March 14, 2026

On Sat Mar 14 02:45:18 2026 +0000, Daniel Lehman wrote: > > Is this just the issue described in the commit message of this patch, > and can be ignored until Nikolay's DOM handling rework lands? > yeah, that's the one. i skip the Release on wine because that's where > it crashed for me, but i could move it up to skip the whole put_text and > make the asan clean. @nsivov do you have a preference? Yes, I think skipping entire test function is good, no need for complicated work arounds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323#note_132260

1 0

Re: [PATCH v2 0/1] MR10323: mxsml3/tests: Add tests for put_text.
by Daniel Lehman (＠dlehman25) March 14, 2026

March 14, 2026

> Is this just the issue described in the commit message of this patch, and can be ignored until Nikolay's DOM handling rework lands? yeah, that's the one. i skip the Release on wine because that's where it crashed for me, but i could move it up to skip the whole put_text and make the asan clean. @nsivov do you have a preference? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323#note_132255

1 0

[PATCH 0/2] MR10202: mxsml3/tests: Add tests for put_text.
by Daniel Lehman (＠dlehman25) March 14, 2026

March 14, 2026

calling IXMLDOMNode_put_text on a text node leads to xmlTextSetContent in libxml2 which duplicates the text (xmlStr[n]dup) and frees the old content before setting the new calling IXMLDOMElement_put_text on an element node leads to xmlNodeParseContent in libxml2 which sets the text on the xmlNode's child and calls xmlFreeNodeList to free the old content an IXMLDOMNode reference to that internal text node holds a pointer to that freed content and crashes on IXMLDOMNode_Release <open> <-- IXMLDOMElement_put_text -> xmlNodeParseContent frees old 'content' held by IXMLDOMNode below sesame <-- IXMLDOMNode_Release on this node double-frees 'content' freed above </open> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10202

3 4

Re: [PATCH v2 0/1] MR10323: mxsml3/tests: Add tests for put_text.
by Bernhard Übelacker March 14, 2026

March 14, 2026

Hello Daniel, this test seems to have uncovered the below use-after-free. Is this just the issue described in the commit message of this patch, and can be ignored until Nikolay's DOM handling rework lands? https://gitlab.winehq.org/bernhardu/wine/-/jobs/237491#L2653 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323#note_132252

1 0

[PATCH 0/2] MR10331: wined3d: Two Vulkan fixes.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10331

2 2

[PATCH v4 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

-- v4: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch. https://gitlab.winehq.org/wine/wine/-/merge_requests/10330

2 2

Re: [PATCH v2 0/1] MR10328: msxml3/sax: Do not attempt to add default attributes for definitions without values. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10328

1 0

Re: [PATCH v2 0/1] MR10325: comctl32: Fix some typos in the comments. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10325

1 0

Re: [PATCH v8 0/6] MR10126: mf: Implement Scrubbing in SAR. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10126

1 0

Re: [PATCH v2 0/1] MR10323: mxsml3/tests: Add tests for put_text. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323

1 0

Re: [PATCH v2 0/1] MR10322: icu/tests: Add initial tests. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10322

1 0

Re: [PATCH v3 0/1] MR10311: vbscript: Do not fail on colon-prefixed statements in If blocks. - approved
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10311

1 0

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Alex Henrie (＠alexhenrie) March 13, 2026

March 13, 2026

I think you meant to write https://bugs.winehq.org/show_bug.cgi?id=48291 in the commit message ;-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132229

1 0

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

On Fri Mar 13 22:01:21 2026 +0000, Alfred Agrell wrote: > Update this comment maybe? I figured context would make it clear enough, but if not I'll try to edit it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132228

1 0

Re: [PATCH v3 0/1] MR10309: vbscript: Split() should return an empty array for empty strings.
by Alexandre Julliard (＠julliard) March 13, 2026

March 13, 2026

No, bugs needs to be resolved FIXED manually (ideally after retesting to confirm the fix). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10309#note_132227

1 0

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Alfred Agrell (＠Alcaro) March 13, 2026

March 13, 2026

Alfred Agrell (@Alcaro) commented about dlls/ntdll/unix/signal_x86_64.c: > } > > > -#ifdef __APPLE__ > +#if defined(__APPLE__) || defined(PR_SET_SYSCALL_USER_DISPATCH) > /********************************************************************** > * sigsys_handler > * > * Handler for SIGSYS, signals that a non-existent system call was invoked. > * Only called on macOS 14 Sonoma and later. Update this comment maybe? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132226

1 0

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

The maybe touchy part of this feature is the logic to find and exclude libc. This is necessary because of sigreturn. (It would also be necessary because of the syscalls made from sigsys_handler itself, namely arch_prctl and the write generated by TRACE, but we could flip the toggle to avoid these.) Returning from the SIGSYS handler will jump back into PE code, but it does so using the sigreturn syscall, which itself will generate SIGSYS otherwise. We cannot flip the toggle after jumping back to PE code. The "exclusion area" was designed to address this exact problem. The proposed approach of dl_iterate_phdr() looks reasonable to me; it relies on documented APIs, and only needs to hardcode the name of libc. If we can't find libc for any reason (e.g. because the name is different, or it's statically linked), we simply don't use SUD. Still, concerns have been raised that this might seem too hacky, so for the sake of completeness here are the alternative approaches I see: * Instead of using dl_iterate_phdr(), parse /proc/self/maps. This is largely the same approach, but would avoid a hypothetical situation where for some reason dl_iterate_phdr() is hooked but the sigreturn syscalls are still in libc. I don't think we know of such a situation though. On the other hand, it would also avoid depending on glibc, instead using more Linux-specific interfaces. I doubt that this is the only glibc-specific logic in Wine, though. * Implement upstream a libc interface to return the area that must be excluded, or, more likely, an interface that simply establishes SUD without any exclusion area, and lets libc establish the exclusion area itself. This will take some time, of course. If this patch seems too hacky, or even "maybe hacky" such that judgement cannot be passed, I would appreciate an evaluation if any of these alternatives seems definitely better, or if none of them do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132225

1 0

[PATCH 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330

2 1

[PATCH v3 0/1] MR10318: Draft: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- v3: vbscript: Allow trailing End If in Else and ElseIf blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

2 1

[PATCH 0/5] MR10255: dsound: Speed up resampling, part 4
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255

3 14

Re: [PATCH v3 0/1] MR10309: vbscript: Split() should return an empty array for empty strings.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

@julliard will this automatically close the referenced wine-bug? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10309#note_132203

1 0

[PATCH v2 0/1] MR10318: Draft: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- v2: vbscript/tests: Add tests for trailing End If in Else and ElseIf blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

2 2