- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR10293: Fix crashes when for_ctrl->set is empty
by eric pouech (＠epo) March 13, 2026

March 13, 2026

two comments on on-going work (thanks for taking care of it): * I believe it's cleaner to dup the empty string in node_builder_parse (that would save a reallocation on every other set) * it's possible you cannot write tests as the crash happens only a) when run from a batch file, b) when echo mode in ON (and most of the tests are run with echo OFF) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10293#note_132199

1 0

[PATCH v7 0/1] MR10302: vbscript: Allow Const to be used before its declaration.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Pre-collect all Const declarations by walking the statement tree before compiling, matching native behavior where constants are visible throughout their enclosing scope. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56931 -- v7: vbscript: Allow Const to be used before its declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10302

2 1

Re: [PATCH v4 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

On Fri Mar 13 12:56:24 2026 +0000, Francis De Brabandere wrote: > removed and rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10310#note_132187

1 0

Re: [PATCH v3 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

On Fri Mar 13 12:56:13 2026 +0000, Francis De Brabandere wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/10310/diffs?diff_id=250773&start_sha=347d8bf1d7b7ca8470ab15cc688da06156aa980d#18a8771bf91222ebfc4599f53729c95217a5ab51_2295_2295) removed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10310#note_132184

1 0

[PATCH 0/1] MR10328: msxml3/sax: Do not attempt to add default attributes for definitions without values.
by Nikolay Sivov (＠nsivov) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10328

2 1

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

On Fri Mar 13 11:04:36 2026 +0000, Jacek Caban wrote: > Could you please check whether this is fixed in a newer version? The > part that was merged was a minimal update to introduce the C++ > dependency, but here is an update to a more recent version: https://gitlab.winehq.org/jacek/wine/-/tree/fluidsynth No, it's still an issue in both 2.4.8 and 2.5.3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132181

1 0

[PATCH 0/1] MR10326: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan).
by Bernhard Übelacker March 13, 2026

March 13, 2026

The function `validate_fmt` may receive a pointer which got just reserved memory for the `WAVEFORMATEX`. Unfortunately the assignment `fmt2 = *fmt` always copies the size of `WAVEFORMATEXTENSIBLE`. CC: @giomasce (I currently cannot point to a specific commit, but this may also be related to the recent changes?) <details> <summary>ASan details [gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/237050#L2464)</summary> ``` ==qcap_test.exe==728==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0022c122 at pc 0x785f4342 bp 0x0022bf4c sp 0x0022bb1c READ of size 40 at 0x0022c122 thread T0 #0 0x785f4341 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x778957a5 in validate_fmt /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 #2 0x77896d1e in client_IsFormatSupported /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:881:10 #3 0x783e3624 in IAudioClient_IsFormatSupported /builds/bernhardu/wine/build64/include/audioclient.h:406:12 #4 0x783e5cd7 in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:454:10 #5 0x783e5928 in WINMM_GetSupportedFormats /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:504:14 #6 0x783e553b in WINMM_InitMMDevice /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:524:35 #7 0x783e4e9b in WINMM_EnumDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:610:17 #8 0x783d30e8 in WINMM_InitMMDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:856:10 #9 0x7be4a996 in RtlRunOnceExecuteOnce /builds/bernhardu/wine/build64/../dlls/ntdll/sync.c:462:10 ... Address 0x0022c122 is located in stack of thread T0 at offset 34 in frame #0 0x783e5c0f in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:442 This frame has 2 object(s): [16, 34) 'fmt' (line 443) <== Memory access at offset 34 overflows this variable [80, 84) 'junk' (line 443) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 in validate_fmt ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10326

1 2

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Jacek Caban (＠jacek) March 13, 2026

March 13, 2026

On Fri Mar 13 08:31:10 2026 +0000, Anton Baskanov wrote: > Weirdly, I get a sudden volume increase of the drums in some MIDI files. > It wasn't like this before this patch. Haven't figured out what's going > on exactly. Could you please check whether this is fixed in a newer version? The part that was merged was a minimal update to introduce the C++ dependency, but here is an update to a more recent version: https://gitlab.winehq.org/jacek/wine/-/tree/fluidsynth -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132178

1 0

[PATCH 0/1] MR10317: vbscript: Allow Not operator as operand of comparison expressions.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

The Not operator was only reachable from the NotExpression grammar rule, which sat above EqualityExpression in the precedence chain. This meant expressions like "a <> Not b" caused a syntax error because the right-hand side of a comparison could not contain Not. Adding Not as a unary operator in SignExpression (alongside unary minus and plus) allows it to be used within comparison operands. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55093 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10317

3 2

[PATCH v2 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

fixes https://bugs.winehq.org/show_bug.cgi?id=55006 -- v2: vbscript: Allow empty Else blocks in If statements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10310

3 2

[PATCH v3 0/3] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 13, 2026

March 13, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v3: comctl32: Expand only when the range is exceeded in ImageList_Add. comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

2 3

[PATCH v2 0/3] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 13, 2026

March 13, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v2: comctl32: Expand only when the range is exceeded in ImageList_Add. comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

1 1

[PATCH 0/1] MR10325: comctl32: Fix some typos in the comments.
by Nikolay Sivov (＠nsivov) March 13, 2026

March 13, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10325

3 3

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

On Fri Mar 13 08:31:10 2026 +0000, Michael Stefaniuc wrote: > @baskanov would be a way better reviewer for the `fluidsynth: Import > upstream release 2.4.3.` commit. > I know he worked with upstream fluidsynth. Weirdly, I get a sudden volume increase of the drums in some MIDI files. It wasn't like this before this patch. Haven't figured out what's going on exactly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132161

1 0

[PATCH 0/3] MR10249: Typos
by Diego Colin (＠docolta) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10249

4 11

Re: [PATCH v4 0/1] MR10294: Fix start word position \\<
by Hans Leidekker (＠hans) March 13, 2026

March 13, 2026

Hans Leidekker (@hans) commented about programs/findstr/main.c: > static BOOL match_regexp(const char *str, const char *regexp, BOOL case_sensitive) > { > if (strstr(regexp, "[")) FIXME("character ranges (i.e. [abc], [^a-z]) are not supported\n"); > - if (strstr(regexp, "\\<") || strstr(regexp, "\\>")) FIXME("word position (i.e. \\< and \\>) not supported\n"); > + if (strstr(regexp, "\\<") != regexp || strstr(regexp, "\\>")) FIXME("word position (i.e. \\< and \\>) not supported\n"); Now the fixme will also printed for every regexp that where \\< doesn't occur. The condition should be something like this: `if ((strstr(regexp, "\\<") && strstr(regexp, "\\<") != regexp) || strstr(regexp, "\\>"))` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10294#note_132155

1 0

[PATCH v7 0/6] MR10126: mf: Implement Scrubbing in SAR.
by Brendan McGrath (＠redmcg) March 13, 2026

March 13, 2026

This MR adds the `IMFPresentationTimeSource` interface to SAR and adds support for scrubbing. -- v7: mf: Report seek time up until we render past this point. mf: Discard samples prior to current seek time. mf: Implement Scrubbing in SAR. mf: Check provided presentation clock has a time source. mf: Implement presentation time source for SAR. mf: Replace state variable with clock_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/10126

3 9

[PATCH 0/1] MR10323: mxsml3/tests: Add tests for put_text.
by Daniel Lehman (＠dlehman25) March 13, 2026

March 13, 2026

https://gitlab.winehq.org/wine/wine/-/merge_requests/10202#note_132045 calling IXMLDOMNode_put_text on a text node leads to xmlTextSetContent in libxml2 which duplicates the text (xmlStr[n]dup) and frees the old content before setting the new calling IXMLDOMElement_put_text on an element node leads to xmlNodeParseContent in libxml2 which sets the text on the xmlNode's child and calls xmlFreeNodeList to free the old content an IXMLDOMNode reference to that internal text node holds a pointer to that freed content and crashes on IXMLDOMNode_Release <open> <-- IXMLDOMElement_put_text -> xmlNodeParseContent frees old 'content' held by IXMLDOMNode below sesame <-- IXMLDOMNode_Release on this node double-frees 'content' freed above </open> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323

3 2

[PATCH v2 0/4] MR10261: Fix toolbar wrapping issues
by Ivan Ivlev (＠iviv) March 13, 2026

March 13, 2026

This MR resolves two bugs with toolbar wrapping I have discovered. 1. Toolbar missing four buttons when app window is maximized (wrap should not appear at all in this case). 2. Last toolbar button disappears when window size (toolbar size) is slightly narrower then button right border. Reasons of this behavior: 1. Toolbar buttons have BTNS_AUTOSIZE style, toolbar width is set using CCS_NORESIZE and equals to widths of all autosized buttons combined. cx (button width) value in TOOLBAR_WrapToolbar is set from nButtonWidth, which contains widest button width. Since buttons in toolbar have different widths, TOOLBAR_WrapToolbar miscalculates total width, because actual buttons widths are less then nButtonWidth. This results in TOOLBAR_WrapToolbar setting TBSTATE_WRAP when it is not not needed, and since app does not paint second button row, wrapped buttons just disappear. 2. After I fixed first issue, I noticed, that last button disappears, when toolbar become narrower then its right border. Then, when toolbar right border approximately in the middle of disappeared button, wrap happens. In windows system, wrapping occurs immediately when toolbar becomes narrower. Found solutions: 1. I noticed, that TOOLBAR_LayoutToolbar calculates buttons rects differently, thats because it checks if button have BTNS_AUTOSIZE style and then calculate size. So i moved this BTNS_AUTOSIZE size calculation in separate function for it to then be used in TOOLBAR_LayoutToolbar and TOOLBAR_WrapToolbar to guarantee that cx values for specific button will be equal in both functions. 2. TOOLBAR_WrapToolbar function decides to wrap in case `if ((x + cx - (infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2 > width).` This `(infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2` turns out, makes this gap, where button right border (x + cx) exceed toolbar right border (width), but wrap wont appear. I did not found any reasons to make this half-button gap, so I just removed it and it solved this issue. The comment above says /\* The layout makes sure the bitmap is visible, but not the button. \*/, but it was introduced in 1999, when TOOLBAR_LayoutToolbar did not existed, and I think its irrelevant now, since layout calculates cx taking both bitmap and string into account. I wrote tests for both fixes: 1. Creates CCS_NORESIZE toolbar, then add BTNS_AUTOSIZE buttons of different widths one by one and checks if wrap happened. In normal case (in windows) wrap should only happen on fourth button, but without fix wrap happens on third. 2. Creates CCS_NORESIZE toolbar with 4 BTNS_AUTOSIZE buttons. Toolbar width at the creation is calculated beforehand and equals exactly buttons widths combined. Then test reduces toolbar width by 1 and checks if wrap happened, in normal case wrap happens, without the fix its not. -- v2: comctl32/toolbar.c: Wrap toolbar immediately after width exceeded comctl32/tests/toolbar.c: Test wrapping occurs immediately when needed https://gitlab.winehq.org/wine/wine/-/merge_requests/10261

2 4

Re: [PATCH v3 0/1] MR10265: Draft: winewayland: Implement support for min/max window size hints.
by Etaash Mathamsetty (＠etaash.mathamsetty) March 13, 2026

March 13, 2026

this still has a bug (when there is a scaling factor) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10265#note_132147

1 0

Re: [PATCH v6 0/2] MR9180: win32u: Fix deadlock caused by nested locking. - closed
by Zhao Yi (＠Zhaoyi) March 13, 2026

March 13, 2026

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9180

1 0

[PATCH v4 0/2] MR10321: mfsrcsnk: Parse pixel aspect ratio from the avcC atom.
by Yuxuan Shui (＠yshui) March 13, 2026

March 13, 2026

More specifically the SPS bytes in the avcC atom. Note this only fixes the problem for winedmo but not gstreamer. This is because gstreamer 1) does not parse the SPS, 2) will set pixel-aspect-ratio in caps regardless if a pasp atom is present. So there is no way for us to distinguish between 1) pasp being present and having an aspect ratio of 1:1, and 2) pasp not being present but pixel-aspect-ratio having been set to 1:1 by gstreamer as fallback. And because this is the case, I made sure winedmo is tested separately. In winedmo's case, if pasp is not present, we can set the PixelAspectRatio.Denominator in MFVIDEOFORMAT to 0 to distinguish. -- v4: mfsrcsnk: Parse pixel aspect ratio from the avcC atom. mfsrcsnk: Test how pixel aspect ratio metadata in an mp4 file are handled. https://gitlab.winehq.org/wine/wine/-/merge_requests/10321

2 3

[PATCH 0/1] MR10322: icu/tests: Add initial tests.
by Zhiyi Zhang (＠zhiyi) March 13, 2026

March 13, 2026

This is mainly to test that ICU data is loaded properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10322

2 1

Re: [PATCH v4 0/2] MR9180: win32u: Fix deadlock caused by nested locking. - closed
by Zhao Yi (＠Zhaoyi) March 13, 2026

March 13, 2026

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9180

1 0

[PATCH v18 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński March 13, 2026

March 13, 2026

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v18: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

1 4