- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

3 4

[PATCH v2 0/2] MR10305: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface.
by Paul Gofman (＠gofman) March 12, 2026

March 12, 2026

-- v2: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/10305

3 5

[PATCH 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

3 3

[PATCH 0/1] MR10316: d2d1: Do not reference layer objects when recording to the command list.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10316

2 1

[PATCH 0/1] MR10315: mfplay: Remove incorrect fixme for MFP_EVENT_TYPE_ERROR.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

This type is already handled, no need for such message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10315

2 1

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

I'm not the one responsible for this area, but I added my comments. If there are any applications or bug reports depending on the behavior you suggest, please let us know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132030

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + > + nt_header.FileHeader.NumberOfSections = 1; > + nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER); > + > + nt_header.OptionalHeader.SectionAlignment = page_size; > + nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE; > + nt_header.OptionalHeader.FileAlignment = page_size; > + nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER); > + nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size; > + > + create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a ); > + mod = LoadLibraryA( dll_name_a ); > + ok(mod != NULL, "can't load test dll\n"); > + if (mod != NULL) > + { > + dll_name[0] = 0; Likewise below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132029

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); It would be better to avoid using magic numbers and use `'\t'` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132028

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/loader.c: > SetLastError( RtlNtStatusToDosError( status )); > done: > TRACE( "%s\n", debugstr_wn(filename, len) ); > + if (!status || status == STATUS_BUFFER_TOO_SMALL) > + { > + if (len < size) > + filename[len] = 0; > + else if (size > 0) Consider adding a test for the false case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132027

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/loader.c: > SetLastError( RtlNtStatusToDosError( status )); > done: > TRACE( "%s\n", debugstr_wn(filename, len) ); > + if (!status || status == STATUS_BUFFER_TOO_SMALL) > + { > + if (len < size) > + filename[len] = 0; > + else if (size > 0) > + filename[size - 1] = 0; Does this also apply to the Win16 case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132026

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) You could expand the test to cover basic `GetModuleFileName()` behaviors, and rename the function to `test_GetModuleFileName` accordingly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132025

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); > + GetModuleFileNameW(NULL, dll_name, dll_name_len); Since the buffer is insufficient, you should check the value of `GetLastError()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132024

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + char dll_name_a[MAX_PATH]; > + HMODULE mod; > + > + nt_header.FileHeader.NumberOfSections = 1; > + nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER); > + > + nt_header.OptionalHeader.SectionAlignment = page_size; > + nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE; > + nt_header.OptionalHeader.FileAlignment = page_size; > + nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER); > + nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size; > + > + create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a ); > + mod = LoadLibraryA( dll_name_a ); > + ok(mod != NULL, "can't load test dll\n"); > + if (mod != NULL) This `if` is redundant; the previous test already covers this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132023

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + > + { > + IMAGE_NT_HEADERS nt_header = nt_header_template; > + char dll_name_a[MAX_PATH]; > + HMODULE mod; > + > + nt_header.FileHeader.NumberOfSections = 1; > + nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER); > + > + nt_header.OptionalHeader.SectionAlignment = page_size; > + nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE; > + nt_header.OptionalHeader.FileAlignment = page_size; > + nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER); > + nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size; > + > + create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a ); I don't think it's necessary to create a new DLL file. How about using an existing one, such as shell32.dll? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132022

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); > + GetModuleFileNameW(NULL, dll_name, dll_name_len); > + for (i = 0; i < MAX_PATH && dll_name[i]; i++) > + ; > + ok(i > 0, "can't get path for NULL module with short buffer\n"); > + ok(i < MAX_PATH, "unterminated path for NULL module with short buffer\n"); > + if (i < MAX_PATH) It would be best to use the `todo_wine` keyword here instead of an `if` statement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132021

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); > + GetModuleFileNameW(NULL, dll_name, dll_name_len); > + for (i = 0; i < MAX_PATH && dll_name[i]; i++) > + ; > + ok(i > 0, "can't get path for NULL module with short buffer\n"); > + ok(i < MAX_PATH, "unterminated path for NULL module with short buffer\n"); You might want to compare this with the return value here as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132020

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); > + GetModuleFileNameW(NULL, dll_name, dll_name_len); > + for (i = 0; i < MAX_PATH && dll_name[i]; i++) > + ; You can replace this implementation with `wcsnlen()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132019

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); You might want to add a return‑value check and compare it with `wcslen()` result to determine success or failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132018

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; This assignment is redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132016

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); It's unclear what the actual value of `dll_name_len` is. See [[Writing good error messages|Wine-Developer's-Guide/Writing-Conformance-Tests#writing-good-error-messages]] for details. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132017

1 0

[PATCH v12 0/1] MR10244: vbscript: Fix Sub first argument parentheses handling.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

Closes https://bugs.winehq.org/show_bug.cgi?id=54177 Fix parsing of expressions like `Sub (i - 20) * 8,y` where a space-separated parenthesized expression followed by a binary operator(*` /` \` ^` &`) was incorrectly treated as call argument parentheses instead of expression grouping. If you look at all the extra test cases in `lang.vbs` you will see which parentheses related issues this solves. I have been testing with a repo full of scripts: https://github.com/sverrewl/vpxtable_scripts There are still quite some compiler issues left but this addresses the biggest parser issues. -- v12: vbscript: Fix Sub first argument parentheses handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/10244

2 1

[PATCH v6 0/1] MR10302: vbscript: Collect const declarations upfront.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

fixes https://bugs.winehq.org/show_bug.cgi?id=56931 -- v6: vbscript: Collect const declarations upfront. https://gitlab.winehq.org/wine/wine/-/merge_requests/10302

2 1

[PATCH v16 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński March 12, 2026

March 12, 2026

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v16: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

2 5

[PATCH v7 0/1] MR10308: vbscript: Fix chained array indexing on call expression results.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

fixes * https://bugs.winehq.org/show_bug.cgi?id=58026 * https://bugs.winehq.org/show_bug.cgi?id=58056 -- v7: vbscript: Fix chained array indexing on call expression results. https://gitlab.winehq.org/wine/wine/-/merge_requests/10308

2 1

[PATCH v3 0/1] MR10312: vbscript: fix dot member access after line continuation
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

fixes https://bugs.winehq.org/show_bug.cgi?id=56480 The lexer distinguishes '.' (member access) from tDOT (with-statement expression) by checking the character before the dot. After a line continuation (_), ptr[-1] is a newline or whitespace instead of the actual preceding token, causing the dot to be incorrectly treated as a with-expression. Track when a line continuation was just consumed and use last_token to resolve the ambiguity in that case. -- v3: vbscript: Fix dot member access after line continuation. https://gitlab.winehq.org/wine/wine/-/merge_requests/10312

2 1