- Wine-GitLab - list.winehq.org

[PATCH v7 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 7, 2026

March 7, 2026

This PR addresses two issues that I observed preventing the Native Instruments Kontakt Player MSI (and other MSI files from the same vendor) from successfully finishing: 1. Some installers contain padding for 4-byte alignment of table streams. * Proposed fix: We relax Wine's parsing to allow for such padding. 2. Some installers declare that they have 3-byte strrefs, but the data actually contains 2-byte strrefs. This looks like a malformed MSI to me, and Wine correctly rejects them currently. The regression tests in this PR indicate that Windows in CI (test-win10-21h2-\*) is reading garbage as well. However, NI ships these MSI files, which implies that somehow the installation successfully completes on Windows machines nevertheless. * Proposed fix: We explicitly detect and correct this particular mismatch at load time of the MSI, in order to be able to complete the installation under Wine as well. --- The above are technically separate issues, but they affect the same software in similar ways, so I opted for one PR. Please me know if I should split them. --- Quick repro hint: Native Instruments offers a program called Native Access (which acts as an installation hub on the user's machine). On user request, NA downloads and launches the affected MSI files in the background. If you try to repro, a couple of things to watch out for: 1. NA seems to always report a successful installation, even when the underlying MSI fails to complete (and therefore nothing is installed). This PR does nothing to address this false positive, as it is most likely a logic bug in the hub or installation orchestration. 2. To observe/examine the underlying MSI files (including the fix presented here), you'll need to grab them after NA downloads and extracts them on your machine (or find manual/direct downloads on the NI website, where applicable) --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issues and coming up with fixes._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v7: msi/tests: Add regression tests for table stream padding and mismatched string refs. msi: Detect mismatched bytes_per_strref in table data. msi: Handle padding bytes in table streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

2 3

[PATCH v6 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 7, 2026

March 7, 2026

This PR addresses two issues that I observed preventing the Native Instruments Kontakt Player MSI (and other MSI files from the same vendor) from successfully finishing: 1. Some installers contain padding for 4-byte alignment of table streams. * Proposed fix: We relax Wine's parsing to allow for such padding. 2. Some installers declare that they have 3-byte strrefs, but the data actually contains 2-byte strrefs. This looks like a malformed MSI to me, and Wine correctly rejects them currently. The regression tests in this PR indicate that Windows in CI (test-win10-21h2-\*) is reading garbage as well. However, NI ships these MSI files, which implies that somehow the installation successfully completes on Windows machines nevertheless. * Proposed fix: We explicitly detect and correct this particular mismatch at load time of the MSI, in order to be able to complete the installation under Wine as well. --- The above are technically separate issues, but they affect the same software in similar ways, so I opted for one PR. Please me know if I should split them. --- Quick repro hint: Native Instruments offers a program called Native Access (which acts as an installation hub on the user's machine). On user request, NA downloads and launches the affected MSI files in the background. If you try to repro, a couple of things to watch out for: 1. NA seems to always report a successful installation, even when the underlying MSI fails to complete (and therefore nothing is installed). This PR does nothing to address this false positive, as it is most likely a logic bug in the hub or installation orchestration. 2. To observe/examine the underlying MSI files (including the fix presented here), you'll need to grab them after NA downloads and extracts them on your machine (or find manual/direct downloads on the NI website, where applicable) --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issues and coming up with fixes._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v6: msi/tests: Add regression tests for table stream padding and mismatched string refs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

2 3

[PATCH v5 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 7, 2026

March 7, 2026

This PR addresses two issues that I observed preventing the Native Instruments Kontakt Player MSI (and other MSI files from the same vendor) from successfully finishing: 1. Some installers contain padding for 4-byte alignment of table streams. * Proposed fix: We relax Wine's parsing to allow for such padding. 2. Some installers declare that they have 3-byte strrefs, but the data actually contains 2-byte strrefs. This looks like a malformed MSI to me, and Wine correctly rejects them currently. The regression tests in this PR indicate that Windows in CI (test-win10-21h2-\*) is reading garbage as well. However, NI ships these MSI files, which implies that somehow the installation successfully completes on Windows machines nevertheless. * Proposed fix: We explicitly detect and correct this particular mismatch at load time of the MSI, in order to be able to complete the installation under Wine as well. --- The above are technically separate issues, but they affect the same software in similar ways, so I opted for one PR. Please me know if I should split them. --- Quick repro hint: Native Instruments offers a program called Native Access (which acts as an installation hub on the user's machine). On user request, NA downloads and launches the affected MSI files in the background. If you try to repro, a couple of things to watch out for: 1. NA seems to always report a successful installation, even when the underlying MSI fails to complete (and therefore nothing is installed). This PR does nothing to address this false positive, as it is most likely a logic bug in the hub or installation orchestration. 2. To observe/examine the underlying MSI files (including the fix presented here), you'll need to grab them after NA downloads and extracts them on your machine (or find manual/direct downloads on the NI website, where applicable) --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issues and coming up with fixes._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v5: msi/tests: Add regression tests for table stream padding and mismatched string refs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

2 3

[PATCH v4 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 7, 2026

March 7, 2026

This PR addresses two issues that I observed preventing the Native Instruments Kontakt Player MSI (and other MSI files from the same vendor) from successfully finishing: 1. Some installers contain padding for 4-byte alignment of table streams. * Proposed fix: We relax Wine's parsing to allow for such padding. 2. Some installers declare that they have 3-byte strrefs, but the data actually contains 2-byte strrefs. This looks like a malformed MSI to me, and Wine correctly rejects them currently. The regression tests in this PR indicate that Windows in CI (test-win10-21h2-\*) is reading garbage as well. However, NI ships these MSI files, which implies that somehow the installation successfully completes on Windows machines nevertheless. * Proposed fix: We explicitly detect and correct this particular mismatch at load time of the MSI, in order to be able to complete the installation under Wine as well. --- The above are technically separate issues, but they affect the same software in similar ways, so I opted for one PR. Please me know if I should split them. --- Quick repro hint: Native Instruments offers a program called Native Access (which acts as an installation hub on the user's machine). On user request, NA downloads and launches the affected MSI files in the background. If you try to repro, a couple of things to watch out for: 1. NA seems to always report a successful installation, even when the underlying MSI fails to complete (and therefore nothing is installed). This PR does nothing to address this false positive, as it is most likely a logic bug in the hub or installation orchestration. 2. To observe/examine the underlying MSI files (including the fix presented here), you'll need to grab them after NA downloads and extracts them on your machine (or find manual/direct downloads on the NI website, where applicable) --- _Disclaimers for reviewers:_ * _AI was used while tracking down the issues and coming up with fixes._ * _I am not affiliated with Native Instruments, I'm just a user._ -- v4: msi/tests: Add regression tests for table stream padding and mismatched string refs. msi: Detect mismatched bytes_per_strref in table data. msi: Handle padding bytes in table streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

2 3

[PATCH v2 0/1] MR10230: combase: Add RoFailFastWithErrorContext stub
by Alistair Leslie-Hughes (＠alesliehughes) March 7, 2026

March 7, 2026

-- v2: combase: Add RoFailFastWithErrorContext stub https://gitlab.winehq.org/wine/wine/-/merge_requests/10230

4 3

[PATCH 0/3] MR10262: {mmdevapi,winmm}/tests: Fix some test failures.
by Giovanni Mascellani (＠giomasce) March 7, 2026

March 7, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10262

3 4

[PATCH v2 0/6] MR10243: mmdevapi: Take the wave format validation code from the tests.
by Giovanni Mascellani (＠giomasce) March 7, 2026

March 7, 2026

-- v2: mmdevapi: Take the wave format validation code from the tests. mmdevapi: Do not query for format support in spatial audio. https://gitlab.winehq.org/wine/wine/-/merge_requests/10243

3 7

[PATCH 0/2] MR10235: gdiplus: Validate window handle in has_gdi_dc
by Yeshun Ye (＠yeyeshun) March 7, 2026

March 7, 2026

graphics->owndc being TRUE indicates that graphics is created using GdipCreateFromHWND. In has_gdi_dc, it is necessary to check whether the window has already been destroyed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10235

3 10

[PATCH 0/1] MR10259: winewayland.drv: Add support for server-side decorations
by zhengyong chen (＠chenzhengyong) March 7, 2026

March 7, 2026

Some compositors support server-side decorated windows. Adding support for SSD will make some windows style(for example: regedit, winecfg. etc) better match the system. There was already a MR https://gitlab.winehq.org/wine/wine/-/merge_requests/8004 previously, but it had not been addressed for a long time. I have re-implemented the functionality here, and part of the processing code references the previous handling logic（in wayland_configure_window function）. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10259

3 7

[PATCH v26 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Vishnunithyasoundhar S (＠svishnunithyasoundhar) March 6, 2026

March 6, 2026

``` Support the \\?\ prefix by skipping it during path resolution while preserving it in the output. Added specific handling for extended UNC paths (\\?\UNC\) to mirror standard UNC behavior, ensuring these paths are treated as network shares and not local devices. Some paths that use the extended length path were filtered out as UNC paths - but not all of them are UNC. There can be UNC path that use extended length path but not all extended length paths are UNC paths. ``` Signed-off-by: Vishnunithyasoundhar S svishnunithyasoundhar(a)gmail.com -- v26: fix: extended-file-name support https://gitlab.winehq.org/wine/wine/-/merge_requests/10192

2 1