- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find
by Alistair Leslie-Hughes (＠alesliehughes) May 19, 2023

May 19, 2023

Find only supports one Column to filter on. The parser for this will be the same for both Find/Filter with the only different is the Filter supports multiple columns. In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases). -- v2: msado15: Implement _Recordset Find https://gitlab.winehq.org/wine/wine/-/merge_requests/2498

3 34

[PATCH v2 0/5] MR206: vkd3d-shader/hlsl: Implement SampleCmp() method.
by Nikolay Sivov (＠nsivov) May 19, 2023

May 19, 2023

-- v2: vkd3d-shader/tpf: Write out comparison mode sampler declarations and corresponding sampling instruction. vkd3d-shader/hlsl: Parse SampleCmp() method. vkd3d-shader/hlsl: Parse SamplerComparisonState objects. vkd3d-shader/hlsl: Use a function table for object methods handlers. vkd3d-shader/hlsl: Move object type checks to methods handlers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/206

4 10

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) May 19, 2023

May 19, 2023

> If you mean setting `O_NONBLOCK` on `server`, that would cause `accept` to return `EWOULDBLOCK` or `EAGAIN`. No, I mean you can set O_NONBLOCK on "client", i.e. the socket that calls connect(). > By "clean up", do you mean only calling `WaitForSingleObject` on it, or is there more that I would need to do? Wait for it and close the handle. It should be unnecessary if you just use nonblocking i/o with the socket, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33265

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) May 19, 2023

May 19, 2023

> ~~Yes,~~ `SO_REUSEADDR` is a valid option on AF_UNIX sockets and is supported by this patch. I'll add a test for it. It looks like this is only true for abstract AF_UNIX sockets, which are expressly unsupported due to Windows' own lack of support for them. Okay, I think I was assuming that "unbinding" meant doing the opposite of bind(), rather than "allowing other sockets to use that address". It'd be nice to have some tests for that functionality, then: * test that trying to use the same address *without* deleting the socket fails (even if you close the socket handle? That part is very surprising to me.) * test that trying to use the same address after deleting the socket succeeds, which currently isn't actually tested. * Can the socket be used normally after deleting it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33264

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) May 19, 2023

May 19, 2023

On Fri May 19 04:17:50 2023 +0000, Ally Sommers wrote: > That's true, but `PATH_MAX` is 4096 on my system, while `sun_path` is a > `char[108]`. The path returned by `wine_get_unix_file_name` can very > easily exceed that. Thus a vararg is needed to conditionally pass the > Unix path to wineserver if we're dealing with an AF_UNIX socket. I still don't understand the issue. The sockaddr we pass to the server is already variable-sized. It's passed as variable-sized input data, using the "ioctl" request, with the code IOCTL_AFD_BIND. Why is sockaddr_un any different from sockaddr_in? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33263

1 0

[PATCH 0/4] MR2861: dinput: Test and fix loading of action maps to the registry.
by Rémi Bernon May 19, 2023

May 19, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54917 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2861

2 6

[PATCH 0/2] MR2849: comdlg32: Make item dialog and file access dialogs a bit more HiDPI friendly.
by Jactry Zeng (＠jactry) May 19, 2023

May 19, 2023

Toolbar buttons won't adjust its size to fit the DPI setting. This two patches set a DPI-considered size to those buttons to make them look better in HiDPI. Here are some comparisons on Wine with 192 DPI: ![get_open_file_before](/uploads/3e786396666fd84d824a4fa1e881d712/get_open_file_before.png) vs ![get_open_file_after](/uploads/f6f3ed910e026d94635ba9cae8f1cc81/get_open_file_after.png) ![item_dialog_before](/uploads/936fab928adb54a3bdf055190332c30d/item_dialog_before.png) vs ![item_dialog_after](/uploads/f74242d52dc461097368897982b0273b/item_dialog_after.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2849

4 6

Re: [PATCH v3 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Esme Povirk (＠madewokherd) May 19, 2023

May 19, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c: > stat = GdipCreateFontFamilyFromName(L"Times New Roman", NULL, nativeFamily); > > if (stat == FontFamilyNotFound) > + // Liberation Serif is free replacement of Times New Roman font `//` comments are not allowed in Wine. Also, I don't think a comment is really needed for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33255

1 0

Re: [PATCH v3 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Esme Povirk (＠madewokherd) May 19, 2023

May 19, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/font.c: > stat = GdipCreateFontFamilyFromName(L"Liberation Mono", NULL, nativeFamily); > > if (stat == FontFamilyNotFound) > - ERR("Missing 'Courier New' font\n"); > + stat = GdipGetGenericFontFamilySansSerif(nativeFamily); Wouldn't it be better to fall back to a monospace font Wine ships with? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2850#note_33254

1 0

[PATCH 0/1] MR2860: gdi32: Mark objects as not used before clearing handles table in emf_reset.
by Piotr Caban (＠piotr) May 19, 2023

May 19, 2023

It should fix [bug 54936](https://bugs.winehq.org/show_bug.cgi?id=54936). I'm expecting this change to also affect [bug 54956](https://bugs.winehq.org/show_bug.cgi?id=54956). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2860

3 2