- Wine-GitLab - list.winehq.org

[PATCH 0/2] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) May 9, 2023

May 9, 2023

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

3 10

[PATCH 0/1] MR2772: imm32/tests: Mark some tests as broken by prior SetForegroundWindow call.
by Rémi Bernon May 9, 2023

May 9, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54760 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2772

2 2

[PATCH v3 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) May 9, 2023

May 9, 2023

Found while running a bunch of D3D9 shaders through MojoShader's HLSL emitter. -- v3: vkd3d-shader/hlsl: Fold constant integral abs(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203

3 3

Re: [PATCH v2 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Giovanni Mascellani (＠giomasce) May 9, 2023

May 9, 2023

On Tue May 9 13:57:15 2023 +0000, Ethan Lee wrote: > I could see this getting hit again if fold_exprs got used elsewhere - if > we can't fold abs(INT_MIN), would it make sense to leave the expression > untouched and let the runtime deal with it instead? I can add a quick > ``` > /* abs(INT_MIN) is undefined, leave this expression alone */ > if (src->value.u[k].i == INT_MIN) > return false; > ``` > if so. That's fine for me. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_32287

1 0

[PATCH 0/10] MR2768: wineps: Start moving remaining gdi driver functions to unixlib.
by Piotr Caban (＠piotr) May 9, 2023

May 9, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2768

3 11

Re: [PATCH v2 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) May 9, 2023

May 9, 2023

On Tue May 9 10:35:56 2023 +0000, Giovanni Mascellani wrote: > This is undefined behavior on `INT_MIN`. > Actually, this case is somewhat interesting, because `lower_int_abs()` > runs before constant expression folding, and should get rid of all `int` > absolute values. So in principle we could stick `vkd3d_unreachable()` > here. However `lower_int_abs()` does not run when doing constant folding > from `evaluate_static_expression_as_uint()`, so this is still reachable. > I'm not sure of what the others think, but I think I would be in favor > to stipulating that this is unreachable and add other passes to `evaluate_static_expression_as_uint()`. I could see this getting hit again if fold_exprs got used elsewhere - if we can't fold abs(INT_MIN), would it make sense to leave the expression untouched and let the runtime deal with it instead? I can add a quick ``` /* abs(INT_MIN) is undefined, leave this expression alone */ if (src->value.u[k].i == INT_MIN) return false; ``` if so. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_32279

1 0

[PATCH 0/1] MR2770: winedump: Fix copy & paste error.
by eric pouech (＠epo) May 9, 2023

May 9, 2023

(Thanks to Andrey for point it out). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2770

3 3

[PATCH v8 0/7] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) May 9, 2023

May 9, 2023

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v8: vkd3d-shader/tpf: Validate input and output index ranges for default control point phases. vkd3d-shader/tpf: Remove an unnecessary carriage return from a parser error message. vkd3d-shader/tpf: Validate index range declarations. vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

4 11

[PATCH v3 0/6] MR2769: imm32: Factor NotifyIME implementations.
by Rémi Bernon May 9, 2023

May 9, 2023

Doing first instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/2637, as it should be more straightforward. -- v3: winemac: Use the default IME implementation for NotifyIME. winex11: Move NotifyIME to the default IME implementation. win32u: Introduce new NtUserNotifyIMEStatus syscall. winex11: Simplify NotifyIME with NI_COMPOSITIONSTR / CPS_COMPLETE. winex11: Clear the composition string when input context is closed. winex11: Use a helper to change internal composition status. https://gitlab.winehq.org/wine/wine/-/merge_requests/2769

2 9

[PATCH v4 0/4] MR2764: wine{alsa,coreaudio,oss,pulse}: Move AudioStreamVolume into mmdevapi.
by Davide Beatrici (＠davidebeatrici) May 9, 2023

May 9, 2023

-- v4: wineoss: Use mmdevapi's AudioStreamVolume. winecoreaudio: Use mmdevapi's AudioStreamVolume. winealsa: Use mmdevapi's AudioStreamVolume. winepulse: Move AudioStreamVolume into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2764

3 5