- Wine-GitLab - list.winehq.org

Re: [PATCH v9 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

1 0

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546

1 0

Re: [PATCH v2 0/1] MR2656: winegstreamer: Call init_gstreamer() in winegstreamer_create_video_decoder(). - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2656

1 0

Re: [PATCH v2 0/1] MR2655: winegstreamer: Fix negative height image size calculation. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2655

1 0

Re: [PATCH v2 0/3] MR164: vkd3d: Support 1D textures. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/164

1 0

Re: [PATCH v4 0/7] MR153: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 1. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/153

1 0

Re: [PATCH v2 0/4] MR152: vkd3d-shader/hlsl: Fixes for sm1 semantics. - approved
by Alexandre Julliard (＠julliard) April 18, 2023

April 18, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/152

1 0

[PATCH v3 0/2] MR161: vkd3d-shader/hlsl: Implement D3DCOLORtoUBYTE4().
by Nikolay Sivov (＠nsivov) April 18, 2023

April 18, 2023

-- v3: vkd3d-shader/hlsl: Implement D3DCOLORtoUBYTE4() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/161

2 4

[PATCH v2 0/4] MR2670: uiautomationcore: Implement root element retrieval and add support for cache request normalization.
by Connor McAdams (＠cmcadams) April 18, 2023

April 18, 2023

-- v2: uiautomationcore: Add normalization navigation to UiaGetUpdatedCache. uiautomationcore: Implement conditional NavigateDirection_Parent navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2670

3 6

Re: [PATCH v3 0/1] MR499: server: Allow cancelling alerted asyncs.
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

> I don't think so. `async_terminate()` is currently no-op if the async has already been terminated with a status other than `STATUS_ALERTED`, and the patch maintains this invariant. Right, that's the bit I failed to think through. > It is possible to introduce a new boolean flag, but the flag cannot replace `terminate_status`. `terminate_status` can be any arbitrary value passed to the third parameter of `async_set_timeout`. Ah, and I missed that that was a possibility, although, in my defense, it's not stated in the patch subject either. I.e. this patch doesn't just fix the race where an alerted async is canceled, it also fixes the similar race where it times out. So yes, I think the patch makes sense as is. Maybe a comment to yet again overdocument asyncs wouldn't hurt? I easily see myself looking at code like this and having to ask myself, "when exactly is terminate_status set?" and the answer is "if (and only if?) the async is canceled or times out while it's alerted", which is nice to have documented and not have to puzzle through later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/499#note_30389

1 0