- Wine-GitLab - list.winehq.org

[PATCH v6 0/1] MR11566: tests: Fix tests that are faulty because of == vs ?: operator precedence.
by Brendan Shanks (＠bshanks) Aug. 24, 2026

Aug. 24, 2026

`==` has higher precedence than `?:`, meaning that a test like `ok(hr == (i < 4) ? S_OK : VFW_E_TYPE_NOT_ACCEPTED, ...)` is parsed as `(hr == (i < 4)) ? S_OK : VFW_E_TYPE_NOT_ACCEPTED` and not the intended `hr == ((i < 4) ? S_OK : VFW_E_TYPE_NOT_ACCEPTED)`. I discovered this when converting `wine/test.h` to use `bool` for conditions (MR coming soon), this generated warnings like: ``` ../dlls/amstream/tests/amstream.c: In function 'test_media_types': ../dlls/amstream/tests/amstream.c:3159:33: warning: '?:' using integer constants in boolean context [-Wint-in-bool-context] 3159 | ok(hr == (i < 4) ? S_OK : VFW_E_TYPE_NOT_ACCEPTED, "Got hr %#lx on ReceiveConnection for subtype %s.\n", hr, ../include/wine/test.h:388:53: note: in definition of macro 'winetest_ok' 388 | #define winetest_ok(cond, ...) (winetest_should_log(cond) ? winetest_ok_(__VA_ARGS__) : winetest_ok_(NULL)) | ^~~~ ../include/wine/test.h:129:18: note: in expansion of macro 'ok_' 129 | #define ok ok_(__FILE__, __LINE__) | ^~~ ../dlls/amstream/tests/amstream.c:3159:9: note: in expansion of macro 'ok' 3159 | ok(hr == (i < 4) ? S_OK : VFW_E_TYPE_NOT_ACCEPTED, "Got hr %#lx on ReceiveConnection for subtype %s.\n", hr, ``` -- v6: tests: Fix tests that are faulty because of == vs ?: operator precedence. https://gitlab.winehq.org/wine/wine/-/merge_requests/11566

2 2

[PATCH v6 0/3] MR11709: Fix GUID paths not being accepted by ShellExecute and explorer's command-line arguments
by Andrea Faulds (＠hikari_no_yume) Aug. 24, 2026

Aug. 24, 2026

This works on Windows, but was broken in WINE: ![Screenshot From 2026-08-20 01-13-02.png](/uploads/4cf087c2d5ab538700b881a72d07a366/Screenshot_From_2026-08-20_01-13-02.png){width=731 height=600} ![Screenshot From 2026-08-20 01-33-09.png](/uploads/787690a027523a914821143824dcc3ab/Screenshot_From_2026-08-20_01-33-09.png){width=731 height=600} The three patches belong together because `ShellExecute` invokes explorer. -- v6: shell32: Fix ShellExecute not accepting GUID shell folder paths explorer: Fix GUID shell folder paths not being accepted on command line shell32/tests: Add test for ShellExecute with GUID shell folder path https://gitlab.winehq.org/wine/wine/-/merge_requests/11709

2 3

Re: [PATCH v5 0/3] MR11709: Fix GUID paths not being accepted by ShellExecute and explorer's command-line arguments
by Andrea Faulds (＠hikari_no_yume) Aug. 24, 2026

Aug. 24, 2026

On Mon Aug 24 15:21:04 2026 +0000, Jinoh Kang wrote: > Thanks for the explanation! > In that case, please add > ```c > if (!winetest_interactive) > { > skip( "interactive explorer guid argument test (set > WINETEST_INTERACTIVE=1)\n" ); > return; > } > ``` > at the top of the `test_guid()` function so that it doesn't run in batch mode. Aha, I didn't know we could have interactive tests. Thanks a lot! I hope the new version looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11709#note_149732

1 0

[PATCH v5 0/1] MR11730: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read().
by Shaun Ren (＠shaunren) Aug. 24, 2026

Aug. 24, 2026

Some non-conforming IStream implementations, including SharpDX, do not handle a NULL pcbRead for Read() [^1]. This causes the game "Surviving Deponia Playtest" to display a black main menu. [^1]: https://github.com/sharpdx/SharpDX/blob/ab36f12303e24aa60fe804866617716b6de… -- v5: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read(). https://gitlab.winehq.org/wine/wine/-/merge_requests/11730

2 2

[PATCH v4 0/1] MR11730: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read().
by Shaun Ren (＠shaunren) Aug. 24, 2026

Aug. 24, 2026

Some non-conforming IStream implementations, including SharpDX, do not handle a NULL pcbRead for Read() [^1]. This causes the game "Surviving Deponia Playtest" to display a black main menu. [^1]: https://github.com/sharpdx/SharpDX/blob/ab36f12303e24aa60fe804866617716b6de… -- v4: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read(). https://gitlab.winehq.org/wine/wine/-/merge_requests/11730

4 4

[PATCH v3 0/1] MR11730: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read().
by Shaun Ren (＠shaunren) Aug. 24, 2026

Aug. 24, 2026

Some non-conforming IStream implementations, including SharpDX, do not handle a NULL pcbRead for Read() [^1]. This causes the game "Surviving Deponia Playtest" to display a black main menu. [^1]: https://github.com/sharpdx/SharpDX/blob/ab36f12303e24aa60fe804866617716b6de… -- v3: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read(). https://gitlab.winehq.org/wine/wine/-/merge_requests/11730

2 1

Re: [PATCH v2 0/1] MR11730: windowscodecs: Always pass a valid pcbRead pointer to IStream::Read().
by Shaun Ren (＠shaunren) Aug. 24, 2026

Aug. 24, 2026

On Mon Aug 24 16:59:01 2026 +0000, Esme Povirk wrote: > We might consider having the stream_read wrapper handle this implicitly, > so if NULL is passed in it would: > * Handle passing a non-NULL argument for pcbRead. > * If fewer bytes are read than requested, return a failing hr. Changed to this in the latest revision. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11730#note_149721

1 0

[PATCH v2 0/4] MR11745: hidclass.sys: Include the device id in the hardware ids list.
by Sanskar Jaiswal (＠sanskarjaiswal2001) Aug. 24, 2026

Aug. 24, 2026

query_hardware_ids() builds the hardware ids list from vid/pid, usage and HID_DEVICE strings, but never includes the PDO's own device id. For composite USB devices this id carries the &MI_xx interface index, which is how Windows lets applications identify which interface of a multi-interface device a given HID device object belongs to. Add it as the most specific (first) entry. Signed-off-by: Sanskar Jaiswal <phoenix2810(a)protonmail.com> -- v2: winebus.sys: Share the container id across a composite device's interfaces. winebus.sys: Do not rewrite the serial number of sibling HID interfaces. winebus.sys: Advertise a USB compatible id for USB devices. hidclass.sys: Include the device id in the hardware ids list. https://gitlab.winehq.org/wine/wine/-/merge_requests/11745

2 4

[PATCH 0/4] MR11745: hidclass.sys: Include the device id in the hardware ids list.
by Sanskar Jaiswal (＠sanskarjaiswal2001) Aug. 24, 2026

Aug. 24, 2026

query_hardware_ids() builds the hardware ids list from vid/pid, usage and HID_DEVICE strings, but never includes the PDO's own device id. For composite USB devices this id carries the &MI_xx interface index, which is how Windows lets applications identify which interface of a multi-interface device a given HID device object belongs to. Add it as the most specific (first) entry. Signed-off-by: Sanskar Jaiswal <phoenix2810(a)protonmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11745

2 4

[PATCH 0/1] MR11730: windowscodecs: Pass pcbRead to IStream::Read() in jpeg_decoder_get_metadata_blocks().
by Shaun Ren (＠shaunren) Aug. 24, 2026

Aug. 24, 2026

Some non-conforming IStream implementations, including SharpDX, do not handle a NULL pcbRead for Read() [^1]. This causes the game "Surviving Deponia Playtest" to display a black main menu. [^1]: https://github.com/sharpdx/SharpDX/blob/ab36f12303e24aa60fe804866617716b6de… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11730

4 5