- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR146: vkd3d: Append a full memory barrier after the command list batch in ExecuteCommandLists().
by Conor McCarthy (＠cmccarthy) April 12, 2023

April 12, 2023

The D3D12 spec guarantees that lists submitted in ExecuteCommandLists() will complete execution before any subsequent commands begin execution. Based on a vkd3d-proton patch by Hans-Kristian Arntzen. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/146

4 10

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) April 12, 2023

April 12, 2023

> The patch may fix an application, but that doesn't mean it's correct. Yeah, I know that. The problem is my test isn't just add an interface function to the existing interface, I need to add a new interface without 'implicit_handle'. I need to understand all the server test code of rpcrt4 and insert my interface in a correct place, and start the server and client at a right time. It's too hard, Visual Studio did this for me automatically. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29694

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) April 12, 2023

April 12, 2023

On Wed Apr 12 07:11:24 2023 +0000, Yeshun Ye wrote: > I tried to add an interface like this: > ``` > [ > uuid(00000000-4114-0704-2301-000000000002) > ] > > interface IServer_Expilicit > { > void need_explicit_handle([in] handle_t binding, [in] unsigned int > protseq); > } > ``` > I added the code above to the file 'server_interp.idl', the function > code to 'server.c' like this: > ``` > void __cdecl s_need_explicit_handle(RPC_BINDING_HANDLE binding, unsigned > int protseq) > { > RPC_STATUS status; > ULONG pid; > winetest_push_context("%s", client_test_name); > ok(binding != NULL, "Got unexpected binding\n"); > trace("s_need_explicit_handle\n"); > if (protseq == RPC_PROTSEQ_LRPC) /* Other protocol sequences throw > exceptions */ > { > trace("RPC_PROTSEQ_LRPC\n"); > status = I_RpcBindingInqLocalClientPID(binding, &pid); > trace("I_RpcBindingInqLocalClientPID\n"); > ok(status == RPC_S_OK, "Got unexpected %ld.\n", status); > ok(pid == client_info.dwProcessId, "Got unexpected pid.\n"); > trace("pid=%x client_info.dwProcessId=%x\n", pid, client_info.dwProcessId); > } > winetest_pop_context(); > } > ``` > Then I don't know what to do next. For a generic test case, you can see https://source.winehq.org/git/wine.git/commitdiff/056dbb04dea4d0b990e0177f6… for an example. However, in this case, you need to add a test case specifically for your changes. To be honest, I don't understand your patch, that's why I asked for a test case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29693

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) April 12, 2023

April 12, 2023

On Wed Apr 12 06:56:41 2023 +0000, Zhiyi Zhang wrote: > Could you be more specific about your question? You can paste your code here. I tried to add an interface like this: ``` [ uuid(00000000-4114-0704-2301-000000000002) ] interface IServer_Expilicit { void need_explicit_handle([in] handle_t binding, [in] unsigned int protseq); } ``` I added the code above to the file 'server_interp.idl', the function code to 'server.c' like this: ``` void __cdecl s_need_explicit_handle(RPC_BINDING_HANDLE binding, unsigned int protseq) { RPC_STATUS status; ULONG pid; winetest_push_context("%s", client_test_name); ok(binding != NULL, "Got unexpected binding\n"); trace("s_need_explicit_handle\n"); if (protseq == RPC_PROTSEQ_LRPC) /* Other protocol sequences throw exceptions */ { trace("RPC_PROTSEQ_LRPC\n"); status = I_RpcBindingInqLocalClientPID(binding, &pid); trace("I_RpcBindingInqLocalClientPID\n"); ok(status == RPC_S_OK, "Got unexpected %ld.\n", status); ok(pid == client_info.dwProcessId, "Got unexpected pid.\n"); trace("pid=%x client_info.dwProcessId=%x\n", pid, client_info.dwProcessId); } winetest_pop_context(); } ``` Then I don't know what to do next. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29689

1 0

[PATCH v4 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) April 12, 2023

April 12, 2023

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v4: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

4 7

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) April 12, 2023

April 12, 2023

On Wed Apr 12 05:38:56 2023 +0000, Yeshun Ye wrote: > I'm sorry I tried again, but still failed. I just know that the > interface should not add 'implicit_handle(handle_t IXXX_HANDLE)' after > 'uuid(IXXX_UUID)'. > Can you help me add a simple interface in the testcases and tell me how > to call the interface function? Otherwise, all I can do is give up. Could you be more specific about your question? You can paste your code here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29687

1 0

[PATCH 0/6] MR2628: Some more shell32 improvements.
by Jactry Zeng (＠jactry) April 12, 2023

April 12, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2628

4 15

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Yeshun Ye (＠yeyeshun) April 12, 2023

April 12, 2023

On Wed Apr 12 05:47:11 2023 +0000, Huw Davies wrote: > There's too much going on in this commit / MR. The changes to the > drivers seem to be addressing a bug rather than implementing the > Endpoint Volume API. > Also, note that the values passed to the non-`Scalar` API are in > decibels, the `Scalar` API appears to be somewhere between linear and > logrithmic, and the `ISimpleAudioVolume` values are linear. > Does your app call the `Scalar` versions of the API? If so, a good > start would be to write some tests to figure out the mapping between > `Scalar` and non-`Scalar` by e.g. setting using one and retreiving that > value using the other. Yes, I'm fixing a bug of an application, not implementing the set of Endpoint Volume API. Do I really need to write some tests? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_29674

1 0

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) April 12, 2023

April 12, 2023

On Fri Apr 7 10:56:17 2023 +0000, Huw Davies wrote: > Did these failures get addressed? I don't see testbot runs for the > later versions of the commits in this MR. No, I think the function will never return 'MIXERR_INVALCONTROL', so I just run the test again without any change, and it passed. This failures maybe caused by a bug of testbot. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29672

1 0

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) April 12, 2023

April 12, 2023

On Wed Apr 12 05:38:56 2023 +0000, Zhiyi Zhang wrote: > Hi Yeshun, you don't need to regularly rebase the MR on top of the > latest master. Because this area of code is largely undocumented, to > help this MR gets in, you need to add a test, even if it might not be > easy. I think you can use some of the example codes in NCALRPC_example. Thanks. I'm sorry I tried again, but still failed. I just know that the interface should not add 'implicit_handle(handle_t IXXX_HANDLE)' after 'uuid(IXXX_UUID)'. Can you help me add a simple interface in the testcases and tell me how to call the interface function? Otherwise, all I can do is give up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29671

1 0