- Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/12] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Mohamad Al-Jaf (＠maljaf) March 20, 2023

March 20, 2023

On Fri Mar 17 10:14:05 2023 +0000, Rémi Bernon wrote: > Yes, thanks a lot. > > Yeah, it might be useful to keep them around. I spent a long time > working on it so it would be nice to keep it, but perhaps I should first > split it up into smaller additions for easier review. In any case, > here's a branch of the headers in case you need it in the future: https://gitlab.winehq.org/maljaf/wine/-/commits/WinRT-Core > I can only imagine the time your spent, and thanks for doing that. It > may be arguably useful to have them in Wine, but at the same time it's > also a lot of additions. > The amount of code that is in the SDK IDL files is quite overwhelming, I > don't know if there's any saner way to have them than rewriting > everything by hand. They are actually generated from some binary > metadata, so maybe we could do that too (but then where to source this > metadata is a good question). > An alternative which I thought about was to implement IDL 3.0 syntax, > which I believe allows much terser interface / runtimeclass declaration, > and would generate the same header output. > Or, somehow, we could make WIDL compatible with the SDK IDL files, and > use them directly, but here like with the .winmd metadata, there's the > question of how to source it properly. > In any case I'm really not looking forward the time where we'll need to > stub or implement all these new interfaces... No problem, anything to make review easier for you. Yeah, it is a lot of additions. Maybe I'll wait for an application to need it before submitting it again, even if it's just for compilation like FireFox mingw. Interesting, I did notice the Windows SDK idl files say they are autogenerated at the top. Sourcing the metadata is indeed the main problem. There are some in C:\Windows\System32\WinMetadata and you could use the tool Ildasm.exe to disassemble them, but this seems like a grey area around clean room design and might be best to avoid it. Another option would be trial-and-error, just writing and rewriting binary metadata until it generates a similar idl file to the Windows SDK one. Though, I'm not sure if it's worth the effort. I took a look at the IDL 3.0 syntax and you're right, it's much more concise and would help with the bigger idl files like `windows.ui.core.idl`. The documentation is thorough: https://learn.microsoft.com/en-us/uwp/midl-3/intro I wouldn't mind stubbing the interfaces, though for windows.ui.core.idl there's definitely too many functions in the `ICoreWindow` interface alone. Implementing them is another issue, hopefully they're not too complex. Also, thanks for the review! :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_27267

1 0

[PATCH 0/2] MR2442: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2442

2 2

[PATCH v2 0/2] MR2438: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- v2: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion (v2) https://gitlab.winehq.org/wine/wine/-/merge_requests/2438

3 7

[PATCH 0/2] MR2441: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

https://bugs.winehq.org/show_bug.cgi?id=54675 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2441

2 3

[PATCH 0/1] MR2440: adsldp/tests: Fix test failures.
by Hans Leidekker (＠hans) March 19, 2023

March 19, 2023

The server is back online now and apparently its contents changed, causing test failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2440

2 1

Re: [PATCH 0/2] MR2438: wine.inf.in: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion
by Louis Lenders (＠xe) March 19, 2023

March 19, 2023

On Sun Mar 19 11:07:47 2023 +0000, Hans Leidekker wrote: > Why "Core"? It seems to me that "Professional" would make more sense > given that ProductName is "Windows 10 Pro". "Core" is what is says on my win10 virtualbox win10, but I guess "Professional" would indeed make more sense. I`ll try to update merge request -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2438#note_27260

1 0

[PATCH 0/5] MR2432: ddraw: SetSurfaceDesc() and ddraw_surface_create() refactoring, part 5.
by Zebediah Figura (＠zfigura) March 17, 2023

March 17, 2023

Out of what will probably end up being 6 total parts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2432

3 6

[PATCH 0/1] MR129: tests: Read integer uniforms with strotol() and strtoul().
by Giovanni Mascellani (＠giomasce) March 17, 2023

March 17, 2023

Because %i sscanf() converters are deprecated, and in practice clamp to [-2^31, 2^31) on 32 bit. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

3 2

[PATCH v4 0/5] MR2422: win32u: Implement NtUserBuildHimcList syscall.
by Rémi Bernon March 17, 2023

March 17, 2023

-- v4: win32u: Implement NtUserBuildHimcList syscall. win32u: Introduce new next_process_user_handle_ptr helper. win32u/tests: Test NtUserBuildHimcList syscall. win32u: Stub NtUserBuildHimcList syscall. win32u/tests: Test NtUserCreateInputContext (et al.). https://gitlab.winehq.org/wine/wine/-/merge_requests/2422

2 7

[PATCH 0/7] MR2431: Fix the advapi32:service tests
by Francois Gouget (＠fgouget) March 17, 2023

March 17, 2023

In particular: * Fix the resume handle comments. * Don't expect START_PENDING and STOP_PENDING services to have a process id. * Take into account service start / stop race conditions. * Enumerate the services using the Unicode API since the ANSI one is broken in some UTF-8 locales. * Skip some tests if the EventLog service crashed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2431

2 7