- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR2134: httpapi: Avoid calling RtlInitUnicodeString on a static constant.
by Alex Henrie (＠alexhenrie) Feb. 8, 2023

Feb. 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2134

3 5

Re: [PATCH v2 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Rémi Bernon Feb. 8, 2023

Feb. 8, 2023

On Wed Feb 8 18:55:31 2023 +0000, Zebediah Figura wrote: > > Should we really crash on any unexpected signal? > All of the signals we catch are signals for which the default action > specified by POSIX is to terminate. In the case of TRAP, SEGV, ILL, BUS > we have no choice. That might be true for FPE too but I can't remember; > but either way, either the program was expecting an exception and won't > get it, or it was going to crash anyway. > In the case of ABRT, QUIT, INT not terminating seems like the wrong > thing to do (and we can't handle them the normal way because we don't > have a TEB and can't contact the server). > We could potentially ignore USR1 and USR2, but that doesn't seem great > for stability. Whatever was sending them had a reason to do so, and > isn't going to function correctly. > Perhaps more saliently, we were already crashing on unexpected signals, > simply by virtue of trying to access the TEB and then dereferencing it. > This patch just makes it more obvious. Well we currently crash indeed but I don't think it is intentional. Making it explicit would make it look more like it is. I'd think that instead we should block the signals in the threads that cannot handle them, or handle them in a way that doesn't require a TEB. USR1 / USR2 / INT for instance could be blocked in non-Wine threads, raising them again until they reach a Wine thread. I think QUIT should be handled properly by calling `pthread_cancel` or `pthread_exit` and letting the thread cleanup properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2126#note_23475

2 1

[PATCH 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Zebediah Figura (＠zfigura) Feb. 8, 2023

Feb. 8, 2023

Without this patch the process will silently die. I managed to trigger this while trying to trace Child of Light with Renderdoc, the latter of which crashed in its own "TargetControlServerThread". This, confusingly, manifested in the game restarting itself without the Ubisoft overlay; apparently the game or one of its launchers was capable of recognizing when the process had died and restarting it, but would not try to inject the overlay a second time. I have not investigated the cause of the crash; it is not unlikely that it resulted from the overlay injection (despite the fact that that should only directly affect PE code.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2126

5 5

[PATCH v5 0/1] MR2132: vbscript: Fix memory leak in interp_redim_preserve
by Jason Millard (＠jsm174) Feb. 8, 2023

Feb. 8, 2023

While running in XCode's profiler, I noticed two memory leaks in `interp_redim_preserve`. After looking at `interp_redim`, the `bounds` structure is freed. I've updated `interp_redim_preserve` to free `bounds` when the array is NULL and not NULL. -- v5: vbscript: Fix memory leak in Split() https://gitlab.winehq.org/wine/wine/-/merge_requests/2132

2 1

[PATCH v4 0/1] MR2132: vbscript: Fix memory leak in interp_redim_preserve
by Jason Millard (＠jsm174) Feb. 8, 2023

Feb. 8, 2023

While running in XCode's profiler, I noticed two memory leaks in `interp_redim_preserve`. After looking at `interp_redim`, the `bounds` structure is freed. I've updated `interp_redim_preserve` to free `bounds` when the array is NULL and not NULL. -- v4: vbscript: Fix memory leak in interp_redim_preserve https://gitlab.winehq.org/wine/wine/-/merge_requests/2132

4 5

[PATCH v2 0/5] MR2073: scardsvr: Add stub service.
by Zebediah Figura (＠zfigura) Feb. 8, 2023

Feb. 8, 2023

The Rutoken driver installer tries to start this service, and fails if it doesn't exist. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54396 -- v2: scardsvr: Add stub service. wine.inf: Always use FLG_ADDREG_APPEND for SvcHost entries. setupapi: Create the registry value if it doesn't exist in append_multi_sz_value(). setupapi: Fail installation when trying to append to a registry value of the wrong type. setupapi/tests: Add tests for FLG_ADDREG_APPEND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2073

2 7

[PATCH 0/2] MR2138: Retry when clipboard operations fail.
by eric pouech (＠epo) Feb. 8, 2023

Feb. 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2138

3 4

[PATCH 0/1] MR2137: msi: Annotate memory allocation functions with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) Feb. 8, 2023

Feb. 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2137

3 2

[PATCH v3 0/5] MR81: vkd3d-shader/hlsl: Fixes for SM1 writemasks and swizzles.
by Francisco Casas (＠fcasas) Feb. 8, 2023

Feb. 8, 2023

Because of the change introduced in f21693b2, SM1 scalars and vectors were not longer getting the correct writemask when they are allocated, so this is fixed. Also, the mapping of sm1 src register swizzles is moved outside `write_sm1_instruction()` since there are some instructions that don't do this, remarkably dp2add. This is fixed. Before the last patch we are writing the operation as: ``` dp2add r0.x, r1.x, r0.x, r2.x ``` and now it is: ``` dp2add r0.x, r1.xyxx, r0.xyxx, r2.x ``` dp2add now has its own function, `write_sm1_dp2add()`, since it seems to be the only instruction with this structure. Ideally we would be using the default swizzles for the first two src arguments: ``` dp2add r0.x, r1, r0, r2.x ``` since, according to native's documentation, these are supported for all sm < 4. But using default swizzles whenever is possible -- along with following the conversion of repeating the last component of the swizzle when fewer than 4 components are to be specified -- has a higher scope. Probably would involve modifying `hlsl_swizzle_from_writemask()` and `hlsl_map_swizzle()`. -- v3: vkd3d-shader/hlsl: Fix SM1 dp2add swizzles. vkd3d-shader/hlsl: Map SM1 src swizzles outside write_sm1_instruction(). vkd3d-shader/hlsl: Set writemasks correctly for SM1 scalar and vector types. vkd3d-shader/hlsl: Expect component count in allocate_register(). vkd3d-shader/hlsl: Rename 'component_count' arguments to 'reg_size'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/81

3 8

[PATCH v4 0/1] MR2131: vbscript: Fix memory leak in Split().
by Jason Millard (＠jsm174) Feb. 8, 2023

Feb. 8, 2023

While running in XCode's profiler, I noticed a memory leak in `Global_Split`. When the strings are being copied into the SafeArray, the `BSTR` is not freed after `VariantCopyInd`. -- v4: vbscript: Fix memory leak in Split() https://gitlab.winehq.org/wine/wine/-/merge_requests/2131

3 3