- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) Nov. 29, 2022

Nov. 29, 2022

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v3: ntdll: TlsIndex should not actually contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

3 2

[PATCH v2 0/1] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) Nov. 28, 2022

Nov. 28, 2022

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v2: ntdll: TlsIndex should not actually contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

2 1

Re: [PATCH v3 0/1] MR1562: wininet: Simplify memory allocation in HTTP_InsertCustomHeader. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1562

1 0

Re: [PATCH v3 0/1] MR1561: vbscript: Accept private and public const global declarations. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1561

1 0

Re: [PATCH v2 0/1] MR1572: ntdll: Detect ntdll module also by module path compatition. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1572

1 0

Re: [PATCH v2 0/6] MR1548: ntdll: Relax heap locking to access block information. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1548

1 0

Re: [PATCH v2 0/2] MR1576: ntdll: Get TEB from signal stack pointer in init_handler. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1576

1 0

Re: [PATCH v2 0/1] MR1573: winedump: Don't crash when dumping .dbg files. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1573

1 0

Re: [PATCH v3 0/3] MR1549: configure: Clang build fixes. - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1549

1 0

Re: [PATCH v2 0/8] MR1558: localspl: Start moving print job related code to localspl - approved
by Alexandre Julliard (＠julliard) Nov. 28, 2022

Nov. 28, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1558

1 0